From unknown Sat Sep 06 02:03:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59352] [PATCH] gnu: Add emacs-org-tree-slide. Resent-From: Sergiu Ivanov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Nov 2022 09:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59352 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59352@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166876306126141 (code B ref -1); Fri, 18 Nov 2022 09:18:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 Nov 2022 09:17:41 +0000 Received: from localhost ([127.0.0.1]:35272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovxVF-0006nY-AG for submit@debbugs.gnu.org; Fri, 18 Nov 2022 04:17:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:37264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovxVD-0006nR-6M for submit@debbugs.gnu.org; Fri, 18 Nov 2022 04:17:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovxVC-0000Ak-JX for guix-patches@gnu.org; Fri, 18 Nov 2022 04:17:38 -0500 Received: from marvid.fr ([163.172.81.107] helo=courriel.marvid.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovxVA-0005mL-N1 for guix-patches@gnu.org; Fri, 18 Nov 2022 04:17:38 -0500 Received: from localhost (schwifty.marvid.fr [51.159.4.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by sahkopoika (Postfix) with ESMTPSA id B123979B84EE for ; Fri, 18 Nov 2022 10:17:26 +0100 (CET) User-agent: mu4e 1.8.11; emacs 28.2 From: Sergiu Ivanov Date: Fri, 18 Nov 2022 10:15:02 +0100 Message-ID: <87v8ncbp09.fsf@colimite.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: none client-ip=163.172.81.107; envelope-from=sivanov@colimite.fr; helo=courriel.marvid.fr X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, FORGED_SPF_HELO=1, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hello, Here's a patch adding emacs-org-tree-slide. It's my second Guix package ever, and I actually enjoyed following the instructions from the manual for building, linting and styling it. Tell me if I got it right :D - Sergiu --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-Add-emacs-org-tree-slide.patch Content-Transfer-Encoding: quoted-printable >From 6f53bc504923028c9cae3619192db976a25af4a4 Mon Sep 17 00:00:00 2001 From: Sergiu Ivanov Date: Fri, 18 Nov 2022 10:11:53 +0100 Subject: [PATCH] gnu: Add emacs-org-tree-slide. --- gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index fe0d9f1dc9..33158f54eb 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -118,6 +118,7 @@ ;;; Copyright =C2=A9 2022 Hilton Chain ;;; Copyright =C2=A9 2022 Nicolas Graves ;;; Copyright =C2=A9 2022 Thiago Jung Bauermann +;;; Copyright =C2=A9 2022 Sergiu Ivanov ;;; ;;; This file is part of GNU Guix. ;;; @@ -5900,6 +5901,27 @@ (define-public emacs-stripe-buffer tables.") (license license:gpl2+))) =20 +(define-public emacs-org-tree-slide + (package + (name "emacs-org-tree-slide") + (version "20221016.1623") + (source + (origin + (method url-fetch) + (uri (string-append "https://melpa.org/packages/org-tree-slide-" + version ".el")) + (sha256 + (base32 "0pzq43l80i7p1w0ph5az1nxpwpl50ahmi7ql22ai31x7rh1a44fi")))) + (build-system emacs-build-system) + (home-page "https://github.com/takaxp/org-tree-slide") + (synopsis "Emacs minor mode for giving presentations with Org-mode") + (description + "This package provides the Org minor mode @code{org-tree-slide} which +allows for using an Org-mode document in presentations by +progressively revealing individual subtrees of the document. +org-tree-slide shows and hides parts of the Org buffer by narrowing.") + (license license:gpl3))) + (define-public emacs-org-beautify-theme ;; Latest release (0.4) is not tagged, use commit hash. (let ((commit "df6a1114fda313e1689363e196c8284fbe2a2738") --=20 2.38.1 --=-=-=-- From unknown Sat Sep 06 02:03:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59352] [PATCH] gnu: Add emacs-org-tree-slide. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Nov 2022 21:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59352 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sergiu Ivanov Cc: 59352@debbugs.gnu.org Received: via spool by 59352-submit@debbugs.gnu.org id=B59352.166880668231873 (code B ref 59352); Fri, 18 Nov 2022 21:25:02 +0000 Received: (at 59352) by debbugs.gnu.org; 18 Nov 2022 21:24:42 +0000 Received: from localhost ([127.0.0.1]:38433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow8qo-0008I0-9W for submit@debbugs.gnu.org; Fri, 18 Nov 2022 16:24:42 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:52131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow8qi-0008Hi-Qb for 59352@debbugs.gnu.org; Fri, 18 Nov 2022 16:24:40 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id BC6D31C0004; Fri, 18 Nov 2022 21:24:28 +0000 (UTC) From: Nicolas Goaziou References: <87v8ncbp09.fsf@colimite.fr> Date: Fri, 18 Nov 2022 22:24:22 +0100 In-Reply-To: <87v8ncbp09.fsf@colimite.fr> (Sergiu Ivanov's message of "Fri, 18 Nov 2022 10:15:02 +0100") Message-ID: <87mt8oot15.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Sergiu Ivanov writes: > Here's a patch adding emacs-org-tree-slide. Thank you. > It's my second Guix package ever, and I actually enjoyed following the > instructions from the manual for building, linting and styling it. Tell > me if I got it right :D Almost ;) Some comments follow. > Subject: [PATCH] gnu: Add emacs-org-tree-slide. > > --- > gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++ Your commit message is missing a part about the module being modified: * gnu/packages/emacs-xyz.scm (emacs-org-tree-slide): New variable. > +(define-public emacs-org-tree-slide > + (package > + (name "emacs-org-tree-slide") > + (version "20221016.1623") Latest version is 2.8.18, the version above is a fancy date tag from MELPA unstable. > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://melpa.org/packages/org-tree-slide-" > + version ".el")) We don't use MELPA as upstream because it doesn't guarantee the tarball will always be available. Use GitHub as upstream instead. > + (synopsis "Emacs minor mode for giving presentations with Org-mode") Nitpick: Org-mode -> Org mode. > + (description > + "This package provides the Org minor mode @code{org-tree-slide} which > +allows for using an Org-mode document in presentations by > +progressively revealing individual subtrees of the document. > +org-tree-slide shows and hides parts of the Org buffer by narrowing.") I suggest: Org Tree Slide is a minor mode for using an Org document in presentations by progressively revealing individual subtrees of the document. > + (license license:gpl3))) License is actually gpl3+ because the license in the org-tree-slide.el file mention "or (at your option), any later version". Could you send an updated patch? Well done BTW! Regards, -- Nicolas Goaziou From unknown Sat Sep 06 02:03:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59352] [PATCH] gnu: Add emacs-org-tree-slide. Resent-From: Sergiu Ivanov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Nov 2022 23:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59352 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 59352@debbugs.gnu.org Received: via spool by 59352-submit@debbugs.gnu.org id=B59352.166881575113918 (code B ref 59352); Fri, 18 Nov 2022 23:56:02 +0000 Received: (at 59352) by debbugs.gnu.org; 18 Nov 2022 23:55:51 +0000 Received: from localhost ([127.0.0.1]:38496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owBD5-0003cP-BL for submit@debbugs.gnu.org; Fri, 18 Nov 2022 18:55:51 -0500 Received: from marvid.fr ([163.172.81.107]:37164 helo=courriel.marvid.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owBD0-0003c8-QH for 59352@debbugs.gnu.org; Fri, 18 Nov 2022 18:55:50 -0500 Received: from localhost (schwifty.marvid.fr [51.159.4.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by sahkopoika (Postfix) with ESMTPSA id 1BE1A79BF95B; Sat, 19 Nov 2022 00:55:40 +0100 (CET) References: <87v8ncbp09.fsf@colimite.fr> <87mt8oot15.fsf@nicolasgoaziou.fr> User-agent: mu4e 1.8.11; emacs 28.2 From: Sergiu Ivanov Date: Sat, 19 Nov 2022 00:54:50 +0100 In-reply-to: <87mt8oot15.fsf@nicolasgoaziou.fr> Message-ID: <874juvg6mc.fsf@colimite.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Nicolas, Thank you for your review! I was starting to apply your suggestions and =E2=80=A6 I found that emacs-org-tree-slide was already packaged! I swear I checked before sending in the patch, but apparently I didn't check well enough :D :'( So, I decided to update the existing definition and improve it according to your suggestions. I attach the new patch. Nicolas Goaziou [2022-11-18T22:24:22+0100]: > Hello, > > Sergiu Ivanov writes: > >> Here's a patch adding emacs-org-tree-slide. > > Thank you. > >> It's my second Guix package ever, and I actually enjoyed following the >> instructions from the manual for building, linting and styling it. Tell >> me if I got it right :D > > Almost ;) Some comments follow. :D :'( >> Subject: [PATCH] gnu: Add emacs-org-tree-slide. >> >> --- >> gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++ > > > Your commit message is missing a part about the module being modified: > > * gnu/packages/emacs-xyz.scm (emacs-org-tree-slide): New variable. A-ha! I looked at other commit messages, but forgot to not only look at their first lines. >> +(define-public emacs-org-tree-slide >> + (package >> + (name "emacs-org-tree-slide") >> + (version "20221016.1623") > > Latest version is 2.8.18, the version above is a fancy date tag from > MELPA unstable. > >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append "https://melpa.org/packages/org-tree-slide-" >> + version ".el")) > > We don't use MELPA as upstream because it doesn't guarantee the tarball > will always be available. Use GitHub as upstream instead. Oh, good to know! >> + (synopsis "Emacs minor mode for giving presentations with Org-mode") > > Nitpick: Org-mode -> Org mode. I fixed this in the other package definition which I found. >> + (description >> + "This package provides the Org minor mode @code{org-tree-slide} wh= ich >> +allows for using an Org-mode document in presentations by >> +progressively revealing individual subtrees of the document. >> +org-tree-slide shows and hides parts of the Org buffer by narrowing.") > > I suggest: > > Org Tree Slide is a minor mode for using an Org document in > presentations by progressively revealing individual subtrees of the > document. I replaced the original text with yours, which I like more. >> + (license license:gpl3))) > > License is actually gpl3+ because the license in the org-tree-slide.el > file mention "or (at your option), any later version". Oh, OK, I'll read better next time. > Could you send an updated patch? > > Well done BTW! Thank you for your time! It was a nice and pleasant training. - Sergiu --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-emacs-org-tree-slide-Update-to-2.8.18.patch >From 97e1307f0a8966149ecf29264ad205e55d29b502 Mon Sep 17 00:00:00 2001 From: Sergiu Ivanov Date: Sat, 19 Nov 2022 00:46:04 +0100 Subject: [PATCH] gnu: emacs-org-tree-slide: Update to 2.8.18. * gnu/packages/emacs-xyz.scm (emacs-org-tree-slide): Update to 2.8.18. --- gnu/packages/emacs-xyz.scm | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index fe0d9f1dc9..f827107b29 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -18644,11 +18644,11 @@ (define-public emacs-kotlin-mode (license license:gpl3+)))) (define-public emacs-org-tree-slide - (let ((commit "036a36eec1cf712d3db155572aed325daa372eb5") - (revision "2")) + (let ((commit "d6529bc2df727d09014e0e56abf4f15a8e8fc20f") + (revision "3")) (package (name "emacs-org-tree-slide") - (version (git-version "2.8.4" revision commit)) + (version (git-version "2.8.18" revision commit)) (source (origin (method git-fetch) (uri (git-reference @@ -18656,15 +18656,15 @@ (define-public emacs-org-tree-slide (commit commit))) (sha256 (base32 - "1r8ncx25xmxicgciyv5przp68y8qgy40fm10ba55awvql4xcm0yk")) + "1br32mpwarmrn158y2pkkmfl2ssv8q8spzknkg2avr16fil0j1pz")) (file-name (git-file-name name version)))) (build-system emacs-build-system) (home-page "https://github.com/takaxp/org-tree-slide") - (synopsis "Presentation tool for org-mode") + (synopsis "Presentation tool for Org mode") (description - "Org-tree-slide provides a slideshow mode to view org-mode files. Use -@code{org-tree-slide-mode} to enter the slideshow mode, and then @kbd{C->} and -@kbd{C-<} to jump to the next and previous slide.") + "Org Tree Slide is a minor mode for using an Org document in +presentations by progressively revealing individual subtrees of +the document.") (license license:gpl3+)))) (define-public emacs-scratch-el -- 2.38.1 --=-=-=-- From unknown Sat Sep 06 02:03:18 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Sergiu Ivanov Subject: bug#59352: closed (Re: [bug#59352] [PATCH] gnu: Add emacs-org-tree-slide.) Message-ID: References: <87a64np9mv.fsf@nicolasgoaziou.fr> <87v8ncbp09.fsf@colimite.fr> X-Gnu-PR-Message: they-closed 59352 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 59352@debbugs.gnu.org Date: Sat, 19 Nov 2022 09:39:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1668850742-14139-1" This is a multi-part message in MIME format... ------------=_1668850742-14139-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #59352: [PATCH] gnu: Add emacs-org-tree-slide. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 59352@debbugs.gnu.org. --=20 59352: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59352 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1668850742-14139-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 59352-done) by debbugs.gnu.org; 19 Nov 2022 09:38:12 +0000 Received: from localhost ([127.0.0.1]:39038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owKIe-0003f4-Gn for submit@debbugs.gnu.org; Sat, 19 Nov 2022 04:38:12 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:38759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owKIZ-0003eZ-U6 for 59352-done@debbugs.gnu.org; Sat, 19 Nov 2022 04:38:10 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id F15A31C0002; Sat, 19 Nov 2022 09:38:00 +0000 (UTC) From: Nicolas Goaziou To: Sergiu Ivanov Subject: Re: [bug#59352] [PATCH] gnu: Add emacs-org-tree-slide. References: <87v8ncbp09.fsf@colimite.fr> <87mt8oot15.fsf@nicolasgoaziou.fr> <874juvg6mc.fsf@colimite.fr> Date: Sat, 19 Nov 2022 10:38:00 +0100 In-Reply-To: <874juvg6mc.fsf@colimite.fr> (Sergiu Ivanov's message of "Sat, 19 Nov 2022 00:54:50 +0100") Message-ID: <87a64np9mv.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59352-done Cc: 59352-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Sergiu Ivanov writes: > So, I decided to update the existing definition and improve it according > to your suggestions. I attach the new patch. Great! I applied it with a minor twist explained below. > Subject: [PATCH] gnu: emacs-org-tree-slide: Update to 2.8.18. > > * gnu/packages/emacs-xyz.scm (emacs-org-tree-slide): Update to 2.8.18. You're updating to the latest commit, which is not exactly "2.8.18", to "2.8.18-0.d6529bc". Also, the commit message must include changes you made to synopsis and description, which could arguably have been done in a subsequent commit, but that's fine. > --- > gnu/packages/emacs-xyz.scm | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index fe0d9f1dc9..f827107b29 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -18644,11 +18644,11 @@ (define-public emacs-kotlin-mode > (license license:gpl3+)))) > > (define-public emacs-org-tree-slide > - (let ((commit "036a36eec1cf712d3db155572aed325daa372eb5") > - (revision "2")) > + (let ((commit "d6529bc2df727d09014e0e56abf4f15a8e8fc20f") > + (revision "3")) The revision is reset to "0" since you bumped the base version. Revision is here to ensure monotonic growth between version bumps because commit hashes cannot ensure this. Therefore, it is only useful to increase the revision number within the same base version. Thank you! Regards, -- Nicolas Goaziou ------------=_1668850742-14139-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 Nov 2022 09:17:41 +0000 Received: from localhost ([127.0.0.1]:35272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovxVF-0006nY-AG for submit@debbugs.gnu.org; Fri, 18 Nov 2022 04:17:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:37264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovxVD-0006nR-6M for submit@debbugs.gnu.org; Fri, 18 Nov 2022 04:17:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovxVC-0000Ak-JX for guix-patches@gnu.org; Fri, 18 Nov 2022 04:17:38 -0500 Received: from marvid.fr ([163.172.81.107] helo=courriel.marvid.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovxVA-0005mL-N1 for guix-patches@gnu.org; Fri, 18 Nov 2022 04:17:38 -0500 Received: from localhost (schwifty.marvid.fr [51.159.4.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by sahkopoika (Postfix) with ESMTPSA id B123979B84EE for ; Fri, 18 Nov 2022 10:17:26 +0100 (CET) User-agent: mu4e 1.8.11; emacs 28.2 From: Sergiu Ivanov To: guix-patches@gnu.org Subject: [PATCH] gnu: Add emacs-org-tree-slide. Date: Fri, 18 Nov 2022 10:15:02 +0100 Message-ID: <87v8ncbp09.fsf@colimite.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: none client-ip=163.172.81.107; envelope-from=sivanov@colimite.fr; helo=courriel.marvid.fr X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, FORGED_SPF_HELO=1, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hello, Here's a patch adding emacs-org-tree-slide. It's my second Guix package ever, and I actually enjoyed following the instructions from the manual for building, linting and styling it. Tell me if I got it right :D - Sergiu --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-Add-emacs-org-tree-slide.patch Content-Transfer-Encoding: quoted-printable >From 6f53bc504923028c9cae3619192db976a25af4a4 Mon Sep 17 00:00:00 2001 From: Sergiu Ivanov Date: Fri, 18 Nov 2022 10:11:53 +0100 Subject: [PATCH] gnu: Add emacs-org-tree-slide. --- gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index fe0d9f1dc9..33158f54eb 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -118,6 +118,7 @@ ;;; Copyright =C2=A9 2022 Hilton Chain ;;; Copyright =C2=A9 2022 Nicolas Graves ;;; Copyright =C2=A9 2022 Thiago Jung Bauermann +;;; Copyright =C2=A9 2022 Sergiu Ivanov ;;; ;;; This file is part of GNU Guix. ;;; @@ -5900,6 +5901,27 @@ (define-public emacs-stripe-buffer tables.") (license license:gpl2+))) =20 +(define-public emacs-org-tree-slide + (package + (name "emacs-org-tree-slide") + (version "20221016.1623") + (source + (origin + (method url-fetch) + (uri (string-append "https://melpa.org/packages/org-tree-slide-" + version ".el")) + (sha256 + (base32 "0pzq43l80i7p1w0ph5az1nxpwpl50ahmi7ql22ai31x7rh1a44fi")))) + (build-system emacs-build-system) + (home-page "https://github.com/takaxp/org-tree-slide") + (synopsis "Emacs minor mode for giving presentations with Org-mode") + (description + "This package provides the Org minor mode @code{org-tree-slide} which +allows for using an Org-mode document in presentations by +progressively revealing individual subtrees of the document. +org-tree-slide shows and hides parts of the Org buffer by narrowing.") + (license license:gpl3))) + (define-public emacs-org-beautify-theme ;; Latest release (0.4) is not tagged, use commit hash. (let ((commit "df6a1114fda313e1689363e196c8284fbe2a2738") --=20 2.38.1 --=-=-=-- ------------=_1668850742-14139-1-- From unknown Sat Sep 06 02:03:18 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59352] [PATCH] gnu: Add emacs-org-tree-slide. Resent-From: Sergiu Ivanov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 19 Nov 2022 11:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59352 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 59352-done@debbugs.gnu.org Received: via spool by 59352-done@debbugs.gnu.org id=D59352.166885691832407 (code D ref 59352); Sat, 19 Nov 2022 11:22:02 +0000 Received: (at 59352-done) by debbugs.gnu.org; 19 Nov 2022 11:21:58 +0000 Received: from localhost ([127.0.0.1]:39114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owLv4-0008Qd-1e for submit@debbugs.gnu.org; Sat, 19 Nov 2022 06:21:58 -0500 Received: from marvid.fr ([163.172.81.107]:38850 helo=courriel.marvid.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owLuz-0008QL-VE for 59352-done@debbugs.gnu.org; Sat, 19 Nov 2022 06:21:56 -0500 Received: from localhost (schwifty.marvid.fr [51.159.4.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by sahkopoika (Postfix) with ESMTPSA id 80B7579C4D7A; Sat, 19 Nov 2022 12:21:47 +0100 (CET) References: <87v8ncbp09.fsf@colimite.fr> <87mt8oot15.fsf@nicolasgoaziou.fr> <874juvg6mc.fsf@colimite.fr> <87a64np9mv.fsf@nicolasgoaziou.fr> User-agent: mu4e 1.8.11; emacs 28.2 From: Sergiu Ivanov Date: Sat, 19 Nov 2022 12:18:07 +0100 In-reply-to: <87a64np9mv.fsf@nicolasgoaziou.fr> Message-ID: <87k03rdwac.fsf@colimite.fr> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Hello, Nicolas Goaziou [2022-11-19T10:38:00+0100]: > Hello, > > Sergiu Ivanov writes: > >> So, I decided to update the existing definition and improve it according >> to your suggestions. I attach the new patch. > > Great! I applied it with a minor twist explained below. Great, thank you! >> Subject: [PATCH] gnu: emacs-org-tree-slide: Update to 2.8.18. >> >> * gnu/packages/emacs-xyz.scm (emacs-org-tree-slide): Update to 2.8.18. > > You're updating to the latest commit, which is not exactly "2.8.18", to > "2.8.18-0.d6529bc". Oh, OK, thank you for the explanation! I am consistently bad at getting versioning right. > Also, the commit message must include changes you made to synopsis and > description, which could arguably have been done in a subsequent commit, > but that's fine. I hesitated about that. I'll split the changes over two patches the next time. >> --- >> gnu/packages/emacs-xyz.scm | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm >> index fe0d9f1dc9..f827107b29 100644 >> --- a/gnu/packages/emacs-xyz.scm >> +++ b/gnu/packages/emacs-xyz.scm >> @@ -18644,11 +18644,11 @@ (define-public emacs-kotlin-mode >> (license license:gpl3+)))) >> >> (define-public emacs-org-tree-slide >> - (let ((commit "036a36eec1cf712d3db155572aed325daa372eb5") >> - (revision "2")) >> + (let ((commit "d6529bc2df727d09014e0e56abf4f15a8e8fc20f") >> + (revision "3")) > > The revision is reset to "0" since you bumped the base version. Revision > is here to ensure monotonic growth between version bumps because commit > hashes cannot ensure this. Therefore, it is only useful to increase the > revision number within the same base version. Oh, I see! I read the docs of git-version to see what "revision" meant, but I didn't get that revision should be reset to 0 when the base version is changed. Thank you for taking the time to review my patch and explain the details! - Sergiu