GNU bug report logs - #59347
29.0.50; `:family` face setting ignored

Previous Next

Package: emacs;

Reported by: Stefan Monnier <monnier <at> iro.umontreal.ca>

Date: Fri, 18 Nov 2022 04:58:01 UTC

Severity: normal

Found in version 29.0.50

Done: Gregory Heytings <gregory <at> heytings.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Gregory Heytings <gregory <at> heytings.org>, Eli Zaretskii <eliz <at> gnu.org>, 59347 <at> debbugs.gnu.org
Subject: bug#59347: 29.0.50; `:family` face setting ignored
Date: Mon, 12 Dec 2022 10:30:10 -0500
> And what was the problem with a list?  How many cycles is traversing a
> list?  How many time will it take for your CPU to perform everything?
> Premature optimization is the root of all evil.

It was not premature optimization.
It was the simpler way to write the code.

Your patch made the C code more complex (not just slower) for the
benefit of a cleaner ELisp-level interface.  A better way to get that
same result would be to write an ELisp function on top of Gregory's
bitmask variable.
This way, you'd get a clean&simple&efficient C code still with
a convenient ELisp API.

Any chance someone could do that so we can move on?


        Stefan





This bug report was last modified 2 years and 160 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.