GNU bug report logs - #59347
29.0.50; `:family` face setting ignored

Previous Next

Package: emacs;

Reported by: Stefan Monnier <monnier <at> iro.umontreal.ca>

Date: Fri, 18 Nov 2022 04:58:01 UTC

Severity: normal

Found in version 29.0.50

Done: Gregory Heytings <gregory <at> heytings.org>

Bug is archived. No further changes may be made.

Full log


Message #149 received at 59347 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: monnier <at> iro.umontreal.ca, 59347 <at> debbugs.gnu.org
Subject: Re: bug#59347: 29.0.50; `:family` face setting ignored
Date: Mon, 21 Nov 2022 17:08:30 +0200
> Date: Mon, 21 Nov 2022 14:48:59 +0000
> From: Gregory Heytings <gregory <at> heytings.org>
> cc: monnier <at> iro.umontreal.ca, 59347 <at> debbugs.gnu.org
> 
> All in all, it seems to me that we should not change font_score now.

OK, thanks.

> > Btw, another conceptual issue I have with your patch is that it treats 
> > 'medium' and 'regular' asymmetrically (AFAIU): if we see 'medium', we 
> > also consider 'normal', but not vice versa.  Why the asymmetry? why not 
> > always consider the other when we see the one?
> >
> 
> That's correct, indeed.  The reason (which is perhaps not convincing 
> enough?) is that fonts with an explicit 'medium' variant are less common 
> than fonts with an explicit 'normal' variant.  So if we're trying to find 
> a 'normal' font, the likelihood that a 'medium' font would be a better 
> match than a 'normal' font is low.

I understand, but are there any downsides to making it symmetrical?

My only other comment is that perhaps the consideration of 'regular' when
'medium' was required (or vice versa) should be controlled by a variable
that people could tweak from Lisp.  This would help us if this change
causes, or is suspected to cause, some regression in some case.




This bug report was last modified 2 years and 159 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.