From unknown Sun Jun 22 00:56:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59345: 28.2; peg.el: syntax-class PEX does not advance point Resent-From: Sean Devlin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Nov 2022 23:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 59345@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1668728980885 (code B ref -1); Thu, 17 Nov 2022 23:50:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Nov 2022 23:49:40 +0000 Received: from localhost ([127.0.0.1]:34633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovodY-0000EB-2y for submit@debbugs.gnu.org; Thu, 17 Nov 2022 18:49:40 -0500 Received: from lists.gnu.org ([209.51.188.17]:54424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovodT-0000E0-VM for submit@debbugs.gnu.org; Thu, 17 Nov 2022 18:49:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovodT-0008Hk-Jz for bug-gnu-emacs@gnu.org; Thu, 17 Nov 2022 18:49:35 -0500 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovodR-00039q-JT for bug-gnu-emacs@gnu.org; Thu, 17 Nov 2022 18:49:35 -0500 Received: by mail-qt1-x831.google.com with SMTP id l15so2213258qtv.4 for ; Thu, 17 Nov 2022 15:49:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toadstyle-org.20210112.gappssmtp.com; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=+B6HQlD9n1+wg1dnGdA45hSeHj4ZbZlbqa2TxSvZ22Q=; b=r3iLn70SY29nsq8ceq0/ODvZT4rrEsV/FfBA0giWZmkgXIPO2w3cFd3V5aZsBPG0H7 XSCWpujFf1Vz/lUDcrYK9VMflvHwbU9GFfpMsg+gLNNh5ljcaAEQKVmO28z6RWEi08dm PuTOzNlkXHgfhWmmce9S/3eV0nAM0NNCBczWx0zyr3wLIBbmEcBMQerL65qi9SF4HkmG M0SQ40iaRGMqRU/vFi0C34jG6JMHG8gcfLd9tdf3dsVkSahBvEcJsMq8w2t/3h2BJacq PmbfPyw20OuFArc4aaITw74c2S4yrhWboO6mBg+vf61UhAyL5lgpkwhkWlQtZq/ekQvh GXVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+B6HQlD9n1+wg1dnGdA45hSeHj4ZbZlbqa2TxSvZ22Q=; b=3d62joZoOSbRP5eZOm5lkYFtcXrVDFr6GZmVBGrkInsliWi3sc6D8P5Wg4o6SdL0Q8 zq6KGhM6K6Qj13gBmtuAOmojCppk9Oqa5Ys3xulkMLLyYSuzlU3M5+ZYyDns+P7++7md v6gz5iKTL/acU3sXOcjniOkcfbuOyAsgQ5L3cgZmrXKpPWMtGlXTx0XjfWECwAdeMceL C/7Xq/Oe+Q+C5ne1+tshHGGSEtKOCSzWPyz5sNnbbmGjgp9dczdH/Dx2fJYBN3PsftcY DoDTIQjRLAMR3DKbxsLKjAO27vPpooFefsT69YC9zRg9euh/8VqUvS24TMpTV6/AxRf+ 08iw== X-Gm-Message-State: ANoB5pljyEPCSzZfprxcNyc8BbJGgiQ1yFbqyNapVbptYEkANkPTgUoh o39LMbFTASNS/lvm+ML3mDAzIAmSQ77mSTw5 X-Google-Smtp-Source: AA0mqf4n9wM9NxSytvt05K0KSBjJFeNcw1v/XvKKGi+R42Mbiq+ppNGupJ/rTMpbgAcZshCsFptJPQ== X-Received: by 2002:ac8:41c9:0:b0:3a5:f9eb:247 with SMTP id o9-20020ac841c9000000b003a5f9eb0247mr4574997qtm.186.1668728971756; Thu, 17 Nov 2022 15:49:31 -0800 (PST) Received: from smtpclient.apple (pool-173-56-106-162.nycmny.ftas.verizon.net. [173.56.106.162]) by smtp.gmail.com with ESMTPSA id do52-20020a05620a2b3400b006fba0a389a4sm1375289qkb.88.2022.11.17.15.49.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Nov 2022 15:49:31 -0800 (PST) From: Sean Devlin Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.96\)) Message-Id: <16D8C25F-31A8-44D8-9DDC-3CFF149183C2@toadstyle.org> Date: Thu, 17 Nov 2022 18:49:20 -0500 X-Mailer: Apple Mail (2.3731.300.96) Received-SPF: pass client-ip=2607:f8b0:4864:20::831; envelope-from=spd@toadstyle.org; helo=mail-qt1-x831.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi folks, In version 1.0 of peg.el, there is a PEX to match the syntax class of the character at point. I expected it to advance the point after recognizing the correct class, but it seems that it does not. I expected its behavior to be similar to character classes, sets and ranges, and all of these seem to advance the point. Instead, it seems it is more like a guard expression. To demonstrate this, you can evaluate the following forms: (require 'peg) (with-temp-buffer (save-excursion (insert " ")) (list (save-excursion (cons (peg-run (peg (syntax-class whitespace))) (point))) (save-excursion (cons (peg-run (peg " ")) (point))))) While both PEGs match the character at point, only the latter advances the point. This might just be a matter of documenting the behavior of the syntax-class PEX, but I think it would make more sense if it behaved like character classes, sets, ranges and literals. Thanks! In GNU Emacs 28.2 System Description: macOS Configured using: 'configure --disable-silent-rules --enable-locallisppath=/opt/homebrew/share/emacs/site-lisp --infodir=/opt/homebrew/Cellar/emacs/28.2/share/info/emacs --prefix=/opt/homebrew/Cellar/emacs/28.2 --with-gnutls --without-x --with-xml2 --without-dbus --with-modules --without-ns --without-imagemagick --without-selinux' Configured features: ACL GMP GNUTLS JSON LIBXML2 MODULES NOTIFY KQUEUE PDUMPER THREADS ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow regexp-opt sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail tool-bar rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm byte-opt gv bytecomp byte-compile cconv iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue multi-tty make-network-process emacs) Memory information: ((conses 16 53226 5880) (symbols 48 6605 1) (strings 32 18480 957) (string-bytes 1 607151) (vectors 16 10649) (vector-slots 8 126128 10593) (floats 8 24 302) (intervals 56 220 0) (buffers 992 11)) From unknown Sun Jun 22 00:56:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59345: 28.2; peg.el: syntax-class PEX does not advance point Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2022 06:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Devlin Cc: Helmut Eller , 59345@debbugs.gnu.org Received: via spool by 59345-submit@debbugs.gnu.org id=B59345.16687522087225 (code B ref 59345); Fri, 18 Nov 2022 06:17:01 +0000 Received: (at 59345) by debbugs.gnu.org; 18 Nov 2022 06:16:48 +0000 Received: from localhost ([127.0.0.1]:35029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovugC-0001sT-7B for submit@debbugs.gnu.org; Fri, 18 Nov 2022 01:16:48 -0500 Received: from mout.web.de ([212.227.15.4]:56695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovugA-0001sG-7B for 59345@debbugs.gnu.org; Fri, 18 Nov 2022 01:16:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1668752199; bh=nB1H4yMCjqgsqFDnWpWPFhbqkggEwd8mRUn4o9oi++M=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=k2GSI0l7xbp0uwtjU0OOIrJCzjOqLZFvKx50b9TL8/1dfFi92tIguReL2znMR+o3R eSorgGiTx/04/c2Cap6+5y1GcY7i4wEKTIY5shLxgR7OTf0TgIDvuqNZBTOiceUdJT sSbqGNCxnuBAbYixG7rehz+1bNUl2Odt09p5LjTmhFldxyMUydqAA+H5QdjpM1UprE 82+93mT5zJ7DZe/K9UyIkqbjIAFMsilDdg1/3qhSo8RfURfqHPuAB6PQlQVzDF2Av6 ds9w6Ap0n5mX/VVQzkWj3M6raWDoRv4pI0Sz0rAQoNvyol+huYyyt15vVHETHGaUe+ E7AtcUDEmDXlA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.71.129]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M4sXj-1otzOr3qkh-001wx6; Fri, 18 Nov 2022 07:16:38 +0100 From: Michael Heerdegen In-Reply-To: <16D8C25F-31A8-44D8-9DDC-3CFF149183C2@toadstyle.org> (Sean Devlin's message of "Thu, 17 Nov 2022 18:49:20 -0500") References: <16D8C25F-31A8-44D8-9DDC-3CFF149183C2@toadstyle.org> Date: Fri, 18 Nov 2022 07:16:38 +0100 Message-ID: <875yfcokhl.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:xOUvtHplYV5yqTc9viJyeOa2D6VTdws4RotRcYAcnBVPGVY65nm vor7k+0SAOR9tXGChHY9npjyGb0oWlLvFgXYT05GjDGsLssW1/oRZ+gE30J6bk3NREtRhPG ZAo4ycnZqfdjPgtJAZsJmL2zNkBWCjFW98AmklPN2FtSC59ycppngJSaFH49HRurgvzKon3 rwHUqJbcKgR5y0AY+xjKg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Bwm/xOsWA0k=;xGfaT3q8hCQpoVIkU6Y2/LdmYYw 6o/BxJOB2QAPLldiClBW3WwEovrone21UkeEZEgncOXDI4oF9CVCiUdYLKLcoxQGceuHlQSnG y+Xaap/77V+xxj184ihdabD5/OGPdYa043lKT2tK21BYJt2nboOKMlo1Nu3e4wflv+1OMkmkL Et6nSEFwLaDSJSy9HxPri1uxzvocy9XP1mUvDouPt/zjMY46/+mIMEGh/pvF2pk69DvJ6LsTv xOWFcyZjNJAuPc5EAOiPFXnk1ESh2cNEltJzNItci+5k+cqnBIw683vyH6VSf6x3PJ3LMhEuh fVQZsNI3veyTpYQ/DhIOXqTzFxM1G08+DxupdBp2BrmfamZE77Yj2qE3naziTjV5VsEvHzgvG UMBgcsqs45dw0rBgw83ky0lTSwVYuc8vkjDdmIfIvigWDkUDkpQ//bWyc9EDdOVT0nJ7Ss0aG H6whfOSoGDAi9dop7IqUwzug7cEVnSfff3/cFWTWJbsRQgR1vQpl9CSXeC5N0qSFlfLUFG/jU 8ZOiuENP8mLlc5nIytHSO4soan0UF/S2y4klMRKTW9i4Afi6lt1oq8qi9LkErc08NVs4fW0KX gQAQbA8cXr1MuPVp8L01inYsaSG6QOsnuXbArLq/o1dG2swCflO3rUiszkiqMSpTSOncmN600 Ppj0EEuyKSt5eN/y/TToYS9/0lvy2ZMLjG91PmUz8yNLF3Vhoy/u3EMGXf/Xas9rUGYUTnaiz 2Pc4katBq3wsS/YcD9sqvvbOUOteZiaAdwPkt7FjeoALtSaRYLqFXTKVQCIB0apj80sFNOKdJ kGdI2GNJA4M1x84QOGbFz2RLeHuzhJeSORq8braf26AJ89hw72uMvxr/Zo56j8+Zg2U56YPUF Rl4W2VxpK5zTlw7KfLrO9wHSt3fm8M/V0zfXa23NvJvHbsWDLHGv0cEk4PaLqcVXsdmZ1Xu8P EOWXsA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Sean Devlin writes: > In version 1.0 of peg.el, there is a PEX to match the syntax class of > the character at point. I expected it to advance the point after > recognizing the correct class, but it seems that it does not. Yes, I too think this is a bug. PEGs that match something after the char class matching part even fail, which is definitely not correct: compare in a buffer containing " a": (peg-run (peg (* [blank]) "a")) vs. (peg-run (peg (* (syntax-class whitespace)) "a")) The fist one matches up to the "a", the seconds doesn't, but should. I CC Helmut Eller, the author of peg.el. Michael. From unknown Sun Jun 22 00:56:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59345: 28.2; peg.el: syntax-class PEX does not advance point Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 08:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: Sean Devlin , 59345@debbugs.gnu.org Received: via spool by 59345-submit@debbugs.gnu.org id=B59345.166962434611880 (code B ref 59345); Mon, 28 Nov 2022 08:33:02 +0000 Received: (at 59345) by debbugs.gnu.org; 28 Nov 2022 08:32:26 +0000 Received: from localhost ([127.0.0.1]:47139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozZYw-00035Y-27 for submit@debbugs.gnu.org; Mon, 28 Nov 2022 03:32:26 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:42553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozZYu-00035S-OE for 59345@debbugs.gnu.org; Mon, 28 Nov 2022 03:32:25 -0500 Received: by mail-wr1-f46.google.com with SMTP id w15so2310861wrl.9 for <59345@debbugs.gnu.org>; Mon, 28 Nov 2022 00:32:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=qbyYiGXDIsGmGMNALcCfadjlrNbFiQXk69aqwRmfhJU=; b=TS2En1ZL/DtmgxVDKsWwJPxEYEg8gsgCBhbW1l5dYHu4y4Z0RpGXnMc5EWQVl0uKla k2yTI8Gqv4VOWP8HUrk0/Aat2aA/kuxtLOM/YvifRpgoRBlJ9x5ayu6FvNWEw/963E1O Bvv7gI6PYcesJiT4gToHAkLnAES+nv4kn1Z6GDDmvtRmPFTSv9wAgLzI+aP+uizAKn5z rRPn9Y/0t73smp9s1+fpMta5ucpU5LQh/UizdHVaj/lkwkJGSOIXpQ1YAUmm8j7F3e4y IFNpq3JjSi3QLYBiBcEBu6XzJU7HzXJ/M1eZzpIY72O93K0yXRCbKW4I3CvXIGnI9Mfs JYiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qbyYiGXDIsGmGMNALcCfadjlrNbFiQXk69aqwRmfhJU=; b=CSCWFy4qvN/0TvVBBMD1i5a0pgAKip/VZ9A969L/hymqR0VndTlOIfFKOM0f9O7sPC sl8rsHybQITTaki7eBgDmfJPcANjSZb5qs7s7Emcc5HvDD5xb/Pzh/Vd+Sn4Z4PraQu9 wyr5tL803oSrEVOPeVZHK3bd/NqKd9IucCYyJLJP/WSnN+t40sSiA7ewJ86dWpIvQYuU FlzuS/LTx+CgA2Yn8iYo/yQxXNyJxKw++LgWZ4AhfxHJ98pqoDptKC36K273bJPLCaJm 8Fh6W7wl2Qp9ITmFlHoE10RMpUDH0NxAI60M0kSK21eFXiEzL7D6p3bV8V/OaF/ciq0d GsAQ== X-Gm-Message-State: ANoB5plXHK4ScfRtmElUUjoUrt6wMD2d6qkbSgx6W9JN4e/5PypJkcId qXvvzZCM8+y/7L8nowKVLSsqMiYpgJQ= X-Google-Smtp-Source: AA0mqf6tOsm9S3GMQ29wl4K2nflWhTY9uWyAX8U105KxL/2cfl/cjzvriHbzLurLvJEcbWT/ywaFxQ== X-Received: by 2002:a05:6000:16c2:b0:241:c56c:b485 with SMTP id h2-20020a05600016c200b00241c56cb485mr25997904wrf.566.1669624338792; Mon, 28 Nov 2022 00:32:18 -0800 (PST) Received: from caladan ([89.107.107.73]) by smtp.gmail.com with ESMTPSA id u17-20020a05600c19d100b003c6f8d30e40sm19500428wmq.31.2022.11.28.00.32.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 00:32:18 -0800 (PST) From: Helmut Eller In-Reply-To: <875yfcokhl.fsf@web.de> (Michael Heerdegen's message of "Fri, 18 Nov 2022 07:16:38 +0100") References: <16D8C25F-31A8-44D8-9DDC-3CFF149183C2@toadstyle.org> <875yfcokhl.fsf@web.de> Date: Mon, 28 Nov 2022 09:32:16 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Nov 18 2022, Michael Heerdegen wrote: > Sean Devlin writes: > >> In version 1.0 of peg.el, there is a PEX to match the syntax class of >> the character at point. I expected it to advance the point after >> recognizing the correct class, but it seems that it does not. > > Yes, I too think this is a bug. Yes, looks like an oversight. > I CC Helmut Eller, the author of peg.el. I may be the original author (long ago), but the current maintainer is Sefan Monnier. Helmut From unknown Sun Jun 22 00:56:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59345: 28.2; peg.el: syntax-class PEX does not advance point Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 08:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Sean Devlin , Helmut Eller , 59345@debbugs.gnu.org Received: via spool by 59345-submit@debbugs.gnu.org id=B59345.166962576912929 (code B ref 59345); Mon, 28 Nov 2022 08:57:02 +0000 Received: (at 59345) by debbugs.gnu.org; 28 Nov 2022 08:56:09 +0000 Received: from localhost ([127.0.0.1]:47301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozZvt-0003MT-DW for submit@debbugs.gnu.org; Mon, 28 Nov 2022 03:56:09 -0500 Received: from mout.web.de ([212.227.15.14]:34717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozZvn-0003Li-DX for 59345@debbugs.gnu.org; Mon, 28 Nov 2022 03:56:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1669625752; bh=Y/G4eOq/c8XlTCytrPyPDMxZDmooP53bTB61wydKF/8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=OEj1aqWYUaWsjRBX9d/e86hGImfGcqLeaBN8E//lqa47Ntq80RIRyu3MKcDTluLM4 WPTpGqjRHoI1FcbXMT299MgOqnjerGo0lJ/Fw9otlzqZ7KrvEBvdAFXzc8oaq0rE3t 64osiPwtX1fsdsOAxbEkvzLSmCiSYbbC+KNj8uw6+6Ubbjxn5UZiGD2VL4jHQvyGQ9 kdaj3p0yZ4TiZzPzRUWjdLu/Va5uCP7cPGAvo6ZsuQDEaMzXVBlEx1bcbpzdjREbbH ZtMwfP91mSiQ4+R2IZfe2+n96/ijZDE6f9bCpweA5P13RdjyJCvCcXIbM5MkzX1M1d 4C3ZLs8hn2Mmw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.76.229.140]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MeDMR-1oQEe71NXr-00bHv1; Mon, 28 Nov 2022 09:55:52 +0100 From: Michael Heerdegen In-Reply-To: (Helmut Eller's message of "Mon, 28 Nov 2022 09:32:16 +0100") References: <16D8C25F-31A8-44D8-9DDC-3CFF149183C2@toadstyle.org> <875yfcokhl.fsf@web.de> Date: Mon, 28 Nov 2022 09:55:50 +0100 Message-ID: <87ilizsbjd.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:KPWkOFzWj96MSnzXWt/hpvzYNYUEMHQGH4ujRUA1K1VapBq7coL OZkBf21G6GCJTf4nlOWdWk72VaQGE3WlgQQfa8XDqkMyteeeNqfTtAabZzBujxx6AmcfGm+ MozFixvfBFrC10zGHdaHXkbQsazoLuMSBcT1zsAuavct/shiEmWYcFf38WaRbLAXDOE+g4E qYHRmmP+PGnqhDTI476MA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:SZfrF1QoOwY=;pm7XH8umJsheVQhJAVnX3cuvVuy QMujMuyO9nntzrPBp1BJPOsU3KEQl4Shhkst4P1fB8IeIOvpSkGwL9YZk2hLiErv1Hz9sVJmB tuZOAbUVubrP7nd0hObBmB4zJyB9/aza3t9Yo5bvUYKtFXzTOk3L31LE4hqJJ09/j/Yl1+gSX ATjJeno26I1YDhOdLtC+rkSL7EcOve3eMLWl9MnM0HlLUXSrBc/n1v3ALRaMdheIt35BE2NhA 8JlOA5Yeu/DDj8sTkFsxh2UwRNUEgss29XlliwDT8zEjrBUAyZiz73aiQHOOwDn4eMMXROaI3 4h94TdZC0b3pyG8yFdkNYt3YQEY1fr7slUxzWEIggkiUhAV5HangRzM5pEroXt9jJyhd0Pu+u hdKw259AhNdyQa/eACbzSWXyy0taYJ/c6nNUYSGJuaR9tEpw0Ltqna0b5qp8RGVlBXbpjhECi dw8q3xGgAFqidnO5f+klficX9dJ/YrAu5qqZKDVEM1ZHeU2ptqGtuzB1RSN9KN/0u0iO1l/Ou 1u80SjGH7+BidtyLTStowaf/aOlg2k0/DT8tLUNJ6bRxpA41gx6ONHit7j8SCNgeQ/4zsNxTg VA2qpN84IpuVjOsotLUDoeGVZr4BEydvTxAgOKWG3HPKRa4W0jIyBm6GpTaQ0BmMV63++sB7x pN2pWdy6rH5Uys8D13izE+crrrp+PnzE2OPsWnk0Mc1tMC+tYhmWmq88/b/mV86EL8L4iljXx /kp0QGiTHf4dn0VDzAc7iAbhquzdKsEl7nhzos4SlI5tH/Bu+AVzUVvnavURoKfHWwwxW+vbp kGTSF5nKDZQujhO8zbRRNdmz+ZViODn05XWFzvv/LdSEnA5QZwm+Eg8Zc73W+DofKUkWIvqqs py3uYNhov2RpBQL9eAPRVIB39kMI+7rWwBh8F2vhBQn3YQLjeYuOvxrXnDSGOycqrXR74ui7w wiMxfu2Y/dvYENC9XLkT2vEIwfI= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Helmut Eller writes: > >> In version 1.0 of peg.el, there is a PEX to match the syntax class of > >> the character at point. I expected it to advance the point after > >> recognizing the correct class, but it seems that it does not. > Yes, looks like an oversight. > [...] > I may be the original author (long ago), but the current maintainer is > Sefan Monnier. Ok, thanks for confirming, Helmut. Then I CC Stefan. Michael. From unknown Sun Jun 22 00:56:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59345: 28.2; peg.el: syntax-class PEX does not advance point Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 16:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: Sean Devlin , Helmut Eller , Stefan Monnier , 59345@debbugs.gnu.org Received: via spool by 59345-submit@debbugs.gnu.org id=B59345.166965470923970 (code B ref 59345); Mon, 28 Nov 2022 16:59:01 +0000 Received: (at 59345) by debbugs.gnu.org; 28 Nov 2022 16:58:29 +0000 Received: from localhost ([127.0.0.1]:49718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozhSf-0006EY-7U for submit@debbugs.gnu.org; Mon, 28 Nov 2022 11:58:29 -0500 Received: from mail.ericabrahamsen.net ([52.70.2.18]:53346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozhSd-0006ES-07 for 59345@debbugs.gnu.org; Mon, 28 Nov 2022 11:58:27 -0500 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 5E236FA01F; Mon, 28 Nov 2022 16:58:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1669654700; bh=yj+N6wgjazgcFfQJh9/K1CtPLq9voxVZIHrQzXngt94=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=R7vvsFBnSSNGbFnJ0883/+yneU3frUHiGYM8MjCUHb7UQi6yrFagfmrsniZfrHsIh JHFQ/syrdDxas7RmbS6dE/SeUtLhcQPvNNul0/ntuS62etKwXlWToOmjfTgJupM+aj kKWqj70bQpHrgVd+r3WI1dV/LyGCSA3lkuj5LCA0= From: Eric Abrahamsen In-Reply-To: <87ilizsbjd.fsf@web.de> (Michael Heerdegen's message of "Mon, 28 Nov 2022 09:55:50 +0100") References: <16D8C25F-31A8-44D8-9DDC-3CFF149183C2@toadstyle.org> <875yfcokhl.fsf@web.de> <87ilizsbjd.fsf@web.de> Date: Mon, 28 Nov 2022 08:58:18 -0800 Message-ID: <87r0xnj9sl.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Heerdegen writes: > Helmut Eller writes: > >> >> In version 1.0 of peg.el, there is a PEX to match the syntax class of >> >> the character at point. I expected it to advance the point after >> >> recognizing the correct class, but it seems that it does not. > >> Yes, looks like an oversight. >> [...] >> I may be the original author (long ago), but the current maintainer is >> Sefan Monnier. > > Ok, thanks for confirming, Helmut. Then I CC Stefan. I'm finally getting around to adding this package to core, so I'll stick myself in the Cc. From unknown Sun Jun 22 00:56:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59345: 28.2; peg.el: syntax-class PEX does not advance point Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 22:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: Sean Devlin , Helmut Eller , Stefan Monnier , 59345@debbugs.gnu.org Received: via spool by 59345-submit@debbugs.gnu.org id=B59345.166967523121809 (code B ref 59345); Mon, 28 Nov 2022 22:41:02 +0000 Received: (at 59345) by debbugs.gnu.org; 28 Nov 2022 22:40:31 +0000 Received: from localhost ([127.0.0.1]:51380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozmne-0005fh-Nc for submit@debbugs.gnu.org; Mon, 28 Nov 2022 17:40:30 -0500 Received: from mail.ericabrahamsen.net ([52.70.2.18]:51190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozmnc-0005fa-Kb for 59345@debbugs.gnu.org; Mon, 28 Nov 2022 17:40:29 -0500 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id E8948FA0BD; Mon, 28 Nov 2022 22:40:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1669675222; bh=qT7SZdinne40Hvv8Myiq+LZ4yHpwAg6L5xRsJ6ehO9g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JbqZTLwIrCatSzvuFVpOsO6wBG7dLsUVGk8MiAQHPibcHNkntrmEqpTBL4rWx0JHX /3NeEAHWYTat5FUik2rW+1Mo5PZiqA6aMHPrjR3+TJowBJKxmlg3HBlSJmEcStthnU caELOiwQd/PI8kKcRfmp4wNgr27VwzZyCW7ijkTI= From: Eric Abrahamsen In-Reply-To: <87r0xnj9sl.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 28 Nov 2022 08:58:18 -0800") References: <16D8C25F-31A8-44D8-9DDC-3CFF149183C2@toadstyle.org> <875yfcokhl.fsf@web.de> <87ilizsbjd.fsf@web.de> <87r0xnj9sl.fsf@ericabrahamsen.net> Date: Mon, 28 Nov 2022 14:40:20 -0800 Message-ID: <874jui1z57.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Eric Abrahamsen writes: > Michael Heerdegen writes: > >> Helmut Eller writes: >> >>> >> In version 1.0 of peg.el, there is a PEX to match the syntax class of >>> >> the character at point. I expected it to advance the point after >>> >> recognizing the correct class, but it seems that it does not. >> >>> Yes, looks like an oversight. >>> [...] >>> I may be the original author (long ago), but the current maintainer is >>> Sefan Monnier. >> >> Ok, thanks for confirming, Helmut. Then I CC Stefan. > > I'm finally getting around to adding this package to core, so I'll > stick myself in the Cc. I guess the fix would look like the attached? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=peg_syntax_class.diff diff --git a/peg.el b/peg.el index 0e4221eeb7..3f86a0bf19 100644 --- a/peg.el +++ b/peg.el @@ -588,7 +588,9 @@ of PEG expressions, implicitly combined with `and'." (cl-defmethod peg--translate ((_ (eql syntax-class)) class) (let ((probe (assoc class peg-syntax-classes))) - (cond (probe `(looking-at ,(format "\\s%c" (cadr probe)))) + (cond (probe `(when (looking-at ,(format "\\s%c" (cadr probe))) + (forward-char) + t) (t (error "Invalid syntax class: %S\nMust be one of: %s" class (mapcar #'car peg-syntax-classes)))))) --=-=-=-- From unknown Sun Jun 22 00:56:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59345: 28.2; peg.el: syntax-class PEX does not advance point Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 22:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eric Abrahamsen Cc: Michael Heerdegen , Sean Devlin , Helmut Eller , 59345@debbugs.gnu.org Received: via spool by 59345-submit@debbugs.gnu.org id=B59345.166967582330860 (code B ref 59345); Mon, 28 Nov 2022 22:51:02 +0000 Received: (at 59345) by debbugs.gnu.org; 28 Nov 2022 22:50:23 +0000 Received: from localhost ([127.0.0.1]:51426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozmxD-00081g-47 for submit@debbugs.gnu.org; Mon, 28 Nov 2022 17:50:23 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozmxB-00081a-Ht for 59345@debbugs.gnu.org; Mon, 28 Nov 2022 17:50:22 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8D07F440864; Mon, 28 Nov 2022 17:50:15 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2CF7244081B; Mon, 28 Nov 2022 17:50:10 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1669675810; bh=4dk/s81CKESm+SdiBtCDdM5CDS5neItBSNSOfGESCUo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Ox7USmghjjrOZhMoUoSWoHl7RmRDXQktnkNGVbITVvpn7jEQdzYK58eDVL6mWe2iQ WMLINdGeUPraEiafjsNmVmXXAxC9m+eRh3IalupaQYcM+8ShQhw4efPg6NlJwgfYZr 2pz6/y1z9SxxTmtavG3Z7V2uFhfO1/ut3ytxMZFedIrcdaPWd/VWl/COPuGCoeMfPG VtJIFJxMC/z8CnZAB/ywIARVCgeiagchlm1NYmiiY98FE0xiPnDomk1GxyGuj8foz+ zEkEC5PN4GDmT7e6emKRbkiv4xZq3fdhX+62DU+ynPjNHIs50onH28XijGkT9b/wX4 Dmauk2ZGxu92A== Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D93BD120776; Mon, 28 Nov 2022 17:50:09 -0500 (EST) From: Stefan Monnier In-Reply-To: <874jui1z57.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 28 Nov 2022 14:40:20 -0800") Message-ID: References: <16D8C25F-31A8-44D8-9DDC-3CFF149183C2@toadstyle.org> <875yfcokhl.fsf@web.de> <87ilizsbjd.fsf@web.de> <87r0xnj9sl.fsf@ericabrahamsen.net> <874jui1z57.fsf@ericabrahamsen.net> Date: Mon, 28 Nov 2022 17:50:03 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.175 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > diff --git a/peg.el b/peg.el > index 0e4221eeb7..3f86a0bf19 100644 > --- a/peg.el > +++ b/peg.el > @@ -588,7 +588,9 @@ of PEG expressions, implicitly combined with `and'." > > (cl-defmethod peg--translate ((_ (eql syntax-class)) class) > (let ((probe (assoc class peg-syntax-classes))) > - (cond (probe `(looking-at ,(format "\\s%c" (cadr probe)))) > + (cond (probe `(when (looking-at ,(format "\\s%c" (cadr probe))) > + (forward-char) > + t) > (t (error "Invalid syntax class: %S\nMust be one of: %s" class > (mapcar #'car peg-syntax-classes)))))) > LGTM, Stefan From unknown Sun Jun 22 00:56:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59345: 28.2; peg.el: syntax-class PEX does not advance point Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Nov 2022 09:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eric Abrahamsen Cc: Sean Devlin , Helmut Eller , Stefan Monnier , 59345@debbugs.gnu.org Received: via spool by 59345-submit@debbugs.gnu.org id=B59345.166971522624579 (code B ref 59345); Tue, 29 Nov 2022 09:48:01 +0000 Received: (at 59345) by debbugs.gnu.org; 29 Nov 2022 09:47:06 +0000 Received: from localhost ([127.0.0.1]:54209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozxCk-0006ON-Gz for submit@debbugs.gnu.org; Tue, 29 Nov 2022 04:47:06 -0500 Received: from mout.web.de ([217.72.192.78]:55243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozxCj-0006O0-52 for 59345@debbugs.gnu.org; Tue, 29 Nov 2022 04:47:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1669715203; bh=m5gRQKC85tv5iyD1QbGA6mGaQtk+as5NLYRz0LAU/Ws=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=gQ6tG6miMpRFk3EzxHLR4Wf4hJQ7F7SDa/7pr8kcF49+LhYUkyUVTjU8bXwjKUf9x fjzngLdAU4G8r9sFkrBGyjnhjpcIEUFewiUO089cJhaKdqRZS9uTfPe2jrXvyQVZao ftue/y4STkTpF8Pd2p9N239ZJBgi/T0D+T12rje/YOmqhyVbvepUm53CaGx96Ytf4n o8TyZIPu8zMvTMTLwH9nHI1Xwn4CbmjH8z93s9xyY8rng8VHo+5mMA5IcMyTSbfeny lDycVe8bkWHUYB4WKT9dvL1ZDOF/LutfvARhXKyGlIb5XtZ1X5rMy4ixU8j+DWqt9x I8yy15Zt8wvGg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.76.229.140]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MxHYA-1oojyl1NV2-00xTbG; Tue, 29 Nov 2022 10:46:43 +0100 From: Michael Heerdegen In-Reply-To: <874jui1z57.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 28 Nov 2022 14:40:20 -0800") References: <16D8C25F-31A8-44D8-9DDC-3CFF149183C2@toadstyle.org> <875yfcokhl.fsf@web.de> <87ilizsbjd.fsf@web.de> <87r0xnj9sl.fsf@ericabrahamsen.net> <874jui1z57.fsf@ericabrahamsen.net> Date: Tue, 29 Nov 2022 10:46:41 +0100 Message-ID: <87o7sqw0se.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:oimmdXucE9c5ionVzPcDqg4Qc0zyJYo1EWMe9e5tR+F9/+DEJiH BqmhCEEWHSvhCUSH8/3x52HYdUTmfy3G8Hl8oiEv4sxEacC3d54LXU75xfS+FcWfCS0i6h9 ohDkzw45OPk1wrcyNEhRrVsCHA99H8j/DpuFh+vDCwLB/Vsljl8195IA/aH4zDIfJrR9ehB Xh3pDf3BPItndzZoqrf0g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:DCvbnS53GME=;+bWGBFEJ6YfvROBVfhgdxOi4rp6 LSaBmthoHw7+tb37yuafNfcxIXzkfkoOpx1VSK8KsFrF1pSXYmyNck1R/oQbj8CB6Lv3y6OQV srh4Uct37TN9aS1sZXnS/JRR1Q8tUzTYsvyjPGu9k7mWG7TP+3pQZFX2hNGu0PuKiE0moj4Aq z+YunDAuY2kg7hLqda3NkBS/0G2OM1wkHt7FmOIEQqmQxEsbUsvG3EeSh2/6BdyjnUnffwZoI 7RFtAPIAInqgos/GfGVLo18/aSsvwgZnfxLFzBMrTkJ/yJiZAujhaTWriD8QB1U8Fy/AkQZL7 js1xXxKeSFca+kwmi15sLBHSbu+0QOLBfXMmSl8T2YDx0I2c+t6bJINURiTfmOMGeSHv5eId5 GLynQ3fzsaX4YYivnZWElqeeiV91jautFDCxNgm6tSFFnXYVtC4Lu35nVO1+v2FfYgcPUVWOK b5Z3hCsia+iBYSDeDMyUr1seG/nElF8p4nOuSWmIZSul4gjUQw7CRxY87Up3+plrvtRswQ5ce Hs/W0gLdKZZK7GYzXo2tJqOFdqYIDlWHJZ0FZ5Tc2MxDTtm+DI6h5C6b5ihekTZqzLwXZEBrz 94e34rSM+kWKQEzvOJoOnYNIom/pYsxCLdGCur0xeVnVfvst3JsWw4gvHX1VcqZtz1ZaXsCnp 4gKl0V1Glg0tm6JE3fcfnkOsAhLqdm/Utnt9UG18Hupv0nyMk9CycVMwIHQ2RqRJPl+LwwjnW kevgN60ZLrvMAWL5oiBEB1pCkfELQc+hjkzQqicZEMFv7vOIDQE9em+4FVy7AaP8jrD/z63hI fJNldmJ1Y+dfXlagiuhrAHsB+Je7SW7KGjl5kpCLIOHTMnQS8uNKEeadUGSQJUmQGSP5PbAb/ fLeaenBCL37G5bSV5G8SBoGNf3sLs20yo8+Woy9oNs5EejPvrDazqpyREfaPW/ZKbzmAJ4wMM 2QljWqXc6SWKeVDWzBuxJ+311Gg= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eric Abrahamsen writes: > I guess the fix would look like the attached? Looks also good to me. And I tested and can confirm that the patch fixes the reported issue. Thanks, Michael. From unknown Sun Jun 22 00:56:34 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Sean Devlin Subject: bug#59345: closed (Re: bug#59345: 28.2; peg.el: syntax-class PEX does not advance point) Message-ID: References: <87zgc9zqom.fsf@ericabrahamsen.net> <16D8C25F-31A8-44D8-9DDC-3CFF149183C2@toadstyle.org> X-Gnu-PR-Message: they-closed 59345 X-Gnu-PR-Package: emacs Reply-To: 59345@debbugs.gnu.org Date: Tue, 29 Nov 2022 16:12:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1669738322-16092-1" This is a multi-part message in MIME format... ------------=_1669738322-16092-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #59345: 28.2; peg.el: syntax-class PEX does not advance point which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 59345@debbugs.gnu.org. --=20 59345: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59345 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1669738322-16092-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 59345-done) by debbugs.gnu.org; 29 Nov 2022 16:11:36 +0000 Received: from localhost ([127.0.0.1]:54983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p03Cq-0004BL-7B for submit@debbugs.gnu.org; Tue, 29 Nov 2022 11:11:36 -0500 Received: from mail.ericabrahamsen.net ([52.70.2.18]:60290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p03Cj-0004BF-U5 for 59345-done@debbugs.gnu.org; Tue, 29 Nov 2022 11:11:34 -0500 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 24DF0FA5A1; Tue, 29 Nov 2022 16:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1669738283; bh=Mm1/OOAWmQOiNgTzLqxFsRFGq9x+e0KqJet0tPapzuE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=spLWMilOIfQOGOHV1FFrY2MFOKcYcNjw062C81Kbq3WpAd9J3j8Do46di1wLOmgzO TVL7kuyNkkPgAbK1mZaDVR6/gTG+VG4XKl3k3PskbmYuGsdH+dTMAjdXobHa6JKxdp diJ4V3uEm4oh4t2V9KFxbGd/NswhtrXgU5mOSDlE= From: Eric Abrahamsen To: Michael Heerdegen Subject: Re: bug#59345: 28.2; peg.el: syntax-class PEX does not advance point In-Reply-To: <87o7sqw0se.fsf@web.de> (Michael Heerdegen's message of "Tue, 29 Nov 2022 10:46:41 +0100") References: <16D8C25F-31A8-44D8-9DDC-3CFF149183C2@toadstyle.org> <875yfcokhl.fsf@web.de> <87ilizsbjd.fsf@web.de> <87r0xnj9sl.fsf@ericabrahamsen.net> <874jui1z57.fsf@ericabrahamsen.net> <87o7sqw0se.fsf@web.de> Date: Tue, 29 Nov 2022 08:11:21 -0800 Message-ID: <87zgc9zqom.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59345-done Cc: Sean Devlin , Helmut Eller , Stefan Monnier , 59345-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 11/29/22 10:46 AM, Michael Heerdegen wrote: > Eric Abrahamsen writes: > >> I guess the fix would look like the attached? > > Looks also good to me. And I tested and can confirm that the patch > fixes the reported issue. Thanks for testing! I've added this to peg-tests.el for good measure. Bumped the version number and pushed, and now closing this bug report, thanks to Sean for reporting. Eric ------------=_1669738322-16092-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Nov 2022 23:49:40 +0000 Received: from localhost ([127.0.0.1]:34633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovodY-0000EB-2y for submit@debbugs.gnu.org; Thu, 17 Nov 2022 18:49:40 -0500 Received: from lists.gnu.org ([209.51.188.17]:54424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovodT-0000E0-VM for submit@debbugs.gnu.org; Thu, 17 Nov 2022 18:49:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovodT-0008Hk-Jz for bug-gnu-emacs@gnu.org; Thu, 17 Nov 2022 18:49:35 -0500 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovodR-00039q-JT for bug-gnu-emacs@gnu.org; Thu, 17 Nov 2022 18:49:35 -0500 Received: by mail-qt1-x831.google.com with SMTP id l15so2213258qtv.4 for ; Thu, 17 Nov 2022 15:49:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toadstyle-org.20210112.gappssmtp.com; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=+B6HQlD9n1+wg1dnGdA45hSeHj4ZbZlbqa2TxSvZ22Q=; b=r3iLn70SY29nsq8ceq0/ODvZT4rrEsV/FfBA0giWZmkgXIPO2w3cFd3V5aZsBPG0H7 XSCWpujFf1Vz/lUDcrYK9VMflvHwbU9GFfpMsg+gLNNh5ljcaAEQKVmO28z6RWEi08dm PuTOzNlkXHgfhWmmce9S/3eV0nAM0NNCBczWx0zyr3wLIBbmEcBMQerL65qi9SF4HkmG M0SQ40iaRGMqRU/vFi0C34jG6JMHG8gcfLd9tdf3dsVkSahBvEcJsMq8w2t/3h2BJacq PmbfPyw20OuFArc4aaITw74c2S4yrhWboO6mBg+vf61UhAyL5lgpkwhkWlQtZq/ekQvh GXVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+B6HQlD9n1+wg1dnGdA45hSeHj4ZbZlbqa2TxSvZ22Q=; b=3d62joZoOSbRP5eZOm5lkYFtcXrVDFr6GZmVBGrkInsliWi3sc6D8P5Wg4o6SdL0Q8 zq6KGhM6K6Qj13gBmtuAOmojCppk9Oqa5Ys3xulkMLLyYSuzlU3M5+ZYyDns+P7++7md v6gz5iKTL/acU3sXOcjniOkcfbuOyAsgQ5L3cgZmrXKpPWMtGlXTx0XjfWECwAdeMceL C/7Xq/Oe+Q+C5ne1+tshHGGSEtKOCSzWPyz5sNnbbmGjgp9dczdH/Dx2fJYBN3PsftcY DoDTIQjRLAMR3DKbxsLKjAO27vPpooFefsT69YC9zRg9euh/8VqUvS24TMpTV6/AxRf+ 08iw== X-Gm-Message-State: ANoB5pljyEPCSzZfprxcNyc8BbJGgiQ1yFbqyNapVbptYEkANkPTgUoh o39LMbFTASNS/lvm+ML3mDAzIAmSQ77mSTw5 X-Google-Smtp-Source: AA0mqf4n9wM9NxSytvt05K0KSBjJFeNcw1v/XvKKGi+R42Mbiq+ppNGupJ/rTMpbgAcZshCsFptJPQ== X-Received: by 2002:ac8:41c9:0:b0:3a5:f9eb:247 with SMTP id o9-20020ac841c9000000b003a5f9eb0247mr4574997qtm.186.1668728971756; Thu, 17 Nov 2022 15:49:31 -0800 (PST) Received: from smtpclient.apple (pool-173-56-106-162.nycmny.ftas.verizon.net. [173.56.106.162]) by smtp.gmail.com with ESMTPSA id do52-20020a05620a2b3400b006fba0a389a4sm1375289qkb.88.2022.11.17.15.49.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Nov 2022 15:49:31 -0800 (PST) From: Sean Devlin Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.96\)) Subject: 28.2; peg.el: syntax-class PEX does not advance point Message-Id: <16D8C25F-31A8-44D8-9DDC-3CFF149183C2@toadstyle.org> Date: Thu, 17 Nov 2022 18:49:20 -0500 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3731.300.96) Received-SPF: pass client-ip=2607:f8b0:4864:20::831; envelope-from=spd@toadstyle.org; helo=mail-qt1-x831.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi folks, In version 1.0 of peg.el, there is a PEX to match the syntax class of the character at point. I expected it to advance the point after recognizing the correct class, but it seems that it does not. I expected its behavior to be similar to character classes, sets and ranges, and all of these seem to advance the point. Instead, it seems it is more like a guard expression. To demonstrate this, you can evaluate the following forms: (require 'peg) (with-temp-buffer (save-excursion (insert " ")) (list (save-excursion (cons (peg-run (peg (syntax-class whitespace))) (point))) (save-excursion (cons (peg-run (peg " ")) (point))))) While both PEGs match the character at point, only the latter advances the point. This might just be a matter of documenting the behavior of the syntax-class PEX, but I think it would make more sense if it behaved like character classes, sets, ranges and literals. Thanks! In GNU Emacs 28.2 System Description: macOS Configured using: 'configure --disable-silent-rules --enable-locallisppath=/opt/homebrew/share/emacs/site-lisp --infodir=/opt/homebrew/Cellar/emacs/28.2/share/info/emacs --prefix=/opt/homebrew/Cellar/emacs/28.2 --with-gnutls --without-x --with-xml2 --without-dbus --with-modules --without-ns --without-imagemagick --without-selinux' Configured features: ACL GMP GNUTLS JSON LIBXML2 MODULES NOTIFY KQUEUE PDUMPER THREADS ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow regexp-opt sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail tool-bar rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils term/xterm xterm byte-opt gv bytecomp byte-compile cconv iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue multi-tty make-network-process emacs) Memory information: ((conses 16 53226 5880) (symbols 48 6605 1) (strings 32 18480 957) (string-bytes 1 607151) (vectors 16 10649) (vector-slots 8 126128 10593) (floats 8 24 302) (intervals 56 220 0) (buffers 992 11)) ------------=_1669738322-16092-1--