GNU bug report logs - #5934
24.0.50; get rid of "unix" pre-defined macro when preprocessing Makefile

Previous Next

Full log

Message #12 received at 5934 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Miles Bader <miles <at> gnu.org>
Cc: 5934 <at> debbugs.gnu.org, emacs-devel <at> gnu.org
Subject: Re: 24.0.50;
	get rid of "unix" pre-defined macro when preprocessing Makefile
Date: Mon, 12 Apr 2010 10:00:02 -0400

Miles Bader <miles.bader.fz <at> renesas.com> writes:

> Emacs uses the C preprocessor to process src/Makefile.in, and the CPP on
> many systems defines the token "unix" (to be "1") for historical
> reasons.
>
> This has bad results if some of the Makefile contents include that
> token; in particular, on my system, the definition of ALL_CFLAGS
> contains " -I/usr/include/gio-unix-2.0/", and due to the bogus
> predefined unix macro, this ends up as something that's not even legal
> compiler command-line syntax.
>
> Luckily,  the "unix" macro isn't actually used by Makefile
> preprocessing, so it's simple enough to add that to the list of things
> which the Emacs configure script explicitly undefines when doing
> Makefile preprocessing.
>
> The following patch does this:

Looks good, could you check it into the trunk?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.