GNU bug report logs - #59333
[PATCH] Define macro dlet*

Previous Next

Full log

Message #8 received at 59333 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: daanturo <daanturo <at> gmail.com>, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 Mattias Engdegård <mattiase <at> acm.org>
Cc: 59333 <at> debbugs.gnu.org
Subject: Re: bug#59333: [PATCH] Define macro dlet*
Date: Thu, 17 Nov 2022 09:25:00 +0200

> Date: Thu, 17 Nov 2022 14:13:35 +0700
> From: daanturo <daanturo <at> gmail.com>
> 
> The dlet breakage comes as much surprise to me. There's not even a
> single entry in NEWS that mentions it.

dlet was new in Emacs 28, and the change you mention was done before
Emacs 28 was released.  So NEWS just mentions the introduction of
dlet, and that is enough.

> I would rather prefer b72f88518b89560accf740a4548368863e6238e0 be
> reverted, though. But maybe that's fine if the majority of maintainers
> agree with that change. But please mention similar breakages more
> universally.

I can only understand the breakage if someone picked up dlet as
originally implemented on master, before Emacs 28 was released.  In
that case, it's the risk people take when they follow the development
code too closely.

As for the patch, I'd like to hear opinions about the need for dlet*.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.