Subject: bug#59327: closed (Re: [bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy native-input.)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 22 Nov 2022 09:40:02 +0000

Your bug report

#59327: [PATCH] gnu: python-pudb: Add missing python-numpy native-input.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
59327: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59327
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#59327] [PATCH] gnu: python-pudb: Add missing python-numpy native-input.
From: Christopher Baines <[email-masked]>
To: jgart <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Tue, 22 Nov 2022 09:38:06 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

jgart <[email-masked]> writes:

> On Mon, 21 Nov 2022 08:34:50 -0600 jgart <[email-masked]> wrote:
>> I'll check later today and report back.
>
> Oh, that test just passes an empty list if numpy is not available:
>
> https://github.com/inducer/pudb/blob/v2022.1.3/test/test_var_view.py#L32
>
> Do we want to run that test with our packaged numpy on [np.float32(5),
> np.zeros(5)]?

That seems fine to me, I've tweaked the commit message to describe it as
an "optional test dependency", rather than "missing". and pushed to
master as eda5e9aaafeacc0e21dbf43200d79b91fc1e38ed.

Thanks,

Chris

Subject: [PATCH] gnu: python-pudb: Add missing python-numpy native-input.
From: jgart <[email-masked]>
To: [email-masked]
Cc: jgart <[email-masked]>
Date: Wed, 16 Nov 2022 19:48:33 -0600
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/python-xyz.scm (python-pudb): Add missing native-input.
[native-inputs]: Add python-numpy.
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index a6b1c7e27e..0968f1477f 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -29153,7 +29153,7 @@ (define-public python-pudb
                     (lambda* (#:key tests? #:allow-other-keys)
                       (when tests?
                         (invoke "pytest" "-vv")))))))
-    (native-inputs (list python-pytest python-pytest-mock))
+    (native-inputs (list python-pytest python-pytest-mock python-numpy))
     (propagated-inputs (list python-jedi python-pygments python-urwid
                              python-urwid-readline))
     (home-page "https://documen.tician.de/pudb/")
-- 
2.38.1