From unknown Sat Aug 09 09:36:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59326: 29.0.50; [PATCH] Handle bookmark-relocate error Resent-From: Gabriel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Nov 2022 01:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59326 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 59326@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16686480637845 (code B ref -1); Thu, 17 Nov 2022 01:22:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Nov 2022 01:21:03 +0000 Received: from localhost ([127.0.0.1]:58551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovTaQ-00022T-IH for submit@debbugs.gnu.org; Wed, 16 Nov 2022 20:21:02 -0500 Received: from lists.gnu.org ([209.51.188.17]:60672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovTaN-00021i-7g for submit@debbugs.gnu.org; Wed, 16 Nov 2022 20:21:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovTaN-00037u-36 for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 20:20:59 -0500 Received: from mail-bn8nam11olkn20800.outbound.protection.outlook.com ([2a01:111:f400:7eae::800] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovTaK-0002l6-UY for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 20:20:58 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ekyYuxpgxP7CBLnWkEq+yNPyUpwSw068xYHhITQxHrjJY8rgf+KlRiiYkC/G0dvRhqEsIeYT/2zRLpyHR4RpU4B2DLouU2wDWpp7Sd9C1k6dwc6X8UUKTMfWw/UT4bhY/QAolnTuoUI/JOdg8yKLhPyXvZBeEzbfIkfXozLtJtqLGx7eF4FDlNr8Cu7lcBfrYje2aLa8D9jjTbjtZi+LB/Bz+pcHjQgP2a9HR1WIJnBa0BQor2+MN9wu5KdNX0AoAoQ1B/2OW00AdyUIF3W116AVA8MLjKgWAiiWRgHxrptfJ59B1Hgr9JSdlHsPcJ3RQpXQT5u7Ngk7JBmfBhf9EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0HlibzfVG74gNyuhKoDVUsrEfFCMPpIz0AqiDdv6Fao=; b=VPKli2u7Vlu3PsZsChEe4YVs7CfRpYt7O7+RNLd3I0kw+w0QGX5DvCcdovG5u6aVB6x8AzB3EtfDbjZWYguHwKgcjoEoPX6TQAIZH2pp9ASGOufYs+BOpCWtUSPKsnwScdTfcwczRl81zzCDMw3aZnyvTug0PbxbeI/76bkwlW9C8Wo/TjGdtXA9B4vfa2J0FUrpUfaHXED5DkIScXpL7QZU77SXxLAZcD9RdstyrqKHPJ0bvxe+aLXd9uGKTX+Q9thVp+SWylKn/0nMZkS36rGSNRgfpZi7y/ri1YqYRU1bGJ0IC6jIe4KxrDZ3BGCgt5cGJvc6mtVBj9PktXtACQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0HlibzfVG74gNyuhKoDVUsrEfFCMPpIz0AqiDdv6Fao=; b=tUT9iWjQ7DJfSewoise18xnWyVL/+7YIuSmC4lOMrdIxZ6PbLDhi0FQa5v7J3kJr64O6es9x8vR8ityNGCytm6ZXYHarYHWf1UAx7F23SCNHgul3MBf48XDzJ0fpKK9YMkK13dJ38AqF4rV3NBMpoQmiZajTMeb7BSIUKKKcwST0Pg3mntKhCrdH0OGdkbvykc1LAefP5ICfaWeLMB8t4yjVzJ6fUebxHgD+RvfBLh2NOHc9PCB5Pv7svhOE1SB7bm6MP/+WKI9XzTrNQbgo3HXBvYXnnxFs1KwGhwoekQEgsvPXQMA2gOsRqoPD63ZK9njErcIjnECJ0i6GUkrHJw== Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) by PH0PR06MB8619.namprd06.prod.outlook.com (2603:10b6:510:11a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 01:15:48 +0000 Received: from SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f%4]) with mapi id 15.20.5813.011; Thu, 17 Nov 2022 01:15:48 +0000 From: Gabriel Date: Wed, 16 Nov 2022 22:15:40 -0300 Message-ID: Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [MaSns+h5kw4D4k5mX+q5L7sW9EbeVccNvvCji0/B1U2sH9XTA1WPAcHcFq6rCyN7] X-ClientProxiedBy: CP5P284CA0076.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:93::9) To SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) X-Microsoft-Original-Message-ID: <87fseiwfcz.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|PH0PR06MB8619:EE_ X-MS-Office365-Filtering-Correlation-Id: 85da964c-3bd4-4877-1464-08dac8394213 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4vdxKcZLSIxBreKXOOW1o03Fyezjmg8SMqv9ytmce45KvAS/E3aQk4th1Rb2r/Sn56KKQYdlL9m10vIbu5CRuQMSTrvD3lMHFzv45bNFl6iFrSMUU1naha69mmvZY7JqUXZsA63Wi4orbc9vy/3ob11cD5oqaoonPfZqTraeSj1dRHgoFr7L5+XNcKp4sK/qyYt9Ao323mGDFRKBv+xs7M8aLVxjbvkrSSLQWfy8DXUqMAPW1m8hGka7J3Crgbmu1P2xUXwI51xwqv7lADNwt2Wn40evBzOXQzuglzF9SB4Dj45soeU1bG+pkrIO/WXcWtA0MvaZdbqrdOIMgheD0K9Lsv34Orb8ibcrGeamo5kOrx0dDBIs0cYaDl4eWqOF/b+e8z6Yn4+zsR/W+uILldyujxyGaUrFuXdi6VcCow0nPi0rscl1w4ySxfyrGvZqu24oYaZW09oZqREABRthXohHSh73tMpDAGnVk3mMm4XZYl7WxhK//+A4PJWcZD6fE5cjijl22UeIkF5gYOXQuXPUZTIjsFmcC9OclynGaoFLY20PVJib02OtWsuWOyRlavbL6uhx+xs16fsZisRKAw5iWSp7T6CCK5bfjDZSn96UPCcL2jYilTl70si4gFqB X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: W1TbpVBAJcUIfU1NtWlQ0PjE+E0u64xapF8z0/tsuRCuL3Na28Hh1ch0x6F5BAj8Kruyy2XNa05UFt2QrRLOdf3CO3D3wfVxrYKZzDgcY/5uWmdIPuNHvFBDXU2OfdHkGJjX0NKb8+6+X9kP0ADUZpBMrOvEVeC/K9RLVWJsBkuIi06ocpcuDzdwmzEGhnQSbS0yh4ub9qotpuAXU38IDNky5b24/2C0ihCj8f6wXdTpPTm94qzD9TGCIHZuWBRyl/0elpYXaNYUp5d6zsn148xuGeJqDaZ1UpZ+FMGQLPJjkG9n+OLpHabD03EmxPftL7Yjth3I5r04kdHL0Qe97GE9dqXVdpQX9O94bvJbt0q3SA0va5GSjvROyd9v9xMkhhs9J470UGKS0JnuGcmmP9+fWNGPlq6Pl2uoQbkMyjbZjgfxXYqsR7x3DQmsZ83lDXvW+tixsp/tYycQAx9qzJDQ6A0wFfmD//U4U5bZ2AXZArP+5vOu66rbc4N/QT4MiNzew/jTs3bkrMzy/MnireyWPAaoMuTIHT7dFLslZx9Z4jDJTblRNYRjncoOmeH8yC3iIIsQQjMejFpcCzMwNsuubXUZmfKkekFIS70IAcFGOHKADJUQHB46CqFFwu6EUEzC3e/aO/t9OW3eUUmY8UfGAmgdH3kckx1JED4MkfVi4fH2+6CXINfGbHDiYpICRyROXeMPnHhYxKkJF8BWUolB4NAudiWilt/VWwwIdIQp4FRnLaJMOWOiZE+7+OItYb2BLtY2B9l198H7TD0QY1WmlgxTN9HV8a3icGmH9KMvkilokB3Jg5XK5oyHR65pQWd95M5Hi2B2yblno4I1OItEWhDBNmMLHTrQbOWlDztk6Ok9MyIHPTVN0NmhZgn1Gn8sXvDQz80t8aP7mRULfuR0cuQHUY4bknViXDkNAshEr7Tnf7vLN2HOrKfqwTxNvXGnfsWqLhjWjsiVICZSoEiTYOER6WRCJghDe32kPUusfmQ8oHIw/akpwoHPSKUGFnaWPrOJOZLXHSIbgGbkUYBS4+jG6b8vorvDhyS8FuI3W/Si22FN48ZFPJ0f+R73tEMj5UXYm+ON5oaugyTRvBgkhNI4nPjNPfAXSCRM2XKuI27jCBbxFFmf4rv8asJPQ9wq/FqP8FP5ANi82sdqvY1CFqTCEp+XvvvNSoujKSC5dUG4XY0JMaSYNoN+CSSKf+FeubK3sEZuIIOT8tg8pi+Q5uTSMK2oLTRUyhXkqijVFKUn8sJL5uq4pfSp/TRxprQoFpzzbkWmO/5fIJJCrYyTDpNNiwSTyWcgUjaOmsOrTOPEMyKn6PMVv0l0OdOTJ+O6gEJWfGM9krimGVZ5eA== X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 85da964c-3bd4-4877-1464-08dac8394213 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 01:15:48.2169 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR06MB8619 Received-SPF: pass client-ip=2a01:111:f400:7eae::800; envelope-from=gabriel376@hotmail.com; helo=NAM11-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Description: Currently, Bookmark does not support relocate (bookmark-relocate) for Types that do not have a filename (e.g.: Eshell, EWW, Man etc). We still need to figure out a good way to let Bookmark Types to provide their own implementation (suggestions are welcome). While we don't teach Bookmark to provide such feature, it should handle these cases and provide an useful error message for users. See discussion [1]. Steps: 1) emacs -Q (master f793add1758fd01f678698a90f5847b575f63cf8) 2) Run Eshell: M-x eshell RET 3) Add Eshell to Bookmark list: C-x r m RET 4) Open Bookmark list: C-x r l 5) Try to relocate the Eshell bookmark: R Result: bookmark-relocate: Wrong type argument: stringp, nil Patch: A remediation patch is attached. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Handle-error-in-bookmark-relocate-when-filename-is-n.patch >From f528e26047974d044e35828c52c35229705b278b Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Wed, 16 Nov 2022 21:59:17 -0300 Subject: [PATCH 1/1] Handle error in bookmark-relocate when filename is nil * lisp/bookmark.el (bookmark-relocate): Handle error when filename is nil. --- lisp/bookmark.el | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/lisp/bookmark.el b/lisp/bookmark.el index b57ad12986..45b116ee00 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -1396,20 +1396,25 @@ bookmark-relocate (interactive (list (bookmark-completing-read "Bookmark to relocate"))) (bookmark-maybe-historicize-string bookmark-name) (bookmark-maybe-load-default-file) - (let* ((bmrk-filename (bookmark-get-filename bookmark-name)) - (newloc (abbreviate-file-name - (expand-file-name - (read-file-name - (format "Relocate %s to: " bookmark-name) - (file-name-directory bmrk-filename)))))) - (bookmark-set-filename bookmark-name newloc) - (bookmark-update-last-modified bookmark-name) - (setq bookmark-alist-modification-count - (1+ bookmark-alist-modification-count)) - (if (bookmark-time-to-save-p) + (let ((bmrk-filename (bookmark-get-filename bookmark-name))) + ;; FIXME: Make `bookmark-relocate' support bookmark Types + ;; besides files and directories. + (unless bmrk-filename + (user-error "Cannot relocate bookmark of type \"%s\"" + (bookmark-type-from-full-record + (bookmark-get-bookmark bookmark-name)))) + (let ((newloc (abbreviate-file-name + (expand-file-name + (read-file-name + (format "Relocate %s to: " bookmark-name) + (file-name-directory bmrk-filename)))))) + (bookmark-set-filename bookmark-name newloc) + (bookmark-update-last-modified bookmark-name) + (setq bookmark-alist-modification-count + (1+ bookmark-alist-modification-count)) + (when (bookmark-time-to-save-p) (bookmark-save)) - (bookmark-bmenu-surreptitiously-rebuild-list))) - + (bookmark-bmenu-surreptitiously-rebuild-list)))) ;;;###autoload (defun bookmark-insert-location (bookmark-name &optional no-history) -- 2.34.1 --=-=-= Content-Type: text/plain [1] https://mail.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html --- Gabriel --=-=-=-- From unknown Sat Aug 09 09:36:43 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Gabriel Subject: bug#59326: closed (Re: bug#59326: 29.0.50; [PATCH] Handle bookmark-relocate error) Message-ID: References: <83pmdi53ql.fsf@gnu.org> X-Gnu-PR-Message: they-closed 59326 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 59326@debbugs.gnu.org Date: Sun, 20 Nov 2022 10:18:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1668939482-21664-1" This is a multi-part message in MIME format... ------------=_1668939482-21664-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #59326: 29.0.50; [PATCH] Handle bookmark-relocate error which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 59326@debbugs.gnu.org. --=20 59326: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59326 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1668939482-21664-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 59326-done) by debbugs.gnu.org; 20 Nov 2022 10:17:53 +0000 Received: from localhost ([127.0.0.1]:42387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owhOb-0005d6-5z for submit@debbugs.gnu.org; Sun, 20 Nov 2022 05:17:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owhOZ-0005ct-8W for 59326-done@debbugs.gnu.org; Sun, 20 Nov 2022 05:17:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owhOT-00063s-Ud; Sun, 20 Nov 2022 05:17:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FWw6IOpvfVvA4UFHjFmJi9isdhI0XUc0IJdNQ3iwkao=; b=Uft3fX98ILZA D1gaBIf19h1dh6h8T84z6s5XTIF4WD68q9zPMCsr3sRWjeVO9WNEp1W0lPEraYiw8QNv7Jk8AMAVC PmkGrxOPVXi1sy0uxmFvKwIVrKOV+qAkOhtPqXRb/MEFmCBk4+UYRgC46QoV2wlE8qF8BxY9Fq6Tt l1EFQesgELf/KxIoDqpgua8MYW1gycM+Z943sGkqwS/MlI5v0epkM2v+Hyb6h/HU4V0brJkSKjipu FyOGHpXmBh7bwMxjlxQTjchiLpH6pP9gg5NTWkGO4MCwQAiqdZ2NCMB4ikbAFd8dBgEZ1M7pgHX9U 4w+ppo4ux7DChJoVJmv6Pg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owhOT-00058k-0o; Sun, 20 Nov 2022 05:17:45 -0500 Date: Sun, 20 Nov 2022 12:17:54 +0200 Message-Id: <83pmdi53ql.fsf@gnu.org> From: Eli Zaretskii To: Gabriel In-Reply-To: (message from Gabriel on Wed, 16 Nov 2022 22:15:40 -0300) Subject: Re: bug#59326: 29.0.50; [PATCH] Handle bookmark-relocate error References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59326-done Cc: 59326-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Gabriel > Date: Wed, 16 Nov 2022 22:15:40 -0300 > > Currently, Bookmark does not support relocate (bookmark-relocate) for > Types that do not have a filename (e.g.: Eshell, EWW, Man etc). We > still need to figure out a good way to let Bookmark Types to provide > their own implementation (suggestions are welcome). While we don't > teach Bookmark to provide such feature, it should handle these cases and > provide an useful error message for users. See discussion [1]. > > Steps: > > 1) emacs -Q (master f793add1758fd01f678698a90f5847b575f63cf8) > > 2) Run Eshell: M-x eshell RET > > 3) Add Eshell to Bookmark list: C-x r m RET > > 4) Open Bookmark list: C-x r l > > 5) Try to relocate the Eshell bookmark: R > > Result: bookmark-relocate: Wrong type argument: stringp, nil > > Patch: > > A remediation patch is attached. Thanks, installed, and closing the bug. ------------=_1668939482-21664-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Nov 2022 01:21:03 +0000 Received: from localhost ([127.0.0.1]:58551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovTaQ-00022T-IH for submit@debbugs.gnu.org; Wed, 16 Nov 2022 20:21:02 -0500 Received: from lists.gnu.org ([209.51.188.17]:60672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovTaN-00021i-7g for submit@debbugs.gnu.org; Wed, 16 Nov 2022 20:21:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovTaN-00037u-36 for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 20:20:59 -0500 Received: from mail-bn8nam11olkn20800.outbound.protection.outlook.com ([2a01:111:f400:7eae::800] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovTaK-0002l6-UY for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 20:20:58 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ekyYuxpgxP7CBLnWkEq+yNPyUpwSw068xYHhITQxHrjJY8rgf+KlRiiYkC/G0dvRhqEsIeYT/2zRLpyHR4RpU4B2DLouU2wDWpp7Sd9C1k6dwc6X8UUKTMfWw/UT4bhY/QAolnTuoUI/JOdg8yKLhPyXvZBeEzbfIkfXozLtJtqLGx7eF4FDlNr8Cu7lcBfrYje2aLa8D9jjTbjtZi+LB/Bz+pcHjQgP2a9HR1WIJnBa0BQor2+MN9wu5KdNX0AoAoQ1B/2OW00AdyUIF3W116AVA8MLjKgWAiiWRgHxrptfJ59B1Hgr9JSdlHsPcJ3RQpXQT5u7Ngk7JBmfBhf9EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0HlibzfVG74gNyuhKoDVUsrEfFCMPpIz0AqiDdv6Fao=; b=VPKli2u7Vlu3PsZsChEe4YVs7CfRpYt7O7+RNLd3I0kw+w0QGX5DvCcdovG5u6aVB6x8AzB3EtfDbjZWYguHwKgcjoEoPX6TQAIZH2pp9ASGOufYs+BOpCWtUSPKsnwScdTfcwczRl81zzCDMw3aZnyvTug0PbxbeI/76bkwlW9C8Wo/TjGdtXA9B4vfa2J0FUrpUfaHXED5DkIScXpL7QZU77SXxLAZcD9RdstyrqKHPJ0bvxe+aLXd9uGKTX+Q9thVp+SWylKn/0nMZkS36rGSNRgfpZi7y/ri1YqYRU1bGJ0IC6jIe4KxrDZ3BGCgt5cGJvc6mtVBj9PktXtACQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0HlibzfVG74gNyuhKoDVUsrEfFCMPpIz0AqiDdv6Fao=; b=tUT9iWjQ7DJfSewoise18xnWyVL/+7YIuSmC4lOMrdIxZ6PbLDhi0FQa5v7J3kJr64O6es9x8vR8ityNGCytm6ZXYHarYHWf1UAx7F23SCNHgul3MBf48XDzJ0fpKK9YMkK13dJ38AqF4rV3NBMpoQmiZajTMeb7BSIUKKKcwST0Pg3mntKhCrdH0OGdkbvykc1LAefP5ICfaWeLMB8t4yjVzJ6fUebxHgD+RvfBLh2NOHc9PCB5Pv7svhOE1SB7bm6MP/+WKI9XzTrNQbgo3HXBvYXnnxFs1KwGhwoekQEgsvPXQMA2gOsRqoPD63ZK9njErcIjnECJ0i6GUkrHJw== Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) by PH0PR06MB8619.namprd06.prod.outlook.com (2603:10b6:510:11a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 17 Nov 2022 01:15:48 +0000 Received: from SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f%4]) with mapi id 15.20.5813.011; Thu, 17 Nov 2022 01:15:48 +0000 From: Gabriel To: bug-gnu-emacs@gnu.org Subject: 29.0.50; [PATCH] Handle bookmark-relocate error Date: Wed, 16 Nov 2022 22:15:40 -0300 Message-ID: Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [MaSns+h5kw4D4k5mX+q5L7sW9EbeVccNvvCji0/B1U2sH9XTA1WPAcHcFq6rCyN7] X-ClientProxiedBy: CP5P284CA0076.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:93::9) To SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) X-Microsoft-Original-Message-ID: <87fseiwfcz.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|PH0PR06MB8619:EE_ X-MS-Office365-Filtering-Correlation-Id: 85da964c-3bd4-4877-1464-08dac8394213 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4vdxKcZLSIxBreKXOOW1o03Fyezjmg8SMqv9ytmce45KvAS/E3aQk4th1Rb2r/Sn56KKQYdlL9m10vIbu5CRuQMSTrvD3lMHFzv45bNFl6iFrSMUU1naha69mmvZY7JqUXZsA63Wi4orbc9vy/3ob11cD5oqaoonPfZqTraeSj1dRHgoFr7L5+XNcKp4sK/qyYt9Ao323mGDFRKBv+xs7M8aLVxjbvkrSSLQWfy8DXUqMAPW1m8hGka7J3Crgbmu1P2xUXwI51xwqv7lADNwt2Wn40evBzOXQzuglzF9SB4Dj45soeU1bG+pkrIO/WXcWtA0MvaZdbqrdOIMgheD0K9Lsv34Orb8ibcrGeamo5kOrx0dDBIs0cYaDl4eWqOF/b+e8z6Yn4+zsR/W+uILldyujxyGaUrFuXdi6VcCow0nPi0rscl1w4ySxfyrGvZqu24oYaZW09oZqREABRthXohHSh73tMpDAGnVk3mMm4XZYl7WxhK//+A4PJWcZD6fE5cjijl22UeIkF5gYOXQuXPUZTIjsFmcC9OclynGaoFLY20PVJib02OtWsuWOyRlavbL6uhx+xs16fsZisRKAw5iWSp7T6CCK5bfjDZSn96UPCcL2jYilTl70si4gFqB X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W1TbpVBAJcUIfU1NtWlQ0PjE+E0u64xapF8z0/tsuRCuL3Na28Hh1ch0x6F5?= =?us-ascii?Q?BAj8Kruyy2XNa05UFt2QrRLOdf3CO3D3wfVxrYKZzDgcY/5uWmdIPuNHvFBD?= =?us-ascii?Q?XU2OfdHkGJjX0NKb8+6+X9kP0ADUZpBMrOvEVeC/K9RLVWJsBkuIi06ocpcu?= =?us-ascii?Q?DzdwmzEGhnQSbS0yh4ub9qotpuAXU38IDNky5b24/2C0ihCj8f6wXdTpPTm9?= =?us-ascii?Q?4qzD9TGCIHZuWBRyl/0elpYXaNYUp5d6zsn148xuGeJqDaZ1UpZ+FMGQLPJj?= =?us-ascii?Q?kG9n+OLpHabD03EmxPftL7Yjth3I5r04kdHL0Qe97GE9dqXVdpQX9O94bvJb?= =?us-ascii?Q?t0q3SA0va5GSjvROyd9v9xMkhhs9J470UGKS0JnuGcmmP9+fWNGPlq6Pl2uo?= =?us-ascii?Q?QbkMyjbZjgfxXYqsR7x3DQmsZ83lDXvW+tixsp/tYycQAx9qzJDQ6A0wFfmD?= =?us-ascii?Q?//U4U5bZ2AXZArP+5vOu66rbc4N/QT4MiNzew/jTs3bkrMzy/MnireyWPAao?= =?us-ascii?Q?MuTIHT7dFLslZx9Z4jDJTblRNYRjncoOmeH8yC3iIIsQQjMejFpcCzMwNsuu?= =?us-ascii?Q?bXUZmfKkekFIS70IAcFGOHKADJUQHB46CqFFwu6EUEzC3e/aO/t9OW3eUUmY?= =?us-ascii?Q?8UfGAmgdH3kckx1JED4MkfVi4fH2+6CXINfGbHDiYpICRyROXeMPnHhYxKkJ?= =?us-ascii?Q?F8BWUolB4NAudiWilt/VWwwIdIQp4FRnLaJMOWOiZE+7+OItYb2BLtY2B9l1?= =?us-ascii?Q?98H7TD0QY1WmlgxTN9HV8a3icGmH9KMvkilokB3Jg5XK5oyHR65pQWd95M5H?= =?us-ascii?Q?i2B2yblno4I1OItEWhDBNmMLHTrQbOWlDztk6Ok9MyIHPTVN0NmhZgn1Gn8s?= =?us-ascii?Q?XvDQz80t8aP7mRULfuR0cuQHUY4bknViXDkNAshEr7Tnf7vLN2HOrKfqwTxN?= =?us-ascii?Q?vXGnfsWqLhjWjsiVICZSoEiTYOER6WRCJghDe32kPUusfmQ8oHIw/akpwoHP?= =?us-ascii?Q?SKUGFnaWPrOJOZLXHSIbgGbkUYBS4+jG6b8vorvDhyS8FuI3W/Si22FN48ZF?= =?us-ascii?Q?PJ0f+R73tEMj5UXYm+ON5oaugyTRvBgkhNI4nPjNPfAXSCRM2XKuI27jCBbx?= =?us-ascii?Q?FFmf4rv8asJPQ9wq/FqP8FP5ANi82sdqvY1CFqTCEp+XvvvNSoujKSC5dUG4?= =?us-ascii?Q?XY0JMaSYNoN+CSSKf+FeubK3sEZuIIOT8tg8pi+Q5uTSMK2oLTRUyhXkqijV?= =?us-ascii?Q?FKUn8sJL5uq4pfSp/TRxprQoFpzzbkWmO/5fIJJCrYyTDpNNiwSTyWcgUjaO?= =?us-ascii?Q?msOrTOPEMyKn6PMVv0l0OdOTJ+O6gEJWfGM9krimGVZ5eA=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 85da964c-3bd4-4877-1464-08dac8394213 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 01:15:48.2169 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR06MB8619 Received-SPF: pass client-ip=2a01:111:f400:7eae::800; envelope-from=gabriel376@hotmail.com; helo=NAM11-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Description: Currently, Bookmark does not support relocate (bookmark-relocate) for Types that do not have a filename (e.g.: Eshell, EWW, Man etc). We still need to figure out a good way to let Bookmark Types to provide their own implementation (suggestions are welcome). While we don't teach Bookmark to provide such feature, it should handle these cases and provide an useful error message for users. See discussion [1]. Steps: 1) emacs -Q (master f793add1758fd01f678698a90f5847b575f63cf8) 2) Run Eshell: M-x eshell RET 3) Add Eshell to Bookmark list: C-x r m RET 4) Open Bookmark list: C-x r l 5) Try to relocate the Eshell bookmark: R Result: bookmark-relocate: Wrong type argument: stringp, nil Patch: A remediation patch is attached. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Handle-error-in-bookmark-relocate-when-filename-is-n.patch >From f528e26047974d044e35828c52c35229705b278b Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Wed, 16 Nov 2022 21:59:17 -0300 Subject: [PATCH 1/1] Handle error in bookmark-relocate when filename is nil * lisp/bookmark.el (bookmark-relocate): Handle error when filename is nil. --- lisp/bookmark.el | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/lisp/bookmark.el b/lisp/bookmark.el index b57ad12986..45b116ee00 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -1396,20 +1396,25 @@ bookmark-relocate (interactive (list (bookmark-completing-read "Bookmark to relocate"))) (bookmark-maybe-historicize-string bookmark-name) (bookmark-maybe-load-default-file) - (let* ((bmrk-filename (bookmark-get-filename bookmark-name)) - (newloc (abbreviate-file-name - (expand-file-name - (read-file-name - (format "Relocate %s to: " bookmark-name) - (file-name-directory bmrk-filename)))))) - (bookmark-set-filename bookmark-name newloc) - (bookmark-update-last-modified bookmark-name) - (setq bookmark-alist-modification-count - (1+ bookmark-alist-modification-count)) - (if (bookmark-time-to-save-p) + (let ((bmrk-filename (bookmark-get-filename bookmark-name))) + ;; FIXME: Make `bookmark-relocate' support bookmark Types + ;; besides files and directories. + (unless bmrk-filename + (user-error "Cannot relocate bookmark of type \"%s\"" + (bookmark-type-from-full-record + (bookmark-get-bookmark bookmark-name)))) + (let ((newloc (abbreviate-file-name + (expand-file-name + (read-file-name + (format "Relocate %s to: " bookmark-name) + (file-name-directory bmrk-filename)))))) + (bookmark-set-filename bookmark-name newloc) + (bookmark-update-last-modified bookmark-name) + (setq bookmark-alist-modification-count + (1+ bookmark-alist-modification-count)) + (when (bookmark-time-to-save-p) (bookmark-save)) - (bookmark-bmenu-surreptitiously-rebuild-list))) - + (bookmark-bmenu-surreptitiously-rebuild-list)))) ;;;###autoload (defun bookmark-insert-location (bookmark-name &optional no-history) -- 2.34.1 --=-=-= Content-Type: text/plain [1] https://mail.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html --- Gabriel --=-=-=-- ------------=_1668939482-21664-1--