GNU bug report logs - #59324
[PATCH staging] gnu: spirv-tools: Disable building static libraries.

Previous Next

Package: guix-patches;

Reported by: Kaelyn Takata <kaelyn.alexi <at> protonmail.com>

Date: Wed, 16 Nov 2022 22:54:01 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <marius <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marius Bakke <marius <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59324: closed ([PATCH staging] gnu: spirv-tools: Disable
 building static libraries.)
Date: Thu, 17 Nov 2022 18:25:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 17 Nov 2022 19:24:39 +0100
with message-id <87pmdl1lso.fsf <at> gnu.org>
and subject line Re: [bug#59324] [PATCH staging] gnu: spirv-tools: Disable building static libraries.
has caused the debbugs.gnu.org bug report #59324,
regarding [PATCH staging] gnu: spirv-tools: Disable building static libraries.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59324: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59324
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Kaelyn Takata <kaelyn.alexi <at> protonmail.com>
To: guix-patches <at> gnu.org
Cc: Kaelyn Takata <kaelyn.alexi <at> protonmail.com>
Subject: [PATCH staging] gnu: spirv-tools: Disable building static libraries.
Date: Wed, 16 Nov 2022 22:52:56 +0000
* gnu/packages/vulkan.scm (spirv-tools): Disable building static libraries to
fix linking issues for packages such as mpv.
---
 gnu/packages/vulkan.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm
index c00c06d7f3..6840f66c68 100644
--- a/gnu/packages/vulkan.scm
+++ b/gnu/packages/vulkan.scm
@@ -91,6 +91,9 @@ (define-public spirv-tools
     (build-system cmake-build-system)
     (arguments
      `(#:configure-flags (list "-DBUILD_SHARED_LIBS=ON"
+                               ;; Some packages like mpv fail to link
+                               ;; when the static libraries are built.
+                               "-DSPIRV_TOOLS_BUILD_STATIC=OFF"
                                (string-append
                                 "-DSPIRV-Headers_SOURCE_DIR="
                                 (assoc-ref %build-inputs "spirv-headers")))))

base-commit: 29754d3683acd188c2c461b934227ba1d909ac63
--
2.38.0




[Message part 3 (message/rfc822, inline)]
From: Marius Bakke <marius <at> gnu.org>
To: Kaelyn Takata via Guix-patches via <guix-patches <at> gnu.org>,
 59324-done <at> debbugs.gnu.org
Cc: Kaelyn Takata <kaelyn.alexi <at> protonmail.com>
Subject: Re: [bug#59324] [PATCH staging] gnu: spirv-tools: Disable building
 static libraries.
Date: Thu, 17 Nov 2022 19:24:39 +0100
[Message part 4 (text/plain, inline)]
Kaelyn Takata via Guix-patches via <guix-patches <at> gnu.org> skriver:

> * gnu/packages/vulkan.scm (spirv-tools): Disable building static libraries to
> fix linking issues for packages such as mpv.

Pushed to 'staging' as 522d21863e, thanks!
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 2 years and 238 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.