Subject: bug#59323: closed (Re: bug#59323: [PATCH] gnu: Add alfa)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 01 Dec 2022 21:22:02 +0000

Your bug report

#59323: [PATCH] gnu: Add alfa

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
59323: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59323
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#59323: [PATCH] gnu: Add alfa
From: Ludovic Courtès <[email-masked]>
To: Sharlatan Hellseher <[email-masked]>
Cc: [email-masked]
Date: Thu, 01 Dec 2022 22:21:11 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Sharlatan Hellseher <[email-masked]> skribis:

> * gnu/packages/astronomy.scm (alfa): New variable.

I passed it through ‘guix style’ and changed the license to ‘gpl3’
because source headers specify “v3”, without the “or any later version”
wording.

According to <https://qa.guix.gnu.org/issue/59323> it’s failing on
aarch64-linux and succeeds everywhere else; could you investigate why as
the next step and report it upstream?

Applied, thanks!

Ludo’.

Subject: [PATCH] gnu: Add alfa
From: Sharlatan Hellseher <[email-masked]>
To: [email-masked]
Cc: Sharlatan Hellseher <[email-masked]>
Date: Wed, 16 Nov 2022 22:50:35 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/astronomy.scm (alfa): New variable.
---
 gnu/packages/astronomy.scm | 53 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index bc31a12594..c5f0944219 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -86,6 +86,59 @@ (define-module (gnu packages astronomy)
   #:use-module (ice-9 match)
   #:use-module (srfi srfi-1))
 
+(define-public alfa
+  (package
+    (name "alfa")
+    (version "2.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/rwesson/ALFA")
+             (commit (string-append "v" version))))
+       (sha256
+        (base32 "0aqxqar36822mh373awsl79j7zn8vik4yddyydsxv0c76gn4i2k3"))
+       (file-name (git-file-name name version))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:parallel-build? #f
+      #:make-flags
+      #~(list (string-append "PREFIX=" #$output)
+              (string-append "VERSION=" #$version))
+      #:phases
+      #~(modify-phases %standard-phases
+          (delete 'configure)
+          (delete 'check)
+          (add-after 'install 'post-install-check
+            (lambda* (#:key tests? #:allow-other-keys)
+              (when tests?
+                (invoke "make" "fittest")))))))
+    (inputs (list cfitsio gfortran))
+    (home-page "https://nebulousresearch.org/codes/alfa/")
+    (synopsis "Automated Line Fitting Algorithm")
+    (description
+     "This package provides @acronym{ALFA, Automatic line fitting algorithm}
+which can identify and fit hundreds of lines in emission line spectra in just a
+few seconds with following features:
+@itemize
+
+@item A population of synthetic spectra is generated using a reference line
+catalogue.
+
+@item The goodness of fit for each synthetic spectrum is calculated.  The best
+sets of parameters are retained and the rest discarded.
+
+@item A new population of synthetic spectra is obtained by averaging pairs of
+the best performers.
+
+@item A small fraction of the parameters of the lines in the new generation are
+randomly altered.
+
+@item The process repeats until a good fit is obtained.
+@end itemize")
+    (license license:gpl3+)))
+
 (define-public aocommon
   (let ((commit "7329a075271edab8f6264db649e81e62b2b6ae5e")
         (revision "1"))
-- 
2.38.0