GNU bug report logs - #59310
29.0.50; mode-line width does not respect window-divider

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59310 in the body.
You can then email your comments to 59310 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; mode-line width does not respect window-divider
Date: Wed, 16 Nov 2022 11:58:07 -0300

[Message part 1 (text/plain, inline)]

Description:
Apparently, mode-line width does not respect window-divider. I could not
find an offending commit, so I am not sure for how long this issue
exists. I am currently debugging the Emacs internals to find the root
cause.

Steps:
1) emacs -Q (master 690f7ac86ad9a9d714b1107d05c5e856a43bb18d)

2) Eval:

(progn
  (set-face-attribute 'mode-line nil
                      :background "yellow"
                      :box '(:line-width 4 :color "orange"))

  (set-face-attribute 'mode-line-inactive nil
                      :background "yellow"
		      :box '(:line-width 4 :color "orange"))

  (setopt window-divider-default-places t
          window-divider-default-bottom-width 12
          window-divider-default-right-width 12)

  (set-face-attribute 'window-divider nil :foreground "green")
  (set-face-attribute 'window-divider-last-pixel nil :foreground "green")
  (set-face-attribute 'window-divider-first-pixel nil :foreground "green")

  (window-divider-mode 1))

3) Open some windows with C-x 3

Expected: mode-line width is properly displayed considering the
window-divider width (orange borders in mode-line are properly
displayed).

Actual: mode-line width display does not properly consider the
window-divider width (missing orange right border in mode-line).

See red circle in the attached image.

[bug.png (image/png, attachment)]

[Message part 3 (text/plain, inline)]

---
Gabriel

Message #8 received at 59310 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gabriel <gabriel376 <at> hotmail.com>
Cc: 59310 <at> debbugs.gnu.org
Subject: Re: bug#59310: 29.0.50;
 mode-line width does not respect window-divider
Date: Thu, 17 Nov 2022 11:23:54 +0200

> From: Gabriel <gabriel376 <at> hotmail.com>
> Date: Wed, 16 Nov 2022 11:58:07 -0300
> 
> 1) emacs -Q (master 690f7ac86ad9a9d714b1107d05c5e856a43bb18d)
> 
> 2) Eval:
> 
> (progn
>   (set-face-attribute 'mode-line nil
>                       :background "yellow"
>                       :box '(:line-width 4 :color "orange"))
> 
>   (set-face-attribute 'mode-line-inactive nil
>                       :background "yellow"
> 		      :box '(:line-width 4 :color "orange"))
> 
>   (setopt window-divider-default-places t
>           window-divider-default-bottom-width 12
>           window-divider-default-right-width 12)
> 
>   (set-face-attribute 'window-divider nil :foreground "green")
>   (set-face-attribute 'window-divider-last-pixel nil :foreground "green")
>   (set-face-attribute 'window-divider-first-pixel nil :foreground "green")
> 
>   (window-divider-mode 1))
> 
> 3) Open some windows with C-x 3
> 
> Expected: mode-line width is properly displayed considering the
> window-divider width (orange borders in mode-line are properly
> displayed).
> 
> Actual: mode-line width display does not properly consider the
> window-divider width (missing orange right border in mode-line).

Thanks, this should be fixed now on the master branch.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#59310: 29.0.50; mode-line width does not respect
 window-divider
Date: Thu, 17 Nov 2022 11:03:42 -0300

Eli Zaretskii <eliz <at> gnu.org> writes:
>
> Thanks, this should be fixed now on the master branch.

Fix confirmed, thanks, Eli.

---
Gabriel

Message #16 received at 59310-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gabriel <gabriel376 <at> hotmail.com>
Cc: 59310-done <at> debbugs.gnu.org
Subject: Re: bug#59310: 29.0.50;
 mode-line width does not respect window-divider
Date: Thu, 17 Nov 2022 18:57:34 +0200

> From: Gabriel <gabriel376 <at> hotmail.com>
> Date: Thu, 17 Nov 2022 11:03:42 -0300
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> >
> > Thanks, this should be fixed now on the master branch.
> 
> Fix confirmed, thanks, Eli.

Thanks for testing, I'm therefore closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.