GNU bug report logs - #5931
Turning off blink-cursor-mode does not stop blink-cursor-timer immediately

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5931 in the body.
You can then email your comments to 5931 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: Turning off blink-cursor-mode does not stop blink-cursor-timer 
	immediately
Date: Sun, 11 Apr 2010 22:03:58 +0200

Which can lead to some problems. Could we please just stop this timer
when turning off blink-cursor-mode?

Just add a line like

      (when (timerp blink-cursor-timer) (cancel-timer blink-cursor-timer))

Message #8 received at 5931 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 5931 <at> debbugs.gnu.org
Subject: Re: bug#5931: Turning off blink-cursor-mode does not stop
	blink-cursor-timer immediately
Date: Sun, 11 Apr 2010 16:56:02 -0400

> Which can lead to some problems.

Could you give us some details of the kinds of problem you encountered?

> Could we please just stop this timer
> when turning off blink-cursor-mode?
> Just add a line like
>       (when (timerp blink-cursor-timer) (cancel-timer blink-cursor-timer))

I'd rather call blink-cursor-end, then.
And yes, that would seem like a good idea.  But I'd still like to know
why you think it's important enough.


        Stefan

Message #15 received at 5931 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 5931 <at> debbugs.gnu.org
Subject: Re: bug#5931: Turning off blink-cursor-mode does not stop 
	blink-cursor-timer immediately
Date: Tue, 4 May 2010 02:30:19 +0200

On Sun, Apr 11, 2010 at 10:56 PM, Stefan Monnier
<monnier <at> iro.umontreal.ca> wrote:
>> Which can lead to some problems.
>
> Could you give us some details of the kinds of problem you encountered?
>
>> Could we please just stop this timer
>> when turning off blink-cursor-mode?
>> Just add a line like
>>       (when (timerp blink-cursor-timer) (cancel-timer blink-cursor-timer))
>
> I'd rather call blink-cursor-end, then.
> And yes, that would seem like a good idea.  But I'd still like to know
> why you think it's important enough.


Perhaps it is not very important but I still think it should be done.
I thought I had a reason, but it turned out that calling
blink-cursor-end does not solve the problem I see.

I see a strange problem where I believe I cancel a timer, but it
somehow survives. At the moment I have no other way to reproduce it
then the example below.

I have a minor mode called h-needed-mode in the package nXhtml. This
try to highlight the current line (and optionally column) when it is
needed. To see the problem do like this:

- set hl-need-mark-column to nil (I have forgotten to change the default)
- set hl-needed-flash-duration to 0.5 (not sure this is needed but
that is what I have)
- turn on hl-needed-mode
- turn on blink-cursor-mode
- visit an elisp file.
- divide the frame in two windows visiting this file.
- jump between them
- wait until the line is highlighted
- then jump again

Now the cursor should blink faster. Examining the timer lists (use M-x
describe-timers in nXhtml) there is now an entry in timer-list:

    2010-05-04 00:16:19.5 0.65  (`blink-cursor-timer-function' nil)

This should not be there. However this does not happen every time.

There is a few lines in hl-needed.el where I call blink-cursor-mode
and blink-cursor-end.

It looks to me like what is happening is that when blink-cursor-timer
is canceled it somehow survives, maybe because it is a repeating
timer.

Message #18 received at 5931 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 5931 <at> debbugs.gnu.org
Subject: Re: bug#5931: Turning off blink-cursor-mode does not stop
 blink-cursor-timer immediately
Date: Wed, 05 Feb 2014 16:26:02 -0800

Lennart Borgman <lennart.borgman <at> gmail.com> writes:

> Which can lead to some problems. Could we please just stop this timer
> when turning off blink-cursor-mode?
>
> Just add a line like
>
>       (when (timerp blink-cursor-timer) (cancel-timer blink-cursor-timer))

The cursor blinking stuff has been redone lately, so I think this bug
report most likely isn't that relevant any more.  Please reopen if it
is.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.