Subject: Re: bug#59307: [PATCH] Cancel proced auto update timer if no proced buffers are open

From: Eli Zaretskii <[email-masked]>
Date: Sun, 20 Nov 2022 12:35:45 +0200

> From: Laurence Warne <[email-masked]>
> Date: Wed, 16 Nov 2022 11:57:09 +0000
> 
> Hi, this patch cancels the proced auto update timer if it's detected that no proced buffers are open. 

Thanks, but the patch seems to be incomplete: it indeed cancels the timer
when no buffer uses it, but it doesn't update the display when some buffer
_does_ use the timer.  So the effect of this patch is that invoking
proced-toggle-auto-update to turn on the auto-update has no effect: the
buffer is not updated as expected.

To reproduce, apply the patch and then type

  M-x proced-toggle-auto-update RET

The result is that the Proced display is not updated every 5 sec as
expected, and the value of proced-auto-update-timer is nil.

Did you post the right patch, and if so, how was it tested?