GNU bug report logs - #59307
[PATCH] Cancel proced auto update timer if no proced buffers are open

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59307 in the body.
You can then email your comments to 59307 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Laurence Warne <laurencewarne <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Cancel proced auto update timer if no proced buffers are open
Date: Wed, 16 Nov 2022 11:57:09 +0000

[Message part 1 (text/plain, inline)]

Hi, this patch cancels the proced auto update timer if it's detected that
no proced buffers are open.

Thanks, Laurence

[Message part 2 (text/html, inline)]

[0001-Cancel-proced-auto-update-timer-if-no-proced-buffers.patch (text/x-patch, attachment)]

Message #8 received at 59307 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Laurence Warne <laurencewarne <at> gmail.com>
Cc: 59307 <at> debbugs.gnu.org
Subject: Re: bug#59307: [PATCH] Cancel proced auto update timer if no proced
 buffers are open
Date: Sun, 20 Nov 2022 12:35:45 +0200

> From: Laurence Warne <laurencewarne <at> gmail.com>
> Date: Wed, 16 Nov 2022 11:57:09 +0000
> 
> Hi, this patch cancels the proced auto update timer if it's detected that no proced buffers are open. 

Thanks, but the patch seems to be incomplete: it indeed cancels the timer
when no buffer uses it, but it doesn't update the display when some buffer
_does_ use the timer.  So the effect of this patch is that invoking
proced-toggle-auto-update to turn on the auto-update has no effect: the
buffer is not updated as expected.

To reproduce, apply the patch and then type

  M-x proced-toggle-auto-update RET

The result is that the Proced display is not updated every 5 sec as
expected, and the value of proced-auto-update-timer is nil.

Did you post the right patch, and if so, how was it tested?

Message #11 received at 59307 <at> debbugs.gnu.org (full text, mbox):

From: Laurence Warne <laurencewarne <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59307 <at> debbugs.gnu.org
Subject: Re: bug#59307: [PATCH] Cancel proced auto update timer if no proced
 buffers are open
Date: Sun, 20 Nov 2022 11:18:17 +0000

[Message part 1 (text/plain, inline)]

Hi, thanks for taking a look.  Apologies, you're right.

I've attached an updated patch, the problem before was that it was possible
for a timer to be cancelled when there still existed proced buffers, which
broke proced-toggle-auto-update.

To reproduce, apply the patch and then type
>
>   M-x proced-toggle-auto-update RET
>
> The result is that the Proced display is not updated every 5 sec as
> expected, and the value of proced-auto-update-timer is nil.
>

I've tested this with the new patch, and it works for me.

Thanks, Laurence

[Message part 2 (text/html, inline)]

[0001-Cancel-proced-auto-update-timer-if-no-proced-buffers.patch (text/x-patch, attachment)]

Message #16 received at 59307-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Laurence Warne <laurencewarne <at> gmail.com>
Cc: 59307-done <at> debbugs.gnu.org
Subject: Re: bug#59307: [PATCH] Cancel proced auto update timer if no proced
 buffers are open
Date: Sun, 20 Nov 2022 13:52:51 +0200

> From: Laurence Warne <laurencewarne <at> gmail.com>
> Date: Sun, 20 Nov 2022 11:18:17 +0000
> Cc: 59307 <at> debbugs.gnu.org
> 
> Hi, thanks for taking a look.  Apologies, you're right.
> 
> I've attached an updated patch, the problem before was that it was possible for a timer to be cancelled when
> there still existed proced buffers, which broke proced-toggle-auto-update.

Thanks, installed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.