GNU bug report logs - #5928
grep.el: Incorrect processing of host-default settings in grep-compute-defaults

Previous Next

Full log

Message #8 received at 5928 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 5928 <at> debbugs.gnu.org
Subject: Re: grep.el: Incorrect processing of host-default settings in
	grep-compute-defaults
Date: Wed, 14 Apr 2010 11:34:42 -0400

> grep.el, bzr revision 99871, line 515:
>
> (set setting
>      (or (cadr (assq setting host-defaults))
>          (cadr (assq setting defaults)))))
>
> Value of host-defaults can be nil, e.g. for grep-use-null-device. In
> this case, cadr returns nil and the other branch of the or is
> executed, assigning the value from defaults to the setting and
> effectively discarding the value from host-defaults.
>
> The following patch fixes this issue:

Thanks.  The patch looks clearly correct, and I've committed it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.