GNU bug report logs - #59276
[PATCH] gnu: Add smem.

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: jgart <jgart <at> dismail.de>
Cc: 59276-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59276] [PATCH] gnu: Add smem.
Date: Sat, 19 Nov 2022 14:04:41 +0000

       <#secure method=pgpmime mode=sign>

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/admin.scm (smem): New variable.
> ---
>  gnu/packages/admin.scm | 44 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)

Thanks, I've made some tweaks and pushed this to master as
85f4d87b8154238480dc176b77b8c54dde84e1c4.

> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append "https://selenic.com/repo/smem/archive/"
> +                                 version ".tar.bz2"))
> +             (sha256
> +              (base32
> +               "19ibv1byxf2b68186ysrgrhy5shkc5mc69abark1h18yigp3j34m"))))

As the linter points out, "the source file name should contain the
package name".

> +               (replace 'install
> +                  (lambda _
> +                    (let ((bin (string-append #$output "/bin"))
> +                          (man1 (string-append #$output "/share/man/man8")))
> +                      (install-file "smemcap" bin)
> +                      (install-file "smem" bin)
> +                      (mkdir-p man1)
> +                      (copy-file "smem.8" (string-append man1 "/smem.8"))))))))

I tweaked the indentation above.

> +    (home-page "http://smem.sourceforge.net")

As the linter points out, this page doesn't currently work. As the
source is being fetched from selenic.com, I changed the homepage
accordingly.

> +    (description
> +"This package provides a command line tool that can give numerous reports
> +on memory usage on GNU/Linux systems.")

I also tweaked the indentation above.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.