GNU bug report logs - #59268
[PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use

Previous Next

Package: emacs;

Reported by: Randy Taylor <dev <at> rjt.dev>

Date: Mon, 14 Nov 2022 23:16:03 UTC

Severity: normal

Tags: patch

Done: Randy Taylor <dev <at> rjt.dev>

Bug is archived. No further changes may be made.

Full log


Message #29 received at 59268 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 59268 <at> debbugs.gnu.org
Subject: Re: bug#59268: [PATCH] Utilize new font-lock faces for C/C++ and
 Python tree-sitter use
Date: Thu, 17 Nov 2022 12:07:43 -0800

> On Nov 17, 2022, at 12:02 PM, Randy Taylor <dev <at> rjt.dev> wrote:
> 
> On Thursday, November 17th, 2022 at 13:39, Yuan Fu <casouri <at> gmail.com> wrote:
> 
>> 
>> Ah, the purpose of that rule is to highlight field names in the LHS of assignments only. So if I disable property and enable assignment, I should see normal field names not highlighted, but field names in LHS of assignments highlighted.
>> 
> 
> I see - you're trying to truly cover everything in assignment on its own.
> 
>>> Also, I've attached an updated patch: it seems that the escape-sequence feature needs an override to work (probably because it's inside a string that's highlighted?).<0001-Utilize-new-font-lock-faces-for-C-C-and-Python-tree-.patch>
>> 
>> 
>> Thanks. I will add back the assignment field rule and apply, is that ok with you?
>> 
> 
> Sure! I attached a patch which keeps it.<0001-Utilize-new-font-lock-faces-for-C-C-and-Python-tree-.patch>

Thanks, applied :-)

Yuan



This bug report was last modified 2 years and 190 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.