GNU bug report logs - #59266
29.0.50; [PATCH] Add flat-button to set-face-attribute docstring

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59266: closed (29.0.50; [PATCH] Add flat-button to
 set-face-attribute docstring)
Date: Wed, 16 Nov 2022 14:46:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 16 Nov 2022 16:45:17 +0200
with message-id <83zgcrez5u.fsf <at> gnu.org>
and subject line Re: bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring
has caused the debbugs.gnu.org bug report #59266,
regarding 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59266: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59266
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Gabriel <gabriel376 <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring
Date: Mon, 14 Nov 2022 11:48:23 -0300

[Message part 3 (text/plain, inline)]

Description:
The docstring of `set-face-attribute' does not mention the new
`flat-button' STYLE in BOX section.

See commit 13bd909591e9c1cf0228750b2d4a9e4364f61cc9 and
(info "(elisp)Face Attributes").

Patch:

[0001-Add-flat-button-to-set-face-attribute-docstring.patch (text/x-diff, attachment)]

[Message part 5 (text/plain, inline)]

---
Gabriel

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gabriel <gabriel376 <at> hotmail.com>
Cc: 59266-done <at> debbugs.gnu.org
Subject: Re: bug#59266: 29.0.50;
 [PATCH] Add flat-button to set-face-attribute docstring
Date: Wed, 16 Nov 2022 16:45:17 +0200

> From: Gabriel <gabriel376 <at> hotmail.com>
> Date: Tue, 15 Nov 2022 19:49:29 -0300
> 
> Makes sense, thank you for pointing it out. I took another look at NEWS
> and display.texi, and rephrased the docstring to also mention the
> flat-button in the COLOR section.
> 
> Here is a new patch.

Thanks, installed, and closing the bug.

P.S. There were minor issues with the commit log message, in
particular with our quoting style.  Please examine the commit I
actually push and try to follow this example in the future.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.