From unknown Mon Jun 23 06:00:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59266 <59266@debbugs.gnu.org> To: bug#59266 <59266@debbugs.gnu.org> Subject: Status: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring Reply-To: bug#59266 <59266@debbugs.gnu.org> Date: Mon, 23 Jun 2025 13:00:28 +0000 retitle 59266 29.0.50; [PATCH] Add flat-button to set-face-attribute docstr= ing reassign 59266 emacs submitter 59266 Gabriel severity 59266 normal tag 59266 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 14 18:15:14 2022 Received: (at submit) by debbugs.gnu.org; 14 Nov 2022 23:15:14 +0000 Received: from localhost ([127.0.0.1]:51417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouifZ-0000Ai-Iz for submit@debbugs.gnu.org; Mon, 14 Nov 2022 18:15:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:51314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouifC-0008Tt-LW for submit@debbugs.gnu.org; Mon, 14 Nov 2022 18:14:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouif8-00049x-LJ for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 18:14:49 -0500 Received: from mail-dm6nam04olkn2048.outbound.protection.outlook.com ([40.92.45.48] helo=NAM04-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oualF-0005a4-5m for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 09:48:34 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HGx7hIRWN16RLgFYNb5wn5atlnEXkwy8glSFDV3jcZcpX/ox6WLAll4iAg/Uk5xEIf1EDaN7/L1SCqvqHqTEhb9q2ymtexcnMWYQaTqB0pCs/OKAUTFQivaRG1TGf/st6e2RalOhapMP7X/ObUU7F5LEY9slBEoeYxqdKiylW+dTk+maVdGY1Eo4+Ugw/0jpBrESvF6qsmCgY+4qWnvJxawlSbZ0igQrTTyN3TWH+MYf9qq05ivlRBUvnOC1vRZ4DB1A19nyhzZ9f4Boi4nhPAJe6AKVeSkeBp8wxcJJ/aOowctuln9IzNM3/nuqcUkmgdX7ClmI4R5D+eZEX8Hx2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F3y+NDJXyICWg7cb9omUFXb6W6MmSbl7AhhzmDELa30=; b=ma9KJXp2UkLIHhk3nTsHuVK2jzoqHaCj+ohJjTv/UGYr1bqdNRlHHEJZPsPBGHR4nTgpzyU9fpDIYzNyfCrR6h9DAxCMMWJnQP1OWTOb3ZefGLZ5i+0TqAlLNjOAXLdk6Ev2V53ZHV2wLZvc9cBIM4R1yQyB3CHKwD0YC7TsdVzqGH0rZsQ9oSmITWocVxfv6fEn8tW7DMqtu+/xShRmzsrOLfb7PZg/uGfv4f8//15LVWMfohcs69gbW1S8FY11ohtjSrYtaYrvG6sPZnKKR0fNah85iG/PVnAGamuRZ7l/OAGhR9UpDbf6HT18ZQP85kpaOsRK1FLxvM2XqhIY4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F3y+NDJXyICWg7cb9omUFXb6W6MmSbl7AhhzmDELa30=; b=b9jyylceEaAMUHJxFumeMuvh251+xI3Mjh0Gcr04t/ODeY7DSAyuGDbPMasGhLAofkZmAziN7WmpirMOUEF6clk3YxiLDBZwSZ7o1TcjY2yvObi77TfL3UV2D84NXerj0wB0OdA2EENuX+8sEaFpBKnPNHoan0hEKCLdDKA2e6Rk8pSGHxEUtWIL/PU3PEABBmKxOuDk5I/Shwcq9ui4GTbeJj6Wr/IEKlF2X/YVj3Tw9DPqX8pGObXedJyh2rUiBRzpr1cXdj3bQ2DsMmqeTSVdf1h0PPPwEqZd+xPymWDS2PVuJMGRW8/TGRXwE9peJ6/E4moFkXH25HT2A19CeQ== Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) by CY4PR06MB2357.namprd06.prod.outlook.com (2603:10b6:903:b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Mon, 14 Nov 2022 14:48:29 +0000 Received: from SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f%4]) with mapi id 15.20.5813.011; Mon, 14 Nov 2022 14:48:29 +0000 From: Gabriel To: bug-gnu-emacs@gnu.org Subject: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring Date: Mon, 14 Nov 2022 11:48:23 -0300 Message-ID: Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [GGLvoMr4sVHCcALCU0DLvC3nCzLP82Il/nRcq8nPAikE1hIQIBS7CPSI0EqRZyD9] X-ClientProxiedBy: CP2PR80CA0264.lamprd80.prod.outlook.com (2603:10d6:102:42::36) To SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) X-Microsoft-Original-Message-ID: <87iljh1tjc.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|CY4PR06MB2357:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ce7dffd-4d26-4907-7408-08dac64f4b12 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: etGV6lMYA2ZtXHE2lGE9Sskei8ABIeUjcZxxALsCAIHXj/ST7TldOAQ4KWYkpZKWhTxA+VeLc24o2aALZUfkG7Ca+PK8Ue74p7VVRoqHt24s5syM8VZnaRlqtqNbd3YXq9SSWErLZiVUiyl8iDZIh6AqtAs2EUg7/PV8EgjSHjGwWDmA06nS/A88gD2lI5rRH5vbNMumLwWCShwbZf/PJYZ8C5VAJgsXEiI8VvAM+vkTWdwNNXufxDtbCd4isyD23z7AkeAUdBhL4AyXy1A8/gjnId0naYwV2MPQiF5o9iWZX4TyPlzYLNrnVu4p8MLAu3kYvH6SJgtlnLRIViP31fylRDtk/2o7MTw1bSs5LFk1OgHnEedDAXuMfyHc5mmA0Zq6dpKmK+uqxC/VugDzu5d/sEYz+MNhWxfDldgup3ruauLesEYKbKdLgkDzZhclxypXJYQMAVf0g653qD+PAokGey+OMkVny8DxSxa4wFHutJkCTBeRuUBGK0NEzJsiI9dKckMYpG+fVpNATDCBs1lfgqWTflA+i/jZIzLBoxka/DU+YFrYheGylTFV8ld8D1T1WBaaRD+XMVviadACk654wbj12SoO0aD2tK5sdUAITWk5BfVrWGtWqUd/xYhKNVJXrgaii+D7IE6hwchzRw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?a2An5h54jIHWfeeL0VxwZ5cDvQKynyLbOB+NcGckmh6AcIBZxdKVpmCeNPw1?= =?us-ascii?Q?9mbo2t+X2WKbtERKm8J3aKt5AQDGSg14WbSuZw+JUPlpN1feDOvkg4ddimOe?= =?us-ascii?Q?sJzNN+agkQNPjbvlCf94UcTYDM7oOqxrjIofC5mDNFYqJnu4tLUXfk87uU31?= =?us-ascii?Q?KtlsUCdlMuslvRpS5HvUi4JkLnqfI4wZufA2CbBuQGta3UsUkwlRkgKhKf8H?= =?us-ascii?Q?bUXaws/g5969iZl6PcKHYv5/54besBwznXZVkvaZ8xw1bK55rTlRDj+chJnI?= =?us-ascii?Q?1Wu4678a0kyLQ22yaJMa75tSMldOE+vrFDDcR+ItrDkqESq6pMYZV58arM6x?= =?us-ascii?Q?WQy72+pYiqt/QHEHvi42WnmYS4VhDWX36IyhcSdXGnzFUUwWF9IvN1dxx0QZ?= =?us-ascii?Q?ksw6dHMR9ZigFjmJdO+0EuqKWtNoWIiVobB5vNU5RFyEIo6Eu9SkEkPZc0GS?= =?us-ascii?Q?K8CurJ0qglba0bpbTLfdpwopdpzWbMj2VWsy/Mdglgdf5mp2xFpheZqD2vXy?= =?us-ascii?Q?qDtAvzJaPT9sxGYcjE5MaXDJz9px256LWfQE16H0CpaqxUHQIjujbsBEg35b?= =?us-ascii?Q?Ib8nuZmBYZjqDbJTCw1zSM6MEz+uoCVAJRo8o3m8Goa+nXnqvXLP/2FQT8lL?= =?us-ascii?Q?J/tfFRqH0znjiY2qb3nDSqzlXxSrlGT3jAYm60uxF3HF7tNfpsQ3KdgLO+qO?= =?us-ascii?Q?V7CdEMF6+kgws4f/x7jgXldAm0JjZ7b8lWCU0b8NJKKKPvhgBPJ+Lbgbgr01?= =?us-ascii?Q?Tns7Pp2tA7teAGNm72UpQZdkq4P8WjMImVoZjiLojYJXc6vZSSY8drVodi08?= =?us-ascii?Q?tv/w5SYWn7uyc1qmCRfyeX6NSi0dx9rymVCBul54JfAkmykqltEc6+hNcqYX?= =?us-ascii?Q?opPBeq71Ubcgit/IPLEcHxX5huApMUO0AfK53WHI/WwUQpn9WWwF2Nxd3Mob?= =?us-ascii?Q?XY4d1UDe5S3t75X64WC1IWpnQyRZY/0TBy2kRWZ17H5fFq6VoApFMVlS29Xm?= =?us-ascii?Q?1VIHhBBy/74pr27/9ToWjndLJtkdSerWfS5oIxAvDT7Nwjry+emHwDJVXwzX?= =?us-ascii?Q?/ks1L5SmruWyR5+8ZY+Nh5WsS7Saxoi4SYuQNJ2EfguFyaLyV+WVb1OpCY1i?= =?us-ascii?Q?A1a6LhXXfN0LFdCi8jV+XaC6oa4+LFbiscYKRBVb8TTAVJ7alERgwNDJylcK?= =?us-ascii?Q?4WxSNXi8q1HPRnlo6hEVrzLhNJWO++OpNUnCUnVvhnS9K/i49NHOLUNjzkCP?= =?us-ascii?Q?xNQkFUucCWAgFdL7rHIOAL3tBjwUf+4/Bp6HrpSk7DvLWPoKXgJmyn8EnNE+?= =?us-ascii?Q?0tYKwI/MwIk5xzd+mU31VNUD1xoxcXz7guRWRK8OMn1KVw=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 8ce7dffd-4d26-4907-7408-08dac64f4b12 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 14:48:29.8074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR06MB2357 Received-SPF: pass client-ip=40.92.45.48; envelope-from=gabriel376@hotmail.com; helo=NAM04-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Description: The docstring of `set-face-attribute' does not mention the new `flat-button' STYLE in BOX section. See commit 13bd909591e9c1cf0228750b2d4a9e4364f61cc9 and (info "(elisp)Face Attributes"). Patch: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-flat-button-to-set-face-attribute-docstring.patch >From fed6c0773f152ff795115b1a6c1a7855b3b99f54 Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Mon, 14 Nov 2022 11:36:59 -0300 Subject: [PATCH 1/1] Add flat-button to set-face-attribute docstring * lisp/faces.el (set-face-attribute): Add `flat-button' to STYLE section of docstring. --- lisp/faces.el | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lisp/faces.el b/lisp/faces.el index 09e8110449..4088f4be8a 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -791,9 +791,8 @@ set-face-attribute color of the face for 3D boxes. STYLE specifies whether a 3D box should be draw. If STYLE is `released-button', draw a box looking like a released 3D button. If STYLE is `pressed-button' draw a box -that appears like a pressed button. If STYLE is nil, the default if -the property list doesn't contain a style specification, draw a 2D -box. +that appears like a pressed button. If STYLE is nil, `flat-button' +or omitted, draw a 2D box. `:inverse-video' -- 2.34.1 --=-=-= Content-Type: text/plain --- Gabriel --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 14 23:01:18 2022 Received: (at 59266) by debbugs.gnu.org; 15 Nov 2022 04:01:18 +0000 Received: from localhost ([127.0.0.1]:52463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oun8Q-0007wO-5N for submit@debbugs.gnu.org; Mon, 14 Nov 2022 23:01:18 -0500 Received: from mail-oi1-f182.google.com ([209.85.167.182]:43590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oun8O-0007w9-Oz for 59266@debbugs.gnu.org; Mon, 14 Nov 2022 23:01:17 -0500 Received: by mail-oi1-f182.google.com with SMTP id q83so13615015oib.10 for <59266@debbugs.gnu.org>; Mon, 14 Nov 2022 20:01:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=R22VsRkvtwXN26ss1Xx0Q2weAqR2emjz8hEZtpGeu+w=; b=BnZW4sOOluZ07VLm8qEM3Oum/yCcRkqAItFq/mHs712tM8N2EjVtqTUlw2Or1OFprk UqaDnXRWe4ZYXvqb45Q3vRWKeYS2k78P+BwiNPxWRIGWFQxM1fMb1BA+0caAin3FMX8q vdB8PVHN6h2Hf6IodeL0BQ2PPMeO4JZYpaFDGdlKcPFU2n0Zj6fzVG0Ez4WnWnMZyyqK kfxGhJyDZ1xUsdFZq+jeygBnI5ZvcmkLi3ZdgCQDatEMozChFy/G6RevCD0qKlKjy1nV HHDW+y4DmgxCYg3dWSm8kUkkcoD/wO2vRpWYDJ/iHREPGQYiFgIbAq2535SBoewtEM1r TF3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R22VsRkvtwXN26ss1Xx0Q2weAqR2emjz8hEZtpGeu+w=; b=YiBvqdAokF+L6FZmobb1FDfUAoqWeBQgVRT2iOj/hAMxyJ1ZQwzcS73+sa8/EyNQ0n nFq8LxcNMOmMpVynwbs/LxkKBWzn//WYcZtD6EKknB4mj3BC8ugY1nXGNG8aWhfIo/Ek pu6HserjWTaL9wC5JRuerpOORzIpHqp+C4HFYEmtQ/HVOuGycpEKcHDvCYnEd8ouRKyA yG/jZJcaoJmExLdqZYy7/Amx5LgzqpVouXRu0Yjx4ssFqpf3MK4ki+IgyxXiyKxP1Dq7 B+Ari8+ehq6OdiFG0JKGsAPeImHnM8u/xSDa8svGkZn/FAfgZVYIsEWMy4pGWL8xIZ17 hTCw== X-Gm-Message-State: ANoB5pl8l4WL8BwvtZiqolJ0s6eY4B2nI9GTmetHcDdYqKgNvkM17GSo 2DLThlgR8F3u2xYQsPHRMCiumr14zz0PU0V3SD0= X-Google-Smtp-Source: AA0mqf4gwLawD8PQyh6sZ7rQoBcAQ9ohtEq9J6uV2gVkyjPBLRKB01Ts9jhvKxiVYGjBFxvDaqmOpM97tiVx1lFb3gY= X-Received: by 2002:aca:3b86:0:b0:359:dc32:4f9e with SMTP id i128-20020aca3b86000000b00359dc324f9emr97376oia.92.1668484871125; Mon, 14 Nov 2022 20:01:11 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 14 Nov 2022 20:01:10 -0800 From: Stefan Kangas In-Reply-To: References: X-Hashcash: 1:20:221115:gabriel376@hotmail.com::3oxDX+oR6cf9eznT:0zEQ MIME-Version: 1.0 Date: Mon, 14 Nov 2022 20:01:10 -0800 Message-ID: Subject: Re: bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring To: Gabriel , 59266@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59266 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gabriel writes: > From fed6c0773f152ff795115b1a6c1a7855b3b99f54 Mon Sep 17 00:00:00 2001 > From: Gabriel do Nascimento Ribeiro > Date: Mon, 14 Nov 2022 11:36:59 -0300 > Subject: [PATCH 1/1] Add flat-button to set-face-attribute docstring > > * lisp/faces.el (set-face-attribute): Add `flat-button' to STYLE > section of docstring. > --- > lisp/faces.el | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lisp/faces.el b/lisp/faces.el > index 09e8110449..4088f4be8a 100644 > --- a/lisp/faces.el > +++ b/lisp/faces.el > @@ -791,9 +791,8 @@ set-face-attribute > color of the face for 3D boxes. STYLE specifies whether a 3D box > should be draw. If STYLE is `released-button', draw a box looking > like a released 3D button. If STYLE is `pressed-button' draw a box > -that appears like a pressed button. If STYLE is nil, the default if > -the property list doesn't contain a style specification, draw a 2D > -box. > +that appears like a pressed button. If STYLE is nil, `flat-button' > +or omitted, draw a 2D box. Thanks for the patch. It copies the text from (info "(elisp)Face Attributes") and in that sense looks good. But shouldn't we keep the part saying that nil is "the default if the property list doesn't contain a style specification"? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 15 00:23:30 2022 Received: (at submit) by debbugs.gnu.org; 15 Nov 2022 05:23:30 +0000 Received: from localhost ([127.0.0.1]:52536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouoPx-0003n2-ML for submit@debbugs.gnu.org; Tue, 15 Nov 2022 00:23:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:57376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouoPv-0003mu-JF for submit@debbugs.gnu.org; Tue, 15 Nov 2022 00:23:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouoPu-0002k2-AF for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 00:23:26 -0500 Received: from mail-sn1nam02olkn2062.outbound.protection.outlook.com ([40.92.44.62] helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouoPs-0006B0-KT for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 00:23:26 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XmQm1sIPvpL8mkEGWodi7piEFzU8OzDLc5S06RvrgXlGBd7ns6SZprsmozUCxNj1V5ePECorlwagq74UEuVrrXOkqMDN0IiM8U4+D4EE9fepUNsydRvb6/qO6TQZj5xo9abnyu4YGM7ms+HlKendYLyyD0sM8OnIhEdOhUAG0MrLDWrjiDNw1rfaLQ77dChW052rr2kOgfBT+PJSVAHMfUyBUf8QxziCTbUdbSwWcajl4xp7N98DFtr0TSwGoOQo32/QVDK2llb/cSYwjFuMiB30nWjGnh4f/OqaIxP/hSXXsieiTzCvUz/4fOsS2zJtbge2EDYJdpCJTO9wGCKdSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NcQqoZ0xdStzXXwavhLI4tqfNJ03DMKp7CBGZmqW4hY=; b=D2CAm8XOcWXSSRu0gXovjhj5ZKKG/EZtqvqZgTfWwwrOWB63MkBhZna5a+SjdqK7WUn4/lYXY9zv0FasJxB1h39IxK12MLDRme0879ZH7JtgLHL4sVZU4DO4u1tIZUrzmz2FB0a5odv6we54+ZuB9cm2MG/TOWKa7of+Oe1vUbzWJ52t2CkekKbI9PKlh38GrUshwuSDVrKntrNAw5JlOR0MSp/9hFNAPVJzr4K+2na4EmnUmw9ADvgC0qlx0OD4X60nV8NdFWy1XT0sGnmnJv0zNgSLJC1MROvC8IPqU32ghvqoGxsSa6wGuowbmtiuNzw7+YBeXZKBMHPZ7pnX4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NcQqoZ0xdStzXXwavhLI4tqfNJ03DMKp7CBGZmqW4hY=; b=DKLnni/ha421Wy2kWA0eJc7gV30prf0jLLVZqTdUB/IyX+RZ1A2nTo7J0FEhtuat5wHwX4OGCdPNs+jjD/dyxvjVlM9Q1eXdYvSO2Js8tdkC8MG5GQNgSaG0RCimYEXihK4B1jeduZ0+4+iUpf3kbtcFHr8QcLSJ3gnNB+CxfsmfY4fIuqNTGRJY8twlPtiD/OI2R3r9TCPDJ2y6Lj6YwcvIToD3OqDT+fBttpGM4ZJ0/7Y4NY2OMYrLeI/exZ1jltb4blaRUormWlTGVz2nfcqQpJtnE+u41fkISwEukM/EyFy9qv5WSUkkHHg6oazwyzkqUcIQPwTGVeWbW9iopg== Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) by BY5PR06MB6531.namprd06.prod.outlook.com (2603:10b6:a03:23a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.7; Tue, 15 Nov 2022 05:23:20 +0000 Received: from SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f%4]) with mapi id 15.20.5813.011; Tue, 15 Nov 2022 05:23:20 +0000 From: Gabriel To: bug-gnu-emacs@gnu.org Subject: Re: bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring In-Reply-To: (Stefan Kangas's message of "Mon, 14 Nov 2022 20:01:10 -0800") References: Date: Tue, 15 Nov 2022 02:23:14 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-TMN: [DvxkbUoc0odIdmO0wSO5VgFrPK+8y/02WLqEKwBHelOTpKY/CrH/SIeqrfflmS6+] X-ClientProxiedBy: CP6P284CA0036.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:1ac::15) To SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) X-Microsoft-Original-Message-ID: <87tu30aj0d.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|BY5PR06MB6531:EE_ X-MS-Office365-Filtering-Correlation-Id: bf092cd6-939b-4bab-8cdd-08dac6c98237 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vp0yp9V3pAgJRUQ/FvUD3uaQ+HyXP/d+gX9ZRZ4wNcST5Hqt0RDr97XC4pv5xGQq86K93WqxeurRCu18ik+sn1W9kpbOfgfQt5HNwCAd6Lkm0TaemhSuHhFqozL/6oyXkN4Xh0vs4LkRHQ/PM2vo635cb4Mc92DHUvT6lIr1qUzPlDlp3RiI/50KkaGtBIAcH1kLEF21VV+NmnGiZOYaVVkGdO7XFNGWCKx3MQBwQYdXTZiEa/9Q9vx+w5N5kWOOxDiO/StF3Gj1Vt6XttGYyA/9uG2H4Rx2+ZkT/6VxEImeza+N/UMoo2KOzFrLxLuzznFdrmeNZENZ4n1pVbkg8H9wQrBsyN++1lFelxg46ZKedcOBntJGkHG6viDMnbei0gv8FYBoQ6rGbkg+GbOvAerD8UpJa1Kkz+5DsnrHjvqZkTH4CvUjPeJMgLZd1ETPJVHF2VeIRi+j0oXczYJNpqfLRHaCWgRMTMtEQmnZ8p+5OEZ8fag67NPKK2nvMRokJ7xQ5CqLWMLDNRcpzDfK88tEVAQw0K4Lf9ZfezZiGcqNMecNjmCjcpIo1fWqRjtCmTBGsllutuKeOpj5xePZeGVaz2d68XN/q8u4mgBmk+9ZZq6mneeFAB53TAuKs4UW2gBYHXs654xB2KQVCfTrpuREDA4g4rSaHiPrlf+e0KqyOMr242e+7n+nYd2jURifFAsxeaIz1/flY2XN2w0B8dmh1UQ825XTvEmABRr1tb4= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6fis/p76L74h/wjDbv9iPyizOb3e/TLihOA3+Z200/tFQvx8H9hN2GJ1GG0l?= =?us-ascii?Q?R9bwLhJjqvn9FjDV1LolqDGsHirifeILg4GiqiUb3dL4Gwziz+Yh1KfZmOzy?= =?us-ascii?Q?C8pk/7nqmN5XEcsdSo5+eCBTgPYYiN1oKqs1sCjVIWpOOsYHQ0XszTe1bLHY?= =?us-ascii?Q?BjrUEY0OKuaJkp7B2XOIEzC9zTiuzyoBFsKoBRVRdYckMukr6PmDrHId4kNj?= =?us-ascii?Q?wagKFux/Wro4ataHgxNTWWDmu5/qh8iF46/+QGE82BQc9j/7Hu65msGffWew?= =?us-ascii?Q?XAm1bkRhAJcSJdsvv67rvLdpgyo86HusjRajUJ0RiCvcqXCStcpAjAXz4Lr1?= =?us-ascii?Q?eTKDW/3O/CE0rNifA1ABDYAgl5wt8+rOgy0/ejt/h408kUzZVAU9fjLpmo+3?= =?us-ascii?Q?OSjfTdwLiYV9tp5vsBwqDV2KE6ASKg8Xtd2D8an/pPDZ9SP6HI6YvJ8sedU2?= =?us-ascii?Q?rWdC6H5PXfMEwX2k+WaSNzIWhYC/mUu1RXEhaZUdr5F0e7xJeNARE9k8nD3h?= =?us-ascii?Q?V0HqfncATs1Z1eqY45CIH99Y3U7mLCuMLu2qiOLjvHxHfHcmzZQFHaW3rTRH?= =?us-ascii?Q?nJoZD51YA+RmXkXTvgvB8Hxj+lvE3fvuJWtfsED8IbucfeLByAD63HaSi2BJ?= =?us-ascii?Q?OyrDe5vnJLXrgBVfw9f9Rkw4Qs6/WfZ4VxPtNd7dQrAj77QRCuHKZhpkQDCS?= =?us-ascii?Q?zAbYq2qlJCSsE3Td/Za8YEjWkhRawCBkffemWDX/4S6UiUqqe+OfV6bq1fyd?= =?us-ascii?Q?uASepnDgMrz7soKVrKE0OxvxTUcHPghLhWnMUMf9QghCxfdRzYgc0Ftn6VPB?= =?us-ascii?Q?qGP1jxshbNFyjFrmcVlPiNeY6vD87SAqtfXkO8ggqJRkdhGmpcjXyEO8oo1Z?= =?us-ascii?Q?8oG032emnKSzno1iv2mDir62HqLhyel5KiMivT+S90oZhAqfZkuA9/NlAvKV?= =?us-ascii?Q?wHSk3coTnJ2LG8fHxK1PMuIpKsnphL4YA2ckTf/UixzKd4Cshj0sC41sFRH9?= =?us-ascii?Q?eMhfLDp5wUAaC5Vzvmg6CSxDirXgEEZNMmxCbGZ51tNV9O3Dpaz8CRjBwutr?= =?us-ascii?Q?ePelzKvrYtwvdqN5LZPm83ZQFYK4eKWVwq4StmzE4iTgisQJVrGjsN4nIl0J?= =?us-ascii?Q?YNI6iHSpjdugZVj6Nk0ZKkIE0c8y230JeJiDKvB0GYYO/p+QZp+sz9oPl9h4?= =?us-ascii?Q?RvwrNWV/qmH2A56wMpgL4+P+/daHV2SkiPf3++oqE1FyCh8R6ddPn7svK1Xb?= =?us-ascii?Q?vP+L4kcQubPAAHRf+IfujOgHUqLfCGo8TtsDupBx/a7rqSXAd5cBoS74CdHM?= =?us-ascii?Q?Fg8jld5O6hI/kn/dOb7rAhaLbcsIGcaLqqOe49Wm5qHIOA=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: bf092cd6-939b-4bab-8cdd-08dac6c98237 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 05:23:20.7843 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR06MB6531 Received-SPF: pass client-ip=40.92.44.62; envelope-from=gabriel376@hotmail.com; helo=NAM02-SN1-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Stefan Kangas writes: > Thanks for the patch. It copies the text from (info "(elisp)Face > Attributes") and in that sense looks good. But shouldn't we keep the > part saying that nil is "the default if the property list doesn't > contain a style specification"? Hi Stefan, I think the word "omitted" makes it clear that "nil is the default if the property list doesn't contain a STYLE specification", similar to how it's phrased in (info "(elisp)Face Attributes"). WDYT? "[...] If STYLE is nil, `flat-button' or omitted, draw a 2D box." --- Gabriel From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 15 01:56:23 2022 Received: (at 59266) by debbugs.gnu.org; 15 Nov 2022 06:56:23 +0000 Received: from localhost ([127.0.0.1]:52642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouprr-0006L2-Fq for submit@debbugs.gnu.org; Tue, 15 Nov 2022 01:56:23 -0500 Received: from mail-oo1-f49.google.com ([209.85.161.49]:34690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouprq-0006Ko-0v for 59266@debbugs.gnu.org; Tue, 15 Nov 2022 01:56:22 -0500 Received: by mail-oo1-f49.google.com with SMTP id j1-20020a4ad181000000b0049e6e8c13b4so1917214oor.1 for <59266@debbugs.gnu.org>; Mon, 14 Nov 2022 22:56:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=iA/s/MkGXsQr2CHIbNBL7qnHbX5K5mRijGzew1lRM2U=; b=PahHMK5AVLve+0vKzwjkfCWi33Z0tKrjFjTWBuousAohvrdO9iyijWNd7U27SFYt1n V9VeEV25VB+83rzWy+D8gARy0TeFPIobDazh9MpobsT6CqaOgMCLQEJcpN4Jge6PiJLZ SJ7M9Zs6zKsnyWwZbLV/9ChgTMG3363e4DdDh0EdrONj7voiqzOfD4UYSXVyEdF4ydXQ rgC/aqKmcqQI7QG3Gf3x65983zXOYS461j8GBerVEMzW8vem1GxeZYsyiEQQFen4HWLX 3SKQFz82xyvTWsS9YAZlELs/DQxwr8exWAHGgXiHnWBqK5vdq55uWEfrZdj89ko/kTkj dyrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iA/s/MkGXsQr2CHIbNBL7qnHbX5K5mRijGzew1lRM2U=; b=DVTAMRflKjFXy548892uU1RVnVUghrrvdfok0Ubvd3poJ+eJ4k8swzG4WzPWgviweC S0zlnibtQ7GnhmUn+xlxJ0ZP2Qgq7loXFoiQoE5h12zB9W7PF3rqd5dqiLSBl/NrAXXK OmdCFhLqS+Qt5ta6/wB/qWgrSsqV+mV7DqwemoDNG6YLCeXpT+ox0G4DiR76UPwCbkWY 0d+1kiRI+JOqTK25Lfwj0vproRcDLBbESqWl6jM7hqEZCxlt/+/4U+pPoWrjRDu1YPVc 24+U+KE1b/qH+ZZ9NlzwvInCUdardfUX/5Ecl9XvJ23/CQ6YAdEdKozJjVWe8U33z2gJ dTiw== X-Gm-Message-State: ANoB5pm/iWiNeb0bMOeV/5Sw28Vdt3JNUlOEJ/U4mPT3WjiTqra8vsZT SWPRxyIp57PngfYhuec4Ug3uOiqJf7IBDbGQ14k= X-Google-Smtp-Source: AA0mqf6QD8uTUYMTZbxfv7bJU9Et8QFpJss6O95L/aTTOw7naf97TC4sH6LbM4+YfrD1PSQw3LutxP9S5/vwQwpig2Y= X-Received: by 2002:a4a:eb95:0:b0:49e:3627:279f with SMTP id d21-20020a4aeb95000000b0049e3627279fmr6929673ooj.5.1668495376149; Mon, 14 Nov 2022 22:56:16 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 14 Nov 2022 22:56:15 -0800 From: Stefan Kangas In-Reply-To: References: X-Hashcash: 1:20:221115:gabriel376@hotmail.com::UG1uEhRXIAO3I17r:1Y1O MIME-Version: 1.0 Date: Mon, 14 Nov 2022 22:56:15 -0800 Message-ID: Subject: Re: bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring To: Gabriel , 59266@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59266 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Gabriel writes: >> Thanks for the patch. It copies the text from (info "(elisp)Face >> Attributes") and in that sense looks good. But shouldn't we keep the >> part saying that nil is "the default if the property list doesn't >> contain a style specification"? > > I think the word "omitted" makes it clear that "nil is the default if > the property list doesn't contain a STYLE specification", similar to how > it's phrased in (info "(elisp)Face Attributes"). WDYT? > > "[...] If STYLE is nil, `flat-button' or omitted, draw a 2D box." Ah, right. Yes, I agree. I think this could go in, but let's see if anyone else has any comments first. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 15 07:34:17 2022 Received: (at 59266) by debbugs.gnu.org; 15 Nov 2022 12:34:17 +0000 Received: from localhost ([127.0.0.1]:53291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouv8r-0000yd-A9 for submit@debbugs.gnu.org; Tue, 15 Nov 2022 07:34:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouv8p-0000yP-5f for 59266@debbugs.gnu.org; Tue, 15 Nov 2022 07:34:16 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouv8j-0000Aa-2r; Tue, 15 Nov 2022 07:34:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ugOFawg209DdC89EZ/wrUU0jgLwdU80Qct5FKhE5sPg=; b=TieqCdXZTTg/ 0F+1rhDfxKgcJZFzugGIiPrs1PkdyBFXN/O80bwWQo+2TeiHAxl2r3kDDXYnyYYqY+ppuMuWMODua RtDJlhFQOgOZF8gIHbmBuVI74qGC0nv/HfwOwchL3LwCcZfpzCL2+lODmRPwJxlmiOa28NIOeSpoA pS4kYMpeWTIRugB6l5l6HHn4Mb7TvA2ha5iIL/xLthluqKNmwtZTHT5vRxGYo8Tue9Ituu5WhLkee PPyxv9A/OmpviBONGnP664jLWU62nht0T1D7TT6rpE0dQt5xLT4PWvvBBS1Yqii1MtHTKyRZ0Cm/W xzMHiIdkX0/FovmP6k1OQw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouv8i-0001wd-Du; Tue, 15 Nov 2022 07:34:08 -0500 Date: Tue, 15 Nov 2022 14:34:21 +0200 Message-Id: <83tu30iegi.fsf@gnu.org> From: Eli Zaretskii To: Gabriel In-Reply-To: (message from Gabriel on Mon, 14 Nov 2022 11:48:23 -0300) Subject: Re: bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59266 Cc: 59266@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Gabriel > Date: Mon, 14 Nov 2022 11:48:23 -0300 > > diff --git a/lisp/faces.el b/lisp/faces.el > index 09e8110449..4088f4be8a 100644 > --- a/lisp/faces.el > +++ b/lisp/faces.el > @@ -791,9 +791,8 @@ set-face-attribute > color of the face for 3D boxes. STYLE specifies whether a 3D box > should be draw. If STYLE is `released-button', draw a box looking > like a released 3D button. If STYLE is `pressed-button' draw a box > -that appears like a pressed button. If STYLE is nil, the default if > -the property list doesn't contain a style specification, draw a 2D > -box. > +that appears like a pressed button. If STYLE is nil, `flat-button' > +or omitted, draw a 2D box. Thanks, but can you rephrase so that `flat-button' appeared as one of the values for STYLE, with an explicit (not implied) description of what it does? For example, how does `flat-button' affect what COLOR does for the button isn't clear from your suggested text. IOW, what I see in NEWS about this doesn't follow from the text you propose, at least not easily. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 15 17:49:46 2022 Received: (at submit) by debbugs.gnu.org; 15 Nov 2022 22:49:46 +0000 Received: from localhost ([127.0.0.1]:55466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ov4kT-0004pu-Rx for submit@debbugs.gnu.org; Tue, 15 Nov 2022 17:49:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:46096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ov4kO-0004ph-PH for submit@debbugs.gnu.org; Tue, 15 Nov 2022 17:49:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ov4kO-0000BR-Jz for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 17:49:40 -0500 Received: from mail-bn8nam11olkn2010.outbound.protection.outlook.com ([40.92.20.10] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ov4kM-00045N-6u for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 17:49:40 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QfJ1z1G3fSFVFeD8KV7MYtEvtLnnkmoblOHDfYkCEN0WRXDlWXjHm+bwYu6xcfIABGU9epDGSfmrjZV3mgjDugAQNfa7Jpk6U/2z90pF+m+nQbNT+mijMh1nanKflmsQAec8ABDq/Pxjz1ow1BYuHicMHZjdsM7wDiOLWdjl0Jq5KdmeZQP1+coKPAZB4l2kuNkaTPCSMqETosW+0IIBn+GbLkiseDeQrCG1d5sqz3CqzU4+EiqT4sHjUgStmmTfPhr0faZDLS8CpxGbWmZZ1IASIr1eOyn7fiLsUilmMopcAviCxCr26mvZbWTTjVZHhf3SyD6dsiSp3qDtedEs2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hHXLFex5MvM0EX+pUrfFjO3yvxL4sGjBb8Oy88n4zn4=; b=fq+ICwdCMOaER9LmqRvZPOBPR/E6KnZBzxDS3kFVvuOghx2SO8niJIiwhd4J+B5AFgU4ogpgv4dAqiS4jrbDHQ9MSCwiBZj63WOx3jNVBuoK5Wie4PtjaBByqLgmROo/Ie7HZ1cQHIxIiJofEwAsSOwA6z76A/hsvhvjFeJacHuMaT8xgtvkDEuQoLTOT9YvDJelC46DVlonaZ3pKqsaU9ZLJ3zgmeomNMziR+6AYVopHKhMkx9OYux4haxRX2DFlEg4bw7Gp27cE/iomHWHg1X2ji5srqGwhQJnHn1wDicohjVhoyGzrck8D4bEBwEvK37okfcG/tpnRG3a0maLaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hHXLFex5MvM0EX+pUrfFjO3yvxL4sGjBb8Oy88n4zn4=; b=OTm4X4MwtmRtGNZrzlB2z6RgKTPuMsW+J62jczaqho1r9j2SpT7l/2FwebNib1t4KSfaHpP59AB+RvZxjadzBiBPu1ErNqvMakBibwmRZkwSXRe5ULoAtFzNCvPaZYsb/QFt9GuQ5oSbYlXwuln5WU9PWxPTp0iPLt9x5PWTzam0F7bGFuzZbnyuBZ6QMF2EpSkEnI+s/0V7LvKNwgR0cNhM1i/yU//X333r41IuB4T6K/oTcRf4wUC3jECrXigDv/jGQnfC3WwAurcHc7qpg1xwTia3dV8EwAN2SkNsKJLxYPKGjXR86c42IHeGY8bmu9nYiOg0HW4puG3X4x2Ytg== Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) by PH7PR06MB9017.namprd06.prod.outlook.com (2603:10b6:510:12c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Tue, 15 Nov 2022 22:49:35 +0000 Received: from SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f%4]) with mapi id 15.20.5813.011; Tue, 15 Nov 2022 22:49:35 +0000 From: Gabriel To: bug-gnu-emacs@gnu.org Subject: Re: bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring In-Reply-To: <83tu30iegi.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Nov 2022 14:34:21 +0200") References: <83tu30iegi.fsf@gnu.org> Date: Tue, 15 Nov 2022 19:49:29 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [LZQ1U2s8WlwYTQME0p9DMcN7iukS6W6n4XX5/qWcCDU6Fxw/Py1bTzSicRsRQ4VH] X-ClientProxiedBy: CPYP284CA0061.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:80::12) To SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) X-Microsoft-Original-Message-ID: <87edu3x286.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|PH7PR06MB9017:EE_ X-MS-Office365-Filtering-Correlation-Id: 86281755-0b8a-4730-6b5a-08dac75bab09 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xIt6Ctss4wBuFLRksb405DflN2Ow8RH8ECfWtzWGtwuX7Z8dE6z3nMuyI7lme+ZZDsQvGesLdg6LC+Rm5sauxuCvDTneF9vXWNt5HsH7NuM/4/hm+8I7i+cCFmg5rIpDEACkPihS5/zaQ/NrSTbWup8fe5nVnPA/8/MXYBNNmb+GPRT6q/7Zikeev/4X/+FkttZcvOcW//OUOP70w9jrHE99S0bEFiOsOqLlW9a9SjXE0F8ppKvB43eiFPGMFQbzuinOFHODDw4YZ0Y+2jjlLoI2J0y8IPURY3v+Zwcu4p2PQmF2Vz1C0+zTv+DmLu68Vr+oE0D7UrbSR4xJEiQKJaYO0LAlK94JvKG2n/ChxsV9yuf3q5mMfzueHR0pvv9I+xBt47hCvMIIQCMazk98hrl+p8ZhGT+2TulZieHiUv1cykqDn2mztC5YPQ/X/I9W3KQIIcmir0xKic6dej91XSz2F2qNI1DRpYmJtOFeoeOOHh87ZvvaDLGPRS6A+11bl0/wstt7f35lwi6kJx5Uxp1tfS0ME59tI5M/y9rOLJdxlU9dWOYSjm9j0PBCulD2018b/Okkt3Nz7Sxhv8eAL4jQ9WobivD4NyecMISMg9gcfKAcf+e2Su18WbxUoDRgDI2bIMaQc/tUzJRncM8+T0zUFuO/SaHfgFxASX6l22xcivERRELadxotYpR1HXOX7tTe/QX6Doug13An68/tMJ5a2QqAdjZ1Pj7JilCI2Jc= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q7CQBjupKZ6GOUvOtWr03Z4ampV1mOM7YxNeeWQLs+8dmAKTLRO+q1y1l1VS?= =?us-ascii?Q?Z7+1Ai9XQEsKVRDP4B2MhoTxrv0D2DJatu/lSiZFXpsCD701rX3pDiHhXZrB?= =?us-ascii?Q?OhayJuO9CAiB3ONRyFI6e72USNxWg5IvlBFdUtiOmgZQGbgvkZByxV2tWV50?= =?us-ascii?Q?IMmQmS8xFfQWfDI5JaLpoYr+Y2TikEhBmmr6b97OPcZvb6aYljcqJbeYmgd8?= =?us-ascii?Q?ELjtweD+Lpk1t8mpT5IA3/c1g6/3ual/nEZ/qdsjLFmqfefyuwoSTuAD0UNn?= =?us-ascii?Q?g7bO1RYYelwWR5A4kR7NDYB4+eV/aTWOMJzmChDSGynMub1iGbuEu2T4iGF+?= =?us-ascii?Q?5o5Ezl4tO80iCSiUp2YjTizd5LM6VQFhRniPqk1y6SpOjCvJuMTYNo3USbxp?= =?us-ascii?Q?x8zOXkxA4E1Blekl98qkrTb3gVQbpR3NH81dPwaHbVZ91NdIHpoxvLqrfiS5?= =?us-ascii?Q?KO8o232Tw4jAOv9BAvjLHDFTyoQi8AFVdtp10hiRhzaQ9fIpULtrfIVqdnno?= =?us-ascii?Q?QmYjvjsyEjwIeRNruvzlobKAU9pvN8eiyotGKtqwL32hBU4BJtR+2fYqoZ2y?= =?us-ascii?Q?dkC0eYGJ0cmHeoUQsR3/enaAzVSsomJI89bKca4JX8X4bmFIh1gzyKqKEG5c?= =?us-ascii?Q?HzcR16ORJXJx2Ny7sZ5gi2f0cPqU09dIy4JZvvX07bNKRyN9LIqimOdqu2uc?= =?us-ascii?Q?5wUOpNeE0bO8mm6fpIRQvE4Q/lNeQiI1GF59IF68EUYi0dy68/wzULeKKMNW?= =?us-ascii?Q?55cr6PJP0weLR1HFrmoWzaKW+i2WwhhhnZf+O5MUuGZoQ+V+SEHQ1FTtjGl3?= =?us-ascii?Q?UaxQ3rc+SZbePmdmA240TBG7/7RZ0Q5XP+Fs69uzxxigXSwbcHkdVvEv901Y?= =?us-ascii?Q?OYfViVCzu601c2+nfJvdouc9cGoQmI2ham6OksvlNm3PEs3MjADbLipWWged?= =?us-ascii?Q?1ZiFg37IZCm+QnsWwyM3qHEjtKU0ZF3D87GUBeh7/JulLZlZQDojsVxLK/gM?= =?us-ascii?Q?FCEQ1hQw6QmH6VXel9AcKEyKitdSivOUHDI1EUjji/G8cy7EotwV/rgrT3WZ?= =?us-ascii?Q?kwG5hY82gUjDy4fbZhE0iYONyBZ2yRv/30G438wELxKLkX5g6jJK4849FY9U?= =?us-ascii?Q?SvlS+N8o2yM3R11Z1cvSe3JwAWSg/Gf/Z2d0iCjFiHuBrUIm9H+uPmyf0Uwl?= =?us-ascii?Q?5GEw2hLENxWvxMuljGITCaF/VytZlIdvrbv+LOlbbi8ESn6UJwMqlGddbEE1?= =?us-ascii?Q?hrr0kdKct08OB6+UYi92S4UXlhUMdFqTbybjz0AzJ7XN5ubipQznHyap+R66?= =?us-ascii?Q?2ny8avFleRpRRgkJIHfimnCD7uK9t8WhBVVx2pp4WRjCBA=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 86281755-0b8a-4730-6b5a-08dac75bab09 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 22:49:35.6818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR06MB9017 Received-SPF: pass client-ip=40.92.20.10; envelope-from=gabriel376@hotmail.com; helo=NAM11-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > > Thanks, but can you rephrase so that `flat-button' appeared as one of > the values for STYLE, with an explicit (not implied) description of > what it does? For example, how does `flat-button' affect what COLOR > does for the button isn't clear from your suggested text. > > IOW, what I see in NEWS about this doesn't follow from the text you > propose, at least not easily. Hi Eli, Makes sense, thank you for pointing it out. I took another look at NEWS and display.texi, and rephrased the docstring to also mention the flat-button in the COLOR section. Here is a new patch. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-flat-button-to-set-face-attribute-docstring.patch >From 5456fbba9cfd3cd27dfc4db60f0729d7a79578c5 Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Tue, 15 Nov 2022 19:42:01 -0300 Subject: [PATCH 1/1] Add flat-button to set-face-attribute docstring * lisp/faces.el (set-face-attribute): Add `flat-button' to COLOR and STYLE sections of docstring. --- lisp/faces.el | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/lisp/faces.el b/lisp/faces.el index 09e8110449..5ae1c65a4d 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -787,13 +787,12 @@ set-face-attribute defaults to 1. If WIDTH is negative, the absolute value is the width of the lines, and draw top/bottom lines inside the characters area, not around it. COLOR is the name of the color to draw in, default is -the foreground color of the face for simple boxes, and the background -color of the face for 3D boxes. STYLE specifies whether a 3D box -should be draw. If STYLE is `released-button', draw a box looking -like a released 3D button. If STYLE is `pressed-button' draw a box -that appears like a pressed button. If STYLE is nil, the default if -the property list doesn't contain a style specification, draw a 2D -box. +the background color of the face for 3D boxes and `flat-button', and +the foreground color of the face for other boxes. STYLE specifies +whether a 3D box should be draw. If STYLE is `released-button', draw +a box looking like a released 3D button. If STYLE is `pressed-button' +draw a box that appears like a pressed button. If STYLE is nil, +`flat-button' or omitted, draw a 2D box. `:inverse-video' -- 2.34.1 --=-=-= Content-Type: text/plain --- Gabriel --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 16 09:45:33 2022 Received: (at 59266-done) by debbugs.gnu.org; 16 Nov 2022 14:45:33 +0000 Received: from localhost ([127.0.0.1]:56503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovJfR-00028I-9f for submit@debbugs.gnu.org; Wed, 16 Nov 2022 09:45:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovJfL-00027z-CS for 59266-done@debbugs.gnu.org; Wed, 16 Nov 2022 09:45:31 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovJfG-0007iI-5w; Wed, 16 Nov 2022 09:45:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kQQx7YrfWNwGKy5O5y+zryAyBGnvUhHfG2mnW7rQIbA=; b=dCONWVR8zV5w 0fwxN/gcGoQAeX4DX3oBvtxDNpfBrGqLIXeymCWHaAOyqAXaDttW4eKXQGHtUNETbf3R2zq7+x5HO lJT1YGihielU3RqhbpDzMezrx6yDelhDqRgulGrq+Nzrw0VFVYczdOrP3MEfwzzVIdYUDjoRQmdUe ddE2s5VeU1h4YuLTXz8jmlQCiC7DIfysRpE4MIJKZEhNNKWiyCp17r2n6wxVMadZ7ZH6YYBh+ymDl 90yi8oy+Feo+4a30gpqU7+T6717RGQYaxxrDE0Wk5PT4zcDuj7JRQQRAaOM80T5/zhE3lktvviE1m CYWmMRpe1A605YXPRF5/+A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovJfF-00047k-Cg; Wed, 16 Nov 2022 09:45:21 -0500 Date: Wed, 16 Nov 2022 16:45:17 +0200 Message-Id: <83zgcrez5u.fsf@gnu.org> From: Eli Zaretskii To: Gabriel In-Reply-To: (message from Gabriel on Tue, 15 Nov 2022 19:49:29 -0300) Subject: Re: bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring References: <83tu30iegi.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59266-done Cc: 59266-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Gabriel > Date: Tue, 15 Nov 2022 19:49:29 -0300 > > Makes sense, thank you for pointing it out. I took another look at NEWS > and display.texi, and rephrased the docstring to also mention the > flat-button in the COLOR section. > > Here is a new patch. Thanks, installed, and closing the bug. P.S. There were minor issues with the commit log message, in particular with our quoting style. Please examine the commit I actually push and try to follow this example in the future. From unknown Mon Jun 23 06:00:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 15 Dec 2022 12:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator