Subject: bug#59266: closed (Re: bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 16 Nov 2022 14:46:02 +0000

Your bug report

#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
59266: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59266
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring
From: Eli Zaretskii <[email-masked]>
To: Gabriel <[email-masked]>
Cc: [email-masked]
Date: Wed, 16 Nov 2022 16:45:17 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: Gabriel <[email-masked]>
> Date: Tue, 15 Nov 2022 19:49:29 -0300
> 
> Makes sense, thank you for pointing it out. I took another look at NEWS
> and display.texi, and rephrased the docstring to also mention the
> flat-button in the COLOR section.
> 
> Here is a new patch.

Thanks, installed, and closing the bug.

P.S. There were minor issues with the commit log message, in
particular with our quoting style.  Please examine the commit I
actually push and try to follow this example in the future.

Subject: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring
From: Gabriel <[email-masked]>
To: [email-masked]
Date: Mon, 14 Nov 2022 11:48:23 -0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Description:
The docstring of `set-face-attribute' does not mention the new
`flat-button' STYLE in BOX section.

See commit 13bd909591e9c1cf0228750b2d4a9e4364f61cc9 and
(info "(elisp)Face Attributes").

Patch:
>From fed6c0773f152ff795115b1a6c1a7855b3b99f54 Mon Sep 17 00:00:00 2001
From: Gabriel do Nascimento Ribeiro <[email-masked]>
Date: Mon, 14 Nov 2022 11:36:59 -0300
Subject: [PATCH 1/1] Add flat-button to set-face-attribute docstring

* lisp/faces.el (set-face-attribute): Add `flat-button' to STYLE
  section of docstring.
---
 lisp/faces.el | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lisp/faces.el b/lisp/faces.el
index 09e8110449..4088f4be8a 100644
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -791,9 +791,8 @@ set-face-attribute
 color of the face for 3D boxes.  STYLE specifies whether a 3D box
 should be draw.  If STYLE is `released-button', draw a box looking
 like a released 3D button.  If STYLE is `pressed-button' draw a box
-that appears like a pressed button.  If STYLE is nil, the default if
-the property list doesn't contain a style specification, draw a 2D
-box.
+that appears like a pressed button.  If STYLE is nil, `flat-button'
+or omitted, draw a 2D box.
 
 `:inverse-video'
 
-- 
2.34.1

---
Gabriel