Subject: Re: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path.

From: Maxim Cournoyer <[email-masked]>
Date: Sun, 13 Nov 2022 22:01:45 -0500

Hi,

Thiago Jung Bauermann via Guix-patches via <[email-masked]>
writes:

> Hello Liliana,
>
> Liliana Marie Prikler <[email-masked]> writes:
>
>> Am Sonntag, dem 13.11.2022 um 22:24 +0100 schrieb Liliana Marie
>> Prikler:
>>> Am Sonntag, dem 13.11.2022 um 18:11 -0300 schrieb Thiago Jung
>>> Bauermann:
>>> > Magit has a strong dependency on Git so it should directly
>>> > reference
>>> > the
>>> > git executable rather than expect it to be available in the profile
>>> > or
>>> > environment.
>>> > 
>>> > This also fixes a build failure in emacs-forge.
>>> > 
>>> > * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments]<#:phases>:
>>> > Substitute
>>> > git path in the ‘magit-git-executable’ variable.
>>> LGTM, will push once I'm done with some other stuff.
>> Aaaand it's done.
>
> Wow, that was quick. Thank you!

Won't this make magit unusable from TRAMP (which already seems broken
for me since the time we enabled native comp -- anyone else?).

-- 
Thanks,
Maxim