From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 16:11:37 2022 Received: (at submit) by debbugs.gnu.org; 13 Nov 2022 21:11:38 +0000 Received: from localhost ([127.0.0.1]:48473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouKGP-0002IM-BA for submit@debbugs.gnu.org; Sun, 13 Nov 2022 16:11:37 -0500 Received: from lists.gnu.org ([209.51.188.17]:51198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouKGJ-0002IA-8A for submit@debbugs.gnu.org; Sun, 13 Nov 2022 16:11:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouKGH-00014d-KP for guix-patches@gnu.org; Sun, 13 Nov 2022 16:11:30 -0500 Received: from mx.kolabnow.com ([212.103.80.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouKGE-0006Mi-TE for guix-patches@gnu.org; Sun, 13 Nov 2022 16:11:28 -0500 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id D060B1784 for ; Sun, 13 Nov 2022 22:11:23 +0100 (CET) Authentication-Results: ext-mx-out001.mykolab.com (amavisd-new); dkim=pass (4096-bit key) reason="pass (just generated, assumed good)" header.d=kolabnow.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:subject:subject:from:from:received :received:received; s=dkim20160331; t=1668373883; x=1670188284; bh=UQNWKVvFwixJtgRKrlktG3V/oWH7iW0/yDFMQ7xVhhQ=; b=gOs5tXKnjDR2 cFw3PNYv4dTjbPGoub+d4vMyGXkOJ9bgUUcz/kYcCaU338WA1U3Lks3wU8Qbk266 jW3Dy/dh7uqcfWd1DvgMPSsiVrX4pewqPqV8He8Ajb6L/Fb1VXVe5glppg64KzDt H6JC0GJCq3H7b8MeLCrOPjRJs+zAWlyvgVGRvRFgspyhp8OaMR4+RXmDotwVMEN/ zPq45TEqOtkeMX68V5a8nw5sLZXz6UlxRLv5MaQfqzdFFpq7oaPPfUIqIfxL3y5/ nQ/dKMFs8U+WcH/VHF8rVGSYDa6QfuGwP66npc4l0Zh5I2IBwekarUuDpHhPnWsE Wq5xawGTx6gBddjlaQs9qgO3P+m03nU7ZQEHLheYYPU4NnsojaxtJ1NEeflRb5yO Gk0HrdmPAV8Ov/nwusC6bQgsVekyT8BpSOIddGjOS7IdlryljrqF/ncf3pcaPwYU 7mo5hnCovg0ppx5Pv3ryrT5nNIK3gLqQHz6MfU6x3boK0GjBxZklvw0bIbOiFArw WybPBMXcn1UgvOpR/XoIq1re5i8qzLxfHt9HYciI2LE7FXlxnM54/23qSchq7W/L X4LnZED6rO2uOUSJ2gE2/I5DDJuTvMPO76yN132gaF2+KUFQufEvQfTZ+nmd6khg czHkEEE/pQw8ZvoNwhItlmz7d1BQMzw= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-10 required=4 tests=[BAYES_00=-1.9] autolearn=no autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z93B-dXfTrpy for ; Sun, 13 Nov 2022 22:11:23 +0100 (CET) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by mx.kolabnow.com (Postfix) with ESMTPS id 9A7A614D1 for ; Sun, 13 Nov 2022 22:11:22 +0100 (CET) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx002.mykolab.com (Postfix) with ESMTPS id 6693B370E; Sun, 13 Nov 2022 22:11:22 +0100 (CET) From: Thiago Jung Bauermann To: guix-patches@gnu.org Subject: [PATCH] gnu: emacs-magit: Substitute git executable path. Date: Sun, 13 Nov 2022 18:11:11 -0300 Message-Id: <20221113211111.59581-1-bauermann@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: andrew@trop.in X-Debbugs-Cc: liliana.prikler@gmail.com Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=212.103.80.155; envelope-from=bauermann@kolabnow.com; helo=mx.kolabnow.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Thiago Jung Bauermann X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Magit has a strong dependency on Git so it should directly reference the git executable rather than expect it to be available in the profile or environment. This also fixes a build failure in emacs-forge. * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments]<#:phases>: Substitute git path in the ‘magit-git-executable’ variable. --- gnu/packages/emacs-xyz.scm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 8ff6275bad96..1406f8a715f2 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -117,6 +117,7 @@ ;;; Copyright © 2022 Jose G Perez Taveras ;;; Copyright © 2022 Hilton Chain ;;; Copyright © 2022 Nicolas Graves +;;; Copyright © 2022 Thiago Jung Bauermann ;;; ;;; This file is part of GNU Guix. ;;; @@ -1031,7 +1032,11 @@ (define-public emacs-magit ("magit-version" #$version)))) (add-after 'set-magit-version 'patch-exec-paths (lambda* (#:key inputs #:allow-other-keys) - (make-file-writable "lisp/magit-sequence.el") + (for-each make-file-writable + (list "lisp/magit-git.el" "lisp/magit-sequence.el")) + (emacs-substitute-variables "lisp/magit-git.el" + ("magit-git-executable" + (search-input-file inputs "/bin/git"))) (emacs-substitute-variables "lisp/magit-sequence.el" ("magit-perl-executable" (search-input-file inputs "/bin/perl"))))) From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 16:24:38 2022 Received: (at 59253) by debbugs.gnu.org; 13 Nov 2022 21:24:38 +0000 Received: from localhost ([127.0.0.1]:48492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouKSz-0002cT-Nb for submit@debbugs.gnu.org; Sun, 13 Nov 2022 16:24:38 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:43751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouKSv-0002cC-5t for 59253@debbugs.gnu.org; Sun, 13 Nov 2022 16:24:36 -0500 Received: by mail-ed1-f67.google.com with SMTP id i21so14683281edj.10 for <59253@debbugs.gnu.org>; Sun, 13 Nov 2022 13:24:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=HXtMCkK9cuFsQcV/gRBiiMrgFsffbrBJr4s6hsDmA+Y=; b=A7S8qP4OyiIEr4gf65hA8g8JQHca1yyfaI1Z13h74thNpSqnK61UHco4xfKWkcjGnI LVqlnjzdYqiMZ4daoN9P2g52o0XhEjwWeAo+LAd6eq4lQYiD5RNLyRVmv4tYE8LMkpyg D++P6PGJmBwJlrkw3tN3oUTH3wGzjtjjyAqAS5qh4Traa3vWrOLctqRcFUle1H7gArTG CJrJxWoOpWE1ik//DCWuFxDaVf/U9A4IiSGs9ZmANrr2q/KJwAUWM16SL6HRjnF6llQO C4YMm7WLsnhndo/cXSae5Qubg5SgIiP5KVZl3QWiLG7QTKJ2wzxJr6mL+xl6vjacHlvL HXuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HXtMCkK9cuFsQcV/gRBiiMrgFsffbrBJr4s6hsDmA+Y=; b=FF1dqWRDvUNxwgp4Azqht7OekOsFcR07tWwJHfFYD+uNQPwJDqqpcvmQEtDwEtCs9z k0xNwoh642x4oF89zw7EUtszorf2SI86qSNZY/hwD9FEx8vC6eZMrZfZRsrYYbu1zsDu Ru6ULbdstE5KkYoDpakriJ55iiX15shScqsnp7qCmw642dK87hlB5oZGNN/VNxDmhHoJ sp40EeT9/fKPJM5eYxZp/RQMfsHDoYbBXuLgJi2rTFFkLkVTSXGqlVv5cl5nziGSAlEk hW5oiwOrnh6JiOSXfFLiMK90ZtKOhzrQhCaqejNHc0yWpR3/VwyS4DhM8PCBOR7vyYeF N8FA== X-Gm-Message-State: ANoB5pldvPs0O4L6oy37KKzbJm7/ZwqtdX714hCxbXFVNwI1WymbNMdK jmM7R95QrSZOzbMn0TYzJws= X-Google-Smtp-Source: AA0mqf7dgUrJZh7c6GixB6V/LuPb6NAFvRBkA1ZugXJyI/AYbYNjrg4KfyC2NzWhQ1FfyWOfrYpZGQ== X-Received: by 2002:aa7:c649:0:b0:463:b0de:c210 with SMTP id z9-20020aa7c649000000b00463b0dec210mr9290166edr.10.1668374666242; Sun, 13 Nov 2022 13:24:26 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id ft29-20020a170907801d00b0077016f4c6d4sm3382321ejc.55.2022.11.13.13.24.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Nov 2022 13:24:25 -0800 (PST) Message-ID: <2f939a4eb14313d5e2c656951ebe91bba31c8504.camel@gmail.com> Subject: Re: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path. From: Liliana Marie Prikler To: Thiago Jung Bauermann , 59253@debbugs.gnu.org Date: Sun, 13 Nov 2022 22:24:24 +0100 In-Reply-To: <20221113211111.59581-1-bauermann@kolabnow.com> References: <20221113211111.59581-1-bauermann@kolabnow.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59253 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) QW0gU29ubnRhZywgZGVtIDEzLjExLjIwMjIgdW0gMTg6MTEgLTAzMDAgc2NocmllYiBUaGlhZ28g SnVuZwpCYXVlcm1hbm46Cj4gTWFnaXQgaGFzIGEgc3Ryb25nIGRlcGVuZGVuY3kgb24gR2l0IHNv IGl0IHNob3VsZCBkaXJlY3RseSByZWZlcmVuY2UKPiB0aGUKPiBnaXQgZXhlY3V0YWJsZSByYXRo ZXIgdGhhbiBleHBlY3QgaXQgdG8gYmUgYXZhaWxhYmxlIGluIHRoZSBwcm9maWxlCj4gb3IKPiBl bnZpcm9ubWVudC4KPiAKPiBUaGlzIGFsc28gZml4ZXMgYSBidWlsZCBmYWlsdXJlIGluIGVtYWNz LWZvcmdlLgo+IAo+ICogZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20gKGVtYWNzLW1hZ2l0KVth cmd1bWVudHNdPCM6cGhhc2VzPjoKPiBTdWJzdGl0dXRlCj4gZ2l0IHBhdGggaW4gdGhlIOKAmG1h Z2l0LWdpdC1leGVjdXRhYmxl4oCZIHZhcmlhYmxlLgo+IC0tLQo+IMKgZ251L3BhY2thZ2VzL2Vt YWNzLXh5ei5zY20gfCA3ICsrKysrKy0KPiDCoDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2VtYWNzLXh5 ei5zY20gYi9nbnUvcGFja2FnZXMvZW1hY3MteHl6LnNjbQo+IGluZGV4IDhmZjYyNzViYWQ5Ni4u MTQwNmY4YTcxNWYyIDEwMDY0NAo+IC0tLSBhL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCj4g KysrIGIvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20KPiBAQCAtMTE3LDYgKzExNyw3IEBACj4g wqA7OzsgQ29weXJpZ2h0IMKpIDIwMjIgSm9zZSBHIFBlcmV6IFRhdmVyYXMgPGpvc2VncHQyN0Bn bWFpbC5jb20+Cj4gwqA7OzsgQ29weXJpZ2h0IMKpIDIwMjIgSGlsdG9uIENoYWluIDxoYWtvQHVs dHJhcmFyZS5zcGFjZT4KPiDCoDs7OyBDb3B5cmlnaHQgwqkgMjAyMiBOaWNvbGFzIEdyYXZlcyA8 bmdyYXZlc0BuZ3JhdmVzLmZyPgo+ICs7OzsgQ29weXJpZ2h0IMKpIDIwMjIgVGhpYWdvIEp1bmcg QmF1ZXJtYW5uIDxiYXVlcm1hbm5Aa29sYWJub3cuY29tPgo+IMKgOzs7Cj4gwqA7OzsgVGhpcyBm aWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCj4gwqA7OzsKPiBAQCAtMTAzMSw3ICsxMDMyLDExIEBA IChkZWZpbmUtcHVibGljIGVtYWNzLW1hZ2l0Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgICgibWFnaXQtdmVyc2lvbiIgIyR2ZXJzaW9uKSkpKQo+IMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCAoYWRkLWFmdGVyICdzZXQtbWFnaXQtdmVyc2lvbiAncGF0Y2gtZXhlYy1wYXRo cwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGxhbWJkYSogKCM6a2V5IGlucHV0cyAj OmFsbG93LW90aGVyLWtleXMpCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAobWFr ZS1maWxlLXdyaXRhYmxlICJsaXNwL21hZ2l0LXNlcXVlbmNlLmVsIikKPiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIChmb3ItZWFjaCBtYWtlLWZpbGUtd3JpdGFibGUKPiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGxpc3QgImxpc3Av bWFnaXQtZ2l0LmVsIiAibGlzcC9tYWdpdC0KPiBzZXF1ZW5jZS5lbCIpKQo+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgKGVtYWNzLXN1YnN0aXR1dGUtdmFyaWFibGVzICJsaXNwL21h Z2l0LWdpdC5lbCIKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoIm1hZ2l0 LWdpdC1leGVjdXRhYmxlIgo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg KHNlYXJjaC1pbnB1dC1maWxlIGlucHV0cyAiL2Jpbi9naXQiKSkpCj4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgKGVtYWNzLXN1YnN0aXR1dGUtdmFyaWFibGVzICJsaXNwL21hZ2l0 LXNlcXVlbmNlLmVsIgo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoIm1h Z2l0LXBlcmwtZXhlY3V0YWJsZSIKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCAoc2VhcmNoLWlucHV0LWZpbGUgaW5wdXRzICIvYmluL3BlcmwiKSkpKSkKTEdUTSwgd2ls bCBwdXNoIG9uY2UgSSdtIGRvbmUgd2l0aCBzb21lIG90aGVyIHN0dWZmLgoK From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 16:56:01 2022 Received: (at 59253-done) by debbugs.gnu.org; 13 Nov 2022 21:56:01 +0000 Received: from localhost ([127.0.0.1]:48540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouKxM-0003QU-R5 for submit@debbugs.gnu.org; Sun, 13 Nov 2022 16:56:01 -0500 Received: from mail-ej1-f67.google.com ([209.85.218.67]:39591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouKxI-0003QF-Ur for 59253-done@debbugs.gnu.org; Sun, 13 Nov 2022 16:55:59 -0500 Received: by mail-ej1-f67.google.com with SMTP id i10so15512715ejg.6 for <59253-done@debbugs.gnu.org>; Sun, 13 Nov 2022 13:55:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Uppp5ItLmJijAGTCJ5xGG7pQsq5MW/tOZ76bdICbukc=; b=CS2paet+RCpBaODv+DABzWV3Pbi9NFRUvr7zAvsHEnXvz9ewy3R11iShX90GB/0Ytv FztkpWPgtHHAcin70u0KlWoSjhCv6IVObtNqRWRO9VTBWha05nwLxUeXJmb2W/tFP/7+ 219820UAf3wUAEUxFDHXwZbBUyvvrlfFR17DPpsmZqzVXYp/IGd0VyPBDm1FHwSfItd1 s0qjrdlSuiJ9feTSuAXBLrKU01ke6I5zUmYjSA5ncMLiOOMK0NVhfKtZwiwnNUe3wHq4 sIdppsT5we8YeS3gMIn49KvYAVWSXUJFndhjoRH+oNixmDQzuqMGh/zNQJzUvVrtUR1S 7SUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Uppp5ItLmJijAGTCJ5xGG7pQsq5MW/tOZ76bdICbukc=; b=T8fLt1wIlQYmqbCU83jqlnMyTe04coxd4ItvkV9BvfC5kfv2rdSJ6w7KtLsJN/TBYS /jwxW/7efv+BA95LNBaPMdYAGvPhR8S9Qb+SQke0NM3/rOYLyrZ8LmXESJBPKxDuM3Im q3k8T3YY084Z0JnRnrNOTnTw/WMxTmOo/j3GKB+s64AJCEJ1BkVy5GiagNVncRvr89jQ /zSq+jhsH8iNWlMPko084qz2iTpAlARH6hQPOtmiu19DZ930liEnGiJk297jiZj964YU 8aDaTi19OOzZkt3XfJiGltkmI4tSbTu1GhQpnnM83g+EiOPhmULHk2Vt+rAdrGLlruLD KVgQ== X-Gm-Message-State: ANoB5pnVNoeayyQhcdFFocfgezEhxrLBwzrg+HkPlK6VCllVnuZUpjyn ReeITsAiLcown/DZIEkyOJA= X-Google-Smtp-Source: AA0mqf7swy14H/LenMeJuhskMU7JIvfnTeAbqQTyp6k1PR17/cRvkFuZNoOQkJwVP/UrzJfHa2LcMA== X-Received: by 2002:a17:906:5fc9:b0:781:c97c:84d1 with SMTP id k9-20020a1709065fc900b00781c97c84d1mr8480863ejv.147.1668376550739; Sun, 13 Nov 2022 13:55:50 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id d13-20020aa7c1cd000000b00463597d2c25sm3941796edp.74.2022.11.13.13.55.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Nov 2022 13:55:50 -0800 (PST) Message-ID: <93a8d2f90b5b25e8bfce44b114015a50ec091ec3.camel@gmail.com> Subject: Re: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path. From: Liliana Marie Prikler To: Thiago Jung Bauermann , 59253-done@debbugs.gnu.org Date: Sun, 13 Nov 2022 22:55:48 +0100 In-Reply-To: <2f939a4eb14313d5e2c656951ebe91bba31c8504.camel@gmail.com> References: <20221113211111.59581-1-bauermann@kolabnow.com> <2f939a4eb14313d5e2c656951ebe91bba31c8504.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59253-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) QW0gU29ubnRhZywgZGVtIDEzLjExLjIwMjIgdW0gMjI6MjQgKzAxMDAgc2NocmllYiBMaWxpYW5h IE1hcmllClByaWtsZXI6Cj4gQW0gU29ubnRhZywgZGVtIDEzLjExLjIwMjIgdW0gMTg6MTEgLTAz MDAgc2NocmllYiBUaGlhZ28gSnVuZwo+IEJhdWVybWFubjoKPiA+IE1hZ2l0IGhhcyBhIHN0cm9u ZyBkZXBlbmRlbmN5IG9uIEdpdCBzbyBpdCBzaG91bGQgZGlyZWN0bHkKPiA+IHJlZmVyZW5jZQo+ ID4gdGhlCj4gPiBnaXQgZXhlY3V0YWJsZSByYXRoZXIgdGhhbiBleHBlY3QgaXQgdG8gYmUgYXZh aWxhYmxlIGluIHRoZSBwcm9maWxlCj4gPiBvcgo+ID4gZW52aXJvbm1lbnQuCj4gPiAKPiA+IFRo aXMgYWxzbyBmaXhlcyBhIGJ1aWxkIGZhaWx1cmUgaW4gZW1hY3MtZm9yZ2UuCj4gPiAKPiA+ICog Z251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20gKGVtYWNzLW1hZ2l0KVthcmd1bWVudHNdPCM6cGhh c2VzPjoKPiA+IFN1YnN0aXR1dGUKPiA+IGdpdCBwYXRoIGluIHRoZSDigJhtYWdpdC1naXQtZXhl Y3V0YWJsZeKAmSB2YXJpYWJsZS4KPiA+IC0tLQo+ID4gwqBnbnUvcGFja2FnZXMvZW1hY3MteHl6 LnNjbSB8IDcgKysrKysrLQo+ID4gwqAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAx IGRlbGV0aW9uKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZW1hY3MteHl6 LnNjbSBiL2dudS9wYWNrYWdlcy9lbWFjcy0KPiA+IHh5ei5zY20KPiA+IGluZGV4IDhmZjYyNzVi YWQ5Ni4uMTQwNmY4YTcxNWYyIDEwMDY0NAo+ID4gLS0tIGEvZ251L3BhY2thZ2VzL2VtYWNzLXh5 ei5zY20KPiA+ICsrKyBiL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCj4gPiBAQCAtMTE3LDYg KzExNyw3IEBACj4gPiDCoDs7OyBDb3B5cmlnaHQgwqkgMjAyMiBKb3NlIEcgUGVyZXogVGF2ZXJh cyA8am9zZWdwdDI3QGdtYWlsLmNvbT4KPiA+IMKgOzs7IENvcHlyaWdodCDCqSAyMDIyIEhpbHRv biBDaGFpbiA8aGFrb0B1bHRyYXJhcmUuc3BhY2U+Cj4gPiDCoDs7OyBDb3B5cmlnaHQgwqkgMjAy MiBOaWNvbGFzIEdyYXZlcyA8bmdyYXZlc0BuZ3JhdmVzLmZyPgo+ID4gKzs7OyBDb3B5cmlnaHQg wqkgMjAyMiBUaGlhZ28gSnVuZyBCYXVlcm1hbm4KPiA+IDxiYXVlcm1hbm5Aa29sYWJub3cuY29t Pgo+ID4gwqA7OzsKPiA+IMKgOzs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4Lgo+ID4g wqA7OzsKPiA+IEBAIC0xMDMxLDcgKzEwMzIsMTEgQEAgKGRlZmluZS1wdWJsaWMgZW1hY3MtbWFn aXQKPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoIm1hZ2l0LXZlcnNp b24iICMkdmVyc2lvbikpKSkKPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoYWRkLWFmdGVy ICdzZXQtbWFnaXQtdmVyc2lvbiAncGF0Y2gtZXhlYy1wYXRocwo+ID4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCAobGFtYmRhKiAoIzprZXkgaW5wdXRzICM6YWxsb3ctb3RoZXIta2V5cykK PiA+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKG1ha2UtZmlsZS13cml0YWJsZSAi bGlzcC9tYWdpdC1zZXF1ZW5jZS5lbCIpCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIChmb3ItZWFjaCBtYWtlLWZpbGUtd3JpdGFibGUKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAobGlzdCAibGlzcC9tYWdpdC1naXQuZWwi ICJsaXNwL21hZ2l0LQo+ID4gc2VxdWVuY2UuZWwiKSkKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgKGVtYWNzLXN1YnN0aXR1dGUtdmFyaWFibGVzICJsaXNwL21hZ2l0LWdpdC5l bCIKPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgibWFnaXQtZ2l0LWV4 ZWN1dGFibGUiCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChzZWFy Y2gtaW5wdXQtZmlsZSBpbnB1dHMgIi9iaW4vZ2l0IikpKQo+ID4gwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgKGVtYWNzLXN1YnN0aXR1dGUtdmFyaWFibGVzICJsaXNwL21hZ2l0LQo+ ID4gc2VxdWVuY2UuZWwiCj4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg KCJtYWdpdC1wZXJsLWV4ZWN1dGFibGUiCj4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCAoc2VhcmNoLWlucHV0LWZpbGUgaW5wdXRzICIvYmluL3BlcmwiKSkpKSkKPiBM R1RNLCB3aWxsIHB1c2ggb25jZSBJJ20gZG9uZSB3aXRoIHNvbWUgb3RoZXIgc3R1ZmYuCkFhYWFu ZCBpdCdzIGRvbmUuCg== From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 17:22:18 2022 Received: (at 59253-done) by debbugs.gnu.org; 13 Nov 2022 22:22:18 +0000 Received: from localhost ([127.0.0.1]:48576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouLMo-00045u-7j for submit@debbugs.gnu.org; Sun, 13 Nov 2022 17:22:18 -0500 Received: from mx.kolabnow.com ([212.103.80.154]:11762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouLMl-00045f-IL for 59253-done@debbugs.gnu.org; Sun, 13 Nov 2022 17:22:17 -0500 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 3305417B6; Sun, 13 Nov 2022 23:22:09 +0100 (CET) Authentication-Results: ext-mx-out001.mykolab.com (amavisd-new); dkim=pass (4096-bit key) reason="pass (just generated, assumed good)" header.d=kolabnow.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:in-reply-to:date:date:subject:subject:from:from :references:received:received:received; s=dkim20160331; t= 1668378128; x=1670192529; bh=RpJmdajEg+0WWlVHOKzWTKCQyGPwSzy3R0G m/wjnSPk=; b=ZlkHrqTVIEmKBdrNqgZb6zw/p36JPTjhgD9GoWxeKtVNi7klCsa Ynd1oefUD6hc4goFp0X7dfkYsfiiZ1fawSmqX/Do0uZHQfNVPmztTbZ0jOhd/oXQ UQIPP5ujiYrj3jRmijYjEkxm3Zu/pyE963sHdyCIguQdTHaJwsF07b0OTLvLjIM4 vbNeK4ajD5OIVAbb4z4IWrsbKXhQAfsMI0W0NoIQJ0RyBtgojHBF7d6tFB7jXcbc rHfwk0iOHVrQrZ8y/mnOo8v6ttEv3UfGDopf+4xjlKDwJeCgrX6xyBBtUcrm8ffH WXWGtW9YBOserqfkDnPQ+vLI7KdjBd7RY5JWPzP2kZXJv7qeymFMLzuOBsjNVJ1B 7rRSEOTNbtVTn0xL6AJ7MRp89xN+SdEonMp4eUTPZ/Tna2HXyXhqTKvLKmSGXyce dwPp0Ul8YSIUt9+eBaZNiLcLIt/wNeRYn7HBypS8UF6PehyzWjZ9Hwbyp9Do015T l825hyZw1GevzniIOiOadc2YH9Gwjd2vaksaGZ1eqRVpyuoahYpF16/O5iKU6r+a IVajzgrr8gqExXsI+gx6fvW49p5oEphgB9Ly836zykxxWBKcGaP4pVhznyocrgJ2 LKet/T825WIXrnwBPHFhFq6D5x33YB5buJTQ4v5rdiuX1wH4IQb2V/k8= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-10 required=4 tests=[BAYES_00=-1.9] autolearn=no autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EbG3NAJ6zxJ6; Sun, 13 Nov 2022 23:22:08 +0100 (CET) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by mx.kolabnow.com (Postfix) with ESMTPS id B54091502; Sun, 13 Nov 2022 23:22:08 +0100 (CET) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx002.mykolab.com (Postfix) with ESMTPS id 66E163712; Sun, 13 Nov 2022 23:22:08 +0100 (CET) References: <20221113211111.59581-1-bauermann@kolabnow.com> <2f939a4eb14313d5e2c656951ebe91bba31c8504.camel@gmail.com> <93a8d2f90b5b25e8bfce44b114015a50ec091ec3.camel@gmail.com> From: Thiago Jung Bauermann To: Liliana Marie Prikler Subject: Re: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path. Date: Sun, 13 Nov 2022 19:21:11 -0300 In-reply-to: <93a8d2f90b5b25e8bfce44b114015a50ec091ec3.camel@gmail.com> Message-ID: <87r0y6pkac.fsf@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59253-done Cc: 59253-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Liliana, Liliana Marie Prikler writes: > Am Sonntag, dem 13.11.2022 um 22:24 +0100 schrieb Liliana Marie > Prikler: >> Am Sonntag, dem 13.11.2022 um 18:11 -0300 schrieb Thiago Jung >> Bauermann: >> > Magit has a strong dependency on Git so it should directly >> > reference >> > the >> > git executable rather than expect it to be available in the profile >> > or >> > environment. >> >=20 >> > This also fixes a build failure in emacs-forge. >> >=20 >> > * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments]<#:phases>: >> > Substitute >> > git path in the =E2=80=98magit-git-executable=E2=80=99 variable. >> LGTM, will push once I'm done with some other stuff. > Aaaand it's done. Wow, that was quick. Thank you! --=20 Thiago From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 22:01:57 2022 Received: (at 59253-done) by debbugs.gnu.org; 14 Nov 2022 03:01:57 +0000 Received: from localhost ([127.0.0.1]:48742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouPjQ-0002bG-NF for submit@debbugs.gnu.org; Sun, 13 Nov 2022 22:01:57 -0500 Received: from mail-qv1-f51.google.com ([209.85.219.51]:44809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouPjN-0002b2-I2 for 59253-done@debbugs.gnu.org; Sun, 13 Nov 2022 22:01:55 -0500 Received: by mail-qv1-f51.google.com with SMTP id n18so7102130qvt.11 for <59253-done@debbugs.gnu.org>; Sun, 13 Nov 2022 19:01:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=N+eU5AsWZq0MYMMttELewFpw1axBCtw8XHXkZNoGVk8=; b=VFx2yNMwfWHsp/Am/ENn9YO0Jf359IdvWfSrF0UttU9TKAyImX/xY27ZCC4VD2qtj+ t5EbiR+NaIYjb4DenkrlqVyrklE1DPbJ6nzJ8FEjL2h5OZFSFgwUkVJ0SVOfEZc9N+JM n/kRDH60uZNYjhXvydpAf8kuVTB5COYSTBz/eKGzjGT7wtHkT+09r+1WVG3V26y1sv2+ 1lhm00nZ2UW530r/6vyWrL6xV+mIRtkn+dNNwLX6kM3jN8cFOt48uEzi075UoP0mWXDF 2zrRfORPpvAEpyMQ57h2V3OqVP8acvmgjiJWIJVACSjsIrV4jMzMlWF9fI8mWjwx66ll /2Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=N+eU5AsWZq0MYMMttELewFpw1axBCtw8XHXkZNoGVk8=; b=qQMJO+GlyjwLVD1Yds92+lACa3Nwr4Cj8vXyT7z+u2RA30nhVZ6L8xVOR+uBsoYy84 rgQPhtsYzz+b/9cH582vba5HW2djK8zTWip5IkhMGY/jGAzc/aPKT5aHpV8w5b1s5TQS HrJX3VgiUyPSVr9rb7Ikk/wTXvVE1k+hhKgsRwyR7mZ/9E9cW6N7+R7MrwH+3Gw4PMeA 9iEbFLs96niHontf9CZCm1/W1yYUjrLGAutA57ZBQDnYN1UwWC1pbmo/2WHhbQhrQoDJ RnN1zgT4NGuiV/TFtkODM/VPKAfAjznjaaXxWJYYrhh/LjmRnb2ZY/h66bGMS8mANrju 3Dlw== X-Gm-Message-State: ANoB5pml60dKfB7lFj4g0nl2YiAvMfRVWL7aMgv9g0oUl04z06VrDHF4 Rukitu+BL7+k4SAOG1uyAsXu1lWIJBDSnw== X-Google-Smtp-Source: AA0mqf6C1cHBiJto/tHLeZF8JpMXE+i/T/r/kp/NV/0DOPnKZjNpohikgNVL3t3hWwH+4+sUplNjKA== X-Received: by 2002:a0c:e1d0:0:b0:4b1:8165:58da with SMTP id v16-20020a0ce1d0000000b004b1816558damr10988798qvl.30.1668394907774; Sun, 13 Nov 2022 19:01:47 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1001]) by smtp.gmail.com with ESMTPSA id bq40-20020a05620a46a800b006f7ee901674sm5699766qkb.2.2022.11.13.19.01.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Nov 2022 19:01:47 -0800 (PST) From: Maxim Cournoyer To: Thiago Jung Bauermann via Guix-patches via Subject: Re: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path. References: <20221113211111.59581-1-bauermann@kolabnow.com> <2f939a4eb14313d5e2c656951ebe91bba31c8504.camel@gmail.com> <93a8d2f90b5b25e8bfce44b114015a50ec091ec3.camel@gmail.com> <87r0y6pkac.fsf@kolabnow.com> Date: Sun, 13 Nov 2022 22:01:45 -0500 In-Reply-To: <87r0y6pkac.fsf@kolabnow.com> (Thiago Jung Bauermann via Guix-patches via's message of "Sun, 13 Nov 2022 19:21:11 -0300") Message-ID: <87y1seqlwm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59253-done Cc: 59253-done@debbugs.gnu.org, Liliana Marie Prikler , Thiago Jung Bauermann X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Thiago Jung Bauermann via Guix-patches via writes: > Hello Liliana, > > Liliana Marie Prikler writes: > >> Am Sonntag, dem 13.11.2022 um 22:24 +0100 schrieb Liliana Marie >> Prikler: >>> Am Sonntag, dem 13.11.2022 um 18:11 -0300 schrieb Thiago Jung >>> Bauermann: >>> > Magit has a strong dependency on Git so it should directly >>> > reference >>> > the >>> > git executable rather than expect it to be available in the profile >>> > or >>> > environment. >>> >=20 >>> > This also fixes a build failure in emacs-forge. >>> >=20 >>> > * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments]<#:phases>: >>> > Substitute >>> > git path in the =E2=80=98magit-git-executable=E2=80=99 variable. >>> LGTM, will push once I'm done with some other stuff. >> Aaaand it's done. > > Wow, that was quick. Thank you! Won't this make magit unusable from TRAMP (which already seems broken for me since the time we enabled native comp -- anyone else?). --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 22:19:20 2022 Received: (at 59253-done) by debbugs.gnu.org; 14 Nov 2022 03:19:20 +0000 Received: from localhost ([127.0.0.1]:48754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouQ0F-00031Z-Qc for submit@debbugs.gnu.org; Sun, 13 Nov 2022 22:19:20 -0500 Received: from mx.kolabnow.com ([212.103.80.154]:20300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouQ0D-00031K-8W for 59253-done@debbugs.gnu.org; Sun, 13 Nov 2022 22:19:18 -0500 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 026A41803; Mon, 14 Nov 2022 04:19:11 +0100 (CET) Authentication-Results: ext-mx-out001.mykolab.com (amavisd-new); dkim=pass (4096-bit key) reason="pass (just generated, assumed good)" header.d=kolabnow.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:in-reply-to:date:date:subject:subject:from:from :references:received:received:received; s=dkim20160331; t= 1668395950; x=1670210351; bh=oqDJ6+Zr7P6mOqTbYRuE+kwn8Af0qko3RYj pLuob9MQ=; b=4wM8qR0uWc+tsjbFU+R6cnHKsm6hUdRVGM7te76naWOyGYEzfex 7YV6fbUG/7tASK7YUDYTHikFqPZ+xIRmrcLtkSKLnnl00l4nSTxjkYdn3U5OPcw6 /HQYJoeeTucntQDXWDKOxkC9+p/VUlHlckncVOzH8Y6Jnna3Bib7BYzCSJwlh+1n DCS64qi1+L2ouHIRIyYlwzv7kEm0QLN2IZccNsOuzaTwGWMS7Bdg7Ve68Gzn6Yev PrufTJ2CZ5/XkjvZr4dYDxppW7yRHupE24GRls+uW30NkfHlJ7/7Ft2b0AEz9U79 GLj6+ZTGEu/8CfuYzrbx2wWxiBWVDitlRVLW06HLQivo6muhaH220AKpjngfDb1j i2yTTYiz7wi3chxBB141fbvsmG/WreRP8DKXJArIHWmlaPLylapctcq0yOWQwLjo qs8IuWiA4/Q8420xGwO3MI1dsiuSo5xQSTxhNa2T6iEmqiycz0ALwuuJawSP/Tuv Np3KACB9uBIAdSscD4fPIqu3n2mz5oKeaDNRESDaZ0dNPebWLMlvi4hbkvvZh6oD dJTT6bW6AvVf4Yw4uiG9XKQ443a6BtAgtEaEykPeT8f/TNYetDgk3upUv/t+/Lw9 QR6OhjpZIxMwekYzMsCp7AQagLsY9DO1c+haVt2D34Eu/CVT57cdFlzY= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-10 required=4 tests=[BAYES_00=-1.9] autolearn=no autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GqGN7H0i1AKa; Mon, 14 Nov 2022 04:19:10 +0100 (CET) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by mx.kolabnow.com (Postfix) with ESMTPS id 73F9615F8; Mon, 14 Nov 2022 04:19:09 +0100 (CET) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx001.mykolab.com (Postfix) with ESMTPS id 0B5849F5; Mon, 14 Nov 2022 04:19:09 +0100 (CET) References: <20221113211111.59581-1-bauermann@kolabnow.com> <2f939a4eb14313d5e2c656951ebe91bba31c8504.camel@gmail.com> <93a8d2f90b5b25e8bfce44b114015a50ec091ec3.camel@gmail.com> <87r0y6pkac.fsf@kolabnow.com> <87y1seqlwm.fsf@gmail.com> From: Thiago Jung Bauermann To: Maxim Cournoyer Subject: Re: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path. Date: Mon, 14 Nov 2022 00:09:21 -0300 In-reply-to: <87y1seqlwm.fsf@gmail.com> Message-ID: <87h6z2p6jc.fsf@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59253-done Cc: Liliana Marie Prikler , Thiago Jung Bauermann via Guix-patches via , 59253-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Maxim, Maxim Cournoyer writes: > Hi, > > Thiago Jung Bauermann via Guix-patches via > writes: > >> Hello Liliana, >> >> Liliana Marie Prikler writes: >> >>> Am Sonntag, dem 13.11.2022 um 22:24 +0100 schrieb Liliana Marie >>> Prikler: >>>> Am Sonntag, dem 13.11.2022 um 18:11 -0300 schrieb Thiago Jung >>>> Bauermann: >>>> > Magit has a strong dependency on Git so it should directly >>>> > reference >>>> > the >>>> > git executable rather than expect it to be available in the profile >>>> > or >>>> > environment. >>>> >=20 >>>> > This also fixes a build failure in emacs-forge. >>>> >=20 >>>> > * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments]<#:phases>: >>>> > Substitute >>>> > git path in the =E2=80=98magit-git-executable=E2=80=99 variable. >>>> LGTM, will push once I'm done with some other stuff. >>> Aaaand it's done. >> >> Wow, that was quick. Thank you! > > Won't this make magit unusable from TRAMP (which already seems broken > for me since the time we enabled native comp -- anyone else?). Hm, interesting point. I don't know. I don't use TRAMP because it was too slow for me in the couple of times I've tried. magit/lisp/magit-git.el does have this custom variable though, which this patch didn't change: #+BEGIN_SRC elisp (defcustom magit-remote-git-executable "git" "The Git executable used by Magit on remote machines. On the local host `magit-git-executable' is used instead. Consider customizing `tramp-remote-path' instead of this option." :package-version '(magit . "3.2.0") :group 'magit-process :type 'string) #+END_SRC elisp So I'd say it's possible that my patch doesn't affect whether Magit works from TRAMP=E2=80=A6 --=20 Thanks Thiago From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 14 19:52:45 2022 Received: (at 59253) by debbugs.gnu.org; 15 Nov 2022 00:52:45 +0000 Received: from localhost ([127.0.0.1]:52186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oukBw-00034y-T8 for submit@debbugs.gnu.org; Mon, 14 Nov 2022 19:52:45 -0500 Received: from out0.migadu.com ([94.23.1.103]:42549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oukBu-00034o-Pb for 59253@debbugs.gnu.org; Mon, 14 Nov 2022 19:52:43 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1668473559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U5GhvQCwPfXBasPW/1hvBGfQl5+jT0nd9yCLAEmrVE8=; b=JuTNWhcE2AtwKhlZZg8UGN3Bgj8Cm27hA4WylAatkghTbG+YYxCyGb55b5EeJR/iUTNT+d pzDBnvQbdlST8tFL8zkT8YsiVBwwxzBzaERJSN9F6VZH8Ggv7lookpAq8tRCJbWCjUyqcE vhduVWY9qlcMoQLUJ9tSd2fU0yA5/flK8/4NYK/tunURZSAG9HGwmJOyV00/EHqgVX4BUQ rTMcICmSVHJYlHrN/6CvPuad52dr8ravosiMDo0/UNhPeiQ1a0ibphhgLbWdt1AVQZxrcX E/gHLgK/o5ZJVZRz2UiK4MEJNrLsDg2GH3F5hWn9YONG7L6+vjbt2mor470H0g== From: Kyle Meyer To: Thiago Jung Bauermann Subject: Re: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path. In-Reply-To: <87h6z2p6jc.fsf@kolabnow.com> References: <20221113211111.59581-1-bauermann@kolabnow.com> <2f939a4eb14313d5e2c656951ebe91bba31c8504.camel@gmail.com> <93a8d2f90b5b25e8bfce44b114015a50ec091ec3.camel@gmail.com> <87r0y6pkac.fsf@kolabnow.com> <87y1seqlwm.fsf@gmail.com> <87h6z2p6jc.fsf@kolabnow.com> Date: Mon, 14 Nov 2022 19:52:36 -0500 Message-ID: <87cz9pvy23.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59253 Cc: 59253@debbugs.gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Thiago Jung Bauermann via Guix-patches via writes: > Maxim Cournoyer writes: [...] >> Won't this make magit unusable from TRAMP (which already seems broken >> for me since the time we enabled native comp -- anyone else?). > > Hm, interesting point. I don't know. I don't use TRAMP because it was > too slow for me in the couple of times I've tried. > > magit/lisp/magit-git.el does have this custom variable though, which > this patch didn't change: > > #+BEGIN_SRC elisp > (defcustom magit-remote-git-executable "git" > "The Git executable used by Magit on remote machines. > On the local host `magit-git-executable' is used instead. > Consider customizing `tramp-remote-path' instead of this > option." > :package-version '(magit . "3.2.0") > :group 'magit-process > :type 'string) > #+END_SRC elisp > > So I'd say it's possible that my patch doesn't affect whether Magit > works from TRAMP=E2=80=A6 That's right. magit-remote-git-executable is the executable that will be used when operating remotely via TRAMP, so your patch shouldn't affect it (and if it does, it's unintended behavior on Magit's end). Note that, as the :package-version value suggests, this split happened in a relatively recent release, so previous some previous discussions on the list (e.g., bug#30434) are now out of date. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 14 23:31:53 2022 Received: (at 59253) by debbugs.gnu.org; 15 Nov 2022 04:31:53 +0000 Received: from localhost ([127.0.0.1]:52500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ounc1-0002V6-1x for submit@debbugs.gnu.org; Mon, 14 Nov 2022 23:31:53 -0500 Received: from mx.kolabnow.com ([212.103.80.154]:13690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ounby-0002Uq-68 for 59253@debbugs.gnu.org; Mon, 14 Nov 2022 23:31:51 -0500 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id B08D21854; Tue, 15 Nov 2022 05:31:43 +0100 (CET) Authentication-Results: ext-mx-out001.mykolab.com (amavisd-new); dkim=pass (4096-bit key) reason="pass (just generated, assumed good)" header.d=kolabnow.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:in-reply-to:date:date:subject:subject:from:from :references:received:received:received; s=dkim20160331; t= 1668486703; x=1670301104; bh=IX8aQbwZ6lBpZD5fNqDU07ssxuJ2DckbyxH e3mOe/Cc=; b=GC/opQCQvGkjpWxxo7/UuF/AnBzim4bMNwAVjHKtKrTFFS6Q297 hAPBrDBHG7m/m2/UhRZ+GMWWuW1a2FFVhJ0b1DaATDPPyS2TjYmXZuwtXyUGUoRG Vdd/KVY21oCfCATmE03cCF2qfqA0FzPOq82Nkgm6jZawrvKlhjMnl19ogMEeNWdM L2SC2gOnDqKUJ4ADfPNqrv+Gdd67kJuOhgfUjmHsNrLQDBUHBFuQlvaN757fav0/ Nv4urZrZ8mRlTzbHQQHhp/n82j7hyEWic/rAqtlMZTX73wTzGW6A8qydxnDHX1E6 Hcmo2/dhhfNAocpP0woxLn2RfMDk9TGjxC4bZaKJbOovweHmZlRmy74oNo/HYXeh NDGc2g/ADgMIZBQ/gU92yTeysbPaeuryUi3SegLy5/DkbnkKmgZMZtKepKX1FrRB KIwqW0rqWeQb5bSw9kfhZ1tvuJKkjpzyVHVG12Ls/8GZWwDwlk0WfWRj7mzXCofT zLm7+oiOi1GHxSHAoZV/1o2octwrrsW0sA2SbeVphJi2yXmSWAyiABpUPCO9gkjj 2o7z79jarocMvOIH7bJ1s4dcZxDGPEtsrLh9u5FMtDUxkfp+2Y8W192xkPXrct1v liIwSLGrIPP+ySysMFhUY37fAk/g0W+shaVW3mQVi6HP5ILbUM01f6bU= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-10 required=4 tests=[BAYES_00=-1.9] autolearn=no autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F5cgPjS-E-Yg; Tue, 15 Nov 2022 05:31:43 +0100 (CET) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by mx.kolabnow.com (Postfix) with ESMTPS id 64EE51853; Tue, 15 Nov 2022 05:31:42 +0100 (CET) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx001.mykolab.com (Postfix) with ESMTPS id E3F418CB; Tue, 15 Nov 2022 05:31:41 +0100 (CET) References: <20221113211111.59581-1-bauermann@kolabnow.com> <2f939a4eb14313d5e2c656951ebe91bba31c8504.camel@gmail.com> <93a8d2f90b5b25e8bfce44b114015a50ec091ec3.camel@gmail.com> <87r0y6pkac.fsf@kolabnow.com> <87y1seqlwm.fsf@gmail.com> <87h6z2p6jc.fsf@kolabnow.com> <87cz9pvy23.fsf@kyleam.com> From: Thiago Jung Bauermann To: Kyle Meyer Subject: Re: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path. Date: Tue, 15 Nov 2022 01:30:17 -0300 In-reply-to: <87cz9pvy23.fsf@kyleam.com> Message-ID: <87cz9oq1nb.fsf@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59253 Cc: 59253@debbugs.gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Kyle, Kyle Meyer writes: > Thiago Jung Bauermann via Guix-patches via writes: > >> Maxim Cournoyer writes: > [...] >>> Won't this make magit unusable from TRAMP (which already seems broken >>> for me since the time we enabled native comp -- anyone else?). >> >> Hm, interesting point. I don't know. I don't use TRAMP because it was >> too slow for me in the couple of times I've tried. >> >> magit/lisp/magit-git.el does have this custom variable though, which >> this patch didn't change: >> >> #+BEGIN_SRC elisp >> (defcustom magit-remote-git-executable "git" >> "The Git executable used by Magit on remote machines. >> On the local host `magit-git-executable' is used instead. >> Consider customizing `tramp-remote-path' instead of this >> option." >> :package-version '(magit . "3.2.0") >> :group 'magit-process >> :type 'string) >> #+END_SRC elisp >> >> So I'd say it's possible that my patch doesn't affect whether Magit >> works from TRAMP=E2=80=A6 > > That's right. magit-remote-git-executable is the executable that will > be used when operating remotely via TRAMP, so your patch shouldn't > affect it (and if it does, it's unintended behavior on Magit's end). > > Note that, as the :package-version value suggests, this split happened > in a relatively recent release, so previous some previous discussions on > the list (e.g., bug#30434) are now out of date. That's great! Thank you for the clarification. --=20 Thanks Thiago From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 15 08:49:13 2022 Received: (at 59253) by debbugs.gnu.org; 15 Nov 2022 13:49:13 +0000 Received: from localhost ([127.0.0.1]:53495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouwJN-000303-36 for submit@debbugs.gnu.org; Tue, 15 Nov 2022 08:49:13 -0500 Received: from mail-qv1-f53.google.com ([209.85.219.53]:40639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouwJL-0002zo-2f for 59253@debbugs.gnu.org; Tue, 15 Nov 2022 08:49:11 -0500 Received: by mail-qv1-f53.google.com with SMTP id h10so9798043qvq.7 for <59253@debbugs.gnu.org>; Tue, 15 Nov 2022 05:49:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=yhih+W4s4/43fxbxKX2Ze5znD6ThyuyGXsK0ruXJKNg=; b=cAqoZ68Zw1G270euLLVuYiFLEoqz7i3Ztmr5/Dk6H0CktEmB3pHZpfYsYKU9UlqZ76 NmbaNnIaONzxmJcaSV+pRZw55uIw8ULxdSt4LyMOaE9V4XscYhF+4lty7L5FGrxZ7/Zj kxv8jomrouRrarTUcbnQoxKBwZ7FfLHu+4Huvf5DRsOiNPeWqAUxJXcdKNYOiVl7srwr RbAZKWVVi4ytmPjz0V3M5fD3klSSqOm4Py9vaG0EpJNHY8cxrl0S7S00YjptAu6lQhzk gC8quqMN2ue9/w9bR3EV1Orr5BHGJ1Dp9xju3rqpkLMP8IzSKTrvjTRysRDyoxtbOJk/ U2GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yhih+W4s4/43fxbxKX2Ze5znD6ThyuyGXsK0ruXJKNg=; b=NXjx5Hst4GO7wLZTH+7WhBEqRDjHvrZaIGhIXgGia5kzEQoCaz8IUZEAyTfR23Wra6 iz9Z3ZG5pWFeXOI0O7zCAIWRbja6F88qwbinK6HD9zG03CJXW13LtRpXATwM8s92YIrE tof+xUm+YIA83bUbU1pfzp0C2vbCJf01r/HI7NruDsNSuSnyyP/KDwW1tRC6INIBgQSd E4xGTXMkM/Vhv/PQTSBVhcotJVmAX5iFmP/Dwq6cRSQI/l6BC/PTMn/LYZfe65kCx1a5 HkwUOo501Qj8pKwtf8FYcLOBvZ0EMjI0QXjnJIWwsFCTLaQtMhlRlGEmQ65PM2tfUk9k IWGw== X-Gm-Message-State: ANoB5pnidI7LRfK2Qa/RW+EZ4xyhWTyjIPgsT/Rf4bNeaoGZHbqJKmlg Avm6rNKziJB/Tu8Q+x1HFm8kDlLD/Gw= X-Google-Smtp-Source: AA0mqf7lEvy9s7+giHPZXNdDqvgH9f9UCUmxPSw6j4oudvZONyeN+LnVofQIme6wZ3ozyEF1l5cX/Q== X-Received: by 2002:a05:6214:3706:b0:4bb:c66b:1c53 with SMTP id np6-20020a056214370600b004bbc66b1c53mr16582122qvb.30.1668520144390; Tue, 15 Nov 2022 05:49:04 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1001]) by smtp.gmail.com with ESMTPSA id z9-20020ae9c109000000b006ce76811a07sm7999751qki.75.2022.11.15.05.49.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 05:49:04 -0800 (PST) From: Maxim Cournoyer To: Kyle Meyer Subject: Re: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path. References: <20221113211111.59581-1-bauermann@kolabnow.com> <2f939a4eb14313d5e2c656951ebe91bba31c8504.camel@gmail.com> <93a8d2f90b5b25e8bfce44b114015a50ec091ec3.camel@gmail.com> <87r0y6pkac.fsf@kolabnow.com> <87y1seqlwm.fsf@gmail.com> <87h6z2p6jc.fsf@kolabnow.com> <87cz9pvy23.fsf@kyleam.com> Date: Tue, 15 Nov 2022 08:49:02 -0500 In-Reply-To: <87cz9pvy23.fsf@kyleam.com> (Kyle Meyer's message of "Mon, 14 Nov 2022 19:52:36 -0500") Message-ID: <87tu30pbu9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59253 Cc: 59253@debbugs.gnu.org, liliana.prikler@gmail.com, Thiago Jung Bauermann X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Kyle Meyer writes: > Thiago Jung Bauermann via Guix-patches via writes: > >> Maxim Cournoyer writes: > [...] >>> Won't this make magit unusable from TRAMP (which already seems broken >>> for me since the time we enabled native comp -- anyone else?). >> >> Hm, interesting point. I don't know. I don't use TRAMP because it was >> too slow for me in the couple of times I've tried. >> >> magit/lisp/magit-git.el does have this custom variable though, which >> this patch didn't change: >> >> #+BEGIN_SRC elisp >> (defcustom magit-remote-git-executable "git" >> "The Git executable used by Magit on remote machines. >> On the local host `magit-git-executable' is used instead. >> Consider customizing `tramp-remote-path' instead of this >> option." >> :package-version '(magit . "3.2.0") >> :group 'magit-process >> :type 'string) >> #+END_SRC elisp >> >> So I'd say it's possible that my patch doesn't affect whether Magit >> works from TRAMP=E2=80=A6 > > That's right. magit-remote-git-executable is the executable that will > be used when operating remotely via TRAMP, so your patch shouldn't > affect it (and if it does, it's unintended behavior on Magit's end). > > Note that, as the :package-version value suggests, this split happened > in a relatively recent release, so previous some previous discussions on > the list (e.g., bug#30434) are now out of date. Excellent. Thanks for the explanation! --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 15 09:54:57 2022 Received: (at 59253) by debbugs.gnu.org; 15 Nov 2022 14:54:57 +0000 Received: from localhost ([127.0.0.1]:53645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouxKy-0004ja-Tl for submit@debbugs.gnu.org; Tue, 15 Nov 2022 09:54:57 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]:42623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouxKt-0004is-UK; Tue, 15 Nov 2022 09:54:52 -0500 Received: by mail-wr1-f47.google.com with SMTP id cl5so24695208wrb.9; Tue, 15 Nov 2022 06:54:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=6wDywfXo8N2s6r3mYgnHN11xmNMyN/A8oLQe2X+gP4w=; b=aZpWKkw3W96ltH+Pyg0n0NoKtpUOP0n9palNDEPXOX7S7DznjFCnmCpUak8kHNblkR K0L7mMHFOVaTMAA2p+sQ/JaPZda4XVvzFYZi0TxB7U0UyuqWNAX4Waugm4Zv6Dl5CVMb hIqemWPubXRcQ1Mw352So6K0Nhsb1DUy8b8iXx0iI7WkdO56wSHiiCmFqrI+WvUlsr9Y RLoanZZ00d6k5VIFSg7aIpHGJs/9pkUyol5N/Qxyb/2GByPoO87rXhIpJSxD6OoFYtw0 Wd8ty59TIQPGJ3OcieqO7wHFqv7VEEzhyjvJ3hW4aJrQ/M7i5oDcTMJ+PIBHTmH55tnw ju+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6wDywfXo8N2s6r3mYgnHN11xmNMyN/A8oLQe2X+gP4w=; b=O5Nnfm2UdCHBiEDAs+lMeTNK5RXd1eFiplkdC4oIRmMKCpDOOOh1LMIFTGFpZHH7TZ mdLWoo9qiMeFinM2DQG82YdB8PxP3NEdON+IseRmFuCazgzuv3Jh+Qx8hNw9lZ2RUUCZ 2RQ89FR6/vZbV6AQLzHcRcpfFsPX1UYCx/z+VOitxgTk4J9lFmhCA/gjJK7Lh2ulfODP B69t2oMSYLFXBLTmhP2U07UsZHkTq8Pau8sLVjryX/sDB+yRY+3jdourE8hJiitooAbm osIIXjMj0XNp4ET9JZvT9Kv0g172TGWEmXXSR8+T4VSeAHfFugTkbIH1b647T4mXHWhw KPPQ== X-Gm-Message-State: ANoB5pmFGNBwwHEB1THsZeCOLLUVomiUBi6WaoE7WRfqLbFtGlBYqKyi rCJVYPd6SB33tABKQMGbQzA= X-Google-Smtp-Source: AA0mqf7cib+bjoN+q8UkqKWjRkwB4a7IV1tCv/xzCTePb4Xq12sg4LI414DXBJ7LN92JJIsuV4z9ng== X-Received: by 2002:adf:f18e:0:b0:236:b8b9:b018 with SMTP id h14-20020adff18e000000b00236b8b9b018mr11368830wro.596.1668524086213; Tue, 15 Nov 2022 06:54:46 -0800 (PST) Received: from lili (roam-nat-fw-prg-194-254-61-41.net.univ-paris-diderot.fr. [194.254.61.41]) by smtp.gmail.com with ESMTPSA id b3-20020adff903000000b002366fb99cdasm12556788wrr.50.2022.11.15.06.54.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 06:54:45 -0800 (PST) From: zimoun To: Maxim Cournoyer , 59253@debbugs.gnu.org Subject: Re: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path. In-Reply-To: <87y1seqlwm.fsf@gmail.com> References: <20221113211111.59581-1-bauermann@kolabnow.com> <2f939a4eb14313d5e2c656951ebe91bba31c8504.camel@gmail.com> <93a8d2f90b5b25e8bfce44b114015a50ec091ec3.camel@gmail.com> <87r0y6pkac.fsf@kolabnow.com> <87y1seqlwm.fsf@gmail.com> Date: Tue, 15 Nov 2022 09:52:14 +0100 Message-ID: <86v8ngioqp.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Maxim, Unrelated to this patch. On Sun, 13 Nov 2022 at 22:01, Maxim Cournoyer wrote: Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.1 DATE_IN_PAST_06_12 Date: is 6 to 12 hours before Received: date 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.47 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zimon.toutoune[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.47 listed in wl.mailspike.net] X-Debbugs-Envelope-To: 59253 Cc: Thiago Jung Bauermann , 59253-done@debbugs.gnu.org, Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Hi Maxim, Unrelated to this patch. On Sun, 13 Nov 2022 at 22:01, Maxim Cournoyer wrote: > Won't this make magit unusable from TRAMP (which already seems broken > for me since the time we enabled native comp -- anyone else?). For TRAMP precisely, I do not know, but ESS has troubles with TRAMP, see bug#58690. 1: Cheers, simon From unknown Sat Aug 16 14:25:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 14 Dec 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator