GNU bug report logs - #59251
29.0.50; Fix-some-inconsistencies-in-ts-modes

Previous Next

Package: emacs;

Reported by: Theodor Thornhill <theo <at> thornhill.no>

Date: Sun, 13 Nov 2022 20:43:01 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59251: closed (29.0.50; Fix-some-inconsistencies-in-ts-modes)
Date: Sun, 23 Feb 2025 01:33:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 23 Feb 2025 01:32:37 +0000
with message-id <CADwFkm=hX7VA9z_5jZ9az3MG2hUxPwe5q16On9dSJghEmK12aw <at> mail.gmail.com>
and subject line Re: bug#59251: 29.0.50; Fix-some-inconsistencies-in-ts-modes
has caused the debbugs.gnu.org bug report #59251,
regarding 29.0.50; Fix-some-inconsistencies-in-ts-modes
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59251: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59251
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Theodor Thornhill <theo <at> thornhill.no>
To: bug-gnu-emacs <at> gnu.org
Cc: casouri <at> gmail.com
Subject: 29.0.50; Fix-some-inconsistencies-in-ts-modes
Date: Sun, 13 Nov 2022 21:42:19 +0100
[Message part 3 (text/plain, inline)]
Hi Yuan!

I've make some changes to my *-ts-modes, and would appreciate a second
opinion as well as a push to the feature/tree-sitter branch :-)

I've extracted some of the relevant mode-init variables into defcustoms
so that users can tweak their behavior.  It also seems I forgot some
electric indent configs in some of the other files, so I added that
aswell.

BTW, should we do the same thing we did with js-mode - add a js-ts-mode
and don't change the js.el file at all?  We could either go the same
route as c-ts-mode, where we define both c and c++ in the same file, or
keep them separate.  What do you think?

Theo


[0001-Fix-some-inconsistencies-in-ts-modes.patch (text/x-diff, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Stefan Kangas <stefankangas <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 59251-done <at> debbugs.gnu.org, Theodor Thornhill <theo <at> thornhill.no>
Subject: Re: bug#59251: 29.0.50; Fix-some-inconsistencies-in-ts-modes
Date: Sun, 23 Feb 2025 01:32:37 +0000
Yuan Fu <casouri <at> gmail.com> writes:

> Thanks, merged and pushed.

It seems like this was never closed.  I'm therefore closing this bug
report.


This bug report was last modified 89 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.