GNU bug report logs - #59251
29.0.50; Fix-some-inconsistencies-in-ts-modes

Previous Next

Full log

Message #14 received at 59251 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 59251 <at> debbugs.gnu.org
Subject: Re: bug#59251: Acknowledgement (29.0.50;
 Fix-some-inconsistencies-in-ts-modes)
Date: Sun, 13 Nov 2022 16:51:52 -0800

> On Nov 13, 2022, at 3:01 PM, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs <at> gnu.org> wrote:
> 
> Theodor Thornhill <theo <at> thornhill.no> writes:
> 
>> Added a few more finishes.
> 
> Aaand another.  Last one for now.  I promise…

Cool! Some comments:

+(defcustom c-ts-mode-font-lock-feature-list
+  '((comment preprocessor operator constant string literal keyword)
+    (type definition expression statement)
+    ())
+  "Language constructs to font-lock.
+
+See `treesit-font-lock-feature-list' for description of how to
+use this variable.  Supported features are as defined in
+`c-ts-mode--font-lock-settings'."
+  :version "29.1"
+  :type 'list
+  :safe 'listp
+  :group 'c)
+

I think Stefan M’s opinion is to make feature-list private, and let users add/remove features. Right now they can add/remove features with treesit-recompute-feature-list. I guess we can keep them as defvar’s for now, so people as the option to redefine this list should they want to. (One argument against having them as custom options is that, if a user sets it as a custom option, they will miss out on future changes to this variable.)


+  (setq-local comment-style c-ts-mode-comment-style)

Why don’t we let users set comment style themselves? Does cc-mode have a similar variable?

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.