From unknown Fri Aug 15 20:57:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59224: 29.0.50; Don't use defvar+make-sparse-keymap for example in docs Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: larsi@gnus.org, bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Nov 2022 20:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59224 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 59224@debbugs.gnu.org Cc: Lars Ingebrigtsen X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Lars Ingebrigtsen Received: via spool by submit@debbugs.gnu.org id=B.16682833576748 (code B ref -1); Sat, 12 Nov 2022 20:03:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Nov 2022 20:02:37 +0000 Received: from localhost ([127.0.0.1]:49079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otwi4-0001km-Tu for submit@debbugs.gnu.org; Sat, 12 Nov 2022 15:02:37 -0500 Received: from lists.gnu.org ([209.51.188.17]:40278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otwi3-0001ke-4Z for submit@debbugs.gnu.org; Sat, 12 Nov 2022 15:02:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otwi2-0001bP-VM for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 15:02:34 -0500 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otwi1-0003Gx-Jl for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 15:02:34 -0500 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-13bd2aea61bso8810847fac.0 for ; Sat, 12 Nov 2022 12:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :from:from:to:cc:subject:date:message-id:reply-to; bh=/0OQmNXiF/EmUJglFPyJ6UKrXJUIZjGin3ncUv4Z8YE=; b=j2u0Rivj4HeL6lkvJTHba/NSy+vCDJUG8ZTnno8bntovtl93envsca011lsGK5JGHg RfOCeGXgBkdbgYpTzkEdFwqbtM24WrWVuGMKXrMstiJGUq+xa6fnQJXrcgw7ldVSsvLH MyFCJ5Sb8lRvIRaTgg4byAn7aD/lKAwWCVixDKbChSSjMLYWDb7ScWpBC2TFgQNoTYnn uIUhKPMioLp+QM+vTVFe9IciIJpr5UPsHDm8E3qk6qnDcg6UE5ma9EqhtUk4HEwq68z9 JoBU/UJxosmLnjDfyIhGc59LXwSmC6DC77idCmBjDtkgWd2NqOkUNy76IxmzT7rwSZnq Ok2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/0OQmNXiF/EmUJglFPyJ6UKrXJUIZjGin3ncUv4Z8YE=; b=wNBuyQdeOkoY7QvsTvNbZTn/gHpTwqvIUxpTffq92uCqBPeERh64Tq6lE0VBsWSp2E PkE6vt+RL2xH4grwmfbNK4ySIFTMMcCHC4X3v76hMYJ3srYsxjPjm3Q7dvGlqQ5m6zNs /zh158WAR6i+G2fxPa8H17fnnnxiqom70CqWnpchZbj7ZnzNE/EXBCYulj2fb3ZbwgN0 VI18iGGEl7S0CLbREOr+fKwBxeBfxmJYcqUr4Ng5OoJE4zkxdsFmWyjLSDsl0OcQHx9Y a2IOTZ8l7AJl2MR/I8meGM3n9Dl8lX1+Kv/I6KGu8FT9t3OncXhq29kh2SQVBu4y1uNW ulVA== X-Gm-Message-State: ANoB5plpAoM29/gbBC7hhfavkLF1jHqBdAbz7vXDT0k2zMeIfgIVS4t4 PhlGYW6E9sX8t+jPQ6Jtn8h+8iZ+Mlcr3cnFWvyx+B73 X-Google-Smtp-Source: AA0mqf65nRg6AtfPlna8bCWM4EQmNqycweeF0Md032k5hY4lUR/sLEDABiv1ZuSgXgxNZr9VaeVSnehPe5u3DviywYo= X-Received: by 2002:a05:6870:6c15:b0:13b:8a07:2a1f with SMTP id na21-20020a0568706c1500b0013b8a072a1fmr3932414oab.199.1668283352115; Sat, 12 Nov 2022 12:02:32 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 12 Nov 2022 12:02:31 -0800 From: Stefan Kangas X-Hashcash: 1:20:221112:bug-gnu-emacs@gnu.org::VRAixNDOvg/g0u7v:0dGm MIME-Version: 1.0 Date: Sat, 12 Nov 2022 12:02:31 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2001:4860:4864:20::36; envelope-from=stefankangas@gmail.com; helo=mail-oa1-x36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Severity: wishlist In (info "(elisp) Tips for Defining"), we have: When defining and initializing a variable that holds a complicated value (such as a keymap with bindings in it), it=E2=80=99s = best to put the entire computation of the value into the =E2=80=98defvar=E2= =80=99, like this: (defvar my-mode-map (let ((map (make-sparse-keymap))) (keymap-set map "C-c C-a" 'my-command) ... map) DOCSTRING) Could we use an example here that is not a keymap (which should be defined using `defvar-keymap' these days)? What would be a good example to use? `make-syntax-table'? From unknown Fri Aug 15 20:57:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stefan Kangas Subject: bug#59224: closed (Re: bug#59224: 29.0.50; Don't use defvar+make-sparse-keymap for example in docs) Message-ID: References: X-Gnu-PR-Message: they-closed 59224 X-Gnu-PR-Package: emacs Reply-To: 59224@debbugs.gnu.org Date: Sun, 10 Sep 2023 23:52:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1694389922-7685-1" This is a multi-part message in MIME format... ------------=_1694389922-7685-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #59224: 29.0.50; Don't use defvar+make-sparse-keymap for example in docs which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 59224@debbugs.gnu.org. --=20 59224: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59224 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1694389922-7685-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 59224-done) by debbugs.gnu.org; 10 Sep 2023 23:51:40 +0000 Received: from localhost ([127.0.0.1]:51531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfUDM-0001zN-5g for submit@debbugs.gnu.org; Sun, 10 Sep 2023 19:51:40 -0400 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:41990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfUDI-0001z7-HX for 59224-done@debbugs.gnu.org; Sun, 10 Sep 2023 19:51:38 -0400 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-500760b296aso4663224e87.0 for <59224-done@debbugs.gnu.org>; Sun, 10 Sep 2023 16:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694389887; x=1694994687; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=nlAYnEmXEdjS20ro8VgndgzVV0gKXEqMxSiGwArn0PY=; b=ib9lKWykkPr4i78PJIs5xAHcxpfwopdVclBegPEPpX5ql0zBNz7sSdW3QC8b/POZSf lePt8UlPgTO6AABYD6Ta0bKyzgMpEBaaO0MhkPyE2HhidOYYUmuTiS2HV8Ghb+8XJMoi R3i8/Xwpo7/kzSM4t6LpTRgJ2A0b2PpCbeiCceUFCr2sH8ADVLBivTI6jxiqEGCndAqn pqSYUhW2jQh05v/dMOb7NrvBq98CptctgnM0fjOCJ5ZhdWCD299NWTXFocgE52sqfZZj IlJQ9R+BQEExJlgn0S2eYtLENLcCE1RDCQkc1mksTtl3BWHquNafv7KhX+NmBwqrDGDN GvHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694389887; x=1694994687; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nlAYnEmXEdjS20ro8VgndgzVV0gKXEqMxSiGwArn0PY=; b=iliTWhRqIAz+ZqYMX/l5cLWUhUMe0OaHETSwfrRwoKy0QzgSnUYgaGDDsnxxLnnG01 BBe/SZdlk4oqwpBRlMd9KZtpKzznmUjtn3+BU3C4v/aRsyYjN6baml1BMzHEsrAh0c9/ 43RBtDlFtTSv6O4L0gwQE3ngxq5Nr5bu0cF6SU6J92kAqs+hBor4fYv0TPcuPC4Cv7OK zsbmet+fTybepgbtyTis0lFDoLPchbjCxhWtVzMQmRbtRmz3Nm1BfysHYvCZzJC/uggO QB056CrcdB9rM0HX7haLPs32awllK4E+TQ+79eLsrT26Eq0G79kS6O0/PC9H6wPW541i lSrw== X-Gm-Message-State: AOJu0YwbpUWh1mRch4o94yV1sWnDhtKuGFfDN47QNgGt+wtQyEO0Zs6z siqMm4H+m8JC1OSlAjJhevqCAcE96nUP7cX+7yJcuQ+C734= X-Google-Smtp-Source: AGHT+IHzWSD9mVUlq9GkGZUTqd1oDdY6ZIpbI3cFggoRT3SZxWdigUvHRsjYMdMfr6/SVVG8lQJDuhyJ7YkATEOnuBo= X-Received: by 2002:ac2:4db1:0:b0:500:7aba:4d07 with SMTP id h17-20020ac24db1000000b005007aba4d07mr2234434lfe.22.1694389886445; Sun, 10 Sep 2023 16:51:26 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 10 Sep 2023 16:51:25 -0700 From: Stefan Kangas In-Reply-To: (Stefan Kangas's message of "Sat, 12 Nov 2022 12:02:31 -0800") References: MIME-Version: 1.0 Date: Sun, 10 Sep 2023 16:51:25 -0700 Message-ID: Subject: Re: bug#59224: 29.0.50; Don't use defvar+make-sparse-keymap for example in docs To: 59224-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59224-done Cc: Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 29.2 Stefan Kangas writes: > Severity: wishlist > > In (info "(elisp) Tips for Defining"), we have: > > When defining and initializing a variable that holds a > complicated value (such as a keymap with bindings in it), it=E2=80=99= s best > to put the entire computation of the value into the =E2=80=98defvar= =E2=80=99, like > this: > > (defvar my-mode-map > (let ((map (make-sparse-keymap))) > (keymap-set map "C-c C-a" 'my-command) > ... > map) > DOCSTRING) > > Could we use an example here that is not a keymap (which should be > defined using `defvar-keymap' these days)? > > What would be a good example to use? `make-syntax-table'? I've now changed this example to `make-syntax-table' on emacs-29. If anyone can think of a better example, please speak up and we can reopen the bug for further tweaking. ------------=_1694389922-7685-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Nov 2022 20:02:37 +0000 Received: from localhost ([127.0.0.1]:49079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otwi4-0001km-Tu for submit@debbugs.gnu.org; Sat, 12 Nov 2022 15:02:37 -0500 Received: from lists.gnu.org ([209.51.188.17]:40278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otwi3-0001ke-4Z for submit@debbugs.gnu.org; Sat, 12 Nov 2022 15:02:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otwi2-0001bP-VM for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 15:02:34 -0500 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otwi1-0003Gx-Jl for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 15:02:34 -0500 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-13bd2aea61bso8810847fac.0 for ; Sat, 12 Nov 2022 12:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :from:from:to:cc:subject:date:message-id:reply-to; bh=/0OQmNXiF/EmUJglFPyJ6UKrXJUIZjGin3ncUv4Z8YE=; b=j2u0Rivj4HeL6lkvJTHba/NSy+vCDJUG8ZTnno8bntovtl93envsca011lsGK5JGHg RfOCeGXgBkdbgYpTzkEdFwqbtM24WrWVuGMKXrMstiJGUq+xa6fnQJXrcgw7ldVSsvLH MyFCJ5Sb8lRvIRaTgg4byAn7aD/lKAwWCVixDKbChSSjMLYWDb7ScWpBC2TFgQNoTYnn uIUhKPMioLp+QM+vTVFe9IciIJpr5UPsHDm8E3qk6qnDcg6UE5ma9EqhtUk4HEwq68z9 JoBU/UJxosmLnjDfyIhGc59LXwSmC6DC77idCmBjDtkgWd2NqOkUNy76IxmzT7rwSZnq Ok2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/0OQmNXiF/EmUJglFPyJ6UKrXJUIZjGin3ncUv4Z8YE=; b=wNBuyQdeOkoY7QvsTvNbZTn/gHpTwqvIUxpTffq92uCqBPeERh64Tq6lE0VBsWSp2E PkE6vt+RL2xH4grwmfbNK4ySIFTMMcCHC4X3v76hMYJ3srYsxjPjm3Q7dvGlqQ5m6zNs /zh158WAR6i+G2fxPa8H17fnnnxiqom70CqWnpchZbj7ZnzNE/EXBCYulj2fb3ZbwgN0 VI18iGGEl7S0CLbREOr+fKwBxeBfxmJYcqUr4Ng5OoJE4zkxdsFmWyjLSDsl0OcQHx9Y a2IOTZ8l7AJl2MR/I8meGM3n9Dl8lX1+Kv/I6KGu8FT9t3OncXhq29kh2SQVBu4y1uNW ulVA== X-Gm-Message-State: ANoB5plpAoM29/gbBC7hhfavkLF1jHqBdAbz7vXDT0k2zMeIfgIVS4t4 PhlGYW6E9sX8t+jPQ6Jtn8h+8iZ+Mlcr3cnFWvyx+B73 X-Google-Smtp-Source: AA0mqf65nRg6AtfPlna8bCWM4EQmNqycweeF0Md032k5hY4lUR/sLEDABiv1ZuSgXgxNZr9VaeVSnehPe5u3DviywYo= X-Received: by 2002:a05:6870:6c15:b0:13b:8a07:2a1f with SMTP id na21-20020a0568706c1500b0013b8a072a1fmr3932414oab.199.1668283352115; Sat, 12 Nov 2022 12:02:32 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 12 Nov 2022 12:02:31 -0800 From: Stefan Kangas X-Debbugs-CC: Lars Ingebrigtsen X-Hashcash: 1:20:221112:bug-gnu-emacs@gnu.org::VRAixNDOvg/g0u7v:0dGm MIME-Version: 1.0 Date: Sat, 12 Nov 2022 12:02:31 -0800 Message-ID: Subject: 29.0.50; Don't use defvar+make-sparse-keymap for example in docs To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2001:4860:4864:20::36; envelope-from=stefankangas@gmail.com; helo=mail-oa1-x36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Severity: wishlist In (info "(elisp) Tips for Defining"), we have: When defining and initializing a variable that holds a complicated value (such as a keymap with bindings in it), it=E2=80=99s = best to put the entire computation of the value into the =E2=80=98defvar=E2= =80=99, like this: (defvar my-mode-map (let ((map (make-sparse-keymap))) (keymap-set map "C-c C-a" 'my-command) ... map) DOCSTRING) Could we use an example here that is not a keymap (which should be defined using `defvar-keymap' these days)? What would be a good example to use? `make-syntax-table'? ------------=_1694389922-7685-1--