GNU bug report logs - #59223
[PATCH] services: gitolite: Use the correct variable for the user-group

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59223: closed ([PATCH] services: gitolite: Use the correct
 variable for the user-group)
Date: Thu, 17 Nov 2022 12:13:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 17 Nov 2022 12:11:30 +0000
with message-id <87wn7tdbl8.fsf <at> cbaines.net>
and subject line Re: [bug#59223] [PATCH] services: gitolite: Use the correct variable for the user-group
has caused the debbugs.gnu.org bug report #59223,
regarding [PATCH] services: gitolite: Use the correct variable for the user-group
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59223: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59223
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: EuAndreh <eu <at> euandre.org>
To: guix-patches <at> gnu.org
Cc: EuAndreh <eu <at> euandre.org>
Subject: [PATCH] services: gitolite: Use the correct variable for the
 user-group
Date: Sat, 12 Nov 2022 15:53:21 -0300

The default value for <gitolite-configuration> has "git" for both the
values of the user and the group, as costumary, which means that unless
someone uses a custom configuration and chooses different strings for
user and group, this wouldn't show up.

* gnu/services/version-control.scm (gitolite-accounts): Use the correct
  variable for the name of a (user-group ...).
---

I did a "git grep user-group gnu/services/" and looked at the returned
entries.  After a quick cursory look, either all the entries had a
hard-coded string value, or picked the correct variable for the group
name.  So I think this one is a one-off :)

This surfaced after a debugging session with mirai on IRC earlier today.

 gnu/services/version-control.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/version-control.scm b/gnu/services/version-control.scm
index b6b78e504e..86d40bdbe3 100644
--- a/gnu/services/version-control.scm
+++ b/gnu/services/version-control.scm
@@ -313,7 +313,7 @@ (define gitolite-accounts
     (($ <gitolite-configuration> package user group home-directory
                                  rc-file admin-pubkey)
      ;; User group and account to run Gitolite.
-     (list (user-group (name user) (system? #t))
+     (list (user-group (name group) (system? #t))
            (user-account
             (name user)
             (group group)
-- 
2.38.1

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: EuAndreh <eu <at> euandre.org>
Cc: 59223-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59223] [PATCH] services: gitolite: Use the correct
 variable for the user-group
Date: Thu, 17 Nov 2022 12:11:30 +0000

[Message part 4 (text/plain, inline)]

EuAndreh via Guix-patches via <guix-patches <at> gnu.org> writes:

> The default value for <gitolite-configuration> has "git" for both the
> values of the user and the group, as costumary, which means that unless
> someone uses a custom configuration and chooses different strings for
> user and group, this wouldn't show up.
>
> * gnu/services/version-control.scm (gitolite-accounts): Use the correct
>   variable for the name of a (user-group ...).
> ---
>
> I did a "git grep user-group gnu/services/" and looked at the returned
> entries.  After a quick cursory look, either all the entries had a
> hard-coded string value, or picked the correct variable for the group
> name.  So I think this one is a one-off :)
>
> This surfaced after a debugging session with mirai on IRC earlier today.
>
>  gnu/services/version-control.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/services/version-control.scm b/gnu/services/version-control.scm
> index b6b78e504e..86d40bdbe3 100644
> --- a/gnu/services/version-control.scm
> +++ b/gnu/services/version-control.scm
> @@ -313,7 +313,7 @@ (define gitolite-accounts
>      (($ <gitolite-configuration> package user group home-directory
>                                   rc-file admin-pubkey)
>       ;; User group and account to run Gitolite.
> -     (list (user-group (name user) (system? #t))
> +     (list (user-group (name group) (system? #t))
>             (user-account
>              (name user)
>              (group group)

Good spot! I've pushed this to master as
35ef5fca0ac997680e47942e25f403fb3ec54c7d.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.