From unknown Thu Aug 14 21:53:55 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59223 <59223@debbugs.gnu.org> To: bug#59223 <59223@debbugs.gnu.org> Subject: Status: [PATCH] services: gitolite: Use the correct variable for the user-group Reply-To: bug#59223 <59223@debbugs.gnu.org> Date: Fri, 15 Aug 2025 04:53:55 +0000 retitle 59223 [PATCH] services: gitolite: Use the correct variable for the = user-group reassign 59223 guix-patches submitter 59223 EuAndreh severity 59223 normal tag 59223 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 12 14:08:24 2022 Received: (at submit) by debbugs.gnu.org; 12 Nov 2022 19:08:24 +0000 Received: from localhost ([127.0.0.1]:49045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otvrc-0006f7-E9 for submit@debbugs.gnu.org; Sat, 12 Nov 2022 14:08:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:37434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otvra-0006ez-MN for submit@debbugs.gnu.org; Sat, 12 Nov 2022 14:08:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otvra-00049g-F7 for guix-patches@gnu.org; Sat, 12 Nov 2022 14:08:22 -0500 Received: from box.euandre.org ([46.101.160.115]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otvrU-0002DJ-GM for guix-patches@gnu.org; Sat, 12 Nov 2022 14:08:22 -0500 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id 9DEB8FC406; Sat, 12 Nov 2022 16:08:08 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1668280089; bh=qCvfCVYwQcIjkUWr2XCIwzzGHOLD+Jn+7hYspv0EkAQ=; h=From:To:Cc:Subject:Date:From; b=kkG+BtjROOOQD0yoBCL37j6a2e2CAXuPfLqgNh1kuPkP1lOcqX9qu/N6D1skazQK4 xrs6lwMcsXUm8oR6jkRjfCYJxHwpdjVF33YrVilZu8nea6Q/mY239IH5KN0/c75wDy PXZ39cw3hvLwPMdVVgp8/NdOzVgA+maK1XyVeOTQjB/6R8Sq4fzNkFPj6v1/cbiYi3 J/928ozN2UQfj72gM5O2QMBPa1S3D1SLZvMbHHQejjnemZtXujiqSV+/1HDPo8+tSr 7kpVSKVrP5lnpE6+g+hdSb6pU8KcygvLoAhMFVkyF56Mmr6Zx/d4F+3ZOK95F9yPzq M89DxRtDuN9hA== From: EuAndreh To: guix-patches@gnu.org Subject: [PATCH] services: gitolite: Use the correct variable for the user-group Date: Sat, 12 Nov 2022 15:53:21 -0300 Message-Id: <20221112185321.17566-1-eu@euandre.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=46.101.160.115; envelope-from=eu@euandre.org; helo=box.euandre.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: EuAndreh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) The default value for has "git" for both the values of the user and the group, as costumary, which means that unless someone uses a custom configuration and chooses different strings for user and group, this wouldn't show up. * gnu/services/version-control.scm (gitolite-accounts): Use the correct variable for the name of a (user-group ...). --- I did a "git grep user-group gnu/services/" and looked at the returned entries. After a quick cursory look, either all the entries had a hard-coded string value, or picked the correct variable for the group name. So I think this one is a one-off :) This surfaced after a debugging session with mirai on IRC earlier today. gnu/services/version-control.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/services/version-control.scm b/gnu/services/version-control.scm index b6b78e504e..86d40bdbe3 100644 --- a/gnu/services/version-control.scm +++ b/gnu/services/version-control.scm @@ -313,7 +313,7 @@ (define gitolite-accounts (($ package user group home-directory rc-file admin-pubkey) ;; User group and account to run Gitolite. - (list (user-group (name user) (system? #t)) + (list (user-group (name group) (system? #t)) (user-account (name user) (group group) -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 17 07:12:11 2022 Received: (at submit) by debbugs.gnu.org; 17 Nov 2022 12:12:11 +0000 Received: from localhost ([127.0.0.1]:59458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovdkZ-0002jb-CB for submit@debbugs.gnu.org; Thu, 17 Nov 2022 07:12:11 -0500 Received: from lists.gnu.org ([209.51.188.17]:47374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovdkV-0002jO-O5 for submit@debbugs.gnu.org; Thu, 17 Nov 2022 07:12:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovdkV-0001ff-J6 for guix-patches@gnu.org; Thu, 17 Nov 2022 07:12:07 -0500 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovdkT-00081k-2Y for guix-patches@gnu.org; Thu, 17 Nov 2022 07:12:07 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 3EDF927BBE9; Thu, 17 Nov 2022 12:12:04 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 122439cd; Thu, 17 Nov 2022 12:12:03 +0000 (UTC) References: <20221112185321.17566-1-eu@euandre.org> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines To: EuAndreh Subject: Re: [bug#59223] [PATCH] services: gitolite: Use the correct variable for the user-group Date: Thu, 17 Nov 2022 12:11:30 +0000 In-reply-to: <20221112185321.17566-1-eu@euandre.org> Message-ID: <87wn7tdbl8.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 59223-done@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain EuAndreh via Guix-patches via writes: > The default value for has "git" for both the > values of the user and the group, as costumary, which means that unless > someone uses a custom configuration and chooses different strings for > user and group, this wouldn't show up. > > * gnu/services/version-control.scm (gitolite-accounts): Use the correct > variable for the name of a (user-group ...). > --- > > I did a "git grep user-group gnu/services/" and looked at the returned > entries. After a quick cursory look, either all the entries had a > hard-coded string value, or picked the correct variable for the group > name. So I think this one is a one-off :) > > This surfaced after a debugging session with mirai on IRC earlier today. > > gnu/services/version-control.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gnu/services/version-control.scm b/gnu/services/version-control.scm > index b6b78e504e..86d40bdbe3 100644 > --- a/gnu/services/version-control.scm > +++ b/gnu/services/version-control.scm > @@ -313,7 +313,7 @@ (define gitolite-accounts > (($ package user group home-directory > rc-file admin-pubkey) > ;; User group and account to run Gitolite. > - (list (user-group (name user) (system? #t)) > + (list (user-group (name group) (system? #t)) > (user-account > (name user) > (group group) Good spot! I've pushed this to master as 35ef5fca0ac997680e47942e25f403fb3ec54c7d. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmN2JRNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XefeBAAh58N+l67CovzLzNcId0oVQlPcLGo2S6c /+IX/pHrqAEe86lrhZAsV9xsA2ee5whzECnu6BXY0/1kbu/xF5CmK/OAB1/rxqLO eyaJ4Ux6jOeXSjhIGnTJq8vyarejR5KI9JEWmDhPCeDCJZ9xgL6ui2L5XtA+JzwM G8B1zesN3BTaKVbHhnylFneJJhKRRoVOO3rLk6DtHMC0qynXLYGHP3DcvD9Y9S3W kSEUUr20lG4t6XiGw5/bP06JZxqanZV5/11CeOYlE2TIw41nLiHoLem7jNeogq+F yo7gkXSpOIBa7ns2iKigc8K+tdNN1nc48IuuByD7wJpHjXmtuZfSF89UU5TMNYY2 6vH0JDBz2nDO1872BLGFd1fd6oYgOcnb3QEhp6HTog/WCPPYpxmVb7WEM0XRgnJm /SpWHYxrJSw7DCty18JYgwSQN6los0vwrP+vDnzAHnIj6lKuNSrLyoxcWPIPN5k0 2tz2nEIxq7yMkl1M9YEHkoL1WyDXKy+gFPpvW7TtHi+s+FTgx33dpa8bZyQ9ZY0D EXd2iHWirHyCfNrzN0ejMwadsJ/j+bRPfjy8YD99glhBlACxEUBgdvhg5p6VyQOk sRzs+NYFdCjKvsCiyTlQAdTA92bQyRwqDaODtK6Bf8ftG42tFhI5OL9xgQpB3JWB Tn9+At4ocJ8= =MClf -----END PGP SIGNATURE----- --=-=-=-- From unknown Thu Aug 14 21:53:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 15 Dec 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator