GNU bug report logs - #59212
29.0.50; [PATCH] Set default value of bookmark Type

Previous Next

Full log

View this message in rfc822 format

From: Gabriel <gabriel376 <at> hotmail.com>
To: 59212 <at> debbugs.gnu.org
Subject: bug#59212: 29.0.50; [PATCH] Set default value of bookmark Type
Date: Sat, 12 Nov 2022 05:56:22 -0300

[Message part 1 (text/plain, inline)]

Description:
Not a bug per se, but a suggestion for improvement in how Bookmark
displays the Type (added by commit 7c995264359824cc1aca40ca37201db5ed44e659).

Currently, bookmark-bmenu-list (C-x r l) displays a column named Type,
which has a proper value for all handlers (e.g.: Eshell, VC, EWW etc)
except for regular files, in which an empty string is displayed. I
believe the current behavior could be improved by displaying a default
value ("Files") to make the interface more uniform, explicit and to
avoid confusion.

Steps:
1) emacs -Q
2) M-x eshell
3) C-x r m <RET>
4) C-x C-f ~/foo.bar
5) C-x r m <RET>
6) C-x r b

These steps will add two bookmarks (eshell and foo.bar) and will open
the Bookmarks list. The Type column will have values "" and
"Eshell". After the patch below is applied, the Type column will have
values "File" and "Eshell".

[0001-Set-default-value-of-bookmark-Type.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

---
Gabriel

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.