GNU bug report logs - #59193
[PATCH] gnu: sbcl-njson: Update to 0.2.1.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59193 in the body.
You can then email your comments to 59193 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Artyom Bologov <mail <at> aartaka.me>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: sbcl-njson: Update to 0.2.1.
Date: Fri, 11 Nov 2022 16:49:40 +0400

[Message part 1 (text/plain, inline)]

Hello Guix,

This updates sbcl-njson to the current latest 0.2.1.

[0001-gnu-sbcl-njson-Update-to-0.2.1.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Thanks,
--
Artyom Bologov.

Message #8 received at 59193 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Artyom Bologov <mail <at> aartaka.me>
Cc: 59193 <at> debbugs.gnu.org
Subject: Re: [bug#59193] [PATCH] gnu: sbcl-njson: Update to 0.2.1.
Date: Tue, 15 Nov 2022 09:56:10 +0000

[Message part 1 (text/plain, inline)]

Artyom Bologov <mail <at> aartaka.me> skribis:

> Hello Guix,
>
> This updates sbcl-njson to the current latest 0.2.1.

The sbcl-nactivitypub package fails to build with sbcl-njson 0.2.1.
Could you take a look at it?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 59193 <at> debbugs.gnu.org (full text, mbox):

From: Artyom Bologov <mail <at> aartaka.me>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 59193 <at> debbugs.gnu.org, Artyom Bologov <mail <at> aartaka.me>
Subject: Re: [bug#59193] [PATCH] gnu: sbcl-njson: Update to 0.2.1.
Date: Fri, 18 Nov 2022 15:34:29 +0400

[Message part 1 (text/plain, inline)]

Hello Guillaume,

> The sbcl-nactivitypub package fails to build with sbcl-njson 0.2.1.
> Could you take a look at it?

Yes, see the attached patch updating sbcl-nactivitypub too!

[0001-gnu-Update-cl-nactivitypub-to-0.0.3.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Thanks,
--
Artyom.

Message #14 received at 59193 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Artyom Bologov <mail <at> aartaka.me>
Cc: 59193 <at> debbugs.gnu.org
Subject: Re: [bug#59193] [PATCH] gnu: sbcl-njson: Update to 0.2.1.
Date: Fri, 18 Nov 2022 12:47:04 +0000

[Message part 1 (text/plain, inline)]

Artyom Bologov <mail <at> aartaka.me> skribis:

> Hello Guillaume,
>
>> The sbcl-nactivitypub package fails to build with sbcl-njson 0.2.1.
>> Could you take a look at it?
>
> Yes, see the attached patch updating sbcl-nactivitypub too!
>
> [2. Update cl-nactivitypub. --- text/x-patch; 0001-gnu-Update-cl-nactivitypub-to-0.0.3.patch]...
>
>
> Thanks,

Hi,

The sbcl-nactivitypub-0.0.3 package still fails to build.

The first error I got was: "The name NJSON/ALIASES does not designate
any package." I was able to get a bit further by applying the attached
patch to build the missing njson/aliases subsystem and adding it to
the 'depends-on' field in "nactivitypub.asd".

I then hit another error: "nactivitypub.lisp" is trying to use
a njson/aliases:truep symbol that doesn't exist. I took a look at
exported symbols of njson and njson/aliases, and I think nactivitypub
should use either njson:jtruep or njson/aliases:true.

[0001-gnu-cl-njson-Build-extra-systems.patch (text/x-patch, inline)]

From 1896223a12fb5713a12b81fb683232ddc8a06b61 Mon Sep 17 00:00:00 2001
From: Guillaume Le Vaillant <glv <at> posteo.net>
Date: Fri, 18 Nov 2022 13:34:32 +0100
Subject: [PATCH] gnu: cl-njson: Build extra systems.

* gnu/packages/lisp-xyz.scm (sbcl-njson)[arguments]: Add "njson/aliases" and
  "njson/cl-json" to 'asd-systems'.
---
 gnu/packages/lisp-xyz.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 1c0100bbe4..b3abe264f0 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -22804,6 +22804,8 @@ (define-public sbcl-njson
     (build-system asdf-build-system/sbcl)
     (inputs (list sbcl-cl-json))
     (native-inputs (list sbcl-lisp-unit2))
+    (arguments
+     '(#:asd-systems '("njson" "njson/aliases" "njson/cl-json")))
     (home-page "https://github.com/atlas-engineer/njson")
     (synopsis "JSON handling framework for Common Lisp")
     (description
-- 
2.38.1

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 59193 <at> debbugs.gnu.org (full text, mbox):

From: Artyom Bologov <mail <at> aartaka.me>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 59193 <at> debbugs.gnu.org, Artyom Bologov <mail <at> aartaka.me>
Subject: Re: [bug#59193] [PATCH] gnu: sbcl-njson: Update to 0.2.1.
Date: Fri, 18 Nov 2022 22:42:41 +0400

[Message part 1 (text/plain, inline)]

Hi,

> The sbcl-nactivitypub-0.0.3 package still fails to build.
>
> The first error I got was: "The name NJSON/ALIASES does not designate
> any package." I was able to get a bit further by applying the attached
> patch to build the missing njson/aliases subsystem and adding it to
> the 'depends-on' field in "nactivitypub.asd".
>
> I then hit another error: "nactivitypub.lisp" is trying to use
> a njson/aliases:truep symbol that doesn't exist. I took a look at
> exported symbols of njson and njson/aliases, and I think nactivitypub
> should use either njson:jtruep or njson/aliases:true.

Indeed! Thanks for taking the look at it and pointing me in the right
direction! I've updated both njson and nactivitypub and now they should
be mutually compatible, see the attached patches.

[0001-gnu-Update-cl-njson-to-0.2.3.patch (text/x-patch, attachment)]

[0001-gnu-Update-cl-nactivitypub-to-0.0.4.patch (text/x-patch, attachment)]

[Message part 4 (text/plain, inline)]

Thanks,
--
Artyom.

Message #22 received at 59193-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Artyom Bologov <mail <at> aartaka.me>
Cc: 59193-done <at> debbugs.gnu.org
Subject: Re: [bug#59193] [PATCH] gnu: sbcl-njson: Update to 0.2.1.
Date: Sat, 19 Nov 2022 11:59:51 +0000

[Message part 1 (text/plain, inline)]

Patches pushed as 337fe45544c2e89127d79557f9a05a0fa237c779 and
following.
Thanks.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.