From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 18:16:11 2022 Received: (at submit) by debbugs.gnu.org; 10 Nov 2022 23:16:11 +0000 Received: from localhost ([127.0.0.1]:44618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otGmI-0006tg-T9 for submit@debbugs.gnu.org; Thu, 10 Nov 2022 18:16:11 -0500 Received: from lists.gnu.org ([209.51.188.17]:38642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otGmH-0006tZ-CJ for submit@debbugs.gnu.org; Thu, 10 Nov 2022 18:16:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otGmH-0003vb-7a for guix-patches@gnu.org; Thu, 10 Nov 2022 18:16:09 -0500 Received: from mx2.dismail.de ([159.69.191.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otGm8-0005KI-AS for guix-patches@gnu.org; Thu, 10 Nov 2022 18:16:08 -0500 Received: from mx2.dismail.de (localhost [127.0.0.1]) by mx2.dismail.de (OpenSMTPD) with ESMTP id 5bb827f3 for ; Fri, 11 Nov 2022 00:15:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=20190914; bh=fo/p7U+dfgPikcS8+LmwfS5RDo0As+dbKrSNlmS2YIY=; b= GEg5SKan4L7PY7rlHRpMAZK0wYJtlWR2b+QtdArzZ+toIGdXVqUbeGlvhiGNkS3X DwgfxlGPT9xTJry5hZDyNL+OV780fMc88ZiPQtFrs6zRyVmkME4SYAZpB6BRqEsA pxxgRuV5GWYMKzOhG2Mzl86bH9kLHMA3NayClr7vLqspIWcAZjy04VfbBJKeYbtB yvz7Bgou3if9WJNKtYao4VMnUJndFzGdgR3jncVvUXMKux61EgJEY3Rp8/L5278s rP0Y4pKutdrvTKbXArkFubF+rn9hVynxCRaum0dQzhYMuK1tTj95WZWnGWfyTDlZ RKchks3TvgMFa/UHd5FrFw== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx2.dismail.de (OpenSMTPD) with ESMTP id 828d67d4 for ; Fri, 11 Nov 2022 00:15:55 +0100 (CET) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id 191ca9ac for ; Fri, 11 Nov 2022 00:15:55 +0100 (CET) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 0df10e9a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 11 Nov 2022 00:15:55 +0100 (CET) From: jgart To: guix-patches@gnu.org Subject: [PATCH] gnu: Add emacs-free-keys. Date: Thu, 10 Nov 2022 17:15:38 -0600 Message-Id: <20221110231538.18589-1-jgart@dismail.de> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=159.69.191.136; envelope-from=jgart@dismail.de; helo=mx2.dismail.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/emacs-xyz.scm (emacs-free-keys): New variable. --- gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c0faf221d6..aaa6e7d0e4 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -33866,6 +33866,28 @@ (define-public emacs-vertico-posframe a vertical completion UI.") (license license:gpl3+))) +(define-public emacs-free-keys + (package + (name "emacs-free-keys") + (version "1.0.0") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/Fuco1/free-keys") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0xgifa7s9n882f9ymyyz9gc11xfbj3vfpnxiq1fqfm5hmwx9pwbc")))) + (build-system emacs-build-system) + (home-page "https://github.com/Fuco1/free-keys") + (synopsis "Show free keybindings for modkeys or prefixes") + (description +"@code{emacs-free-keys} shows available key bindings in the current +buffer.") + (license license:gpl3+))) + ;;; ;;; Avoid adding new packages to the end of this file. To reduce the chances ;;; of a merge conflict, place them above by existing packages with similar -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 11 05:46:00 2022 Received: (at submit) by debbugs.gnu.org; 11 Nov 2022 10:46:00 +0000 Received: from localhost ([127.0.0.1]:45153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otRXr-00039A-QF for submit@debbugs.gnu.org; Fri, 11 Nov 2022 05:46:00 -0500 Received: from lists.gnu.org ([209.51.188.17]:37752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otRXm-00038y-FV for submit@debbugs.gnu.org; Fri, 11 Nov 2022 05:45:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otRXm-00070A-A9 for guix-patches@gnu.org; Fri, 11 Nov 2022 05:45:54 -0500 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otRXk-0006qt-3B for guix-patches@gnu.org; Fri, 11 Nov 2022 05:45:53 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 34CA0240003; Fri, 11 Nov 2022 10:45:44 +0000 (UTC) From: Nicolas Goaziou To: jgart via Guix-patches via Subject: Re: [bug#59186] [PATCH] gnu: Add emacs-free-keys. References: <20221110231538.18589-1-jgart@dismail.de> Date: Fri, 11 Nov 2022 11:45:44 +0100 In-Reply-To: <20221110231538.18589-1-jgart@dismail.de> (jgart via Guix-patches via's message of "Thu, 10 Nov 2022 17:15:38 -0600") Message-ID: <87sfipsraf.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:4b98:dc4:8::221; envelope-from=mail@nicolasgoaziou.fr; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 59186@debbugs.gnu.org, jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, jgart via Guix-patches via writes: > * gnu/packages/emacs-xyz.scm (emacs-free-keys): New variable. Thank you. > + (description > +"@code{emacs-free-keys} shows available key bindings in the current > +buffer.") Could you please use @code{free-keys} or (better, IMO) Free Keys instead of @code{emacs-free-keys}, for a reason given a couple of times in the past already? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 11 08:12:33 2022 Received: (at 59186) by debbugs.gnu.org; 11 Nov 2022 13:12:33 +0000 Received: from localhost ([127.0.0.1]:45291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otTpa-0000Aq-I9 for submit@debbugs.gnu.org; Fri, 11 Nov 2022 08:12:32 -0500 Received: from mx2.dismail.de ([159.69.191.136]:3157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otTpW-0000Aa-QR for 59186@debbugs.gnu.org; Fri, 11 Nov 2022 08:12:25 -0500 Received: from mx2.dismail.de (localhost [127.0.0.1]) by mx2.dismail.de (OpenSMTPD) with ESMTP id 5d04fd1c; Fri, 11 Nov 2022 14:12:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=20190914; bh=aZtROr6rVrwwcVVRSMyhT1V2FepabYtGjryO4iKgA3c=; b= s6VbgVDU0tte3QJn+rgC68hDvhzmuh+/QryZgRFx/218Pt3pI00tFMRFG8Jq/GjJ GEDipjPFnxrnoeVlBC5Xn6sMM4kL8E8Y05A2SmYiq3Yfs4hMOvhI7MX4TDIHFvd5 3Fwuf0hgJ2N51PpbYjGgsUiorhOeldqNK6YYIDFL7OuzvD7dtuNnkH8JmtYBGXjN m5k9bjUeo5HrchyXlnaiwn6qWRBwfcxuKvDbaczhaEqop9R0a86rR2iQWYsgzD/G D2Eo8nZrGDZBfBURagxrSG3vJggzxD3TM8TD6NIZMtTjANxMXXsfhhWMHCEj7IHL EA4ivK4klVzyjMdkr0Pxlg== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx2.dismail.de (OpenSMTPD) with ESMTP id 53f4cd00; Fri, 11 Nov 2022 14:12:15 +0100 (CET) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id 7e836194; Fri, 11 Nov 2022 14:12:15 +0100 (CET) Received: by dismail.de (OpenSMTPD) with ESMTPSA id d2369075 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 11 Nov 2022 14:12:09 +0100 (CET) From: jgart To: 59186@debbugs.gnu.org Subject: [PATCH v2] gnu: Add emacs-free-keys. Date: Fri, 11 Nov 2022 07:07:59 -0600 Message-Id: <20221111130758.27692-1-jgart@dismail.de> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59186 Cc: jgart , Nicolas Goaziou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/emacs-xyz.scm (emacs-free-keys): New variable. Hi Nicolas, Sorry about that. Here is v2 with the texinfo markup updated. Is what you're saying that @code markup should never be used to reference guix code? all best, jgart --- gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c0faf221d6..b2cf31d3d9 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -33866,6 +33866,28 @@ (define-public emacs-vertico-posframe a vertical completion UI.") (license license:gpl3+))) +(define-public emacs-free-keys + (package + (name "emacs-free-keys") + (version "1.0.0") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/Fuco1/free-keys") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0xgifa7s9n882f9ymyyz9gc11xfbj3vfpnxiq1fqfm5hmwx9pwbc")))) + (build-system emacs-build-system) + (home-page "https://github.com/Fuco1/free-keys") + (synopsis "Show free keybindings for modkeys or prefixes") + (description +"@code{free-keys} shows available key bindings in the current +buffer.") + (license license:gpl3+))) + ;;; ;;; Avoid adding new packages to the end of this file. To reduce the chances ;;; of a merge conflict, place them above by existing packages with similar -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 12 05:47:05 2022 Received: (at submit) by debbugs.gnu.org; 12 Nov 2022 10:47:05 +0000 Received: from localhost ([127.0.0.1]:47378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oto2S-0007cb-PI for submit@debbugs.gnu.org; Sat, 12 Nov 2022 05:47:05 -0500 Received: from lists.gnu.org ([209.51.188.17]:50296) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oto2Q-0007cL-Ni for submit@debbugs.gnu.org; Sat, 12 Nov 2022 05:47:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oto2Q-0007ng-8r for guix-patches@gnu.org; Sat, 12 Nov 2022 05:47:02 -0500 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oto2N-0003ee-VE for guix-patches@gnu.org; Sat, 12 Nov 2022 05:47:01 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id C2CDCE0004; Sat, 12 Nov 2022 10:46:53 +0000 (UTC) From: Nicolas Goaziou To: jgart via Guix-patches via Subject: Re: [bug#59186] [PATCH v2] gnu: Add emacs-free-keys. References: <20221110231538.18589-1-jgart@dismail.de> <20221111130758.27692-1-jgart@dismail.de> Date: Sat, 12 Nov 2022 11:46:52 +0100 In-Reply-To: <20221111130758.27692-1-jgart@dismail.de> (jgart via Guix-patches via's message of "Fri, 11 Nov 2022 07:07:59 -0600") Message-ID: <87o7tcsb4z.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2001:4b98:dc4:8::224; envelope-from=mail@nicolasgoaziou.fr; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 59186-done@debbugs.gnu.org, jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, jgart via Guix-patches via writes: > * gnu/packages/emacs-xyz.scm (emacs-free-keys): New variable. > > Sorry about that. Here is v2 with the texinfo markup updated. Thank you. I moved the package definition outside the end of the file, changed @code{free-keys} into Free-keys (sorry, I couldn't help) and applied it. > Is what you're saying that @code markup should never be used to reference > guix code? No, it isn't. I'm saying that we should not mix the Guix variable name (here `emacs-free-keys') and the name of the project (here `free-keys'). The description is more about the project than the Guix variable. Therefore, we should reference the former, not the latter. As a consequence, @code{free-keys} is better than @code{emacs-free-keys} because we're not referencing Guix code. Also, on a more personal POV, I think we're using emphasis too much in descriptions as it hinders readability. In particular, @code markup should really be reserved to symbols (variables, functions=E2=80=A6) rather= than project names. Capitalization is much more elegant in this case. Regards, --=20 Nicolas Goaziou From unknown Sat Sep 20 21:09:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 10 Dec 2022 12:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator