Subject: bug#59177: closed (Re: bug#59177: [PATCH] python-protobuf: Use C++ implementation)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 02 Dec 2022 13:15:02 +0000

Your bug report

#59177: [PATCH] python-protobuf: Use C++ implementation

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
59177: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59177
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#59177: [PATCH] python-protobuf: Use C++ implementation
From: Ludovic Courtès <[email-masked]>
To: <[email-masked]>
Cc: [email-masked]
Date: Fri, 02 Dec 2022 14:13:50 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

<[email-masked]> skribis:

> From a1f443dcf7ad1e222a9796441f6d96425dbfe787 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Ontje=20L=C3=BCnsdorf?= <[email-masked]>
> Date: Thu, 10 Nov 2022 09:11:11 +0100
> Subject: [PATCH] gnu: python-protobuf: Use C++ implementation.
>
> * gnu/packages/protobuf.scm (python-protobuf): Use C++ implementation.
>   [inputs]: Add protobuf.
>   [arguments]: Add --cpp_implementation configure flags.

Perfect.  Applied, thanks!

Ludo’.

Subject: [PATCH] python-protobuf: Use C++ implementation
From: <[email-masked]>
To: <[email-masked]>
Date: Thu, 10 Nov 2022 08:23:34 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Guix,

this patch configures python-protobuf to use the C++ protobuf
implementation. This additional dependency pays off with a 10x
performance improvement in some of my workloads.

Best regards,
Ontje
From f2675cccf54d2bb1291ba1614ca44966730734e1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ontje=20L=C3=BCnsdorf?= <[email-masked]>
Date: Thu, 10 Nov 2022 09:11:11 +0100
Subject: [PATCH] gnu: python-protobuf: Use C++ implementation.

* gnu/packages/protobuf.scm (python-protobuf): Use C++ implementation.
  [propagated-inputs]: Add protobuf.
  [arguments]: Add --cpp_implementation configure flags.
---
 gnu/packages/protobuf.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/protobuf.scm b/gnu/packages/protobuf.scm
index 1448691a42..9be35783fb 100644
--- a/gnu/packages/protobuf.scm
+++ b/gnu/packages/protobuf.scm
@@ -393,6 +393,9 @@ (define-public python-protobuf
         (base32
          "1ja2vpk9nklllmsirmil2s4l7ni9yfqvbvj47zz5xx17s1k1bhxd"))))
     (build-system python-build-system)
+    (propagated-inputs (list protobuf))
+    (arguments
+     `(#:configure-flags '("--cpp_implementation")))
     (home-page "https://github.com/google/protobuf")
     (synopsis "Protocol buffers is a data interchange format")
     (description
-- 
2.38.1