From unknown Sun Jun 22 04:32:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59164] [PATCH v2 1/4] Makefile.am: Sort EXTRA_DIST entries. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Nov 2022 04:25:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59164 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59164@debbugs.gnu.org Cc: Maxim Cournoyer X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166805426319429 (code B ref -1); Thu, 10 Nov 2022 04:25:04 +0000 Received: (at submit) by debbugs.gnu.org; 10 Nov 2022 04:24:23 +0000 Received: from localhost ([127.0.0.1]:41560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osz70-00053J-Ug for submit@debbugs.gnu.org; Wed, 09 Nov 2022 23:24:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:52128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osz6x-00052v-21 for submit@debbugs.gnu.org; Wed, 09 Nov 2022 23:24:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osz6v-00048b-ST for guix-patches@gnu.org; Wed, 09 Nov 2022 23:24:18 -0500 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osz6n-0006mD-Gl for guix-patches@gnu.org; Wed, 09 Nov 2022 23:24:17 -0500 Received: by mail-qt1-x82c.google.com with SMTP id fz10so399070qtb.3 for ; Wed, 09 Nov 2022 20:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XGrPvhQ/9qGJmUplPfL27tDsvHuvx+A+Tne09I59vJU=; b=aPYZ11GzJPv5zxE0si5ZDV0SvG7bF0KYOvZrRhfBK+L4m8gl5upvKmFaLyPYCPSO0s KFxWo6waaS8so06zR+ax+v/PAIrnD7icIJbb5xgRw8vybw+a6v2myhjwVTFa+/T2NdpI 49zyD1XfjP10uxReedVnIDaXPYTDEcHNzcdScOMhmgc9p/7sdT0dKV5AHWqt0ezhPsxT LnSIHZx7gOKqqInTOzIkRF/N7Uj150ElD/Z1WiSR/TpzlkVgX9cJCSMt/PBihi7bTQbi cWTSmVfEhali6Xyk9pVlaDw2lj4H2jpvV0+qStVk8B7eVmNGLDIOao3ZwNLU0+exzYOK lCEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XGrPvhQ/9qGJmUplPfL27tDsvHuvx+A+Tne09I59vJU=; b=qVitUaW8FFJDlmIcBYyJ3/K2PoLosVL7seiXC59DnkEGa5T7HSxmVrEV0UKyG85YT9 3PIO2WKDK5uihrfz2KF0Ib9rZPr8AgjdtywGS2R34mlrJuGG0a079czdI6vv5ahUvnKO FE4aicvuaFuGapz0d1qv2pZwIytgfMO7CVNflDOSLwEc2bEeuOZIUrQeKp1BCZUG4lqU Fptd4WdaOPcukr9ay2N7DRl8tAEgAvjIQ5Qmso3j4z+UgPC+rHjf4LMJTVVSs6DuSaaW rRHdHelcrFF0uoDHVgHUBXpGykR+AUDxWsxBBcoCD/Eb9ZoLYB+20U0DFG7/dNXU/5a8 wFEw== X-Gm-Message-State: ACrzQf1/ty8RCWusMBbhEzn1G5QeLsi+k07tbgAAwtkkas/KWi3Q6bBK qNviTxDbIMbipT1AqQGetqN0PX3b2ew= X-Google-Smtp-Source: AMsMyM5aRRjFZl0pyIuIHnGtGUrFdhWZQb0Rl1UvFkPBRrQJgj4wb5Qh0lKdA/ZFxIt7gorfNbvxUw== X-Received: by 2002:a05:622a:116:b0:3a5:7422:112 with SMTP id u22-20020a05622a011600b003a574220112mr21947360qtw.429.1668054248018; Wed, 09 Nov 2022 20:24:08 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1001]) by smtp.gmail.com with ESMTPSA id r1-20020ac85e81000000b0039cc7ebf46bsm10515105qtx.93.2022.11.09.20.24.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 20:24:07 -0800 (PST) From: Maxim Cournoyer Date: Wed, 9 Nov 2022 23:23:48 -0500 Message-Id: <20221110042351.829-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <87h6z7omzy.fsf_-_@gnu.org> References: <87h6z7omzy.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::82c; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x82c.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URI_HEX=0.1 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.2 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.2 (--) * Makefile.am (EXTRA_DIST): Sort. --- Makefile.am | 52 ++++++++++++++++++++++++++-------------------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/Makefile.am b/Makefile.am index 47886721fa..c3af23b68e 100644 --- a/Makefile.am +++ b/Makefile.am @@ -660,49 +660,49 @@ dist_fishcompletion_DATA = etc/completion/fish/guix.fish nodist_selinux_policy_DATA = etc/guix-daemon.cil EXTRA_DIST += \ - HACKING \ - ROADMAP \ - TODO \ - CODE-OF-CONDUCT \ .dir-locals.el \ .guix-authorizations \ .guix-channel \ - scripts/guix.in \ - etc/disarchive-manifest.scm \ - etc/guix-install.sh \ - etc/news.scm \ - etc/release-manifest.scm \ - etc/source-manifest.scm \ - etc/system-tests.scm \ - etc/time-travel-manifest.scm \ - etc/historical-authorizations \ + CODE-OF-CONDUCT \ + HACKING \ + ROADMAP \ + TODO \ + bootstrap \ build-aux/build-self.scm \ - build-aux/compile-all.scm \ - build-aux/cuirass/hurd-manifest.scm \ - build-aux/check-final-inputs-self-contained.scm \ build-aux/check-channel-news.scm \ + build-aux/check-final-inputs-self-contained.scm \ + build-aux/compile-all.scm \ build-aux/compile-as-derivation.scm \ + build-aux/config.rpath \ build-aux/convert-xref.scm \ + build-aux/cuirass/hurd-manifest.scm \ build-aux/generate-authors.scm \ build-aux/test-driver.scm \ - build-aux/update-guix-package.scm \ build-aux/update-NEWS.scm \ - tests/test.drv \ + build-aux/update-guix-package.scm \ + doc/build.scm \ + etc/disarchive-manifest.scm \ + etc/guix-install.sh \ + etc/historical-authorizations \ + etc/news.scm \ + etc/release-manifest.scm \ + etc/source-manifest.scm \ + etc/system-tests.scm \ + etc/time-travel-manifest.scm \ + scripts/guix.in \ tests/cve-sample.json \ - tests/keys/signing-key.pub \ - tests/keys/signing-key.sec \ tests/keys/civodul.pub \ - tests/keys/rsa.pub \ tests/keys/dsa.pub \ - tests/keys/ed25519.pub \ - tests/keys/ed25519.sec \ tests/keys/ed25519-2.pub \ tests/keys/ed25519-2.sec \ tests/keys/ed25519-3.pub \ tests/keys/ed25519-3.sec \ - build-aux/config.rpath \ - bootstrap \ - doc/build.scm \ + tests/keys/ed25519.pub \ + tests/keys/ed25519.sec \ + tests/keys/rsa.pub \ + tests/keys/signing-key.pub \ + tests/keys/signing-key.sec \ + tests/test.drv \ $(TESTS) if !BUILD_DAEMON_OFFLOAD -- 2.37.3 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 08:42:50 2022 Received: (at control) by debbugs.gnu.org; 10 Nov 2022 13:42:50 +0000 Received: from localhost ([127.0.0.1]:42278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot7pR-0002hr-RN for submit@debbugs.gnu.org; Thu, 10 Nov 2022 08:42:50 -0500 Received: from mail-qk1-f171.google.com ([209.85.222.171]:34739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot7pQ-0002he-B9 for control@debbugs.gnu.org; Thu, 10 Nov 2022 08:42:49 -0500 Received: by mail-qk1-f171.google.com with SMTP id 8so1077566qka.1 for ; Thu, 10 Nov 2022 05:42:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=/VshDXtsbjF/nrr8D42/bFKv+C0ueZHoZsDZh75vCOc=; b=ZWIn1MP386H5CPffseCE9kL5WAiS2hHfOJ/VUNgZPusuxe+qq18GNBrOyg5jh5t/bE hEkekYOc2CtbbKNdPnK4Xlgq9DXto4f1gjc+HoupeEqNUc8WpETuAif5VfAx51+e0is5 HZ/HWbde8uXdu9oqGdZVuZVHS8fShsqjguSdAOKi5SDYd/sAFsqnWHjCWfPetQGr53fS lbhNsJ+IN51NccouywJzsEu2BVxxWh/St7C/bpg1rCxxvX49UWdQZ9R+SB8cgHdxsHoX 0W/NwHn1rUk9VPxT3YcVqVUOw4BLVP+USlMfKbmHRDGqhAJpYWHgsgcJ6h5FFKVNtxw2 YLJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/VshDXtsbjF/nrr8D42/bFKv+C0ueZHoZsDZh75vCOc=; b=URSMYDV/qw0y4yV5hRDCL6AW9JAqh9i8xt/fVUnNWESqdMRBhZ8CYZJuCQrwcpMRyU CPYBd/WenBM1qZ85BstcHWyCyGDHgLeqtsKgVEbCc3NmQRBQizlW2W5+XLaYJte3bvU2 HWGpWjqikHxXmMadW60ROwOveRSRjdh1iBdlikO1l9jUlTIRraaOiEvAp7j0zxz8B7Is RQ/MJTlCXJtSm+oiSzIy12eIysZuSROiG7GBEBzCyEdtXKrfOfW9D5/W4XgwJdDOijvR V//1JLhsa+evb7pxxAKjmQ02GHs58/++rS8huYtoKQlNqgA7SUG84dU3cTl55jhp61qN tJYg== X-Gm-Message-State: ACrzQf38P7DWkYrCJ2qbdmj4bNI1ZolqpVyM2/HzTgYtKu4PvE2huKzA QyzZQOxLYw3dQODHq/ee3P5xEbZOmV0= X-Google-Smtp-Source: AMsMyM6rp2jduRc/vpODfoDic5NonS4537vXvDSckKam6NdZiCbXJuMkKxbrg8YhhypDxwfKlVOJyw== X-Received: by 2002:a05:620a:14c:b0:6fa:60fb:b32c with SMTP id e12-20020a05620a014c00b006fa60fbb32cmr31980583qkn.332.1668087762421; Thu, 10 Nov 2022 05:42:42 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1001]) by smtp.gmail.com with ESMTPSA id ay9-20020a05620a178900b006cfc1d827cbsm12951020qkb.9.2022.11.10.05.42.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 05:42:42 -0800 (PST) Date: Thu, 10 Nov 2022 08:42:41 -0500 Message-Id: <87y1sjvsby.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #59161 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 59161 59164 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 08:42:59 2022 Received: (at control) by debbugs.gnu.org; 10 Nov 2022 13:42:59 +0000 Received: from localhost ([127.0.0.1]:42281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot7pb-0002iF-3L for submit@debbugs.gnu.org; Thu, 10 Nov 2022 08:42:59 -0500 Received: from mail-qk1-f172.google.com ([209.85.222.172]:45987) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot7pY-0002i0-M2 for control@debbugs.gnu.org; Thu, 10 Nov 2022 08:42:57 -0500 Received: by mail-qk1-f172.google.com with SMTP id v8so1041017qkg.12 for ; Thu, 10 Nov 2022 05:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=rFGlD255pC/s7KVqevhkBCV9TyGbrY0fjHUf5LwRO0M=; b=j/D0NwXTMuGolcSoihdL/a4MFIJ+HgsuG6QWWnxfcv7Erod7rJF9tMN9rTNfqB0uEN OZcMaXhJntEhFA6KS9l5NPrF07OmsCSh0B6lrttxLPlZgS7jOrbFAzhoqi1c6Th2zQQN 4PIJM+K/i+bgC3rOpUMnDVJyqmw1m4dpp+dHSBPlj49qNLuZmYKeSCk95qOiYaZiLyvp ij6qmtKk5lAvgFSRcuacNqDYbHUuRGPVdb3cF5bEta42BDdwUx/XyZ1q0GFAtMBvhRyv 2c/DE8UsSQK97DJdcPtbERZKL4UtcEqbzVf7l3K13dM1YsdQYJwK7hbCZeiZPzclmLbD QRZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rFGlD255pC/s7KVqevhkBCV9TyGbrY0fjHUf5LwRO0M=; b=o6Mu2+hwlAEqil2MKjmGEhKpUwySMs9eQbc6oSLYwKHtqv/b88LfxilnsLoLQJaBPM 9R1UsPv0x+wTx0vZXCywoYtQt4OVSoi9Qa7zrcIwQWg075Hgpw15B/AaBvK4xgjfEIXT gCxtU/oVzQOR7bfcY5m/4Y2l+0EjS4vxRgKlc/dEato+slSHUBEDDwK0oIbMDKse/o98 QMULuGWYTKBM5FSHk4az0X0mx7fR6QL/m0MbpaY9UvTDub3h8T0fZDzDtTRlJdN9bEDE vCJY/Qz+jhtnQZ2MPjk9+gQt1ODrHoTSlcTEtWrTDnvCpdCQDAfSBLsVA53L8JDTJV6H N4Ng== X-Gm-Message-State: ANoB5pnpShwILu9w3GWRyvF74CYJsLwDb3GPU3VwPHljaZ3b6aZ7aAQt ytilcog766gEcqBnkWIodxaBixt7Cjs= X-Google-Smtp-Source: AA0mqf5ryjS78TxGjgUoR5bZ+n+c+6+D/03nsIzQgqYWQVd2hgeSA5z3e2uPDdMDEGzjJqhNp4AudQ== X-Received: by 2002:a37:684a:0:b0:6fa:e0bb:cb6d with SMTP id d71-20020a37684a000000b006fae0bbcb6dmr697043qkc.707.1668087771001; Thu, 10 Nov 2022 05:42:51 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1001]) by smtp.gmail.com with ESMTPSA id fb16-20020a05622a481000b00399fe4aac3esm11172134qtb.50.2022.11.10.05.42.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 05:42:50 -0800 (PST) Date: Thu, 10 Nov 2022 08:42:49 -0500 Message-Id: <87wn83vsbq.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #59162 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 59162 59164 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 08:43:03 2022 Received: (at control) by debbugs.gnu.org; 10 Nov 2022 13:43:03 +0000 Received: from localhost ([127.0.0.1]:42288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot7pf-0002j5-C6 for submit@debbugs.gnu.org; Thu, 10 Nov 2022 08:43:03 -0500 Received: from mail-qk1-f175.google.com ([209.85.222.175]:44858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot7pd-0002i6-Vt for control@debbugs.gnu.org; Thu, 10 Nov 2022 08:43:02 -0500 Received: by mail-qk1-f175.google.com with SMTP id z17so1044440qki.11 for ; Thu, 10 Nov 2022 05:43:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=XznHWN5gCjLIb7gHi+dXVh/5KrlVpERONzWgUE6jVws=; b=n/hacJzCrrW7uPzQ2I8zWs42a0f9eAdjo6fTTVqfFM5XMxzQi2RNw2XsNxsbXcuBGS Q/sSkqUyADV3ek+qQSq0maICiocV3L7vYRsMoAyGpdoX0OgkB03bfE9Suz+Uku6e/YCD K7zjJcNZ9GacyAsVF542DzJAoXvqZNJDyKcFYCyueglHSpuDeGQMXEx3kQGo/SE6d+BP /nLn0nIArNKdex7pJgL9ypYhdNZHZBzKCxAG0pS9Zzfy+JTz4F+egvduJDM3ep+WHrdS jypybQZuqhley3BW+2Rrvg/GlcRIqZitXf1xykLMDWX50MEUnIU1EP2FsTkiqu/VCb9f Hq+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XznHWN5gCjLIb7gHi+dXVh/5KrlVpERONzWgUE6jVws=; b=PSNxxFOZjBhkJ6j/+Lwhnvk/vb6VBThJnrNQfVz+p+EtAZkq02ZqRilMyjdGLkVUMo bLWhIraLw01cGF+VKGR9Y/Tt3LrhoPVSZJ8LyAJ1Zs83xoEJDThw8H6p59jp61B418+a nmKPNSYukYqon7NG+2iTCC0GUQ0+7WoN0TCjwqvW/E1J0QGTrheMjlreVmno31DJl2Sm Q/d9eLPvmdGkJbuHdRFdLEUmWWT8d8lIHyjuSkc0asgmn880NwMpoawOPmujB3T2NBp4 y8osjK9mXGB2okAkKePlolxYh8LtU50Hk85ubAPCpSFYWXkKdAo5QwSOtXRXaGGOiKab AlEQ== X-Gm-Message-State: ACrzQf1/R3cIoR+rUZTZlEcw21JnE4Ao6LOUKFoNcv9hwufiTkrhUPdu RQYwTIyy+nBWC3buQAKqHzl6xffJIsE= X-Google-Smtp-Source: AMsMyM58YGN0WjOzRPhMo3QQp4XFRpCyk/3Z42FR1XU09QcW6GtB388BexXYKpenXQkO8UMupHtnHg== X-Received: by 2002:a37:53c7:0:b0:6fa:4b14:e071 with SMTP id h190-20020a3753c7000000b006fa4b14e071mr35757729qkb.230.1668087776355; Thu, 10 Nov 2022 05:42:56 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1001]) by smtp.gmail.com with ESMTPSA id m5-20020ac84445000000b003a51e8ef03dsm11254623qtn.62.2022.11.10.05.42.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 05:42:56 -0800 (PST) Date: Thu, 10 Nov 2022 08:42:55 -0500 Message-Id: <87v8nnvsbk.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #59163 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 59163 59164 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 08:43:21 2022 Received: (at control) by debbugs.gnu.org; 10 Nov 2022 13:43:22 +0000 Received: from localhost ([127.0.0.1]:42291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot7px-0002jn-M4 for submit@debbugs.gnu.org; Thu, 10 Nov 2022 08:43:21 -0500 Received: from mail-qv1-f42.google.com ([209.85.219.42]:43953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot7pw-0002jb-3H for control@debbugs.gnu.org; Thu, 10 Nov 2022 08:43:20 -0500 Received: by mail-qv1-f42.google.com with SMTP id c8so1353180qvn.10 for ; Thu, 10 Nov 2022 05:43:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=zxD9xhBFIoOBax9tCeYsKMzgotmtmhdoVcNi0lEFyxM=; b=bpZp9BnecBjyMagNGmHCg/RTKcdtwZXsYHDL07BpVDRBDE5VRieMD3yN/TLsTZANrZ luSvg0yXPnqS3hKSd5n4oVo5wS2iJTIw9c2cf/KXTZdyhDkNztQGPz3dL7i7G3V7Kz4V 1MzVTj1R14S6GwmGenmmKUGX9h+ZZ/0iG5bKcYUGFS3XX8RnxrWeAg6PWt3dj7ga/hAy zy5Hi5TAEsaZE9+2c0qfKXQ7/MLxE7ymx2HvqJQxDiucpPPALWjBlVJHjihetXI6NRk3 6VzWEZRJRZwuDIiiRZ5Z1RL0UFJ4j9tJxxRiA5p697hhsLMvAKsMiwmAR277yHF/6OO/ u4lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zxD9xhBFIoOBax9tCeYsKMzgotmtmhdoVcNi0lEFyxM=; b=qYwEgmSmY5mYYhw0Nbt8uDiZJZXy/qtQV9K5i5qoT3XKAUMSF/CIe9vBT3tmlZz7uR h73gTO123GdhOS0Pik2mCxO/B07AQSK3jGrj8puyLorSOpGZweCjEudr4oAfni0OV90H rWeC5cjr8XyBiNTfWy31kamJRGiKeQZ8PnxVz6uETd8XHfDogH+AjT9G7FnMw/pikrwZ X3EGTWYIZUhrtHQh0+6mYab8IV8xYBX40QBAIUWVvH6f/0++T9msQq4YOEiSoekpJYSq dEh8xrNAyWum3vDuEZvVjZ7nz/GLolW2chAGYiihuVlnaSDv/nVam9D8jTooNUeryjnO 53iQ== X-Gm-Message-State: ACrzQf1uuDz0xbNNSl19UG+iGxRARAzVSFVSrLTPBR7/1iulZvYuJfnv oYzuX0/oM2/TmHdSORJhWm/1erIklq4= X-Google-Smtp-Source: AMsMyM5IXVysB1wwV2TAejvFSW18glvyghByjLe2yrIbX0ldTS8C4JMiuqzh4bv5a0rrDtZy9vsIpg== X-Received: by 2002:ad4:5eca:0:b0:4ba:535a:6d45 with SMTP id jm10-20020ad45eca000000b004ba535a6d45mr58952419qvb.56.1668087794494; Thu, 10 Nov 2022 05:43:14 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1001]) by smtp.gmail.com with ESMTPSA id j11-20020a05620a410b00b006ce40fbb8f6sm13046337qko.21.2022.11.10.05.43.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 05:43:14 -0800 (PST) Date: Thu, 10 Nov 2022 08:43:13 -0500 Message-Id: <87tu37vsb2.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #59164 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 59164 58812 quit From unknown Sun Jun 22 04:32:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59164] bug#58812: [PATCH v3 1/4] shell: Detect --symlink spec problems early. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 15 Nov 2022 21:25:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59164 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 58812-done@debbugs.gnu.org Cc: 59164-done@debbugs.gnu.org Received: via spool by 59164-done@debbugs.gnu.org id=D59164.166854750010208 (code D ref 59164); Tue, 15 Nov 2022 21:25:04 +0000 Received: (at 59164-done) by debbugs.gnu.org; 15 Nov 2022 21:25:00 +0000 Received: from localhost ([127.0.0.1]:55397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ov3QR-0002eZ-P1 for submit@debbugs.gnu.org; Tue, 15 Nov 2022 16:24:59 -0500 Received: from mail-qk1-f175.google.com ([209.85.222.175]:46000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ov3QP-0002eH-Kk; Tue, 15 Nov 2022 16:24:58 -0500 Received: by mail-qk1-f175.google.com with SMTP id v8so10413531qkg.12; Tue, 15 Nov 2022 13:24:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=6On4ymAF8XwbbSSlnrqmfj74U2KxNG9NkiWzr1kjxfQ=; b=SYW2psAZkQvUmKvVYv11rhKuy0o1echY75eG+hlJ4aijMzO4zXx/yKj5/DetUG7Plm MTO0VxL5pNJ522KwulrtX5gHB44Ecq056TeMQdZd6dWgVpaAa56hDC4uZd8KhxUh8CKC PZy9qRuTaSEjZvtdVk0lp9Nu5nCg/9L1kyEaB2QCiwyy1w5toXpM6urPq+3CrgP0NprT wlKxbWn+rlG/CwcQUE2DvL7O7gq8h5sxjJ0zK5wMH10SQx6U9/J64D7XgSKabQureY0+ MWoD3Fm1P7bpS/ga1ImmlemZw+421CalumWcAbFeb3Zm1RaWHLPdAZXl3MnShXWev+Rz sjeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6On4ymAF8XwbbSSlnrqmfj74U2KxNG9NkiWzr1kjxfQ=; b=MoFNAeLGsNAFJNVsnOc/AyPjS0l/F6+KPbphA0qgBVh8Z1/hX/H5KjtSkQVfY2PxYJ ZkSCtHUfcZ/Mq911ASohtyxwbA2aA9pMYUgveLEvBx3i2iTnis9cR+qjzv5TcPGzjO57 OGM319vg1yhJGlLIQgsj33Rtan113uWaKR5oyhaOZQnbY4kFchy6UsM2A1sgsVKIZXIk tqiPVg6GGQPq+iXQP8aCaXu+1I/9tgB4DpPqZgcLRVZk3L8rF53AtBj98ksu7hicTB7w WoVT+pkzTTt1nLZqocco7tpE1ijjIqu0VeLVy7KbnkFXz/KEShj69jnvqC1VY7jiwdOI sPPw== X-Gm-Message-State: ANoB5plCfiLKeRGR/RSrwVFrDOTOvlcmCACvPf8XzVG7xwWzbBzvInZn RjRWTTUVLQsxLBSEVKoyvffjakN+DY+ytw== X-Google-Smtp-Source: AA0mqf5YXpFyR8Zc9+PRUtg/Kgu2id5FuLFmVrUOYpm+vHa9TEo6KAGjXCT56ZfyWL5ISFMW1o+3EA== X-Received: by 2002:a05:620a:51c6:b0:6fa:476:99ec with SMTP id cx6-20020a05620a51c600b006fa047699ecmr16420660qkb.727.1668547491936; Tue, 15 Nov 2022 13:24:51 -0800 (PST) Received: from hurd (dsl-151-98.b2b2c.ca. [66.158.151.98]) by smtp.gmail.com with ESMTPSA id i17-20020ac85c11000000b00397e97baa96sm7890032qti.0.2022.11.15.13.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 13:24:51 -0800 (PST) From: Maxim Cournoyer References: <20221027034154.28435-1-maxim.cournoyer@gmail.com> Date: Tue, 15 Nov 2022 16:24:47 -0500 In-Reply-To: <20221027034154.28435-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 26 Oct 2022 23:41:54 -0400") Message-ID: <87y1sblxls.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, [...] > Makefile.am: Sort EXTRA_DIST entries. > tests: Add a tests/utils.sh support file. > install: Validate symlink target in evaluate-populate-directive. > guix: shell: Add '--symlink' option. > shell: Detect --symlink spec problems early. I've now pushed this series as 8f9588185d, with a news entry added as 47f319f21f. Closing! -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 17 12:31:48 2022 Received: (at control) by debbugs.gnu.org; 17 Nov 2022 17:31:48 +0000 Received: from localhost ([127.0.0.1]:34246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovijr-0005F6-SG for submit@debbugs.gnu.org; Thu, 17 Nov 2022 12:31:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovijq-0005Eu-17 for control@debbugs.gnu.org; Thu, 17 Nov 2022 12:31:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovijj-0007Ou-62 for control@debbugs.gnu.org; Thu, 17 Nov 2022 12:31:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=vPR22pr2GkK2gcZ/EADNWgW7PB6mFnoXpSB+1AYBIFY=; b=c+nTNyh95eWRsx nNRSILzifwIshsPmI4D/CxT7o/a6/KdreeMRc6SrJqs9mC4b/XG+UQTAOlVAH7nI5GvTF+tJZXMNl S4MRNx0kTVjd8aaw7S2FucVLin1ygAzm4fUuTQH0uE+5aXSNr+GiBhTPX1e0Ly3W9Oqxt8EkGtSKv +xMoGKv7FTjArWPFpZqe6jNHxHBG1fAvvWdLh/M0cVV3U8jhQ42StGKslNuYNY7Omz3cZmBukjz9k p5BCJ7OsIePxjEmVaNnrk94vtdYnYvQplRhqvxEhSxipOHOsZ/m79bZFp0YWceC9gS07DJFrc5mzW r/EW6m+TghBcwGiMjmlw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovijh-00074P-GA for control@debbugs.gnu.org; Thu, 17 Nov 2022 12:31:38 -0500 Date: Thu, 17 Nov 2022 18:31:35 +0100 Message-Id: <87zgcpfpxk.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #59164 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) retitle 59164 [PATCH] Add '--symlink' to 'guix shell' quit From unknown Sun Jun 22 04:32:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59164] Coding style: similarly-named variables Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 17 Nov 2022 17:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59164 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 59164@debbugs.gnu.org, 58812@debbugs.gnu.org Received: via spool by 59164-submit@debbugs.gnu.org id=B59164.166870666920768 (code B ref 59164); Thu, 17 Nov 2022 17:38:02 +0000 Received: (at 59164) by debbugs.gnu.org; 17 Nov 2022 17:37:49 +0000 Received: from localhost ([127.0.0.1]:34259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovipg-0005Oo-RM for submit@debbugs.gnu.org; Thu, 17 Nov 2022 12:37:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovipf-0005OQ-6U; Thu, 17 Nov 2022 12:37:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovipZ-0008I5-Qo; Thu, 17 Nov 2022 12:37:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=XIQC+g9JaYt78aJpubTEMWT/cz5ilH7L1mEsvIwcf2s=; b=nU7G5Cn/iwnTvTw0iq3N WIMD6U9l2zRniK1RtyPY+iD/qJ4e92H65a3eiuw94jhel5dW8XVUulTPXOtWEGM4UZIXcohzlEW7M 2k25ur3p1q2vBtgbLRLUFcvZnbDMQQExrs0vZIYn7z/Qgv9s2xaUH9pNguJeTR+BJ7yUGFccbfpwG 3cBzh7AM9a12pZiCIGg8SQCr9U3nsLIRWhX8EkqxYvV7Gu5MUiP3Fj9xLD3LnNzyZZf2Be+YfKOPP m4lI30xC+kKugzJgwinWrqZYHv1pnnwvYQv8c54G1McE3Q+lAwjj/9pmoVYTfgq2RAS4i9sfsuhTf X3gI0DbUfj5LXQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovipY-0006rn-SZ; Thu, 17 Nov 2022 12:37:41 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221027035100.28852-1-maxim.cournoyer@gmail.com> <20221027035100.28852-3-maxim.cournoyer@gmail.com> <87leojon1z.fsf_-_@gnu.org> <877d03xywl.fsf@gmail.com> Date: Thu, 17 Nov 2022 18:37:39 +0100 In-Reply-To: <877d03xywl.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 09 Nov 2022 22:37:46 -0500") Message-ID: <87sfihfpng.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: > >> Maxim Cournoyer skribis: >> >>> * gnu/build/install.scm (evaluate-populate-directive): By default, erro= r when >>> the target of a symlink doesn't exist. Always ensure TARGET ends with = "/". >>> (populate-root-file-system): Call evaluate-populate-directive with >>> #:error-on-dangling-symlink #t and add comment. >> >> [...] >> >>> + (define target* (if (string-suffix? "/" target) >>> + target >>> + (string-append target "/"))) >> >> Maybe make it: >> >> (let ((target (if =E2=80=A6))) >> =E2=80=A6) >> >> so there=E2=80=99s only one =E2=80=98target=E2=80=99 in scope (and no = =E2=80=98target*=E2=80=99); otherwise it=E2=80=99s >> easy to forget the =E2=80=98*=E2=80=99 and refer to wrong one. > > It's a pattern I've used at other places; I find it more hygienic to not > shadow existing variables; it signal to the reader "be careful, this is > not the same as the argument-bound one, though they are closely > related". I don=E2=80=99t buy it. :-) The reader might be careful yet end up using = the =E2=80=9Cwrong=E2=80=9D variable. As long as the =E2=80=9Cwrong=E2=80=9D v= ariable has no use, I think it=E2=80=99s best to shadow it so that mistakes cannot happen. Of course the details vary depending on context, but I think we should not start introducing this pattern in different places. Perhaps something to discuss and codify under =E2=80=9CFormatting Code=E2=80=9D? Ludo=E2=80=99. From unknown Sun Jun 22 04:32:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59164] Coding style: similarly-named variables Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 17 Nov 2022 20:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59164 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 59164@debbugs.gnu.org, 58812@debbugs.gnu.org Received: via spool by 59164-submit@debbugs.gnu.org id=B59164.166871727813982 (code B ref 59164); Thu, 17 Nov 2022 20:35:02 +0000 Received: (at 59164) by debbugs.gnu.org; 17 Nov 2022 20:34:38 +0000 Received: from localhost ([127.0.0.1]:34531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovlao-0003dN-4r for submit@debbugs.gnu.org; Thu, 17 Nov 2022 15:34:38 -0500 Received: from mail-qt1-f176.google.com ([209.85.160.176]:37821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovlal-0003d4-2x; Thu, 17 Nov 2022 15:34:36 -0500 Received: by mail-qt1-f176.google.com with SMTP id l15so1911374qtv.4; Thu, 17 Nov 2022 12:34:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=D8g2H1couwc9wvxak+9BIHQcWcgXJ03zy6cZpvnbnFI=; b=csBQ9koAauuQif8uEUmm7lqs1VtxXVOKl8BCEkh/9Fi8Gdc+lMmktLEo8Tg1U5ZEPh edB0NBt6Pbu/xiZcJA3ZPOf2ldsUB+azRwCO/3ssOu4lxcthXGSJ0NzxRmvM9XPDU4SG N0vkQXX4UFKHTIMT3lNI3SzlofXo3TsG1IL5UuSzCNfI7azBoSLGnT5vWvQVY1ADt1bx otFgsfKWfbJednMG6zpIedEbr7uqvIA7Vr6Oy2DTvzri9kcAuNITggfE5KN2GRpQYBp5 WP96hK9a2oiXVoZc9eWNpyrmRPCWg1yznOpBmDz6wIh3o3prM9hsAjnPN3bBypS43l5L lK+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=D8g2H1couwc9wvxak+9BIHQcWcgXJ03zy6cZpvnbnFI=; b=GWnfykC7H7etgPFnrYDJEYwbkonZZ4EGxeaEYQL3sk5KGT8Lf24/9KFp9Lq8Saj7aN YnAtqRYLSDf7PN563DpkhBYAv1TYH25qToYs/N/w/qpKFELc5Cmf21dHwEbyL2MvtCde 6WUqKdTzHpmiAMLuRWQQRGxahaH+5kre2vfTT/SkhvYsA5VSQshOhWGiZdBcAmXJDaOZ ccT4RPhmRgJUj3DxIIxKsNaYdan3/KD64f3arjdJ7+EUwQQlsdmLEkiUlTHAV4Mjt6TK eWlMu5V0ZZC1086wuJxisU6DXjB411dzjY5gXRmBUGbPmUTMJmBK7f9alKFPRBJpuJGy xMaQ== X-Gm-Message-State: ANoB5plz6IquerI+7fGH1EOvLyekKVyysGhnGyE53+FDhLDiJ4KPXOZ4 rBefJt1P6znvYWIRtt+KGdf4HPVcnNE= X-Google-Smtp-Source: AA0mqf5TVcJ6pZMXnlsLXfADPpfk5dZlSC/1XOxRhLMPnY7zVzSTWeWPx9r2MF1ghDPDr+DWWT34Tg== X-Received: by 2002:ac8:1483:0:b0:39c:bf89:65f0 with SMTP id l3-20020ac81483000000b0039cbf8965f0mr3941924qtj.35.1668717269380; Thu, 17 Nov 2022 12:34:29 -0800 (PST) Received: from hurd (dsl-10-133-21.b2b2c.ca. [72.10.133.21]) by smtp.gmail.com with ESMTPSA id p5-20020ac84605000000b003a55fe9f352sm863559qtn.64.2022.11.17.12.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 12:34:29 -0800 (PST) From: Maxim Cournoyer References: <20221027035100.28852-1-maxim.cournoyer@gmail.com> <20221027035100.28852-3-maxim.cournoyer@gmail.com> <87leojon1z.fsf_-_@gnu.org> <877d03xywl.fsf@gmail.com> <87sfihfpng.fsf_-_@gnu.org> Date: Thu, 17 Nov 2022 15:34:27 -0500 In-Reply-To: <87sfihfpng.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 17 Nov 2022 18:37:39 +0100") Message-ID: <87v8ndtj58.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> Ludovic Court=C3=A8s writes: >> >>> Maxim Cournoyer skribis: >>> >>>> * gnu/build/install.scm (evaluate-populate-directive): By default, err= or when >>>> the target of a symlink doesn't exist. Always ensure TARGET ends with= "/". >>>> (populate-root-file-system): Call evaluate-populate-directive with >>>> #:error-on-dangling-symlink #t and add comment. >>> >>> [...] >>> >>>> + (define target* (if (string-suffix? "/" target) >>>> + target >>>> + (string-append target "/"))) >>> >>> Maybe make it: >>> >>> (let ((target (if =E2=80=A6))) >>> =E2=80=A6) >>> >>> so there=E2=80=99s only one =E2=80=98target=E2=80=99 in scope (and no = =E2=80=98target*=E2=80=99); otherwise it=E2=80=99s >>> easy to forget the =E2=80=98*=E2=80=99 and refer to wrong one. >> >> It's a pattern I've used at other places; I find it more hygienic to not >> shadow existing variables; it signal to the reader "be careful, this is >> not the same as the argument-bound one, though they are closely >> related". > > I don=E2=80=99t buy it. :-) The reader might be careful yet end up usin= g the > =E2=80=9Cwrong=E2=80=9D variable. As long as the =E2=80=9Cwrong=E2=80=9D= variable has no use, I think > it=E2=80=99s best to shadow it so that mistakes cannot happen. I'm surprised you're not buying it, given we're writing Scheme in a more functional style, and mutating same-named variables clearly goes against that style :-). > Of course the details vary depending on context, but I think we should > not start introducing this pattern in different places. Perhaps > something to discuss and codify under =E2=80=9CFormatting Code=E2=80=9D? That's more of a coding style guidelines than "formatting" code (when I read "formatting", I think of a mechanical process like 'guix style' or 'rust-fmt' can do), but yes, that could be nice to have. Better yet, something basic to share across the whole Guile/Scheme community and include in the Guile user manual, like Python has PEP 8 they can refer to, to save every Guile/Scheme project from having to reinvent the wheel. --=20 Thanks, Maxim From unknown Sun Jun 22 04:32:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59164] Coding style: similarly-named variables Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 17 Nov 2022 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59164 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxim Cournoyer Cc: 59164@debbugs.gnu.org, 58812@debbugs.gnu.org Received: via spool by 59164-submit@debbugs.gnu.org id=B59164.166872151320670 (code B ref 59164); Thu, 17 Nov 2022 21:46:02 +0000 Received: (at 59164) by debbugs.gnu.org; 17 Nov 2022 21:45:13 +0000 Received: from localhost ([127.0.0.1]:34552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovmh7-0005NF-2C for submit@debbugs.gnu.org; Thu, 17 Nov 2022 16:45:13 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:51099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovmh4-0005Mv-JG; Thu, 17 Nov 2022 16:45:11 -0500 Received: by mail-wm1-f46.google.com with SMTP id v7so2346744wmn.0; Thu, 17 Nov 2022 13:45:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=PzRSbKNYHGFmGVEiTRsmCY5EiTxuiy/jAs2zx6ddK90=; b=KPFNGPc+FC/NWmPLz0lfBeGw5e2ddkafxrVGeXzgH6jcRnlR/O8zyKEeBnbo9gmiwv tc/jLMJLA7H7PnqYFGpQQIi09YTjpnJYVV9Bmf1I2RFK/0ZPjJQp9cYKIld1Df+j7nnQ YglRcDhd5a6FTkOjZRSqKTVfiRxS2QWlaVoZPQ0fnWN1OAZJZEU7Eh6cj+JuDnGSXRMx tF7TflGo5QHmO6799i/5Uq2a9gEckHOo8XtSFM35kNfweCYHi7vr1QOp/HHDFWI/tRcw lBToaUXNWm0ZWuYz4x/fR2MYP+dfDoRZW1Ho1lyiOidEnx9acqzqXr7tTIu7KkYrj4QO R2Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PzRSbKNYHGFmGVEiTRsmCY5EiTxuiy/jAs2zx6ddK90=; b=2Jlw1awhsiV3Bv/xoI4q8JWF2hMeqvqePDGCpDBcPFxIJ4L4Q/g62Zv9aPUVQG93gk CZY47G/rN0tL3Rck0JHEaSxjyKhu64gd0KI2TtmzXT0wEKgVtAu0uNfxcRCaW6tuG4n8 rQoaozHO4zV2OMq3PKelj76wG6jH8/gqOTBLZXIQdRVPYkXxlwsfxo1ELSdG99qWiGEl UTuPJv2A0cd0YKtJEh53savbEQtk9a8JZOhlzqaBeFT3wW3U6a6VURwaaINTmGB/z97g rU6ukW6I4HEZyPQ2pwu4BKA0xQqt2T51JLPNzalTACBzf84iubSCF9CQJyDipwUMEujW q5HQ== X-Gm-Message-State: ANoB5plJy9pW+llmM+Gf28TvxDtNW8OtWIOkFdR7+p0I8TjdmKnUnDpa Q5YrdF0dYorzz3UPDrEh1NPgIknsszA= X-Google-Smtp-Source: AA0mqf4zHmMFabRqQX4SGm0dM1S//Fffo4VfQRkDWLiuXgjxv8Lt6Waw6FhyxyYk12/hyl9xf5laXA== X-Received: by 2002:a7b:c84a:0:b0:3cf:5d41:b74b with SMTP id c10-20020a7bc84a000000b003cf5d41b74bmr6319729wml.184.1668721503468; Thu, 17 Nov 2022 13:45:03 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id 6-20020a05600c024600b003b50428cf66sm2340271wmj.33.2022.11.17.13.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 13:45:03 -0800 (PST) From: zimoun In-Reply-To: <87sfihfpng.fsf_-_@gnu.org> References: <20221027035100.28852-1-maxim.cournoyer@gmail.com> <20221027035100.28852-3-maxim.cournoyer@gmail.com> <87leojon1z.fsf_-_@gnu.org> <877d03xywl.fsf@gmail.com> <87sfihfpng.fsf_-_@gnu.org> Date: Thu, 17 Nov 2022 19:44:18 +0100 Message-ID: <86zgcpju9p.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, On Thu, 17 Nov 2022 at 18:37, Ludovic =?UTF-8?Q?Court=C3=A8s?= wrote: >> It's a pattern I've used at other places; I find it more hygienic to not >> shadow existing variables; it signal to the reader "be careful, this is >> not the same as the argument-bound one, though [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zimon.toutoune[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.46 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.46 listed in list.dnswl.org] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Hi, On Thu, 17 Nov 2022 at 18:37, Ludovic Court=C3=A8s wrote: >> It's a pattern I've used at other places; I find it more hygienic to not >> shadow existing variables; it signal to the reader "be careful, this is >> not the same as the argument-bound one, though they are closely >> related". > > I don=E2=80=99t buy it. :-) The reader might be careful yet end up usin= g the > =E2=80=9Cwrong=E2=80=9D variable. As long as the =E2=80=9Cwrong=E2=80=9D= variable has no use, I think > it=E2=80=99s best to shadow it so that mistakes cannot happen. > > Of course the details vary depending on context, but I think we should > not start introducing this pattern in different places. Perhaps > something to discuss and codify under =E2=80=9CFormatting Code=E2=80=9D? I agree with Ludo. For another instance than target*, the previous was, --8<---------------cut here---------------start------------->8--- ((new '-> old) [...] - (symlink old (string-append target new))) [...] - (delete-file (string-append target new)) --8<---------------cut here---------------end--------------->8--- then replaced by, --8<---------------cut here---------------start------------->8--- ((new '-> old) [...] + (let ((new* (string-append target* new))) [...] + (error (format #f "symlink `~a' points to nonexis= tent \ +file `~a'" new* old))))) + (symlink old new*)) --8<---------------cut here---------------end--------------->8--- Well, it seems a Star War. ;-) As Ludo, I am not convinced that it is less error-prone, maybe the contrary. Cheers, simon From unknown Sun Jun 22 04:32:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59164] Coding style: similarly-named variables Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Nov 2022 17:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59164 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 59164@debbugs.gnu.org, 58812@debbugs.gnu.org Received: via spool by 59164-submit@debbugs.gnu.org id=B59164.16687909745878 (code B ref 59164); Fri, 18 Nov 2022 17:03:02 +0000 Received: (at 59164) by debbugs.gnu.org; 18 Nov 2022 17:02:54 +0000 Received: from localhost ([127.0.0.1]:38123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow4lR-0001Wf-K7 for submit@debbugs.gnu.org; Fri, 18 Nov 2022 12:02:53 -0500 Received: from mail-qk1-f169.google.com ([209.85.222.169]:38814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow4lP-0001WM-F7; Fri, 18 Nov 2022 12:02:51 -0500 Received: by mail-qk1-f169.google.com with SMTP id s20so3845772qkg.5; Fri, 18 Nov 2022 09:02:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=GZqS0vELfbgnJQqgEuoyKqeSudkJk9ipeJxdZdtd/cs=; b=Sd6xtZ69GR828LndhYUUIomNc+mPCs8XGNLME9KtnKtj1VEgyef+Vd1/HAoPxlepsx zOnNe3yWtPqTVoh2cRRw6n09fbsszPLgXEI97dy+OYyYq4vlxQgmSrB9//diFCiYSn57 o2Ynu61Uzotaat+4QLFJ71ODGwWW4pRIuUT4AJxLvpP85iieqDVOiY0DcoOORlxY4tHy sZsyUbUcCq1nrinXb5w/u3EYDWLJiqEeV5Lg5Z/QuUh6HcK5Q7ljJ0TZqMw8bfznQGS8 pqP5ePTM0Grj9ZgQGSddZFS4ZtmpifL+anDjYndDgdszHGvDBiq0H+G7yVzafzqP/ysd QSMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GZqS0vELfbgnJQqgEuoyKqeSudkJk9ipeJxdZdtd/cs=; b=wGBlRccEo6zndQuqNiHzHxkQIKbhkJTJo2cO+bpTDTv360QGr0dwBtfKLKbAknMPTK f54EC0f4dUJjNYaZDmLt5zOYOfLGax96wvrq6fT2jwrv+mEjIsEJ4f+vHaCIOcJrhGcr f8rDY589aiiPPOvCmqRKJdQ5QdxZvHxv86IP/e+Czl5GT2cehRTXOKQcvjzv9x51pujR 15T1cSnwz6rMtO8zHqPMgj90n9k59B3o221hXENqrS5+mMOUs6pjkeE4j4d1u/AV28sS AO1RSw5Xdeue3zHZ5ZpXMI9gwlgNFlAb4oLDyFwzEUERMrheQ0Un/OS5dAu2uPJyHpgD zonQ== X-Gm-Message-State: ANoB5pngL4nHToaBbeijjGl8uMm+PiZ5EOvwbVKhOOIET054+0L2QFyP HGuDOUTgpW3usFwSPaG4dQe74Vq6gzPZcw== X-Google-Smtp-Source: AA0mqf7EqziDVhlEjMOjAqB5FXv29sGCXgip9eTetG1nOIM/mWoLvICQ24QGu5nI7HM2jD+AW3qQsw== X-Received: by 2002:a37:b96:0:b0:6fa:1031:5b2f with SMTP id 144-20020a370b96000000b006fa10315b2fmr6682368qkl.585.1668790965632; Fri, 18 Nov 2022 09:02:45 -0800 (PST) Received: from hurd (dsl-10-132-210.b2b2c.ca. [72.10.132.210]) by smtp.gmail.com with ESMTPSA id w11-20020a05620a444b00b006fb72dbbaa4sm2736649qkp.27.2022.11.18.09.02.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 09:02:45 -0800 (PST) From: Maxim Cournoyer References: <20221027035100.28852-1-maxim.cournoyer@gmail.com> <20221027035100.28852-3-maxim.cournoyer@gmail.com> <87leojon1z.fsf_-_@gnu.org> <877d03xywl.fsf@gmail.com> <87sfihfpng.fsf_-_@gnu.org> <86zgcpju9p.fsf@gmail.com> Date: Fri, 18 Nov 2022 12:02:44 -0500 In-Reply-To: <86zgcpju9p.fsf@gmail.com> (zimoun's message of "Thu, 17 Nov 2022 19:44:18 +0100") Message-ID: <87y1s82o23.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, zimoun writes: > Hi, > > On Thu, 17 Nov 2022 at 18:37, Ludovic Court=C3=A8s wrote: > >>> It's a pattern I've used at other places; I find it more hygienic to not >>> shadow existing variables; it signal to the reader "be careful, this is >>> not the same as the argument-bound one, though they are closely >>> related". >> >> I don=E2=80=99t buy it. :-) The reader might be careful yet end up usi= ng the >> =E2=80=9Cwrong=E2=80=9D variable. As long as the =E2=80=9Cwrong=E2=80= =9D variable has no use, I think >> it=E2=80=99s best to shadow it so that mistakes cannot happen. >> >> Of course the details vary depending on context, but I think we should >> not start introducing this pattern in different places. Perhaps >> something to discuss and codify under =E2=80=9CFormatting Code=E2=80=9D? > > I agree with Ludo. For another instance than target*, the previous was, > > ((new '-> old) > [...] > - (symlink old (string-append target new))) > [...] > - (delete-file (string-append target new)) > > > then replaced by, > > ((new '-> old) > [...] > + (let ((new* (string-append target* new))) > [...] > + (error (format #f "symlink `~a' points to nonex= istent \ > +file `~a'" new* old))))) > + (symlink old new*)) The intent was to keep away from the following imperative style, which hurts both readability and debuggability in my opinion: --8<---------------cut here---------------start------------->8--- (let* ((my-target "something") (my-target (mutate-once my-target)) (my-target (mutate-twice my-target))) (do-something-with my-target)) --8<---------------cut here---------------end--------------->8--- Perhaps the problem at hand would benefit being broken down in smaller chunks, to avoid having a page-full of code sharing the same scope. --=20 Thanks, Maxim From unknown Sun Jun 22 04:32:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59164] Coding style: similarly-named variables Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Nov 2022 10:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59164 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 59164@debbugs.gnu.org, 58812@debbugs.gnu.org Received: via spool by 59164-submit@debbugs.gnu.org id=B59164.166894117324543 (code B ref 59164); Sun, 20 Nov 2022 10:47:02 +0000 Received: (at 59164) by debbugs.gnu.org; 20 Nov 2022 10:46:13 +0000 Received: from localhost ([127.0.0.1]:42451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owhq0-0006Ni-K0 for submit@debbugs.gnu.org; Sun, 20 Nov 2022 05:46:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owhpx-0006NP-Tk; Sun, 20 Nov 2022 05:46:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owhps-0002nG-K7; Sun, 20 Nov 2022 05:46:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=AooPTJittKMtshp5EuVjLkXx8fWHzSCbkMVx/nIIrhw=; b=iBDKxyNmXsw0UQ/wDKSG g8Llmpirl017MxFQR5E6y5WhVlyYkJZW1gcY6zsxxpdscE+y9QEnczmpbH9YUHYKOuVSCq+Kriajk 7fdQwNn/AgjbGlmTd40CD/VL7rJiMOfVDOKEgK6pK3TvWsCoAxej4kT3pV4B/kT+P5/1Ot9TLtcko GktuPf0roU/5ScHocqfYkngyaRbrdewhq35QoCAT1Ws6+PKEvsiIaV6fjALw1FeFIlLC5ZKdkISqa MOSmbYnYxa8nEAuBOV4jDkTyPe3nF0tqIhBPDXgAdbyogAQ0ueg44l/ZzmPFJHDFi7XgbnqI6Dxqi iJw/umTtdAVHag==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owhps-0004Xx-5R; Sun, 20 Nov 2022 05:46:04 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221027035100.28852-1-maxim.cournoyer@gmail.com> <20221027035100.28852-3-maxim.cournoyer@gmail.com> <87leojon1z.fsf_-_@gnu.org> <877d03xywl.fsf@gmail.com> <87sfihfpng.fsf_-_@gnu.org> <87v8ndtj58.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: =?UTF-8?Q?D=C3=A9cadi?= 30 Brumaire an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Rouleau X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 20 Nov 2022 11:46:00 +0100 In-Reply-To: <87v8ndtj58.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 17 Nov 2022 15:34:27 -0500") Message-ID: <87pmdh7vkn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: [...] >>> It's a pattern I've used at other places; I find it more hygienic to not >>> shadow existing variables; it signal to the reader "be careful, this is >>> not the same as the argument-bound one, though they are closely >>> related". >> >> I don=E2=80=99t buy it. :-) The reader might be careful yet end up usi= ng the >> =E2=80=9Cwrong=E2=80=9D variable. As long as the =E2=80=9Cwrong=E2=80= =9D variable has no use, I think >> it=E2=80=99s best to shadow it so that mistakes cannot happen. > > I'm surprised you're not buying it, given we're writing Scheme in a more > functional style, and mutating same-named variables clearly goes against > that style :-). There=E2=80=99s no mutation here, only lexical scoping. Anyway, I find it = clear that the risk of typing =E2=80=98x=E2=80=99 instead of =E2=80=98x*=E2=80=99= , especially in relatively long functions, justifies shadowing in situations like this one. WDYT? >> Of course the details vary depending on context, but I think we should >> not start introducing this pattern in different places. Perhaps >> something to discuss and codify under =E2=80=9CFormatting Code=E2=80=9D? > > That's more of a coding style guidelines than "formatting" code Sorry I meant =E2=80=9CCoding Style=E2=80=9D, which is the section that doc= uments the project=E2=80=99s conventions. > (when I read "formatting", I think of a mechanical process like 'guix > style' or 'rust-fmt' can do), but yes, that could be nice to have. > Better yet, something basic to share across the whole Guile/Scheme > community and include in the Guile user manual, like Python has PEP 8 > they can refer to, to save every Guile/Scheme project from having to > reinvent the wheel. I won=E2=80=99t do it, but sure, why not! My immediate concern is to make = sure we have a shared understanding, within Guix, of some of the conventions we follow. It=E2=80=99s a minor issue, but minor issues are what our day-t= o-day work is made of. :-) Thanks, Ludo=E2=80=99. From unknown Sun Jun 22 04:32:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59164] [bug#58812] [bug#59164] Coding style: similarly-named variables Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Nov 2022 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59164 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 59164@debbugs.gnu.org, 58812@debbugs.gnu.org Received: via spool by 59164-submit@debbugs.gnu.org id=B59164.166904296931661 (code B ref 59164); Mon, 21 Nov 2022 15:03:02 +0000 Received: (at 59164) by debbugs.gnu.org; 21 Nov 2022 15:02:49 +0000 Received: from localhost ([127.0.0.1]:48450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox8Jt-0008Ea-1a for submit@debbugs.gnu.org; Mon, 21 Nov 2022 10:02:49 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:34633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox8Ji-0008Do-7e; Mon, 21 Nov 2022 10:02:42 -0500 Received: by mail-wr1-f54.google.com with SMTP id s5so3058051wru.1; Mon, 21 Nov 2022 07:02:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=I4Y6SfsgqjKChPZM8JJeYtcbXRrdExtrTZ1SAk97xoQ=; b=jqo95tjL0rm+nb+inIiT/pdbIQWh2gJsuSfpvcAOUQ/XPDhkpntSkePrprpPj96iVK P9G+xXU58QJ7rHls84deosP9BWhB90JI1vtg48Rkz2vsqx062MyxIxz5zF6pMi9sQy2z 3CzTUZ/o9smUZLhgKnTSws4H/cv4fAr8akrM9saNrRjjHjfWK999nhwhCllAkdMXD8Po UbHs4xpssvX6bqZjza5Nnyo60Mvjop8eCojulgWAUFa8DUgFSAEjnTMwEsBBhlc+lF8V ahjL64SgfDTF4LTCJRzX2HQUcxcwESPDhx2ecioWxYaRjFm+CEGXcqIwH7VR+LDpR8cl vu6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I4Y6SfsgqjKChPZM8JJeYtcbXRrdExtrTZ1SAk97xoQ=; b=ATL8H4o8sCcmpwR1uqaSfdvIhTvbQX2HxAVJLsaz/KruJF19CqtcMF9kDbud3GbQPa /H0Q+E8fPM2eSgG9nzERcAwmup7eMN973pwPgXjcztsZp3Q2OX50FXM8O1/soAyLUIEG ELc5rl/Btb/G6gylPX+DrN+esbUcBMNRIonU8Rrq8cVoTriOehtunCO76gZxtmB75wG7 4u4W3BhPrBS0D6GbQLE233T56qwH7kgudWA/RyK5WjqlJUG2cZlI1LezlrXMrb31NXl+ qEDHIi0bfZnDaq+3XIVahOnXmiTsA9J7IDu5ocULB1dS9Nv1RHptijQTA8pMc8PVzWFr Rhmg== X-Gm-Message-State: ANoB5pmc1bwJiiYxhBIb/DM3mpJ9UCm7/+BRb8H3/VcRe0C3OEvLBgS+ XBrvJTZUqBpjAFSSv+0fVQWak6RdPYM= X-Google-Smtp-Source: AA0mqf60WhkqmdZgsN4dUJbgKn9DWFwH+FcURRsEzmkipBxaQDRUgTnQmoEnC0kIDbmcLrN9GMOkuQ== X-Received: by 2002:adf:f8ca:0:b0:241:c933:4b0e with SMTP id f10-20020adff8ca000000b00241c9334b0emr4613716wrq.48.1669042946973; Mon, 21 Nov 2022 07:02:26 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id f3-20020a5d4dc3000000b0022e57e66824sm13111119wru.99.2022.11.21.07.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 07:02:26 -0800 (PST) From: zimoun In-Reply-To: <87y1s82o23.fsf@gmail.com> References: <20221027035100.28852-1-maxim.cournoyer@gmail.com> <20221027035100.28852-3-maxim.cournoyer@gmail.com> <87leojon1z.fsf_-_@gnu.org> <877d03xywl.fsf@gmail.com> <87sfihfpng.fsf_-_@gnu.org> <86zgcpju9p.fsf@gmail.com> <87y1s82o23.fsf@gmail.com> Date: Mon, 21 Nov 2022 16:02:19 +0100 Message-ID: <87zgckwdtw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Fri, 18 Nov 2022 at 12:02, Maxim Cournoyer w= rote: > The intent was to keep away from the following imperative style, which > hurts both readability and debuggability in my opinion: > > --8<---------------cut here---------------start------------->8--- > (let* ((my-target "something") > (my-target (mutate-once my-target)) > (my-target (mutate-twice my-target))) > (do-something-with my-target)) > --8<---------------cut here---------------end--------------->8--- Well, =E2=80=99mutate-*=E2=80=99 is not really mutating. Maybe I miss some= thing and from my understanding, this =E2=80=99let*=E2=80=99reads, --8<---------------cut here---------------start------------->8--- (let ((my-target "something")) (let ((my-target (mutate-once my-target))) (let ((my-target (mutate-twice my-target))) (do-something-with my-target)))) --8<---------------cut here---------------end--------------->8--- and not, --8<---------------cut here---------------start------------->8--- (begin (define my-target "something") (set! my-target (mutate-once my-target)) (set! my-target (mutate-twice my-target)) (do-something-with my-target)) --8<---------------cut here---------------end--------------->8--- Well, the former is =E2=80=99lexical-scope=E2=80=99d so the 3 =E2=80=99my-t= arget=E2=80=99 are not truly an imperative style, I guess. Back to the pattern, you are suggesting to write, --8<---------------cut here---------------start------------->8--- (let* ((my-target "something") (my-target* (mutate-once my-target)) (my-target** (mutate-twice my-target*))) (do-something-with my-target**)) --8<---------------cut here---------------end--------------->8--- well, I am not convinced it helps for readibility. And I think, the pattern is manually doing what =E2=80=99let*=E2=80=99 is already doing for = you. Cheers, simon From unknown Sun Jun 22 04:32:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59164] [bug#58812] [bug#59164] Coding style: similarly-named variables Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Nov 2022 15:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59164 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 59164@debbugs.gnu.org, 58812@debbugs.gnu.org Received: via spool by 59164-submit@debbugs.gnu.org id=B59164.166904598113498 (code B ref 59164); Mon, 21 Nov 2022 15:53:02 +0000 Received: (at 59164) by debbugs.gnu.org; 21 Nov 2022 15:53:01 +0000 Received: from localhost ([127.0.0.1]:48525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox96T-0003VR-07 for submit@debbugs.gnu.org; Mon, 21 Nov 2022 10:53:01 -0500 Received: from mail-wr1-f49.google.com ([209.85.221.49]:45014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox96N-0003V0-4b; Mon, 21 Nov 2022 10:52:59 -0500 Received: by mail-wr1-f49.google.com with SMTP id v1so20455673wrt.11; Mon, 21 Nov 2022 07:52:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=vGu88NGK3bl0EzsaMcsFWCozdy09RqmbXZbPldUaQN4=; b=C1SvSORZhvMOy625ttNmO5SyVJZGFqOzMLb7GsZZX2QZfUh6JJIpbYXX+pbnUXmSeV vNMBZZaiORLHYpkbfu4q8lKdZywT90VIfq7DrxA/DCP83zKDa4L0eiHi6fIvNuR8+apK pJGLYre4KPBQPWtEjLvr13HGpQ0zpz4BPdXlauXqPun+D67JL1pXy4JW9uw+qrA52fsV nCvkP1dRSH/6RhG5TrHbGs+sah4cTcH0XamW+Zj0QS7pEAnZAhQ/MUgSe5YlqnZVu1Ja nzy+P4C3ht3LLzXrYZgyeip5sJ5HxYwZ1wd3TG1fYemU/5tyd21q8lUJXl/O4SVfeUFg CQxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vGu88NGK3bl0EzsaMcsFWCozdy09RqmbXZbPldUaQN4=; b=VXtvbuatTx7NUTKySiXaDrRTQlD6xEYYvviFcCvNeCQEuUB91uqIQb/2j8V0Ta31g1 A7rK2+Y1J/qo3PWc38lg1eD4Yhnt7EeaM9YA3LNnBavxQ4efAYgfYMFltQ5q5TaLlUtv 1ER/lefVgYjtANOi+SYLbEGpYkCHFVAolCZX7n2Y01URDPVjB6uWl1mrCtyWu/NWL+S0 6fHSxDgTNafjkORQYXMR5mVhLOsUAiZ3JK51u0ft98eDpDvdwjBZE0x9vQNrn9HEVp69 MPPdFWnew4qJ1xr6fYT5j07okJyhLb2MXzReXobp2jPDHnSyOy7HbR7os4KC4qeigYyE YdYQ== X-Gm-Message-State: ANoB5pm2+xen2w2JpmrLSiGNfmYue6PWrzLIfcnKGmxl8Ff0DtiyUggy ISja1F347tFFOSGgchJiXJwMDWKR4VQ= X-Google-Smtp-Source: AA0mqf5nngtEgjGP+lRHIQ5QkexNG0jamjoqMAb49Kkt7KHj6ViOjAQqj3A4HIabOXzCHvvP0UlSrw== X-Received: by 2002:a5d:6acf:0:b0:22e:224c:3443 with SMTP id u15-20020a5d6acf000000b0022e224c3443mr11575190wrw.361.1669045969019; Mon, 21 Nov 2022 07:52:49 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id f12-20020a7bc8cc000000b003c64c186206sm13746386wml.16.2022.11.21.07.52.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 07:52:48 -0800 (PST) From: zimoun In-Reply-To: <87zgckwdtw.fsf@gmail.com> References: <20221027035100.28852-1-maxim.cournoyer@gmail.com> <20221027035100.28852-3-maxim.cournoyer@gmail.com> <87leojon1z.fsf_-_@gnu.org> <877d03xywl.fsf@gmail.com> <87sfihfpng.fsf_-_@gnu.org> <86zgcpju9p.fsf@gmail.com> <87y1s82o23.fsf@gmail.com> <87zgckwdtw.fsf@gmail.com> Date: Mon, 21 Nov 2022 16:52:44 +0100 Message-ID: <87mt8kwbhv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, 21 Nov 2022 at 16:02, zimoun wrote: > Well, =E2=80=99mutate-*=E2=80=99 is not really mutating. Maybe I miss so= mething and > from my understanding, this =E2=80=99let*=E2=80=99reads, > > --8<---------------cut here---------------start------------->8--- > (let ((my-target "something")) > (let ((my-target (mutate-once my-target))) > (let ((my-target (mutate-twice my-target))) > (do-something-with my-target)))) > --8<---------------cut here---------------end--------------->8--- Well, it compiles to something similar=E2=80=A6 > And I think, the > pattern is manually doing what =E2=80=99let*=E2=80=99 is already doing fo= r you. =E2=80=A6for instance, it reads, --8<---------------cut here---------------start------------->8--- scheme@(guix-user)> (macroexpand '(let* ((my-target "something") (my-target (mutate-once my-target)) (my-target (mutate-twice my-target))) (do-something-with my-target))) $1=3D # --8<---------------cut here---------------end--------------->8--- Cheers, simon From unknown Sun Jun 22 04:32:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59164] [bug#58812] [bug#59164] Coding style: similarly-named variables Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Nov 2022 20:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59164 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 59164@debbugs.gnu.org, 58812@debbugs.gnu.org Received: via spool by 59164-submit@debbugs.gnu.org id=B59164.166906415725276 (code B ref 59164); Mon, 21 Nov 2022 20:56:02 +0000 Received: (at 59164) by debbugs.gnu.org; 21 Nov 2022 20:55:57 +0000 Received: from localhost ([127.0.0.1]:48982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxDpd-0006ZW-8a for submit@debbugs.gnu.org; Mon, 21 Nov 2022 15:55:57 -0500 Received: from mail-qk1-f178.google.com ([209.85.222.178]:45749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxDpZ-0006ZD-TO; Mon, 21 Nov 2022 15:55:54 -0500 Received: by mail-qk1-f178.google.com with SMTP id v8so8909911qkg.12; Mon, 21 Nov 2022 12:55:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=f2BQH21an7hjWbLnErDeQIITcwak8jyouTcuX/SktR8=; b=jOSN5QfQl4uqW2nq4rmt8zgR4g4ZS2SzqTC4oy3fM46x6CTYMnF2PTQ+B7ip9RGSnp Mwx5+14iRKhwVEaPbFh5ckNiPFcsVnuUGO5x57+6BmrqUBnr8iuIW6Tm5cPLIvhCrLtj pDuZVZ8f0Z9xPslRYMako+HSIh1GcPpLNcR99OofYoP/FV7lXI6cZgLAi6AOgATyvp2G C6g7B1Txp7bi0pIMt+Jg/U6GmcivpWa8fKNAx+bQ61BEGudRnAlvYU74daZVZkE19w7Q +86Fx3FHlUR2CT72N/rV4iDWlyIrDFVeaKFZK0UdCLJ8UHyTmqOMu9o8MdN5A8ps5iLs OV6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=f2BQH21an7hjWbLnErDeQIITcwak8jyouTcuX/SktR8=; b=NE6oCL30lHI19QLQwA91GQpmm9sgxG9DGu4T7Gfudbx7MfopT9ksW9AZ9RPJu6OuDR +kwTtCw00q7IvYCu9jYiq9v6rPvaGbfau2ozNPdPu902ymdQLsvq7ErizXcjv19MfLbx 3iC1BaQRS/jjwlvGBljrZ3pO6m3ECn9pnv0yQq1Rgduz+q8kLW39WrlnlYnjVxFjcLab ftCXgfMmcjE55eTFDYS9a1siG33L+LcxnjelVcBewgOjyCzHSSHx6GGixPjWJCw/r7Wb xWFqnnwg6WLEOHaDkWB+ikaEMDcZiZzoW0anoYao5nfGlqmo7O2w3Y9E2AXpzsISZ4oe fIeg== X-Gm-Message-State: ANoB5pmKz3eXytCXkJ/o7zb2GYIXn8cIgiLa6YFX331d+EWR3b0Exz6c NTKb908k3EkcqmXn5cKwr47KPsrA7Tk= X-Google-Smtp-Source: AA0mqf5xo9+hsxIljoKwTGqTH2y9w2XYzrGq8UqIRUgOGjYcXA1U8m5jv+KxfVNiigwBUhdVllIgyw== X-Received: by 2002:a37:44ce:0:b0:6fa:4335:5793 with SMTP id r197-20020a3744ce000000b006fa43355793mr666636qka.242.1669064148020; Mon, 21 Nov 2022 12:55:48 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1003]) by smtp.gmail.com with ESMTPSA id m14-20020ac85b0e000000b003a591194221sm7445908qtw.7.2022.11.21.12.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 12:55:47 -0800 (PST) From: Maxim Cournoyer References: <20221027035100.28852-1-maxim.cournoyer@gmail.com> <20221027035100.28852-3-maxim.cournoyer@gmail.com> <87leojon1z.fsf_-_@gnu.org> <877d03xywl.fsf@gmail.com> <87sfihfpng.fsf_-_@gnu.org> <86zgcpju9p.fsf@gmail.com> <87y1s82o23.fsf@gmail.com> <87zgckwdtw.fsf@gmail.com> Date: Mon, 21 Nov 2022 15:55:46 -0500 In-Reply-To: <87zgckwdtw.fsf@gmail.com> (zimoun's message of "Mon, 21 Nov 2022 16:02:19 +0100") Message-ID: <87sficqb71.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Simon, zimoun writes: > Hi Maxim, > > On Fri, 18 Nov 2022 at 12:02, Maxim Cournoyer = wrote: > >> The intent was to keep away from the following imperative style, which >> hurts both readability and debuggability in my opinion: >> >> --8<---------------cut here---------------start------------->8--- >> (let* ((my-target "something") >> (my-target (mutate-once my-target)) >> (my-target (mutate-twice my-target))) >> (do-something-with my-target)) >> --8<---------------cut here---------------end--------------->8--- > > Well, =E2=80=99mutate-*=E2=80=99 is not really mutating. Maybe I miss so= mething and > from my understanding, this =E2=80=99let*=E2=80=99reads, > > (let ((my-target "something")) > (let ((my-target (mutate-once my-target))) > (let ((my-target (mutate-twice my-target))) > (do-something-with my-target)))) > > > and not, > > (begin > (define my-target "something") > (set! my-target (mutate-once my-target)) > (set! my-target (mutate-twice my-target)) > (do-something-with my-target)) Right. I used "mutated" where I should have used "shadowed by lexical scoping". The outcome for me is the same; the original value of an argument (target) in the code gets shadowed, thus is theory it becomes more difficult to inspect its original value, should we have a debugger that is able to stop at the place to inspect to print ',locals'. In practice since using breakpoints/a debugger to debug Guile code rarely works as intended (in my experience hacking on Guix!), we typically sprinkle the source with 'pk', and that point becomes moot. > Well, the former is =E2=80=99lexical-scope=E2=80=99d so the 3 =E2=80=99my= -target=E2=80=99 are not truly > an imperative style, I guess. > > Back to the pattern, you are suggesting to write, > > (let* ((my-target "something") > (my-target* (mutate-once my-target)) > (my-target** (mutate-twice my-target*))) > (do-something-with my-target**)) > well, I am not convinced it helps for readibility. And I think, the > pattern is manually doing what =E2=80=99let*=E2=80=99 is already doing fo= r you. The value it provides is that it becomes easy to inspect each intermediary result in a debugger. I think we're done expressing the arguments to have on both sides, which aren't too strong either ways :-). I'm happy to restrain myself using such a pattern and keep moving forward. --=20 Thanks, Maxim From unknown Sun Jun 22 04:32:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59164] [bug#58812] [bug#59164] Coding style: similarly-named variables Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 Nov 2022 15:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59164 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 59164@debbugs.gnu.org, 58812@debbugs.gnu.org Received: via spool by 59164-submit@debbugs.gnu.org id=B59164.166913165017340 (code B ref 59164); Tue, 22 Nov 2022 15:41:02 +0000 Received: (at 59164) by debbugs.gnu.org; 22 Nov 2022 15:40:50 +0000 Received: from localhost ([127.0.0.1]:52316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxVOD-0004VW-LP for submit@debbugs.gnu.org; Tue, 22 Nov 2022 10:40:49 -0500 Received: from mail-wm1-f43.google.com ([209.85.128.43]:42592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxVO9-0004V2-5C; Tue, 22 Nov 2022 10:40:47 -0500 Received: by mail-wm1-f43.google.com with SMTP id p13-20020a05600c468d00b003cf8859ed1bso11594948wmo.1; Tue, 22 Nov 2022 07:40:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=4OnFDgr+/AMD5/lfU/rs6H1Y3g/sM8f/bcP4gw2gN7Q=; b=SPedOGtJBUd8CDEEp12rt5H3dmidYw9vi5kF7uEH7OVDNa3bo6yDTnRYyr8b2lC97b nqW46KkuFRvmm/Al1UMCmcaI1pXUilAz/0A//g8Z1OetOkhk/q/Y2FLUMRzHjrDmy1FI fcPlWSSfTclq6g3vDDAZvH0BBiqhBxy6kVcO1y1gLK3glp6+2uHzL/EkGV1ZK+dIx5L9 uL1mhr5gtyBGjrFeXcHrXg8lm0n/ZiEIje+IKu2TnrYBb803jfzCqa2TAY2ytwNqp4Ga UOZHtNDAn85FtIcII3YSzlZIYHbh4g3Lw38kHNTfHvIHFxuWatmnr2AF2Es9I7lJkAQV IFkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4OnFDgr+/AMD5/lfU/rs6H1Y3g/sM8f/bcP4gw2gN7Q=; b=H6EDcer8xyS6CSbPsVUbDu/Ej5BWEnll8lYj6LuPtFMWvk7BZAA5t0TBRyPVJvw34C buUGEfCLRMM+B+a7+oqsJawUsb5gdL6/p7C0iKubk9SsoVEzMDkSlym7E7NdFOqhCn4y ViVN5jOgHmzIUvzpYXb7bW6mGulAx91fnYx/PYwTJa0X+xwr+dba2EyzKaTC5M1XfMN4 ukHU5DdMJmW2a33O4wHj4brVWZTZhmLrw1yqS5g7nX6RDzHsj5NAmPK9kLnhyKlsYMQp P/sjxC7Y/S2EUmateVPKCq60G4iFDZdogvLah3yRG3GpgaOErQSXPBMcMu8s2/YLq5g6 YcgA== X-Gm-Message-State: ANoB5pmXDZODj7P9/0rDlir1WYxWCEyUhd2TpBCVoopV1oCwcedwT9YK FhFynZ00zxbc2ZwgOzHgia1y4+zM3Gk= X-Google-Smtp-Source: AA0mqf62Hoze0YFLbO6CJJKGUvyBkvsd8Qplym/vfbrgmzijU+U1QQND3V824qoffeA6DMFZiUkIFA== X-Received: by 2002:a1c:ed01:0:b0:3cf:7d41:f2bb with SMTP id l1-20020a1ced01000000b003cf7d41f2bbmr4665002wmh.62.1669131639045; Tue, 22 Nov 2022 07:40:39 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id g17-20020a05600c4ed100b003c701c12a17sm25163065wmq.12.2022.11.22.07.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 07:40:38 -0800 (PST) From: zimoun In-Reply-To: <87sficqb71.fsf@gmail.com> References: <20221027035100.28852-1-maxim.cournoyer@gmail.com> <20221027035100.28852-3-maxim.cournoyer@gmail.com> <87leojon1z.fsf_-_@gnu.org> <877d03xywl.fsf@gmail.com> <87sfihfpng.fsf_-_@gnu.org> <86zgcpju9p.fsf@gmail.com> <87y1s82o23.fsf@gmail.com> <87zgckwdtw.fsf@gmail.com> <87sficqb71.fsf@gmail.com> Date: Tue, 22 Nov 2022 15:35:30 +0100 Message-ID: <86fsebdpl9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Mon, 21 Nov 2022 at 15:55, Maxim Cournoyer w= rote: > In practice since using breakpoints/a debugger to debug Guile code > rarely works as intended (in my experience hacking on Guix!), we > typically sprinkle the source with 'pk', and that point becomes moot. I totally agree! Preparing some materials for introducing Guile to GuixHPC folk, I am trying to collect some tips and, if I am honest, the debugging experience with Guile is really poor; compared to others (as Python). For example, DrRacket provides an easy and nice user experience [1] =E2=80=93 where it is easy to compare each intermediary resu= lt in the debugger. For what it is worth, I have not been able to have some similar inspections as in [1]. Maybe, I am missing something=E2=80=A6 Well, IMHO, we are somehow suffering from some Guile limitations and improvements in this area are an hard task. Cheers, simon Short video demoing (link will be dead after 2022-12-07) 1: https://filesender.renater.fr/?s=3Ddownload&token=3D92d4312a-91b4-402e-8= 98a-40ce01a5c3ed From unknown Sun Jun 22 04:32:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#59164] [bug#58812] [bug#59164] Coding style: similarly-named variables Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 26 Nov 2022 14:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59164 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 59164@debbugs.gnu.org, Maxim Cournoyer , 58812@debbugs.gnu.org Received: via spool by 59164-submit@debbugs.gnu.org id=B59164.166947406121907 (code B ref 59164); Sat, 26 Nov 2022 14:48:02 +0000 Received: (at 59164) by debbugs.gnu.org; 26 Nov 2022 14:47:41 +0000 Received: from localhost ([127.0.0.1]:38352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oywSy-0005hD-Lg for submit@debbugs.gnu.org; Sat, 26 Nov 2022 09:47:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oywSx-0005gl-CY; Sat, 26 Nov 2022 09:47:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oywSs-0007dV-4V; Sat, 26 Nov 2022 09:47:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=pXhHo9+CVvQAVWtIQsYZk2Is/Xw+D53l5GQ4hF1jA5k=; b=rAaFGDtb9TxkQH3Sd9Qm U9G1EIy2HUneTm8daNmfiCMTnApaqpIHduib2EtfZU48gRsBdu01MmQz2Uq7bJm4PGzPienw6yYTc mPb0OCRXbPnHRJwVFzBCE09hI/Dk6UEyP5q3M47I+k7ixKqA51+ITYlz0Cnqf9Aqu/90LWPitqDgl T/oc+lqrhQ99NYdvABjsviMQBOiSQQiX5F+dJos+zW8+MZe5ggtQ3eUNA8dtt/mVqFFDnBGWLoomO dRlK1bkJnqjV3ejHmRWBWSgxVihnqWiVHXKqCc/7X5n+zFtesicQazbIA3vuooNEkQRckMTyYfH7f OIyzHG30IzmOgg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oywSr-0003ig-Ob; Sat, 26 Nov 2022 09:47:33 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221027035100.28852-1-maxim.cournoyer@gmail.com> <20221027035100.28852-3-maxim.cournoyer@gmail.com> <87leojon1z.fsf_-_@gnu.org> <877d03xywl.fsf@gmail.com> <87sfihfpng.fsf_-_@gnu.org> <86zgcpju9p.fsf@gmail.com> <87y1s82o23.fsf@gmail.com> <87zgckwdtw.fsf@gmail.com> <87sficqb71.fsf@gmail.com> <86fsebdpl9.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Sextidi 6 Frimaire an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour de la =?UTF-8?Q?M=C3=A2che?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 26 Nov 2022 15:47:31 +0100 In-Reply-To: <86fsebdpl9.fsf@gmail.com> (zimoun's message of "Tue, 22 Nov 2022 15:35:30 +0100") Message-ID: <87pmd993i4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, zimoun skribis: > I totally agree! Preparing some materials for introducing Guile to > GuixHPC folk, I am trying to collect some tips and, if I am honest, the > debugging experience with Guile is really poor; compared to others (as > Python). For example, DrRacket provides an easy and nice user > experience [1] =E2=80=93 where it is easy to compare each intermediary re= sult in > the debugger. For what it is worth, I have not been able to have some > similar inspections as in [1]. Maybe, I am missing something=E2=80=A6 Looking at the video you posted, I better understand what debugging features we=E2=80=99re talking about. DrRacket is the gold standard; here = it does something similar to what we have with in Elisp with EDebug, which is certainly useful. It may be more of a limitation of Geiser than of Guile. I find it more useful in =E2=80=9Ctypical=E2=80=9D imperative ELisp code than in functiona= l Scheme code, but it=E2=80=99d be nice to have either way! Ludo=E2=80=99.