GNU bug report logs - #59158
[PATCH] vc-git: Ensure git doesn't try to colorize stashes

Previous Next

Package: emacs;

Reported by: Morgan Smith <Morgan.J.Smith <at> outlook.com>

Date: Wed, 9 Nov 2022 21:23:02 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #19 received at control <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>, 59158 <at> debbugs.gnu.org
Subject: Re: bug#59158: [PATCH] vc-git: Ensure git doesn't try to colorize
 stashes
Date: Sat, 12 Nov 2022 11:41:54 -0800
close 59158 29.1
thanks

Juri Linkov <juri <at> linkov.net> writes:

>> However, as Emacs can't process those control characters in any case, I
>> think we might as well apply the patch you suggest.  This will save
>> users from shooting themselves in the foot.
>>
>> Does anyone see any reason not to?
>
> Since --color=never doesn't look like a new option of git diff,
> it should be pretty safe to apply the patch.

OK, pushed to master (commit 4ccc385ab1).




This bug report was last modified 2 years and 249 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.