From unknown Sun Aug 17 00:57:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59153 <59153@debbugs.gnu.org> To: bug#59153 <59153@debbugs.gnu.org> Subject: Status: List project buffers Reply-To: bug#59153 <59153@debbugs.gnu.org> Date: Sun, 17 Aug 2025 07:57:24 +0000 retitle 59153 List project buffers reassign 59153 emacs submitter 59153 Juri Linkov severity 59153 wishlist tag 59153 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 09 12:43:08 2022 Received: (at submit) by debbugs.gnu.org; 9 Nov 2022 17:43:08 +0000 Received: from localhost ([127.0.0.1]:40826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osp6S-0003Vc-4X for submit@debbugs.gnu.org; Wed, 09 Nov 2022 12:43:08 -0500 Received: from lists.gnu.org ([209.51.188.17]:33052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osp6Q-0003VU-A0 for submit@debbugs.gnu.org; Wed, 09 Nov 2022 12:43:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osp6Q-0005LY-59 for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 12:43:06 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osp6N-0003bM-1H for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 12:43:05 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 571FBC0002 for ; Wed, 9 Nov 2022 17:42:57 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: List project buffers Organization: LINKOV.NET Date: Wed, 09 Nov 2022 19:40:02 +0200 Message-ID: <86a650t4b1.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=217.70.183.198; envelope-from=juri@linkov.net; helo=relay6-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Version: 29.0.50 Severity: wishlist Tags: patch There are project commands and keys corresponding to the most useful buffer commands: C-x k (kill-buffer) - C-x p k (project-kill-buffers) C-x b (switch-to-buffer) - C-x p b (project-switch-to-buffer) What is still missing is a command to list project buffers: C-x C-b (list-buffers) - C-x p C-b (project-list-buffers) project-kill-buffers already shows a list of project buffers, but only as a part of confirmation for killing buffers. Here is a patch that adds the missing command. Its argument has exactly the same meaning as in 'list-buffers'. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=project-list-buffers.patch diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index fc035675cec..e6f9dd750e7 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -713,6 +713,7 @@ project-prefix-map (define-key map "G" 'project-or-external-find-regexp) (define-key map "r" 'project-query-replace-regexp) (define-key map "x" 'project-execute-extended-command) + (define-key map "\C-b" 'project-list-buffers) map) "Keymap for project commands.") @@ -1223,6 +1224,25 @@ project-display-buffer-other-frame (interactive (list (project--read-project-buffer))) (display-buffer-other-frame buffer-or-name)) +;;;###autoload +(defun project-list-buffers (&optional arg) + "Display a list of project buffers. +The list is displayed in a buffer named \"*Buffer List*\". + +By default, all buffers are listed except those whose names start +with a space (which are for internal use). With prefix argument +ARG, show only buffers that are visiting files." + (interactive "P") + (let* ((pr (project-current t)) + (bufs (mapcan + (lambda (buf) + (when (and (project--buffer-check buf '("\\`[^ ]")) + (or (not arg) + (project--buffer-check buf '(buffer-file-name)))) + (list buf))) + (project-buffers pr)))) + (display-buffer (list-buffers-noselect arg bufs)))) + (defcustom project-kill-buffer-conditions '(buffer-file-name ; All file-visiting buffers are included. ;; Most of temp and logging buffers (aside from hidden ones): @@ -1283,6 +1303,7 @@ project-kill-buffers-display-buffer-list :package-version '(project . "0.8.2") :safe #'booleanp) +;; UNUSED? (defun project--buffer-list (pr) "Return the list of all buffers in project PR." (let ((conn (file-remote-p (project-root pr))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 09 13:02:23 2022 Received: (at 59153) by debbugs.gnu.org; 9 Nov 2022 18:02:23 +0000 Received: from localhost ([127.0.0.1]:40845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ospP5-00042u-7q for submit@debbugs.gnu.org; Wed, 09 Nov 2022 13:02:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ospP2-00042c-H6 for 59153@debbugs.gnu.org; Wed, 09 Nov 2022 13:02:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ospOb-0004iK-Ov; Wed, 09 Nov 2022 13:02:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+lMB64SzyvVtPYr8cNlmSyf4NSqByZYpQmC6ILQL1Us=; b=okzw+gA4brgW mvUdlFTOhtXwJSdBjhyJ7q1fERe11ak0BA1P01C8GalIcD0qacZjFQv3zBtjkHUdQQhbZoYBm8lar /SRxd14EIQAQQfAvdcIY3spIlREpxT3kKvVOLmLNYzzYXSLW57Z+qyggTXkuum/j378KGd+y3Bvvg ONxJyh3Q/WWza3h6B6hBfpiHoUphD6ZCtQ5UeiT0ZdnDCewA7QTje4jctITxHB1zFHvpW4rq+gMIk /zz3Ydkj91RrhS8jfxb/XGU2+QcK01gEPioFdwSF7aKAxSZZ/2hJ3ZQxVP0rDfglQ9Tc8MJmf4bYS qwmH0szz+O3MEKoVY6KRQw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ospOX-0000sk-Mv; Wed, 09 Nov 2022 13:01:52 -0500 Date: Wed, 09 Nov 2022 20:01:47 +0200 Message-Id: <838rkkt3as.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <86a650t4b1.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 09 Nov 2022 19:40:02 +0200) Subject: Re: bug#59153: List project buffers References: <86a650t4b1.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Wed, 09 Nov 2022 19:40:02 +0200 > > +By default, all buffers are listed except those whose names start ^^^^^^^^^^^ Suggest to say "all project buffers", otherwise this could be misinterpreted. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 02:45:47 2022 Received: (at 59153) by debbugs.gnu.org; 10 Nov 2022 07:45:47 +0000 Received: from localhost ([127.0.0.1]:41767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot2Fu-0001ax-TJ for submit@debbugs.gnu.org; Thu, 10 Nov 2022 02:45:47 -0500 Received: from knopi.disroot.org ([178.21.23.139]:37712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot2Fs-0001an-LV for 59153@debbugs.gnu.org; Thu, 10 Nov 2022 02:45:45 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id ECEFC41090; Thu, 10 Nov 2022 08:45:42 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kcjfxmL0oI4H; Thu, 10 Nov 2022 08:45:41 +0100 (CET) From: Akib Azmain Turja DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1668066341; bh=xwiFJZzGn6JOWDFp/jqurgDA7NG3liyNGR7WCsrlo2k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=K9EIiwN03e7VJRtnM/ALbsv7DSUPXdiR+7FUoa0GWdXj6SKCeczE3di0dxPNSS+g9 I6zVgo7KZkTOfn3/oKv/fGPzH4TOOt0l9oRmYiExtNkqWqt8syOui6ih79b9wq2IDd 1EK73vE8QxIZLUfdoCDlm0YYT3bnYeIUU4K8BhSTOna7uwSCUwO3H+PgFXw9RUEzbW PBhhuniz7+m4RLCthDhoSObZ1/c5BjjW31Cj8eg1NVtgwrctVI7b53KjHcCadA1LQP 4k78DU1oZ/ARs4QZMcLdNuOdQ2k9Ji/iRWjKVGvP7oeTxg4Mg/Vkt/VnAiOUGrGfzp cXaERalJWl5Zw== To: Juri Linkov Subject: Re: bug#59153: List project buffers In-Reply-To: <86a650t4b1.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 09 Nov 2022 19:40:02 +0200") References: <86a650t4b1.fsf@mail.linkov.net> Date: Thu, 10 Nov 2022 01:22:30 +0600 Message-ID: <87mt90lyq1.fsf@disroot.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Juri Linkov writes: > What is still missing is a command to list project buffers: > > C-x C-b (list-buffers) - C-x p C-b (project-list-buffers) > > project-kill-buffers already shows a list of project buffers, > but only as a part of confirmation for killing buffers. > > Here is a patch that adds the missing command. Its argument > has exactly the same meaning as in 'list-buffers'. >=20=20 > +;;;###autoload > +(defun project-list-buffers (&optional arg) > + "Display a list of project buffers. > +The list is displayed in a buffer named \"*Buffer List*\". > + > +By default, all buffers are listed except those whose names start > +with a space (which are for internal use). With prefix argument > +ARG, show only buffers that are visiting files." > + (interactive "P") > + (let* ((pr (project-current t)) > + (bufs (mapcan > + (lambda (buf) > + (when (and (project--buffer-check buf '("\\`[^ ]")) > + (or (not arg) > + (project--buffer-check buf '(buffer-fil= e-name)))) > + (list buf))) > + (project-buffers pr)))) > + (display-buffer (list-buffers-noselect arg bufs)))) This won't survive a revert buffer, I think. (I'll show all buffers then.) =2D-=20 Akib Azmain Turja, GPG key: 70018CE5819F17A3BBA666AFE74F0EFA922AE7F5 Fediverse: akib@hostux.social Codeberg: akib emailselfdefense.fsf.org | "Nothing can be secure without encryption." --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEyVTKmrtL6kNBe3FRVTX89U2IYWsFAmNr/fcACgkQVTX89U2I YWs2ihAAnwRYjWrXhL8cNr8wmRgavoHkdgDOUwDbCu1gTtI34k+9IYrB8nDfidTo P3HgS5Gl1GM7zmOHFfBYjWe9tybyx17jwUW4QEN1CdiXV0zPRGIORKN0gBHFSuNL TUBR3b/jCTP9OV1wouxPue4H7vaQn9cKBlRPgWej00fsrBoikLgYMlUJ4j6v8c+F t/1aDtwi8T/aLVNlleOnfEyCBc8Ou7xK5OSPA0Ldv4EeZKsbZnQUfNMiZrOMrerB i/d/LKlHrW4L0AByJLSnQTwm49sMhMDQ/VkrAw7TTd16nnebzb1pWJcPPHx0MRJY MWyOUYqvFzSPpsYRY3zBDCt9rqAMOEQywAY2WsmXqsBZMiZJ6giGwQ/qpyNpV4ME 9Lt50DUjXVAvB/kdmKI9WCW1S330GYqkmH4cMqDz2CU2LJiVFPLIMXL/fKu0bm4K b+UDUjMQstRD7vIxOemH7+S8E0SUaLGdHXhtIWTM7+x15ATML7qVcHGIv5feCWG9 t6mnB7uRrtlg5mj2WWpaL4CQL11cGrCEwzT7D1vuH67ya4wGgdYuG/6b97MfdT1n PQU8IwkL1wLHowD7ONnSHSrF1dV8SPaznBp3CTqd0L8x+nEGPyVgdK05SrcRWwmr J3brvK9TeYWDs59tiQJr75mGFSjc/NtUizeCzsPkTYEWtD2fQUE= =K4fv -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 03:08:44 2022 Received: (at 59153) by debbugs.gnu.org; 10 Nov 2022 08:08:44 +0000 Received: from localhost ([127.0.0.1]:41800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot2c8-0002Bv-JI for submit@debbugs.gnu.org; Thu, 10 Nov 2022 03:08:44 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:54033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot2c6-0002BO-T9 for 59153@debbugs.gnu.org; Thu, 10 Nov 2022 03:08:43 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 74A16240004; Thu, 10 Nov 2022 08:08:34 +0000 (UTC) From: Juri Linkov To: Akib Azmain Turja Subject: Re: bug#59153: List project buffers In-Reply-To: <87mt90lyq1.fsf@disroot.org> (Akib Azmain Turja's message of "Thu, 10 Nov 2022 01:22:30 +0600") Organization: LINKOV.NET References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> Date: Thu, 10 Nov 2022 09:56:01 +0200 Message-ID: <8635arqllm.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> + (bufs (mapcan >> + (lambda (buf) >> + (when (and (project--buffer-check buf '("\\`[^ ]")) >> + (or (not arg) >> + (project--buffer-check buf '(buffer-file-name)))) >> + (list buf))) >> + (project-buffers pr)))) >> + (display-buffer (list-buffers-noselect arg bufs)))) > > This won't survive a revert buffer, I think. (I'll show all buffers > then.) This means that all uses of the BUFFER-LIST arg of 'list-buffers-noselect' are flawed. So better would be to provide not a list of buffers, but a predicate to filter out a list of buffers. Then the revert could use such a predicate from e.g. a buffer-local variable. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 07:30:57 2022 Received: (at 59153) by debbugs.gnu.org; 10 Nov 2022 12:30:58 +0000 Received: from localhost ([127.0.0.1]:42201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot6ht-0000vB-BW for submit@debbugs.gnu.org; Thu, 10 Nov 2022 07:30:57 -0500 Received: from knopi.disroot.org ([178.21.23.139]:39180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot6hb-0000Qg-TX for 59153@debbugs.gnu.org; Thu, 10 Nov 2022 07:30:55 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 2E26B4124B; Thu, 10 Nov 2022 13:30:38 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R6JUBE6MHIqx; Thu, 10 Nov 2022 13:30:35 +0100 (CET) From: Akib Azmain Turja DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1668083434; bh=zE96MNK8FIQGP0Ni31ylk/7h5adm1LusHVkzvRzGkhM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HeiXAbrFQkWIqMyDKMhAmTadhJvOmlZ44wWEjqnEYEsU3FJYQ5yb5W7rx7UoIu8i9 Bl6TOpu5JXgvl2heZY/l1MCo0y3a0vWz+yqhEn4NRtbIw8Motfr1fv9BvrCZQMOE7l t6+ArpBjAx+j6qAYmzhFX/f/jPaSiahzyFMnzWz6W5eZA9GeH3yi+xYbOcMNY7/cY+ Vl/6gd1ba1L/Qx/ktMs+hgY3smJVgG4iD5NiLRmee33YcMTs3HufMm1KhVqBUEXDI8 +b22vzFQna12SIZsYgJG0PPFl5HoapcoT30wVBzY8Camr1DXHGil8k8mzg5/AF83pJ zXsw8frXTAdYg== To: Juri Linkov Subject: Re: bug#59153: List project buffers In-Reply-To: <8635arqllm.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 10 Nov 2022 09:56:01 +0200") References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> Date: Thu, 10 Nov 2022 14:56:53 +0600 Message-ID: <87bkpfjiga.fsf@disroot.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Juri Linkov writes: >>> + (bufs (mapcan >>> + (lambda (buf) >>> + (when (and (project--buffer-check buf '("\\`[^ ]")) >>> + (or (not arg) >>> + (project--buffer-check buf '(buffer-file-name)))) >>> + (list buf))) >>> + ( [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date 0.0 T_SPF_TEMPERROR SPF: test of record failed (temperror) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Juri Linkov writes: >>> + (bufs (mapcan >>> + (lambda (buf) >>> + (when (and (project--buffer-check buf '("\\`[^ ]")) >>> + (or (not arg) >>> + (project--buffer-check buf '(buffer-f= ile-name)))) >>> + (list buf))) >>> + (project-buffers pr)))) >>> + (display-buffer (list-buffers-noselect arg bufs)))) >> >> This won't survive a revert buffer, I think. (I'll show all buffers >> then.) > > This means that all uses of the BUFFER-LIST arg of 'list-buffers-noselect' > are flawed. So better would be to provide not a list of buffers, but > a predicate to filter out a list of buffers. Then the revert could use > such a predicate from e.g. a buffer-local variable. I just modify the tabulated-list-revert-hook buffer-locally. =2D-=20 Akib Azmain Turja --- https://akib.codeberg.page/ GPG key: 70018CE5819F17A3BBA666AFE74F0EFA922AE7F5 Fediverse: akib@hostux.social, Codeberg: akib emailselfdefense.fsf.org | "Nothing can be secure without encryption." --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEyVTKmrtL6kNBe3FRVTX89U2IYWsFAmNsvNUACgkQVTX89U2I YWtwUg/+OcC6I7ZhJ5rklkelse9Ds5WLuZnCUYcAknzGuP+XDjefCl3AZfEUTK+s aIGqgDqL0J68uIpqfKX/84ZSslxBvTI/ujR+59fY1D4myaygl6LQfqwr4uPESEnQ tGvjjcllIF9du/1vYcLZwNInB8U+SpWOlRJVVQcyKaWyZPbtIaq53vuU7LkwagqW 0+94qdz+0FSJ9hb0DKxa4rn3KXAzvAvYrbkoF6Qjb+Egi4ssQ+ZZZbtoUMac/bOq 6GJaOymH/VKXEUHllKxnaTOPPfgWzCDxZrm33lDr25qENZpH6zS/mSMB994L64Ea PomvvIYjjKRlHWzAelRRFbmxKa1iSjpYJmA2dMc0QOklUpOyaih1o9jrcc6dQYPS A+auVkz1w1ZXGQg0WrRxuspFvtFk3K3JlHFbrYCH4OqXGx6E8Cl06u99vruO9y0C QxUq5Tts/wO95Ye2BpIYzRJUBMJUP8d+wVrkPNVs+XaC8yQEcND24Z58Ahck2DQa UnrlebIg9+2cLKDatugWZUCgDB9+gtXLlG51jWpCE/09w2Jeo0F3Wc0Vwj3xNgMK RjEb/QpxGq1NckEMfAkLuYUseQnEvHg5TawvMtcWbfmejwNluiv7I4szGD649qHL YidxlomUumOQavVWcqteUyxEWtVY8Y7js8FF4yHAgP81ljELS2w= =A72m -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 13:05:31 2022 Received: (at 59153) by debbugs.gnu.org; 10 Nov 2022 18:05:31 +0000 Received: from localhost ([127.0.0.1]:44296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otBve-0007yb-Vv for submit@debbugs.gnu.org; Thu, 10 Nov 2022 13:05:31 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:32839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otBvd-0007yN-Bh for 59153@debbugs.gnu.org; Thu, 10 Nov 2022 13:05:30 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 43A79E0002; Thu, 10 Nov 2022 18:05:21 +0000 (UTC) From: Juri Linkov To: Akib Azmain Turja Subject: Re: bug#59153: List project buffers In-Reply-To: <8635arqllm.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 10 Nov 2022 09:56:01 +0200") Organization: LINKOV.NET References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> Date: Thu, 10 Nov 2022 19:59:56 +0200 Message-ID: <86leoilmg3.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain >>> + (bufs (mapcan >>> + (lambda (buf) >>> + (when (and (project--buffer-check buf '("\\`[^ ]")) >>> + (or (not arg) >>> + (project--buffer-check buf '(buffer-file-name)))) >>> + (list buf))) >>> + (project-buffers pr)))) >>> + (display-buffer (list-buffers-noselect arg bufs)))) >> >> This won't survive a revert buffer, I think. (I'll show all buffers >> then.) > > This means that all uses of the BUFFER-LIST arg of 'list-buffers-noselect' > are flawed. So better would be to provide not a list of buffers, but > a predicate to filter out a list of buffers. Then the revert could use > such a predicate from e.g. a buffer-local variable. Here is a patch that adds a buffer-local variable similar to Buffer-menu-files-only: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=Buffer-menu-filter-predicate.patch diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index abf152f058c..fbf2bbc58bc 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -101,6 +101,13 @@ Buffer-menu-files-only This is set by the prefix argument to `buffer-menu' and related commands.") +(defvar-local Buffer-menu-filter-predicate nil + "Function to filter out buffers in the buffer list. +Buffers that don't satisfy the predicate will be skipped. +The value should be a function of one argument; it will be +called with the buffer. If this function returns non-nil, +then the buffer will be displayed in the buffer list.") + (defvar-keymap Buffer-menu-mode-map :doc "Local keymap for `Buffer-menu-mode' buffers." :parent tabulated-list-mode-map @@ -597,19 +604,23 @@ Buffer-menu-view-other-window ;;; Functions for populating the Buffer Menu. ;;;###autoload -(defun list-buffers-noselect (&optional files-only buffer-list) +(defun list-buffers-noselect (&optional files-only buffer-list filter-predicate) "Create and return a Buffer Menu buffer. This is called by `buffer-menu' and others as a subroutine. If FILES-ONLY is non-nil, show only file-visiting buffers. If BUFFER-LIST is non-nil, it should be a list of buffers; it -means list those buffers and no others." +means list those buffers and no others. +If FILTER-PREDICATE is non-nil, it should be a function +that filters out buffers from the list of buffers. +See more at `Buffer-menu-filter-predicate'." (let ((old-buffer (current-buffer)) (buffer (get-buffer-create "*Buffer List*"))) (with-current-buffer buffer (Buffer-menu-mode) (setq Buffer-menu-files-only (and files-only (>= (prefix-numeric-value files-only) 0))) + (setq Buffer-menu-filter-predicate filter-predicate) (list-buffers--refresh buffer-list old-buffer) (tabulated-list-print)) buffer)) @@ -631,6 +642,8 @@ list-buffers--refresh (marked-buffers (Buffer-menu-marked-buffers)) (buffer-menu-buffer (current-buffer)) (show-non-file (not Buffer-menu-files-only)) + (filter-predicate (and (functionp Buffer-menu-filter-predicate) + Buffer-menu-filter-predicate)) entries name-width) ;; Collect info for each buffer we're interested in. (dolist (buffer (or buffer-list @@ -644,7 +657,9 @@ list-buffers--refresh (and (or (not (string= (substring name 0 1) " ")) file) (not (eq buffer buffer-menu-buffer)) - (or file show-non-file)))) + (or file show-non-file) + (or (not filter-predicate) + (funcall filter-predicate buffer))))) (push (list buffer (vector (cond ((eq buffer old-buffer) ".") diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index fc035675cec..917d80b2d3f 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -713,6 +713,7 @@ project-prefix-map (define-key map "G" 'project-or-external-find-regexp) (define-key map "r" 'project-query-replace-regexp) (define-key map "x" 'project-execute-extended-command) + (define-key map "\C-b" 'project-list-buffers) map) "Keymap for project commands.") @@ -1223,6 +1224,19 @@ project-display-buffer-other-frame (interactive (list (project--read-project-buffer))) (display-buffer-other-frame buffer-or-name)) +;;;###autoload +(defun project-list-buffers (&optional arg) + "Display a list of project buffers. +The list is displayed in a buffer named \"*Buffer List*\". + +By default, all project buffers are listed except those whose names +start with a space (which are for internal use). With prefix argument +ARG, show only buffers that are visiting files." + (interactive "P") + (let* ((pr (project-current t)) + (filter-predicate (lambda (buf) (memq buf (project-buffers pr))))) + (display-buffer (list-buffers-noselect arg nil filter-predicate)))) + (defcustom project-kill-buffer-conditions '(buffer-file-name ; All file-visiting buffers are included. ;; Most of temp and logging buffers (aside from hidden ones): @@ -1283,6 +1297,7 @@ project-kill-buffers-display-buffer-list :package-version '(project . "0.8.2") :safe #'booleanp) +;; UNUSED? (defun project--buffer-list (pr) "Return the list of all buffers in project PR." (let ((conn (file-remote-p (project-root pr))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 16:21:46 2022 Received: (at 59153) by debbugs.gnu.org; 10 Nov 2022 21:21:46 +0000 Received: from localhost ([127.0.0.1]:44516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otEzZ-0004CB-VF for submit@debbugs.gnu.org; Thu, 10 Nov 2022 16:21:46 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:37732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otEzX-0004Bx-Jn for 59153@debbugs.gnu.org; Thu, 10 Nov 2022 16:21:44 -0500 Received: by mail-wm1-f46.google.com with SMTP id ay14-20020a05600c1e0e00b003cf6ab34b61so4360890wmb.2 for <59153@debbugs.gnu.org>; Thu, 10 Nov 2022 13:21:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=MRua/wmuFZVawopbLR7ALzDoH6PJNkr57Z5hMGRXewk=; b=MvX4v4vOe5A4c+K7oYVla6Z6QtWcPzh93K0zO1hi//bflX5fUEd5WBVAgjvyypUb+r 4Hsj0CGhhaSMYei9EYCRxAjv7EPpdyKVvVRSMc5S5B8V0gcHpNOCF72Gl3042rrr6Vw0 R8HOcKmIj4jKZ1PuGp+4kNcInfVToAB0Xxbmh8I0HF+tdHaFMoKlwd6xcjkAanozm1nd kBiOscTQW52caVCnWubv4RIrx8V6FVhz8gFYghl1N6EPpgfGLJGGVj3ytAq9IOxh/2zf l1QYft47fq53FiHA7d4YaMJIzKQvckBWFNIIsEV33WlQEBwN69FIb/cI/d+xbaQHvHdU FDMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MRua/wmuFZVawopbLR7ALzDoH6PJNkr57Z5hMGRXewk=; b=GjxwDTPQ+/956w9SdyKPl9liKREkoCJhC3WB7k5nhfuRfqgw1jkUwlFr+QfJQ44mjK zIixHKOYnb/IMjXBjnJP+BaSCVV4DKK0IkyhBlbx9++t5/BB1vSmQ8bJDOEMI0n39oap hVwKsulJI3JgcZZX6Jj+a0StCgj6+6nrF55d6LK1CTVGOb6EeOl1SZvPkMo9tRToaG3Z d94c0j+AnGp8q9qX3garhFO8vhaYP24bS+HWqGhMkcH16LKpg7UFRHRJZZOHWVxDZV2M jjKv9V1L1UnOsGwKEU5A8WjR1kwBu8Rsqbt2bFcl9/LL4CKtqVN6gy+xbgktvyEpyS4g jFmw== X-Gm-Message-State: ACrzQf20WsGQ+DmCrbMtuAcRX4Q9VYi/Lk8U4IT55TFfDMULWBqCEsxp aR6wAnRAY/XrvrDU6UzvidE= X-Google-Smtp-Source: AMsMyM6DVBPA02bhdZryDqNJpyicv5GE0yJt8R+qTx6Lfa1EY6q6lElowr7cQJC+FkT0HmUiL1DPpA== X-Received: by 2002:a05:600c:3ac9:b0:3cf:6be9:e69a with SMTP id d9-20020a05600c3ac900b003cf6be9e69amr41022486wms.130.1668115297792; Thu, 10 Nov 2022 13:21:37 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m23-20020a05600c3b1700b003cf47556f21sm7021677wms.2.2022.11.10.13.21.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Nov 2022 13:21:37 -0800 (PST) Message-ID: <13792f94-52d7-4513-91c4-819b578089b5@yandex.ru> Date: Thu, 10 Nov 2022 23:21:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: bug#59153: List project buffers Content-Language: en-US To: Juri Linkov , 59153@debbugs.gnu.org References: <86a650t4b1.fsf@mail.linkov.net> From: Dmitry Gutov In-Reply-To: <86a650t4b1.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 59153 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 09.11.2022 19:40, Juri Linkov wrote: > There are project commands and keys corresponding > to the most useful buffer commands: > > C-x k (kill-buffer) - C-x p k (project-kill-buffers) > C-x b (switch-to-buffer) - C-x p b (project-switch-to-buffer) > > What is still missing is a command to list project buffers: > > C-x C-b (list-buffers) - C-x p C-b (project-list-buffers) This is fine with me, thank you. > +;; UNUSED? > (defun project--buffer-list (pr) > "Return the list of all buffers in project PR." > (let ((conn (file-remote-p (project-root pr))) And this is a good catch. Apparently the common project buffer enumeration logic is now missing the file-remote-p related speedup we added for https://lists.gnu.org/archive/html/emacs-devel/2021-05/msg00152.html. I wonder if it's still relevant, that's worth retesting. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 11 20:39:11 2022 Received: (at 59153) by debbugs.gnu.org; 12 Nov 2022 01:39:11 +0000 Received: from localhost ([127.0.0.1]:47073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otfUF-0004av-Ft for submit@debbugs.gnu.org; Fri, 11 Nov 2022 20:39:11 -0500 Received: from mail-wr1-f49.google.com ([209.85.221.49]:33370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otfUC-0004ah-Th for 59153@debbugs.gnu.org; Fri, 11 Nov 2022 20:39:10 -0500 Received: by mail-wr1-f49.google.com with SMTP id h9so8510310wrt.0 for <59153@debbugs.gnu.org>; Fri, 11 Nov 2022 17:39:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=u6CFqi641YZaezUCmHelmipLRIU7LJI6qBAzYUM1I4M=; b=OkHHqCLY3/FFZ/dE0xEJUOe1lX4hn9Hk+0KpjR9PHT8S7u9beOFq7mCpMRSkKVPsH2 HobHiIlUN3kVoxdUMQlNGqDI5j6s0kTHGqOBgFohqNXLUhnLWaSNJ7kGiy3pskAvg4tQ lLOFtN9MQDcdcyCeWesD+3MWi5451j3UggVDD1lKe1YNpv/N9w8yVUNRAyLZP2vkvAv9 74whabvcHue7bRj6xWIzXCfr/5PiCX3VmkRypy2NSRej+zS5nVxUFSISn5x2np4Ur590 m45iuiqBSfK4QL2PVyYY2P9Y6h73rk2HoForhifPPmqnvzhaovM0q4vWOhgnq/ztHAIE 4sbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=u6CFqi641YZaezUCmHelmipLRIU7LJI6qBAzYUM1I4M=; b=HtJDaDE61LwineOPCuykP3sGdcTNvj784jXbri5FDBHcjdV5WT7ruZus7mWorViehL 6jwlewmSMOiaQ24YIRoci8VwukiMwVjPVhZxk4qf68Xu0VTlBEjODbnpbBktmRRxhwc4 qMh6mL6rMZ5SNoJ7n3DW0UiYXG2Ax9LZyWZT9wIiWi6OxWSKWMNwf5Bh33pM8VB4CwGR se6CyOUDqDLlgKYkSAlCjg7mUr4DV3cwK/fEBDT+oPOqoQ2MVZ4kH69OPKmQrR9sjgzr kqj+sVrWe5oaitCCNAAdVSYNYGE3r1fOwqUmpl/itMWawStvcugj1y1k0TZWOV0p+sKS 7lDQ== X-Gm-Message-State: ANoB5plaUiyzt37rAFOo175Dtim5vdrwxFyDOPLSK5xpUudtF3Djo6er v2afpL2UcmFWM9jKfpyIZ3U= X-Google-Smtp-Source: AA0mqf4iyD0U5VpPZpUomAvtGaZuz4cBxWwDOL5YZzmQu3gCc3hvN6f6GlKb29raYY4mrs9ayQvdFQ== X-Received: by 2002:a5d:558b:0:b0:236:7670:68b5 with SMTP id i11-20020a5d558b000000b00236767068b5mr2446476wrv.149.1668217142807; Fri, 11 Nov 2022 17:39:02 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id t67-20020a1c4646000000b003cfa622a18asm10352528wma.3.2022.11.11.17.39.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Nov 2022 17:39:02 -0800 (PST) Message-ID: <027e6530-2072-20eb-cdf3-b313f6d6c00a@yandex.ru> Date: Sat, 12 Nov 2022 03:39:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: bug#59153: List project buffers Content-Language: en-US From: Dmitry Gutov To: Juri Linkov , 59153@debbugs.gnu.org References: <86a650t4b1.fsf@mail.linkov.net> <13792f94-52d7-4513-91c4-819b578089b5@yandex.ru> In-Reply-To: <13792f94-52d7-4513-91c4-819b578089b5@yandex.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 59153 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 10.11.2022 23:21, Dmitry Gutov wrote: >> +;; UNUSED? >>   (defun project--buffer-list (pr) >>     "Return the list of all buffers in project PR." >>     (let ((conn (file-remote-p (project-root pr))) > > And this is a good catch. Apparently the common project buffer > enumeration logic is now missing the file-remote-p related speedup we > added for > https://lists.gnu.org/archive/html/emacs-devel/2021-05/msg00152.html. > > I wonder if it's still relevant, that's worth retesting. Never mind. Removed it, thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 11 20:41:55 2022 Received: (at 59153) by debbugs.gnu.org; 12 Nov 2022 01:41:55 +0000 Received: from localhost ([127.0.0.1]:47077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otfWs-0004ee-V1 for submit@debbugs.gnu.org; Fri, 11 Nov 2022 20:41:55 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:35389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otfWq-0004eR-Sy for 59153@debbugs.gnu.org; Fri, 11 Nov 2022 20:41:53 -0500 Received: by mail-wr1-f52.google.com with SMTP id l14so8474648wrw.2 for <59153@debbugs.gnu.org>; Fri, 11 Nov 2022 17:41:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=RBDTlME0aAqCwjEHncz43AyXYHZFgAoVJIrpulKlvpg=; b=V9Ik7v+DjJzgA8oiYMvFHKj9OuvDgUdKHq4RuOzLh3m3ifUHrJWuXAosP5FMdd7LcJ IJB+6VEnR6HvQ2voXUDdD/goLla5JEydbVbahcH2lPLb6GNC7iEtEb9D4ttJvieJjSf2 MQua+UdIxgbWueak69uTYwl2yeWPZV86+W34IUBo1tls1J/1V0t7QMYDpyusmijjSvJr sCcbFXa5B3TUvDXYM90nsmnF9iaYhJ0y7dd2i34Ps08bk2qF8Cx5Wseippv2w800CcqN Qsli0de7C7zun/DjNDbwop99l04VuanyogxpR7KJM0pOkuE9aOzRHfGVcDPHiExdBMoZ XVjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RBDTlME0aAqCwjEHncz43AyXYHZFgAoVJIrpulKlvpg=; b=Tw4i9cJmlDY+RQX5jUorvKFFd9WrNaMCAelg4mTT/k+GwSR6NGNck2GqYNgjYSULLf 9uQ4Zc7RD1n4yVc8oWTI0vtXx3/BCF4BOnRQuw3CmrpF+GKgycIyXlo7ER3L1vC86TH8 SAySEW6SPFd++TuCaX2wA8fhFAunerEO+D7+losrmDJygWIBxEcS9hgmhMDGfNc/YXaj i3KpVJu9NCHGGVnbwxlRY4RZuQX6RBD4mmAopkzDgdhOt0vq98VXxtGRZwVo7ejvw8ga mij53EhNacOyH5m+O8qGMMGCFxPD/TRrMpwEWEM3kRbU1hee5XvDMW4izmVLt7oEvnXO e1Xw== X-Gm-Message-State: ANoB5pmKqxCooKQKOy4XxssyLb+AbE1mLOEpTzz7ivn2C8oOt0KT7kam stg2eKiT1MzWmrXsrYTdrpc8aNQq0TY= X-Google-Smtp-Source: AA0mqf7HrldSXWTkz0vBidtDEtuM20zY2F7SRQzQ2899OmqrVVpqHN1pDqINwKu7yDrlHHeyc9OWsQ== X-Received: by 2002:a5d:58d4:0:b0:230:7452:53cb with SMTP id o20-20020a5d58d4000000b00230745253cbmr2433864wrf.120.1668217307259; Fri, 11 Nov 2022 17:41:47 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j5-20020a05600c1c0500b003cfbbd54178sm15951628wms.2.2022.11.11.17.41.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Nov 2022 17:41:47 -0800 (PST) Message-ID: Date: Sat, 12 Nov 2022 03:41:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: bug#59153: List project buffers Content-Language: en-US To: Juri Linkov , Akib Azmain Turja References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> <86leoilmg3.fsf@mail.linkov.net> From: Dmitry Gutov In-Reply-To: <86leoilmg3.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 10.11.2022 19:59, Juri Linkov wrote: > + (display-buffer (list-buffers-noselect arg nil filter-predicate)))) I suppose we'll need an arity check here? So that this command also works in older emacsen with an install of project.el from ELPA. Alternatively, the command could set the value of Buffer-menu-filter-predicate inside the resulting buffer, rather than pass it as an argument to list-buffers-noselect. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 12 13:11:15 2022 Received: (at 59153) by debbugs.gnu.org; 12 Nov 2022 18:11:15 +0000 Received: from localhost ([127.0.0.1]:48981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otuyJ-000311-Cg for submit@debbugs.gnu.org; Sat, 12 Nov 2022 13:11:15 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:50019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otuyH-00030V-Mn for 59153@debbugs.gnu.org; Sat, 12 Nov 2022 13:11:14 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 29CA7C0003; Sat, 12 Nov 2022 18:11:04 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#59153: List project buffers In-Reply-To: (Dmitry Gutov's message of "Sat, 12 Nov 2022 03:41:45 +0200") Organization: LINKOV.NET References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> <86leoilmg3.fsf@mail.linkov.net> Date: Sat, 12 Nov 2022 20:02:47 +0200 Message-ID: <86sfiom4oo.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org, Akib Azmain Turja X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> + (display-buffer (list-buffers-noselect arg nil filter-predicate)))) > > I suppose we'll need an arity check here? > > So that this command also works in older emacsen with an install of > project.el from ELPA. Ah, I forgot about older emacsen. > Alternatively, the command could set the value of > Buffer-menu-filter-predicate inside the resulting buffer, rather than pass > it as an argument to list-buffers-noselect. Setting a buffer-local variable looks like a safer option since Stefan M. warned many times that an arity check is not reliable. But then need to display buffer twice: first call list-buffers-noselect without an argument, then set buffer-local Buffer-menu-filter-predicate, then programmatically revert the buffer. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 12 21:37:25 2022 Received: (at 59153) by debbugs.gnu.org; 13 Nov 2022 02:37:25 +0000 Received: from localhost ([127.0.0.1]:49671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ou2s8-0005st-O6 for submit@debbugs.gnu.org; Sat, 12 Nov 2022 21:37:25 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:46915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ou2s7-0005sg-Lq for 59153@debbugs.gnu.org; Sat, 12 Nov 2022 21:37:24 -0500 Received: by mail-wr1-f43.google.com with SMTP id d9so6744803wrm.13 for <59153@debbugs.gnu.org>; Sat, 12 Nov 2022 18:37:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=R2yVBy5MmrUkMzypq2+Fv8clhHklL5ivhtIt6ukY+5I=; b=qzIQJW4wbHKN9oX49W5sofv+vFBiX8wG71ntM8h2oMHd6IuT4pVSY7oMxshRk0H86W GlQetJjjUQj2wSuuWclFzdLxglaoAMcAqGNDchlorlwZ3BSVlz0Hm430GNVptleSZXfI ZFcS2m9IG/653szwI59DYCucawwkpfhP/MCxkv/AdddNp4FSzK1ibCwsLv4Brl20B4h/ dibP+zWtiID7FlCpPVCBXN11E9q2N9tsQaZQoaGRYQ5HPhemy5mHl3iX5eFVYZd8MDxP j/ZZ7+lBvMBoCD+eIGHF4ko+A9jq6Aw+oucQMK/wzHmjbYbT07B3qUpZitcPt9lcmltC SonA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R2yVBy5MmrUkMzypq2+Fv8clhHklL5ivhtIt6ukY+5I=; b=ueMpa8ZsvhYhN5werb8ae0JbFRh7QV/2HyuDG06dM/z45r439nLmnV/4wXK6gIbDsp 7Dy1OQOqF8ox5XUD6HDgCAcncJDZ3rExbur+slxEQ7eM75lyqMIP5NbiYVUePBgCqAoZ qD/35mRFAteCItTB2UK9G/LmOJuoMR8lwajwdnihGF/gDbWu/3bQQJ3+sJ4kOtf1DmM8 c7vV/Kkt4EG3IlyCxW7yhydLzQzvn6rpFbqrCR0H+/FdZPIEA+TkzijJ/qDP3jNfZpat HqA+3wtML5o7bZrnhyD9Y7dvrYxYSjECBNw+mEsL0rOfV7xoUnUkbxAYXyQ7wmDH9DtA 6AGA== X-Gm-Message-State: ANoB5pmDXXn19W4Ct2ud/55RvnkuuMVXMBhpA99EU3+PcfZ+MCwp3PuI 2Ajj4qDlvxF6L5/FI4hPsvE= X-Google-Smtp-Source: AA0mqf7diLYh3Xmj72Os+mHAXXKZEsFJwCptUkuVros6vCLJDQmkwusDg1rwWwlj67JbzQzhfKlS5w== X-Received: by 2002:adf:fc81:0:b0:236:7083:21df with SMTP id g1-20020adffc81000000b00236708321dfmr4220850wrr.123.1668307037809; Sat, 12 Nov 2022 18:37:17 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id bh9-20020a05600005c900b0022e36c1113fsm5773158wrb.13.2022.11.12.18.37.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Nov 2022 18:37:17 -0800 (PST) Message-ID: <4cfe3fcc-412f-2bc8-c702-ed67196806b4@yandex.ru> Date: Sun, 13 Nov 2022 04:37:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: bug#59153: List project buffers Content-Language: en-US To: Juri Linkov References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> <86leoilmg3.fsf@mail.linkov.net> <86sfiom4oo.fsf@mail.linkov.net> From: Dmitry Gutov In-Reply-To: <86sfiom4oo.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org, Akib Azmain Turja X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 12.11.2022 20:02, Juri Linkov wrote: >>> + (display-buffer (list-buffers-noselect arg nil filter-predicate)))) >> I suppose we'll need an arity check here? >> >> So that this command also works in older emacsen with an install of >> project.el from ELPA. > Ah, I forgot about older emacsen. > >> Alternatively, the command could set the value of >> Buffer-menu-filter-predicate inside the resulting buffer, rather than pass >> it as an argument to list-buffers-noselect. > Setting a buffer-local variable looks like a safer option since > Stefan M. warned many times that an arity check is not reliable. Catching the wrong-number-of-arguments error is a established way of handling this. But we could also, for example, introduce a new function which receives a predicate, instead of adding a new arg to list-buffers-noselect. Or just use an Emacs version check. It doesn't feel as nice, but should work fine nevertheless. > But then need to display buffer twice: first call > list-buffers-noselect without an argument, then > set buffer-local Buffer-menu-filter-predicate, > then programmatically revert the buffer. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 13:04:30 2022 Received: (at 59153) by debbugs.gnu.org; 13 Nov 2022 18:04:30 +0000 Received: from localhost ([127.0.0.1]:52477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouHLJ-00052t-SL for submit@debbugs.gnu.org; Sun, 13 Nov 2022 13:04:30 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:46113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouHLI-00052T-GG for 59153@debbugs.gnu.org; Sun, 13 Nov 2022 13:04:28 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 0AE021C0005; Sun, 13 Nov 2022 18:04:21 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#59153: List project buffers In-Reply-To: <4cfe3fcc-412f-2bc8-c702-ed67196806b4@yandex.ru> (Dmitry Gutov's message of "Sun, 13 Nov 2022 04:37:15 +0200") Organization: LINKOV.NET References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> <86leoilmg3.fsf@mail.linkov.net> <86sfiom4oo.fsf@mail.linkov.net> <4cfe3fcc-412f-2bc8-c702-ed67196806b4@yandex.ru> Date: Sun, 13 Nov 2022 19:57:32 +0200 Message-ID: <86zgcuagab.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org, Akib Azmain Turja X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Or just use an Emacs version check. It doesn't feel as nice, but should > work fine nevertheless. Using an Emacs version check is the best thing to do because it will allow to hide (undefine) the whole new function (and its keybinding) in older versions since the new function don't work reliably without accompanying changes in buff-menu.el. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 17:18:23 2022 Received: (at 59153) by debbugs.gnu.org; 13 Nov 2022 22:18:24 +0000 Received: from localhost ([127.0.0.1]:48571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouLJ1-0003zk-MX for submit@debbugs.gnu.org; Sun, 13 Nov 2022 17:18:23 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:36556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouLIz-0003zX-K3 for 59153@debbugs.gnu.org; Sun, 13 Nov 2022 17:18:22 -0500 Received: by mail-wr1-f48.google.com with SMTP id j15so14466811wrq.3 for <59153@debbugs.gnu.org>; Sun, 13 Nov 2022 14:18:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=VlNdmuVXugCrtBzgK46uU+I5y3H9HVO6ql2ksSElk6o=; b=VLKeny/8VQ1DdW5L66JDyjcFDHh+qhe7/0CKR5bpsyZvlcl+mHwH0SX3fK+47Sfe2n nul1IpFRadgYdCT9g1CInmLvvyQebXdqJspUkGZQso46gXsCq25vr8lCrPi8/Nq+lKAN 3pFDnkeAhBp8/ImrpZ7gsgxHU7xrOPoD37TsYxdOEZ/tgbdEe2dl+rk/LFY79j9uHGl6 quFICu1Zcw9IxjV1/GXGUBlOCKwtTOOYf7Tu0w2fHKg5xFUfB2t7jE2MFDDlkONIc1jD w33v25CoFufMAeGv4aDpBA7myTrwVVDeqoNwN6IRPANK872oP7qfmIqNB8ryuqM3AdzH 4fBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VlNdmuVXugCrtBzgK46uU+I5y3H9HVO6ql2ksSElk6o=; b=JUIOMyB02HUCKr0VSiRe4kAxMnCZ8JzdRs68sWP+gGI8mi0/zTnghGodjjUKsyXR+V +QaWxsfYHiao5ycGosp5RuGdAkvId3kQzj2V9hpXR4pbFVIjjygl+sraZgOGn7aRIJXA H51H9/VVg4Fymsv1H64ZDCfqiwdA9Gzz0cc38ZZgrxw/2s/ClhyufRHyzinWNb1Xv5gB m0oCnRstdg6/esPxqyMzGapkhzrI6A8QS2tAv/jIFHf9vBi/UpnN51wxkF9SJvQh3yI4 U4YMNRaIv7n88dx/2nQoQ9yHbF8bkXnnI40LX4OBvF4G95KzoGle2o3g7t/1ECJmwmgJ X0Qw== X-Gm-Message-State: ANoB5pk9/CntDK8H6dxIHiSqe35lN/SCA198ADJAp0Pa0Z4u5PyL5hR+ mQMaAd6yKu0fUiJUip6wMKE= X-Google-Smtp-Source: AA0mqf5eFd6SMbmwH/cddspRmEGemm7iG557mauOQ32CUbwODe3/JqLDZzbKjTj20aRA6bgUUPoPDg== X-Received: by 2002:adf:de06:0:b0:236:6e2a:ac11 with SMTP id b6-20020adfde06000000b002366e2aac11mr5771106wrm.529.1668377895575; Sun, 13 Nov 2022 14:18:15 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id o5-20020a05600c510500b003cfa3a12660sm21771481wms.1.2022.11.13.14.18.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Nov 2022 14:18:14 -0800 (PST) Message-ID: Date: Mon, 14 Nov 2022 00:18:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: bug#59153: List project buffers Content-Language: en-US To: Juri Linkov References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> <86leoilmg3.fsf@mail.linkov.net> <86sfiom4oo.fsf@mail.linkov.net> <4cfe3fcc-412f-2bc8-c702-ed67196806b4@yandex.ru> <86zgcuagab.fsf@mail.linkov.net> From: Dmitry Gutov In-Reply-To: <86zgcuagab.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org, Akib Azmain Turja X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 13.11.2022 19:57, Juri Linkov wrote: >> Or just use an Emacs version check. It doesn't feel as nice, but should >> work fine nevertheless. > Using an Emacs version check is the best thing to do > because it will allow to hide (undefine) the whole > new function (and its keybinding) in older versions > since the new function don't work reliably without > accompanying changes in buff-menu.el. If you're sure, maybe. But I would imagine that users of Emacs 28 and earlier would rather enjoy the new command (with a 'g' caveat) than have it disabled. As a safety measure, in older Emacs you could also set 'revert-buffer-function' locally to something displaying an error. I don't remember using 'g' in ibuffer or list-buffers much anyway. But that depends on one's habits. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 15 04:08:13 2022 Received: (at 59153) by debbugs.gnu.org; 15 Nov 2022 09:08:13 +0000 Received: from localhost ([127.0.0.1]:52908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ourvQ-0001FD-KZ for submit@debbugs.gnu.org; Tue, 15 Nov 2022 04:08:12 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:49373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ourvO-0001F0-CZ for 59153@debbugs.gnu.org; Tue, 15 Nov 2022 04:08:11 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id E90B41BF20B; Tue, 15 Nov 2022 09:07:59 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#59153: List project buffers In-Reply-To: (Dmitry Gutov's message of "Mon, 14 Nov 2022 00:18:13 +0200") Organization: LINKOV.NET References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> <86leoilmg3.fsf@mail.linkov.net> <86sfiom4oo.fsf@mail.linkov.net> <4cfe3fcc-412f-2bc8-c702-ed67196806b4@yandex.ru> <86zgcuagab.fsf@mail.linkov.net> Date: Tue, 15 Nov 2022 10:36:14 +0200 Message-ID: <86v8ngy4c9.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org, Akib Azmain Turja X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain > But I would imagine that users of Emacs 28 and earlier would rather enjoy > the new command (with a 'g' caveat) than have it disabled. > > As a safety measure, in older Emacs you could also set > 'revert-buffer-function' locally to something displaying an error. > > I don't remember using 'g' in ibuffer or list-buffers much anyway. But that > depends on one's habits. Maybe something like this that supports 'g' in older versions: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=project-list-buffers.patch diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index ed26872ae77..63510e90502 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -712,6 +712,7 @@ project-prefix-map (define-key map "G" 'project-or-external-find-regexp) (define-key map "r" 'project-query-replace-regexp) (define-key map "x" 'project-execute-extended-command) + (define-key map "\C-b" 'project-list-buffers) map) "Keymap for project commands.") @@ -1222,6 +1223,28 @@ project-display-buffer-other-frame (interactive (list (project--read-project-buffer))) (display-buffer-other-frame buffer-or-name)) +;;;###autoload +(defun project-list-buffers (&optional arg) + "Display a list of project buffers. +The list is displayed in a buffer named \"*Buffer List*\". + +By default, all project buffers are listed except those whose names +start with a space (which are for internal use). With prefix argument +ARG, show only buffers that are visiting files." + (interactive "P") + (let ((pr (project-current t))) + (display-buffer + (if (version< emacs-version "29.0.50") + (let ((buf (list-buffers-noselect arg (project-buffers pr)))) + (with-current-buffer buf + (setq-local revert-buffer-function + (lambda (&rest _ignored) + (list-buffers--refresh (project-buffers pr)) + (tabulated-list-print t)))) + buf) + (list-buffers-noselect + arg nil (lambda (buf) (memq buf (project-buffers pr)))))))) + (defcustom project-kill-buffer-conditions '(buffer-file-name ; All file-visiting buffers are included. ;; Most of temp and logging buffers (aside from hidden ones): --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 15 09:53:58 2022 Received: (at 59153) by debbugs.gnu.org; 15 Nov 2022 14:53:58 +0000 Received: from localhost ([127.0.0.1]:53634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouxK1-0004hT-Sn for submit@debbugs.gnu.org; Tue, 15 Nov 2022 09:53:58 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:46607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouxJy-0004h8-LW for 59153@debbugs.gnu.org; Tue, 15 Nov 2022 09:53:57 -0500 Received: by mail-wr1-f46.google.com with SMTP id d9so19983043wrm.13 for <59153@debbugs.gnu.org>; Tue, 15 Nov 2022 06:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=3GnSOu4CT82VZV6riLz4LTKXCp6XPUvK2OABN8hEuX8=; b=IIwsgGgYvcvAxYugl800dlbYpe5ZWwGpZp7PbYIqVml81JRiup1mcDaVK6du+h3OTs aVx7InS8i1edYTzqYl6wvIXLQQPOTkfGHEX4gMfE5KBBM3KXSra9tF5YIzeyW38lUWn4 GDKGOJFq780sr81SZVJKe9ae4QGy+S2c+I+n2MAoFmd8Sgt20VKYkRAWTk/oFuiqu70b NhMvIU7TOcEV9jaVdRBIMz3fFWK1gBbSbKzUoqI5gJGkj28pKzA+MllCtrGG5eCbydQX NhWdZL25yitOTSwcBdJnyTC21jwD12vqk/J3b7g1MxFMmWTsAYGzouKlT3ZfeboZPGgi h9nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3GnSOu4CT82VZV6riLz4LTKXCp6XPUvK2OABN8hEuX8=; b=658BlLcXW9rNkVwRFJW/UfKZ2pjPjBPL1jDtIENaiauIiJM8BWa4c8clefNLUsstE0 3tFCHCI8MzFbuJyD+gIYWA65HwQPqTNN1sbx/0LtkB1EToW0b4LFLZ0e0vkoXIfNIjAg FIuZbkbtruS6pH2LwK/Fx63b6Sgw78OQskIoGJLmn9tRehtyPZ3El0IZra2LrnRVqjE+ pKThjJvF0U1yr6sHhQCniKrFCLuY691DYWPgqPWz74NYo56ABjCmt/FyrzSkwSU/eeSc n9qQdpXYm6zZTryVVaKT3ThXHf4Tf3lIZBVc1RQk2/XV2TklMEU2oCeOPP77MGMoozpa a8iQ== X-Gm-Message-State: ANoB5pkErZpK3h8UfRMrANEdWy85VuDERa4gApxcG5wXxG5rAga5hqD6 0Esd57cr8OizFOjHdhJO3ls= X-Google-Smtp-Source: AA0mqf5dllciOJ9BBp6jY3X+0tc5v54eYTvxqE0LKIzd4LaHlZQsfMkVFxmCr0OHrAw1wDxwtbwMdQ== X-Received: by 2002:adf:ed45:0:b0:236:8dd7:1922 with SMTP id u5-20020adfed45000000b002368dd71922mr10581755wro.564.1668524028523; Tue, 15 Nov 2022 06:53:48 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id e12-20020adffd0c000000b00236576c8eddsm12765047wrr.12.2022.11.15.06.53.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 06:53:48 -0800 (PST) Message-ID: <7cee03ff-30b4-9995-43e0-7a15613c94cd@yandex.ru> Date: Tue, 15 Nov 2022 16:53:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: bug#59153: List project buffers Content-Language: en-US To: Juri Linkov References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> <86leoilmg3.fsf@mail.linkov.net> <86sfiom4oo.fsf@mail.linkov.net> <4cfe3fcc-412f-2bc8-c702-ed67196806b4@yandex.ru> <86zgcuagab.fsf@mail.linkov.net> <86v8ngy4c9.fsf@mail.linkov.net> From: Dmitry Gutov In-Reply-To: <86v8ngy4c9.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org, Akib Azmain Turja X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 15.11.2022 10:36, Juri Linkov wrote: > Maybe something like this that supports 'g' in older versions: LGTM, thanks! From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 15 13:56:25 2022 Received: (at 59153) by debbugs.gnu.org; 15 Nov 2022 18:56:25 +0000 Received: from localhost ([127.0.0.1]:55240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ov16f-00056q-Hl for submit@debbugs.gnu.org; Tue, 15 Nov 2022 13:56:25 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:59085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ov16d-00056Y-NF; Tue, 15 Nov 2022 13:56:24 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id B2869C0002; Tue, 15 Nov 2022 18:56:13 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#59153: List project buffers In-Reply-To: <7cee03ff-30b4-9995-43e0-7a15613c94cd@yandex.ru> (Dmitry Gutov's message of "Tue, 15 Nov 2022 16:53:46 +0200") Organization: LINKOV.NET References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> <86leoilmg3.fsf@mail.linkov.net> <86sfiom4oo.fsf@mail.linkov.net> <4cfe3fcc-412f-2bc8-c702-ed67196806b4@yandex.ru> <86zgcuagab.fsf@mail.linkov.net> <86v8ngy4c9.fsf@mail.linkov.net> <7cee03ff-30b4-9995-43e0-7a15613c94cd@yandex.ru> Date: Tue, 15 Nov 2022 20:55:37 +0200 Message-ID: <86v8ngdp3q.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org, Akib Azmain Turja X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 59153 29.0.50 thanks >> Maybe something like this that supports 'g' in older versions: > > LGTM, thanks! Thanks for reviewing, now pushed to master. I didn't bump the version to give more time for testing in master. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 16 05:16:49 2022 Received: (at submit) by debbugs.gnu.org; 16 Nov 2022 10:16:49 +0000 Received: from localhost ([127.0.0.1]:56185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovFTN-0001Rl-1X for submit@debbugs.gnu.org; Wed, 16 Nov 2022 05:16:49 -0500 Received: from lists.gnu.org ([209.51.188.17]:46260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovFTK-0001Rb-Kk for submit@debbugs.gnu.org; Wed, 16 Nov 2022 05:16:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovFTK-0004Qc-Fz for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 05:16:46 -0500 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovFTI-00033i-Dx for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 05:16:46 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1ovFSw-0009NW-SI for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 11:16:22 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Pankaj Jangid Subject: Re: bug#59153: List project buffers Date: Wed, 16 Nov 2022 15:46:18 +0530 Message-ID: <874juz2oi5.fsf@codeisgreat.org> References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> <86leoilmg3.fsf@mail.linkov.net> <86sfiom4oo.fsf@mail.linkov.net> <4cfe3fcc-412f-2bc8-c702-ed67196806b4@yandex.ru> <86zgcuagab.fsf@mail.linkov.net> <86v8ngy4c9.fsf@mail.linkov.net> <7cee03ff-30b4-9995-43e0-7a15613c94cd@yandex.ru> <86v8ngdp3q.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Cancel-Lock: sha1:tvs2ves5uGRsKRJpW+elE626Psw= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) This is a really helpful feature. A query though. Will that be another feature request for the users of ibuffer. May be a variable `project-list-buffers-function`. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 18 02:21:03 2022 Received: (at 59153) by debbugs.gnu.org; 18 Nov 2022 07:21:03 +0000 Received: from localhost ([127.0.0.1]:35104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovvgN-0003ev-Ij for submit@debbugs.gnu.org; Fri, 18 Nov 2022 02:21:03 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:52255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovvgL-0003dp-SU for 59153@debbugs.gnu.org; Fri, 18 Nov 2022 02:21:02 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 067C3FF806; Fri, 18 Nov 2022 07:20:54 +0000 (UTC) From: Juri Linkov To: Pankaj Jangid Subject: Re: bug#59153: List project buffers In-Reply-To: <874juz2oi5.fsf@codeisgreat.org> (Pankaj Jangid's message of "Wed, 16 Nov 2022 15:46:18 +0530") Organization: LINKOV.NET References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> <86leoilmg3.fsf@mail.linkov.net> <86sfiom4oo.fsf@mail.linkov.net> <4cfe3fcc-412f-2bc8-c702-ed67196806b4@yandex.ru> <86zgcuagab.fsf@mail.linkov.net> <86v8ngy4c9.fsf@mail.linkov.net> <7cee03ff-30b4-9995-43e0-7a15613c94cd@yandex.ru> <86v8ngdp3q.fsf@mail.linkov.net> <874juz2oi5.fsf@codeisgreat.org> Date: Fri, 18 Nov 2022 09:09:42 +0200 Message-ID: <86o7t4dbc9.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > This is a really helpful feature. A query though. Will that be another > feature request for the users of ibuffer. May be a variable > `project-list-buffers-function`. Probably this could be implemented in ibuffer.el. So when ibuffer is loaded, it could override the keybinding 'C-x p C-b' with own function that uses ibuffer filters with the current project buffers. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 19 13:34:37 2022 Received: (at 59153) by debbugs.gnu.org; 19 Nov 2022 18:34:37 +0000 Received: from localhost ([127.0.0.1]:41115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owSfk-000571-T9 for submit@debbugs.gnu.org; Sat, 19 Nov 2022 13:34:37 -0500 Received: from mail-wm1-f43.google.com ([209.85.128.43]:54096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owSfj-00056p-5k for 59153@debbugs.gnu.org; Sat, 19 Nov 2022 13:34:36 -0500 Received: by mail-wm1-f43.google.com with SMTP id p16so5843939wmc.3 for <59153@debbugs.gnu.org>; Sat, 19 Nov 2022 10:34:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=Yzy4WK9pBff+Sj82OCq1mewAVOtcPUMY+ZHx42o8VY4=; b=UF3ktNwy4QOvJyeTxY+jbJREMf+76jxz+UaRTwROP8XNjQwON1w6HdhIVhe/TIRyq+ fyW57/N3ysXzfu00sumzAeU7F4O6retdLYtE7fXi+pYIaamwijCwkp8P/gJoTjUxUozq BbgAb5TSh4YFStSyC5zYbq8Jahj/qHXCEbrishgczdekix+1mk9SobMFq7Rt/xdmyDsp CMG+J7Ael9j2267kj38YI7Kn1F1j6Hl9sjqoKoNpRw4qeNX4zqlNoxPPPLVA8UvNEikC 7jMfd/T49Cfnd2n3Tz4XCBX4z4sKp4gFu72WSQqJ/l0cspQwehsNofHya5dRynfGlush UBog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Yzy4WK9pBff+Sj82OCq1mewAVOtcPUMY+ZHx42o8VY4=; b=ASEvJRWzFWszxw8oCiClJYcvRvhVacEiykRilBsFSsPR3DlpNdUuUOyvLzyyVtd8a3 dB1lS8SdwNZQ0Mor4vQkCHLMpmWD8lec0uoVYJQ7kwvOgNSvyP1HF6DcZKKlR4SmdG7u VZLlHfNEzrhPbMkrvcCVNjEd5GHz/zyMCtuaXCAw40i+r0OTMh7qlgFYVaky6xozpvF5 rtGkqAO6rqGj6nW+LfOF9kLxBDm0y0asFealeHNxRE9PxSg3pZYFbELlUSl0PCV+sy7i 8zJnXYV03I69ZA0TScnCkNJ0DDd4PRTq11nGwS2pKjk6chqmUGkWc7g13CtmspRUIR/B BYsw== X-Gm-Message-State: ANoB5pnQY8ylfrwRyhXLUDzhyYlZqlv3B3EbpbI2uz6pg5yqHsKBKSYK bOlVo9+6nbkn2klwbGHyBn0= X-Google-Smtp-Source: AA0mqf4mEyFLbO1sW1fMwGgJ6mP+adjOmW88LZ7TYLYibo1DQOLFFixx0n44JKUBxV1APU2kxmqolw== X-Received: by 2002:a05:600c:3553:b0:3cf:8e62:f748 with SMTP id i19-20020a05600c355300b003cf8e62f748mr11388152wmq.175.1668882869148; Sat, 19 Nov 2022 10:34:29 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id k33-20020a05600c1ca100b003b3365b38f9sm9278144wms.10.2022.11.19.10.34.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Nov 2022 10:34:28 -0800 (PST) Message-ID: Date: Sat, 19 Nov 2022 20:34:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: bug#59153: List project buffers Content-Language: en-US To: Juri Linkov , Pankaj Jangid References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> <86leoilmg3.fsf@mail.linkov.net> <86sfiom4oo.fsf@mail.linkov.net> <4cfe3fcc-412f-2bc8-c702-ed67196806b4@yandex.ru> <86zgcuagab.fsf@mail.linkov.net> <86v8ngy4c9.fsf@mail.linkov.net> <7cee03ff-30b4-9995-43e0-7a15613c94cd@yandex.ru> <86v8ngdp3q.fsf@mail.linkov.net> <874juz2oi5.fsf@codeisgreat.org> <86o7t4dbc9.fsf@mail.linkov.net> From: Dmitry Gutov In-Reply-To: <86o7t4dbc9.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 18.11.2022 09:09, Juri Linkov wrote: >> This is a really helpful feature. A query though. Will that be another >> feature request for the users of ibuffer. May be a variable >> `project-list-buffers-function`. > > Probably this could be implemented in ibuffer.el. > So when ibuffer is loaded, it could override the > keybinding 'C-x p C-b' with own function that uses > ibuffer filters with the current project buffers. Might as well add 'project-ibuffer' to project.el straight, similarly to how we have both 'project-shell' and 'project-eshell'. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 19 14:16:09 2022 Received: (at 59153) by debbugs.gnu.org; 19 Nov 2022 19:16:09 +0000 Received: from localhost ([127.0.0.1]:41437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owTJw-0006PH-Pg for submit@debbugs.gnu.org; Sat, 19 Nov 2022 14:16:09 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:49371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owTJO-0006Kk-8n for 59153@debbugs.gnu.org; Sat, 19 Nov 2022 14:15:35 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 4FB01100003; Sat, 19 Nov 2022 19:15:23 +0000 (UTC) From: Juri Linkov To: Dmitry Gutov Subject: Re: bug#59153: List project buffers In-Reply-To: (Dmitry Gutov's message of "Sat, 19 Nov 2022 20:34:27 +0200") Organization: LINKOV.NET References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> <86leoilmg3.fsf@mail.linkov.net> <86sfiom4oo.fsf@mail.linkov.net> <4cfe3fcc-412f-2bc8-c702-ed67196806b4@yandex.ru> <86zgcuagab.fsf@mail.linkov.net> <86v8ngy4c9.fsf@mail.linkov.net> <7cee03ff-30b4-9995-43e0-7a15613c94cd@yandex.ru> <86v8ngdp3q.fsf@mail.linkov.net> <874juz2oi5.fsf@codeisgreat.org> <86o7t4dbc9.fsf@mail.linkov.net> Date: Sat, 19 Nov 2022 20:48:14 +0200 Message-ID: <864juubx1t.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org, Pankaj Jangid X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> This is a really helpful feature. A query though. Will that be another >>> feature request for the users of ibuffer. May be a variable >>> `project-list-buffers-function`. >> Probably this could be implemented in ibuffer.el. >> So when ibuffer is loaded, it could override the >> keybinding 'C-x p C-b' with own function that uses >> ibuffer filters with the current project buffers. > > Might as well add 'project-ibuffer' to project.el straight, similarly to > how we have both 'project-shell' and 'project-eshell'. Not sure where proliferating the number of keybindings for every alternative will lead to. I'd rather try to use more `define-alternatives' to allow choosing alternatives between shell/eshell, list-buffers/ibuffer, ... with the same project keybinding. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 19 14:23:10 2022 Received: (at 59153) by debbugs.gnu.org; 19 Nov 2022 19:23:10 +0000 Received: from localhost ([127.0.0.1]:41460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owTQk-0006aw-78 for submit@debbugs.gnu.org; Sat, 19 Nov 2022 14:23:10 -0500 Received: from mail-wr1-f44.google.com ([209.85.221.44]:43552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owTQe-0006aA-F2 for 59153@debbugs.gnu.org; Sat, 19 Nov 2022 14:23:08 -0500 Received: by mail-wr1-f44.google.com with SMTP id g12so14183194wrs.10 for <59153@debbugs.gnu.org>; Sat, 19 Nov 2022 11:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=g94c0WsWk8hBGvT1IiPkUNbutygdCQwayK5Kbb3HQZY=; b=S5VmY1Dey3Yd+1e7W1cycwEq3zsF2aVCgSxDplszt0YCwLZ80ykDKi6VfS1jSG+3Vl um3lu8Q5wAIsDNqA6wvXpaM8WsCC5cKppP7I0I4fQz6iMGJS7U25lEIul+fdxWtZdpKJ 4Eil/9a3DyRe+sb0tIw/wK3U+rG8M+u4u9sljwcQvP2hnhBxbvVYWN5s8m8K7pmyDRbP DXvtbWqTA1KfSQp4Jn3ysGQSwNoxSIErthP5cVXZ1goV2ogbsKeXbt0lBhEbHJRkR+kG xzm4fbGC/w43GwZh/2u3vReVyR2Alydm0mG9mOpp90uLYWcB8+x0C1drbOM0cxxr6zrq m6lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g94c0WsWk8hBGvT1IiPkUNbutygdCQwayK5Kbb3HQZY=; b=ZV7tE6zqToANPNwi/IhHqQmb+eEWL1sSwsKIhxoTOmd9t2SlIsteqJfTRY4p7/efP8 5Ix8rAZ/LueuEz/9tavLMMpxhsj2sh2lCQH0A9ucmAjV5aHxK4DyrtshOgDEYJCbS0fC N6Oi0ZXg1J6a+uvStDI1u/sppvtSXSn2RD/0k51zT3X6EEPoTefbSA+GojacqmFfFIlS FMqyq/y+JOdt8Y9C+K7x0HXkxQX+AgzrlLnqGvz0JMOjE99F8eavSSjObiTRQjCRTCnx u2Cvv0+7G849iYX+PAg5OGYLyto+hggCv2aeHoQIYOAhTG/ZA1Fks0GesGtz3pcvsB1S WiaQ== X-Gm-Message-State: ANoB5pn3xlczdwiIt0IAsqNU7qPLzkXurg8mfJG8NaltJ4nxY4kj0DoM GHzvsp/o2ctM2ZMYKEKUu80= X-Google-Smtp-Source: AA0mqf4IDdOF734oS59hjiCLts6nM4SgGq4LgpXOS9dRiNPDBbbQnaZv6hgaup6T6UbmjLgQJ++ang== X-Received: by 2002:adf:f30e:0:b0:22c:e002:74c0 with SMTP id i14-20020adff30e000000b0022ce00274c0mr7616363wro.593.1668885778562; Sat, 19 Nov 2022 11:22:58 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id q14-20020a05600c46ce00b003c5571c27a1sm10698285wmo.32.2022.11.19.11.22.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Nov 2022 11:22:58 -0800 (PST) Message-ID: <499a85c8-2e30-8f6d-d990-22ff38d03af9@yandex.ru> Date: Sat, 19 Nov 2022 21:22:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: bug#59153: List project buffers Content-Language: en-US To: Juri Linkov References: <86a650t4b1.fsf@mail.linkov.net> <87mt90lyq1.fsf@disroot.org> <8635arqllm.fsf@mail.linkov.net> <86leoilmg3.fsf@mail.linkov.net> <86sfiom4oo.fsf@mail.linkov.net> <4cfe3fcc-412f-2bc8-c702-ed67196806b4@yandex.ru> <86zgcuagab.fsf@mail.linkov.net> <86v8ngy4c9.fsf@mail.linkov.net> <7cee03ff-30b4-9995-43e0-7a15613c94cd@yandex.ru> <86v8ngdp3q.fsf@mail.linkov.net> <874juz2oi5.fsf@codeisgreat.org> <86o7t4dbc9.fsf@mail.linkov.net> <864juubx1t.fsf@mail.linkov.net> From: Dmitry Gutov In-Reply-To: <864juubx1t.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 59153 Cc: 59153@debbugs.gnu.org, Pankaj Jangid X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 19.11.2022 20:48, Juri Linkov wrote: >>>> This is a really helpful feature. A query though. Will that be another >>>> feature request for the users of ibuffer. May be a variable >>>> `project-list-buffers-function`. >>> Probably this could be implemented in ibuffer.el. >>> So when ibuffer is loaded, it could override the >>> keybinding 'C-x p C-b' with own function that uses >>> ibuffer filters with the current project buffers. >> Might as well add 'project-ibuffer' to project.el straight, similarly to >> how we have both 'project-shell' and 'project-eshell'. > Not sure where proliferating the number of keybindings for every > alternative will lead to. I'd rather try to use more > `define-alternatives' to allow choosing alternatives between > shell/eshell, list-buffers/ibuffer, ... with the same > project keybinding. Maybe add it without a binding. Let the user do that choice themselves. Regarding 'define-alternatives' - sure, that's also possible. From unknown Sun Aug 17 00:57:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 18 Dec 2022 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator