GNU bug report logs - #59144
[PATCH] Add repeat-map for comint and eshell

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59144 in the body.
You can then email your comments to 59144 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add repeat-map for comint and eshell
Date: Wed, 09 Nov 2022 06:16:45 +0000

[Message part 1 (text/plain, inline)]

Tags: patch





In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.16.0, Xaw3d scroll bars)
Repository revision: 68e2a9cd92996dd55ff9599dc1bf99c70070cddb
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: NixOS 22.11 (Raccoon)

Configured using:
 'configure
 --prefix=/nix/store/1bs9w4lkx78fsln68yg51y5i8a1czfjj-emacs-git-20221108.0
 --disable-build-details --with-modules --with-x-toolkit=lucid
 --with-xft --with-cairo --with-native-compilation'

[0001-comint-Add-repeat-map-for-comint.patch (text/patch, attachment)]

[0002-em-prompt-Add-repeat-map-for-em-prompt.patch (text/patch, attachment)]

Message #8 received at 59144 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Brian Leung <leungbk <at> posteo.net>, 59144 <at> debbugs.gnu.org
Subject: Re: bug#59144: [PATCH] Add repeat-map for comint and eshell
Date: Tue, 8 Nov 2022 22:47:14 -0800

On 11/8/2022 10:16 PM, Brian Leung wrote:
> Tags: patch

Thanks. For Eshell, there are a few other commands that might make sense 
to have repeat-maps. For example, 'eshell-forward-argument' (see 
'eshell-command-map' in esh-mode.el). These are defined differently, but 
hopefully repeat-mode can handle them...

Message #11 received at 59144 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> posteo.net>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 59144 <at> debbugs.gnu.org
Subject: Re: bug#59144: [PATCH] Add repeat-map for comint and eshell
Date: Wed, 09 Nov 2022 07:19:31 +0000

[Message part 1 (text/plain, inline)]

> On 11/8/2022 10:16 PM, Brian Leung wrote:
>> Tags: patch
>
> Thanks. For Eshell, there are a few other commands that might 
> make
> sense to have repeat-maps. For example, 
> 'eshell-forward-argument' (see
> 'eshell-command-map' in esh-mode.el). These are defined 
> differently,
> but hopefully repeat-mode can handle them...

OK, see attached for additional Eshell and shell patches.

[0001-esh-mode-Add-repeat-map-for-eshell-forward-backward-.patch (text/x-patch, attachment)]

[0002-shell-Add-repeat-map-for-shell-forward-backward-prom.patch (text/x-patch, attachment)]

Message #14 received at 59144 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> posteo.net>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 59144 <at> debbugs.gnu.org
Subject: Re: bug#59144: [PATCH] Add repeat-map for comint and eshell
Date: Wed, 09 Nov 2022 07:27:40 +0000

[Message part 1 (text/plain, inline)]

Revised the commits. I reworded some commit messages and fixed a 
docstring typo.

[0001-comint-Add-repeat-map-for-comint-next-previous-promp.patch (text/x-patch, attachment)]

[0002-em-prompt-Add-repeat-map-for-eshell-next-previous-pr.patch (text/x-patch, attachment)]

[0003-esh-mode-Add-repeat-map-for-eshell-forward-backward-.patch (text/x-patch, attachment)]

[0004-shell-Add-repeat-map-for-shell-forward-backward-prom.patch (text/x-patch, attachment)]

Message #21 received at 59144-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Brian Leung <leungbk <at> posteo.net>
Cc: jporterbugs <at> gmail.com, 59144-done <at> debbugs.gnu.org
Subject: Re: bug#59144: [PATCH] Add repeat-map for comint and eshell
Date: Thu, 17 Nov 2022 11:37:45 +0200

> Cc: 59144 <at> debbugs.gnu.org
> From: Brian Leung <leungbk <at> posteo.net>
> Date: Wed, 09 Nov 2022 07:27:40 +0000
> 
> Revised the commits. I reworded some commit messages and fixed a 
> docstring typo.

Thanks, installed, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.