From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 20:19:33 2022 Received: (at submit) by debbugs.gnu.org; 9 Nov 2022 01:19:33 +0000 Received: from localhost ([127.0.0.1]:38440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osZkb-0000ra-4Q for submit@debbugs.gnu.org; Tue, 08 Nov 2022 20:19:33 -0500 Received: from lists.gnu.org ([209.51.188.17]:42138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osZkZ-0000rT-Ao for submit@debbugs.gnu.org; Tue, 08 Nov 2022 20:19:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osZkZ-0002x6-4r for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 20:19:31 -0500 Received: from smtp-20.smtpout.orange.fr ([80.12.242.20] helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osZkX-0003rN-0C for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 20:19:30 -0500 Received: from [192.168.1.15] ([2.7.97.237]) by smtp.orange.fr with ESMTPA id sZkQoTPWDOizNsZkRoexME; Wed, 09 Nov 2022 02:19:23 +0100 X-ME-Helo: [192.168.1.15] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Wed, 09 Nov 2022 02:19:23 +0100 X-ME-IP: 2.7.97.237 Content-Type: multipart/mixed; boundary="------------KF6y6bdADNzbmxwv01UAk16x" Message-ID: Date: Wed, 9 Nov 2022 02:19:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: fr, en-US To: bug-gnu-emacs@gnu.org From: David Ponce Subject: 29.0.50; batch-byte-recompile-directory doesn't recompile file as expected Received-SPF: pass client-ip=80.12.242.20; envelope-from=da_vid@orange.fr; helo=smtp.smtpout.orange.fr X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------KF6y6bdADNzbmxwv01UAk16x Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, I recently observed that batch-byte-recompile-directory no more recompile .el files newer than their .elc file. Here is the shell command I use: emacs -batch --no-init-file --no-site-file --eval "(setq load-path [my load path])" -f batch-byte-recompile-directory . After some investigation, I found that commit https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8638aace3fbe01529f33870f469fa60bf5e43ee7 could be the culprit. The attached patch fixed the above commit and solved the issue for me. Thanks In GNU Emacs 29.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6) of 2022-11-07 built on kilauea Repository revision: d04433b96215d7d3387573f19cc315de86f2341a Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Fedora Linux 36 (KDE Plasma) Configured using: 'configure --prefix=/home/dponce --with-x-toolkit=gtk3 PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/lib/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_TIME: fr_FR.utf8 value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix --------------KF6y6bdADNzbmxwv01UAk16x Content-Type: text/x-patch; charset=UTF-8; name="bytecomp.el.patch" Content-Disposition: attachment; filename="bytecomp.el.patch" Content-Transfer-Encoding: base64 aW5kZXggNGQyNThkYS4uYzgxYzQyZSAxMDA2NDQKLS0tIGEvZW1hY3MvbGlzcC9lbWFjcy1s aXNwL2J5dGVjb21wLmVsCisrKyBiL2J5dGVjb21wLmVsCkBAIC0xOTQxLDExICsxOTQxLDEw IEBAIGFsc28gYmUgY29tcGlsZWQuIgogCQkgICAgICA7OyBUaGlzIGZpbGUgaXMgYSBzdWJk aXJlY3RvcnkuICBIYW5kbGUgdGhlbSBkaWZmZXJlbnRseS4KIAkJICAgICAgKG9yIChudWxs IGFyZykgKGVxIDAgYXJnKQogCQkJICAoeS1vci1uLXAgKGNvbmNhdCAiQ2hlY2sgIiBzb3Vy Y2UgIj8gIikpKQotCQkgICAgICAoc2V0cSBkaXJlY3RvcmllcyAobmNvbmMgZGlyZWN0b3Jp ZXMgKGxpc3Qgc291cmNlKSkpCiAgICAgICAgICAgICAgICAgICAgICAgOzsgRGlyZWN0b3J5 IGlzIHJlcXVlc3RlZCB0byBiZSBpZ25vcmVkCi0gICAgICAgICAgICAgICAgICAgICAgKHN0 cmluZy1tYXRjaC1wCi0gICAgICAgICAgICAgICAgICAgICAgIChyZWdleHAtb3B0IGJ5dGUt Y29tcGlsZS1pZ25vcmUtZmlsZXMpCi0gICAgICAgICAgICAgICAgICAgICAgIHNvdXJjZSkK KyAgICAgICAgICAgICAgICAgICAgICAobm90IChzdHJpbmctbWF0Y2gtcAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChyZWdleHAtb3B0IGJ5dGUtY29tcGlsZS1pZ25vcmUtZmls ZXMpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgc291cmNlKSkKICAgICAgICAgICAg ICAgICAgICAgICAoc2V0cSBkaXJlY3RvcmllcyAobmNvbmMgZGlyZWN0b3JpZXMgKGxpc3Qg c291cmNlKSkpKQogICAgICAgICAgICAgICAgOzsgSXQgaXMgYW4gb3JkaW5hcnkgZmlsZS4g IERlY2lkZSB3aGV0aGVyIHRvIGNvbXBpbGUgaXQuCiAgICAgICAgICAgICAgICAoaWYgKGFu ZCAoc3RyaW5nLW1hdGNoIGVtYWNzLWxpc3AtZmlsZS1yZWdleHAgc291cmNlKQpAQCAtMTk1 NSw5ICsxOTU0LDkgQEAgYWxzbyBiZSBjb21waWxlZC4iCiAgICAgICAgICAgICAgICAgICAg ICAgICAobm90IChhdXRvLXNhdmUtZmlsZS1uYW1lLXAgc291cmNlKSkKICAgICAgICAgICAg ICAgICAgICAgICAgIChub3QgKG1lbWJlciBzb3VyY2UgKGRpci1sb2NhbHMtLWFsbC1maWxl cyBkaXJlY3RvcnkpKSkKICAgICAgICAgICAgICAgICAgICAgICAgIDs7IEZpbGUgaXMgcmVx dWVzdGVkIHRvIGJlIGlnbm9yZWQKLSAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmct bWF0Y2gtcAotICAgICAgICAgICAgICAgICAgICAgICAgIChyZWdleHAtb3B0IGJ5dGUtY29t cGlsZS1pZ25vcmUtZmlsZXMpCi0gICAgICAgICAgICAgICAgICAgICAgICAgc291cmNlKSkK KyAgICAgICAgICAgICAgICAgICAgICAgIChub3QgKHN0cmluZy1tYXRjaC1wCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAocmVnZXhwLW9wdCBieXRlLWNvbXBpbGUtaWdub3Jl LWZpbGVzKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc291cmNlKSkpCiAgICAg ICAgICAgICAgICAgICAgKHByb2duIChjbC1pbmNmCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAocGNhc2UgKGJ5dGUtcmVjb21waWxlLWZpbGUgc291cmNlIGZvcmNlIGFyZykKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKCduby1ieXRlLWNvbXBpbGUgc2tpcC1jb3Vu dCkK --------------KF6y6bdADNzbmxwv01UAk16x-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 09 04:41:46 2022 Received: (at 59139) by debbugs.gnu.org; 9 Nov 2022 09:41:46 +0000 Received: from localhost ([127.0.0.1]:39062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oshac-0001Gs-4V for submit@debbugs.gnu.org; Wed, 09 Nov 2022 04:41:46 -0500 Received: from smtp-22.smtpout.orange.fr ([80.12.242.22]:63485 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oshaZ-0001Gi-Rg for 59139@debbugs.gnu.org; Wed, 09 Nov 2022 04:41:44 -0500 Received: from [192.168.1.15] ([2.7.97.237]) by smtp.orange.fr with ESMTPA id shaVolX4vKOP1shaWoOgMC; Wed, 09 Nov 2022 10:41:42 +0100 X-ME-Helo: [192.168.1.15] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Wed, 09 Nov 2022 10:41:42 +0100 X-ME-IP: 2.7.97.237 Message-ID: <08b86242-18b3-0325-86d9-aacf38e3a6c4@orange.fr> Date: Wed, 9 Nov 2022 10:41:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 To: 59139@debbugs.gnu.org Content-Language: fr, en-US From: David Ponce Subject: bug#59139: Acknowledgement (29.0.50; batch-byte-recompile-directory doesn't recompile file as expected) Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59139 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Part of the issue (Bug#59115) has just been fixed by commit a01024c859fd98a4a330a9b627dc11232afc6ad0 However it seems my proposed patch is more complete. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 12 11:01:58 2022 Received: (at 59139) by debbugs.gnu.org; 12 Nov 2022 16:01:58 +0000 Received: from localhost ([127.0.0.1]:48830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otsxC-00062D-KH for submit@debbugs.gnu.org; Sat, 12 Nov 2022 11:01:58 -0500 Received: from smtp-18.smtpout.orange.fr ([80.12.242.18]:57472 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otsxA-00061w-Bv for 59139@debbugs.gnu.org; Sat, 12 Nov 2022 11:01:57 -0500 Received: from [192.168.1.15] ([2.7.97.237]) by smtp.orange.fr with ESMTPA id tsx6opWgftk1atsx6osxwz; Sat, 12 Nov 2022 17:01:54 +0100 X-ME-Helo: [192.168.1.15] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Sat, 12 Nov 2022 17:01:54 +0100 X-ME-IP: 2.7.97.237 Message-ID: <27609d06-c428-d6f4-e7a3-fa9427d99895@orange.fr> Date: Sat, 12 Nov 2022 17:01:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 To: 59139@debbugs.gnu.org, 59115@debbugs.gnu.org Content-Language: fr, en-US From: David Ponce Subject: 29.0.50; batch-byte-recompile-directory doesn't recompile file as expected Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59139 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, If I correctly understood the code, a fix similar to the one applied for Bug#59115 is also needed for directories. Please find below another patch. Please also feel free to close this Bug#59139. diff --git a/bytecomp.el b/bytecomp.el index c685e50..c81c42e 100644 --- a/bytecomp.el +++ b/bytecomp.el @@ -1941,11 +1941,10 @@ also be compiled." ;; This file is a subdirectory. Handle them differently. (or (null arg) (eq 0 arg) (y-or-n-p (concat "Check " source "? "))) - (setq directories (nconc directories (list source))) ;; Directory is requested to be ignored - (string-match-p - (regexp-opt byte-compile-ignore-files) - source) + (not (string-match-p + (regexp-opt byte-compile-ignore-files) + source)) (setq directories (nconc directories (list source)))) ;; It is an ordinary file. Decide whether to compile it. (if (and (string-match emacs-lisp-file-regexp source) Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 02:12:49 2022 Received: (at control) by debbugs.gnu.org; 13 Nov 2022 07:12:50 +0000 Received: from localhost ([127.0.0.1]:49944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ou7Af-0006vX-KG for submit@debbugs.gnu.org; Sun, 13 Nov 2022 02:12:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ou7Ac-0006vB-Et; Sun, 13 Nov 2022 02:12:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ou7AW-0001HA-K2; Sun, 13 Nov 2022 02:12:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=H4bbwBoO1tf/XlsbZHw2A0NYoH+2IIRALinlQa/7Bpc=; b=DVhU4GrLSfaf 9/pqSZ35+lL8hH9ARoYh9elBo6A5fg/eJj/T+uobOzpZoxVeTOWwIPG5YwG2V/9jB2QLEo5o4LppV zizxQaRsuu9yEA2OTw2RLCzhVkMI1Pxj1zNcR2x2+0/8WxTASlFXD6Q4tq9PIZqwibhEUE3ci0rha 9dk6p4G3tP5lwK8qXi+RDeZeppFz7N6AIO+8n3YINweSfCFN2k+CjD2jq1m91Ew83KtASIjNnpI7C J3JXTT9XY55xisKBkcXZbhpZ+HT+vt4GQLGQK20nUZ3uFycpi1XLDxABFJ6ZCfJWfJVuXfkGI+420 5C3H4eQRgj+9VVctU3eDUA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ou7AV-0000YY-2K; Sun, 13 Nov 2022 02:12:40 -0500 Date: Sun, 13 Nov 2022 09:12:47 +0200 Message-Id: <834jv3miog.fsf@gnu.org> From: Eli Zaretskii To: lin Sun , Philip Kaludercic In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#59236: 29.0.50; [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore References: <1181651021.466162.1581309285621.ref@mail.yahoo.com> <1181651021.466162.1581309285621@mail.yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control Cc: 59236@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 59236 59139 thanks > Date: Sun, 13 Nov 2022 04:26:45 +0000 > From: lin Sun via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > The patch 8638aace3f try to use the variable > `byte-compile-ignore-files`, but the logic is inverse for both file > and directory parts; > and the patch a01024c859 fix the logic for file part; > this patch try to fix the logic for directory part. > > Please help review and apply it. Thanks. This is a duplicate of bug#59139. Philip, can you please take care of this? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 05:12:37 2022 Received: (at 59139) by debbugs.gnu.org; 13 Nov 2022 10:12:37 +0000 Received: from localhost ([127.0.0.1]:50111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ou9yf-0005CZ-9U for submit@debbugs.gnu.org; Sun, 13 Nov 2022 05:12:37 -0500 Received: from smtp-15.smtpout.orange.fr ([80.12.242.15]:58696 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ou9yd-0005CR-Ip for 59139@debbugs.gnu.org; Sun, 13 Nov 2022 05:12:36 -0500 Received: from [192.168.1.15] ([2.7.97.237]) by smtp.orange.fr with ESMTPA id u9yYoXkwsTLjwu9yZoVaC3; Sun, 13 Nov 2022 11:12:34 +0100 X-ME-Helo: [192.168.1.15] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Sun, 13 Nov 2022 11:12:34 +0100 X-ME-IP: 2.7.97.237 Message-ID: <9364482a-c29a-cc28-34a8-f596cf019bfa@orange.fr> Date: Sun, 13 Nov 2022 11:12:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#59139: closed (Re: bug#59236: 29.0.50; [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore) Content-Language: fr, en-US To: 59139@debbugs.gnu.org References: <87edu7wc77.fsf@posteo.net> From: David Ponce In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 59139 Cc: Philip Kaludercic , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 13/11/2022 08:23, GNU bug Tracking System wrote: > Your bug report > > #59236: 29.0.50; batch-byte-recompile-directory doesn't recompile file as expected > > which was filed against the emacs package, has been closed. > > The explanation is attached below, along with your original report. > If you require more details, please reply to 59139@debbugs.gnu.org. > As mentioned in bug#59236 and my reported bug#59139, the patch 8638aace3f to use the variable `byte-compile-ignore-files` has the logic inverse for both file and *directory* parts. Currently the patch a01024c859 fixed the logic for file part, but the fix to the directory part is still missing, as far as I can see in master. Currently, according to the code, when a directory matchs `byte-compile-ignore-files` it is appended 2 times instead of being ignored. Thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 14 06:50:53 2022 Received: (at 59139) by debbugs.gnu.org; 14 Nov 2022 11:50:53 +0000 Received: from localhost ([127.0.0.1]:49081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouXzI-0003rI-PW for submit@debbugs.gnu.org; Mon, 14 Nov 2022 06:50:53 -0500 Received: from mout01.posteo.de ([185.67.36.65]:38529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouXzG-0003r4-UU for 59139@debbugs.gnu.org; Mon, 14 Nov 2022 06:50:51 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 49E3F240027 for <59139@debbugs.gnu.org>; Mon, 14 Nov 2022 12:50:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668426645; bh=+PII++uJ0M5JuQq1o+pybWfRWFqYp7/WkFKT166ah9I=; h=From:To:Cc:Subject:Date:From; b=KxZiAFerMm8AoJvTRJ1Tif61twB0rcWGmsKuBdLrA+kmPBQOwo3gKSiAXfEe6BWQK DKYWRTnNUj47FROhCWGPyFVwYWp5UVQqeZCkG2FqZJe7oWpBbvQWrDdNSSjfaEjSr3 I0NuvvM6pVupV7Cd6xTkEhuGoO4pVM9vo6ZzA06Vpym9CrBook41xrw6TCNLMoXE7a 3suhxpbB1HBJDuvxO7sWAFT+fJ39xfrZ+tZk2xWcbpg7ezUmRtPwM4KJ6rWzyPqp3M zJHHeHSSHWsnfLBYuBjz9auzXj5VQNS5sAVKR1nIUt+6y7Txis7GGPIO6Yc9MnLWa9 tgjnhhq9XQtXw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N9ngm34B3z6tmF; Mon, 14 Nov 2022 12:50:44 +0100 (CET) From: Philip Kaludercic To: David Ponce Subject: Re: bug#59139: closed (Re: bug#59236: 29.0.50; [PATCH] bytecomp.el: (byte-recompile-directory): Fix negated ignore) In-Reply-To: <9364482a-c29a-cc28-34a8-f596cf019bfa@orange.fr> (David Ponce's message of "Sun, 13 Nov 2022 11:12:30 +0100") References: <87edu7wc77.fsf@posteo.net> <9364482a-c29a-cc28-34a8-f596cf019bfa@orange.fr> Date: Mon, 14 Nov 2022 11:50:44 +0000 Message-ID: <87v8nh21rf.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59139 Cc: 59139@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) David Ponce writes: > On 13/11/2022 08:23, GNU bug Tracking System wrote: >> Your bug report >> #59236: 29.0.50; batch-byte-recompile-directory doesn't recompile >> file as expected >> which was filed against the emacs package, has been closed. >> The explanation is attached below, along with your original report. >> If you require more details, please reply to 59139@debbugs.gnu.org. >> > > As mentioned in bug#59236 and my reported bug#59139, the patch > 8638aace3f to use the variable `byte-compile-ignore-files` has > the logic inverse for both file and *directory* parts. > Currently the patch a01024c859 fixed the logic for file part, but > the fix to the directory part is still missing, as far as I can > see in master. Currently, according to the code, when a > directory matchs `byte-compile-ignore-files` it is appended 2 > times instead of being ignored. You are right. I have also discovered that this is related to the failing tests reported in bug#59109. I'll rework your patch and apply that then. From unknown Sat Jun 14 19:47:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 15 Dec 2022 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator