GNU bug report logs - #59137
[PATCH] To minor changes related to overlays

Previous Next

Full log

Message #35 received at 59137 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: matt <at> rfc20.org, monnier <at> iro.umontreal.ca, 59137 <at> debbugs.gnu.org
Subject: Re: bug#59137: [PATCH] To minor changes related to overlays
Date: Wed, 30 Nov 2022 15:25:41 +0200

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Wed, 30 Nov 2022 02:28:09 +0100
> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, Eli Zaretskii <eliz <at> gnu.org>, 59137 <at> debbugs.gnu.org
> 
> Matt Armstrong <matt <at> rfc20.org> writes:
> 
> > The admittedly redundant NULL check done by itree_empty_p does not
> > change semantics or cause harm.  mark_overlays in alloc.c is a recursive
> > function so it handles NULL itself, hence the NULL check was omitted in
> > the original code.
> 
> Thanks.
> 
> I guess as this is a minor cleanup this should go to master at this point.

I agree.  We can always cherry-pick if we find a good reason.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.