From unknown Fri Jun 20 07:24:43 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59137 <59137@debbugs.gnu.org> To: bug#59137 <59137@debbugs.gnu.org> Subject: Status: [PATCH] To minor changes related to overlays Reply-To: bug#59137 <59137@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:24:43 +0000 retitle 59137 [PATCH] To minor changes related to overlays reassign 59137 emacs submitter 59137 Matt Armstrong severity 59137 normal tag 59137 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 18:14:31 2022 Received: (at submit) by debbugs.gnu.org; 8 Nov 2022 23:14:31 +0000 Received: from localhost ([127.0.0.1]:38375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osXna-0006Mp-Gj for submit@debbugs.gnu.org; Tue, 08 Nov 2022 18:14:30 -0500 Received: from lists.gnu.org ([209.51.188.17]:52670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osXnY-0006Mi-Ha for submit@debbugs.gnu.org; Tue, 08 Nov 2022 18:14:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osXnY-0005CC-Bo for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 18:14:28 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osXnN-0008LY-Pf for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 18:14:28 -0500 Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id 3C23D1BF203 for ; Tue, 8 Nov 2022 23:14:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1667949253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=161aOcVUVeos8m0/SLRaF2hW9GAMNtP5TasIinDrU7Q=; b=aSaUX9mIIcPRsdqejrQNxVYNvq0VXpHOmrBtZSnfGqJqHvpasLDBGCdE7zbILMy+8T69Kd mA8aMTY7lJYEJXyowijUkUynMKxSRcPCYHaNNXVyZph7ssvYpYwfE5Cu4QyWyKsbYlecy0 a4i4r/bXYx5jFhO40FxB9bZD3kx90aycId994uq9d5k4j4J7cbVpeFPZqZZBeqCOiGhQ44 s6Ofmsr7P/OQKxKNcJfBdKTeofaDVrotbBJBqIkP78a5NbWCtpliebv4BZh0wMOeLhqKkW iQ+Mtutuml+YJpBbq5V/hBlwXE39GPtqogqUIOC9WHBoRXyop3sVYEJ4+G5oxQ== Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1osXnE-001eak-0a for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 15:14:08 -0800 From: Matt Armstrong To: bug-gnu-emacs@gnu.org Subject: [PATCH] To minor changes related to overlays Date: Tue, 08 Nov 2022 15:14:08 -0800 Message-ID: <87edudm43j.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=217.70.183.201; envelope-from=matt@rfc20.org; helo=relay8-d.mail.gandi.net X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Tags: patch X-Debbugs-CC: Stefan Monnier --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-itree_empty_p-for-clarity-and-reduced-coupling.patch >From 023dddaf723aacd6579331f76f61a2741a4e52d5 Mon Sep 17 00:00:00 2001 From: Matt Armstrong Date: Tue, 8 Nov 2022 15:00:18 -0800 Subject: [PATCH 1/2] Add itree_empty_p for clarity and reduced coupling * src/itree.h (itree_empty_p): New predicate. * src/buffer.h (buffer_has_overlays): Call it. * src/pdumper.c (dump_buffer): ditto. * src/alloc.c (mark_buffer): ditto. --- src/alloc.c | 2 +- src/buffer.h | 3 +-- src/itree.h | 9 +++++++++ src/pdumper.c | 2 +- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/alloc.c b/src/alloc.c index 6862cf916fb..d815a199fe0 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -6548,7 +6548,7 @@ mark_buffer (struct buffer *buffer) if (!BUFFER_LIVE_P (buffer)) mark_object (BVAR (buffer, undo_list)); - if (buffer->overlays) + if (!itree_empty_p (buffer->overlays)) mark_overlays (buffer->overlays->root); /* If this is an indirect buffer, mark its base buffer. */ diff --git a/src/buffer.h b/src/buffer.h index 2e80c8a7b04..08b0420c066 100644 --- a/src/buffer.h +++ b/src/buffer.h @@ -1273,8 +1273,7 @@ set_buffer_intervals (struct buffer *b, INTERVAL i) INLINE bool buffer_has_overlays (void) { - return current_buffer->overlays - && (current_buffer->overlays->root != NULL); + return !itree_empty_p (current_buffer->overlays); } /* Functions for accessing a character or byte, diff --git a/src/itree.h b/src/itree.h index 10ee0897c37..d6c6fb10591 100644 --- a/src/itree.h +++ b/src/itree.h @@ -25,6 +25,8 @@ #define ITREE_H #include "lisp.h" +INLINE_HEADER_BEGIN + /* The tree and node structs are mainly here, so they can be allocated. @@ -117,6 +119,11 @@ #define ITREE_H ptrdiff_t, ptrdiff_t); extern struct itree_tree *itree_create (void); extern void itree_destroy (struct itree_tree *); +INLINE bool +itree_empty_p (struct itree_tree *tree) +{ + return !tree || !tree->root; +} extern intmax_t itree_size (struct itree_tree *); extern void itree_clear (struct itree_tree *); extern void itree_insert (struct itree_tree *, struct itree_node *, @@ -183,4 +190,6 @@ #define ITREE_FOREACH_ABORT() \ #define ITREE_FOREACH_NARROW(beg, end) \ itree_iterator_narrow (itree_iter_, beg, end) +INLINE_HEADER_END + #endif diff --git a/src/pdumper.c b/src/pdumper.c index 0a5d96dbb7c..22d3f3f90e4 100644 --- a/src/pdumper.c +++ b/src/pdumper.c @@ -2863,7 +2863,7 @@ dump_buffer (struct dump_context *ctx, const struct buffer *in_buffer) DUMP_FIELD_COPY (out, buffer, inhibit_buffer_hooks); DUMP_FIELD_COPY (out, buffer, long_line_optimizations_p); - if (buffer->overlays && buffer->overlays->root != NULL) + if (!itree_empty_p (buffer->overlays)) /* We haven't implemented the code to dump overlays. */ emacs_abort (); else -- 2.35.1 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0002-Simplify-ITREE_FOREACH.patch >From 67caf59c7399659a7de273c175134eac88e777ac Mon Sep 17 00:00:00 2001 From: Matt Armstrong Date: Tue, 8 Nov 2022 15:08:00 -0800 Subject: [PATCH 2/2] Simplify ITREE_FOREACH * src/itree.c (itree_iterator_next): Call itree_iterator_finish if returning NULL. * src/itree.h (ITREE_FOREACH): Don't call itree_iterator_finish. --- src/itree.c | 3 +++ src/itree.h | 7 +++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/itree.c b/src/itree.c index 989173db4e5..74199db3e42 100644 --- a/src/itree.c +++ b/src/itree.c @@ -1431,6 +1431,9 @@ itree_iterator_next (struct itree_iterator *g) after it was pushed: Check if it still intersects. */ } while (node && ! interval_node_intersects (node, g->begin, g->end)); + if (!node) + itree_iterator_finish(g); + return node; } diff --git a/src/itree.h b/src/itree.h index d6c6fb10591..67e258dd832 100644 --- a/src/itree.h +++ b/src/itree.h @@ -179,10 +179,9 @@ #define ITREE_FOREACH(n, t, beg, end, order) \ { } \ else \ for (struct itree_iterator *itree_iter_ \ - = itree_iterator_start (t, beg, end, ITREE_##order, \ - __FILE__, __LINE__); \ - ((n = itree_iterator_next (itree_iter_)) \ - || (itree_iterator_finish (itree_iter_), false));) + = itree_iterator_start (t, beg, end, ITREE_##order, \ + __FILE__, __LINE__); \ + (n = itree_iterator_next (itree_iter_));) #define ITREE_FOREACH_ABORT() \ itree_iterator_finish (itree_iter_) -- 2.35.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 05:38:44 2022 Received: (at 59137) by debbugs.gnu.org; 10 Nov 2022 10:38:44 +0000 Received: from localhost ([127.0.0.1]:42038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot4xI-000888-7T for submit@debbugs.gnu.org; Thu, 10 Nov 2022 05:38:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot4xG-00087t-Bb for 59137@debbugs.gnu.org; Thu, 10 Nov 2022 05:38:42 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot4xA-00050O-3L; Thu, 10 Nov 2022 05:38:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UaSfT1az+Kc64Qb+VNd6MP3mMqgYnAeDqHT680KbqVM=; b=cMvHh83MdfW7 MCGp7OHEnLten9sOcZQ/NSo4oSwOtcawcK+WCNm1I3L6KiCT0zT4ih+rq3ES6J9NfcHpzUSpEoBOz p9u3Y6JbyqAvhTOTGLbMeQbqQuYRUNla5CAIPPS4wqq1htqf3q6k7qDLOyPNbn24gZyoSyEMi8sbm DlwdMrt2biUNIXu5jHFYObAb7V03880fbq8BCp82GHahyqzTjI/YNwFfSOzXK8gJHQLoHUOu10tgq bhj7HggnQAkXtXofSd2wVkmZN3teZauTY3k0SkyWC9zyePewHsZ9mwdTZ/HtxHQxkmfjpHcD3s9yg raNF43rcGkmGEeOtcfbwDQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot4x0-0001Fx-3H; Thu, 10 Nov 2022 05:38:35 -0500 Date: Thu, 10 Nov 2022 12:38:26 +0200 Message-Id: <834jv7rt5p.fsf@gnu.org> From: Eli Zaretskii To: Matt Armstrong , Stefan Monnier In-Reply-To: <87edudm43j.fsf@rfc20.org> (message from Matt Armstrong on Tue, 08 Nov 2022 15:14:08 -0800) Subject: Re: bug#59137: [PATCH] To minor changes related to overlays References: <87edudm43j.fsf@rfc20.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59137 Cc: 59137@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Matt Armstrong > Date: Tue, 08 Nov 2022 15:14:08 -0800 > > Tags: patch > > X-Debbugs-CC: Stefan Monnier Stefan, any comments? I have just one nit: > diff --git a/src/itree.c b/src/itree.c > index 989173db4e5..74199db3e42 100644 > --- a/src/itree.c > +++ b/src/itree.c > @@ -1431,6 +1431,9 @@ itree_iterator_next (struct itree_iterator *g) > after it was pushed: Check if it still intersects. */ > } while (node && ! interval_node_intersects (node, g->begin, g->end)); > > + if (!node) > + itree_iterator_finish(g); ^ Please leave one space between the function's name and the open parenthesis of the argument list. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 15 12:53:49 2022 Received: (at 59137) by debbugs.gnu.org; 15 Nov 2022 17:53:49 +0000 Received: from localhost ([127.0.0.1]:55199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ov084-0003XB-Gc for submit@debbugs.gnu.org; Tue, 15 Nov 2022 12:53:48 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:60241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ov07y-0003Wq-Ql for 59137@debbugs.gnu.org; Tue, 15 Nov 2022 12:53:47 -0500 Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id C2EC8E0007; Tue, 15 Nov 2022 17:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1668534816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C2eCUlAYLMXE2jfqb7b8Z4/Pj2UW+7RJq001bm/Q+js=; b=RoOn6Gn0vZeRkR7hHgpj5f3PhLay54SzKcg0kADAmZ9XWq5GlOGDCxUa3Rh8PRJywsPeo7 wgAzYdyrgjdkDT9GKSI5TwXvjLFjaZSiM97mcPRhjMp3FDuL4G53dzoVoh4161HvyceWfB QzwqNYiIgY4wV/KE1OWM8KFaQ0/tPwUQbP78G9C5pwe8oWWfH8dzxc0s84/2tBdmT8j29F XpAW148ozZzsl+vpeMU/DqbMJf7OwTCp3GbeKUThYu9d0doBcfidpYUwalMhCxRUvFsOv6 kVbdgUjWuSoVVyDScDDzuuFFvaoxejjGFZHZOkzJWPVNY31/2fryUy+mez83yw== Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1ov07o-000QNd-0b; Tue, 15 Nov 2022 09:53:32 -0800 From: Matt Armstrong To: Eli Zaretskii , Stefan Monnier Subject: Re: bug#59137: [PATCH] To minor changes related to overlays In-Reply-To: <834jv7rt5p.fsf@gnu.org> References: <87edudm43j.fsf@rfc20.org> <834jv7rt5p.fsf@gnu.org> Date: Tue, 15 Nov 2022 09:53:32 -0800 Message-ID: <87edu46r4z.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59137 Cc: 59137@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> + if (!node) >> + itree_iterator_finish(g); > ^ > Please leave one space between the function's name and the open > parenthesis of the argument list. Ahh, yes. Attached are new patches, rebased to current master, with that formatting change. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-itree_empty_p-for-clarity-and-reduced-coupling.patch >From 9cdfe65ee28c68398b9305d15f178358f02f4498 Mon Sep 17 00:00:00 2001 From: Matt Armstrong Date: Tue, 8 Nov 2022 15:00:18 -0800 Subject: [PATCH 1/2] Add itree_empty_p for clarity and reduced coupling * src/itree.h (itree_empty_p): New predicate. * src/buffer.h (buffer_has_overlays): Call it. * src/pdumper.c (dump_buffer): ditto. * src/alloc.c (mark_buffer): ditto. --- src/alloc.c | 2 +- src/buffer.h | 3 +-- src/itree.h | 9 +++++++++ src/pdumper.c | 2 +- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/alloc.c b/src/alloc.c index 6862cf916f..d815a199fe 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -6548,7 +6548,7 @@ mark_buffer (struct buffer *buffer) if (!BUFFER_LIVE_P (buffer)) mark_object (BVAR (buffer, undo_list)); - if (buffer->overlays) + if (!itree_empty_p (buffer->overlays)) mark_overlays (buffer->overlays->root); /* If this is an indirect buffer, mark its base buffer. */ diff --git a/src/buffer.h b/src/buffer.h index 2e80c8a7b0..08b0420c06 100644 --- a/src/buffer.h +++ b/src/buffer.h @@ -1273,8 +1273,7 @@ set_buffer_intervals (struct buffer *b, INTERVAL i) INLINE bool buffer_has_overlays (void) { - return current_buffer->overlays - && (current_buffer->overlays->root != NULL); + return !itree_empty_p (current_buffer->overlays); } /* Functions for accessing a character or byte, diff --git a/src/itree.h b/src/itree.h index 10ee0897c3..d6c6fb1059 100644 --- a/src/itree.h +++ b/src/itree.h @@ -25,6 +25,8 @@ #define ITREE_H #include "lisp.h" +INLINE_HEADER_BEGIN + /* The tree and node structs are mainly here, so they can be allocated. @@ -117,6 +119,11 @@ #define ITREE_H ptrdiff_t, ptrdiff_t); extern struct itree_tree *itree_create (void); extern void itree_destroy (struct itree_tree *); +INLINE bool +itree_empty_p (struct itree_tree *tree) +{ + return !tree || !tree->root; +} extern intmax_t itree_size (struct itree_tree *); extern void itree_clear (struct itree_tree *); extern void itree_insert (struct itree_tree *, struct itree_node *, @@ -183,4 +190,6 @@ #define ITREE_FOREACH_ABORT() \ #define ITREE_FOREACH_NARROW(beg, end) \ itree_iterator_narrow (itree_iter_, beg, end) +INLINE_HEADER_END + #endif diff --git a/src/pdumper.c b/src/pdumper.c index 0a5d96dbb7..22d3f3f90e 100644 --- a/src/pdumper.c +++ b/src/pdumper.c @@ -2863,7 +2863,7 @@ dump_buffer (struct dump_context *ctx, const struct buffer *in_buffer) DUMP_FIELD_COPY (out, buffer, inhibit_buffer_hooks); DUMP_FIELD_COPY (out, buffer, long_line_optimizations_p); - if (buffer->overlays && buffer->overlays->root != NULL) + if (!itree_empty_p (buffer->overlays)) /* We haven't implemented the code to dump overlays. */ emacs_abort (); else -- 2.35.1 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0002-Simplify-ITREE_FOREACH.patch >From c2fc83ff7e7d49bdb013881453e504f21f038104 Mon Sep 17 00:00:00 2001 From: Matt Armstrong Date: Tue, 8 Nov 2022 15:08:00 -0800 Subject: [PATCH 2/2] Simplify ITREE_FOREACH * src/itree.c (itree_iterator_next): Call itree_iterator_finish if returning NULL. * src/itree.h (ITREE_FOREACH): Don't call itree_iterator_finish. --- src/itree.c | 3 +++ src/itree.h | 7 +++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/itree.c b/src/itree.c index ae69c97d6d..18ee6449ce 100644 --- a/src/itree.c +++ b/src/itree.c @@ -1431,6 +1431,9 @@ itree_iterator_next (struct itree_iterator *g) after it was pushed: Check if it still intersects. */ } while (node && ! interval_node_intersects (node, g->begin, g->end)); + if (!node) + itree_iterator_finish (g); + return node; } diff --git a/src/itree.h b/src/itree.h index d6c6fb1059..67e258dd83 100644 --- a/src/itree.h +++ b/src/itree.h @@ -179,10 +179,9 @@ #define ITREE_FOREACH(n, t, beg, end, order) \ { } \ else \ for (struct itree_iterator *itree_iter_ \ - = itree_iterator_start (t, beg, end, ITREE_##order, \ - __FILE__, __LINE__); \ - ((n = itree_iterator_next (itree_iter_)) \ - || (itree_iterator_finish (itree_iter_), false));) + = itree_iterator_start (t, beg, end, ITREE_##order, \ + __FILE__, __LINE__); \ + (n = itree_iterator_next (itree_iter_));) #define ITREE_FOREACH_ABORT() \ itree_iterator_finish (itree_iter_) -- 2.35.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 24 20:16:23 2022 Received: (at 59137) by debbugs.gnu.org; 25 Nov 2022 01:16:23 +0000 Received: from localhost ([127.0.0.1]:60686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyNKI-0008VH-SI for submit@debbugs.gnu.org; Thu, 24 Nov 2022 20:16:23 -0500 Received: from mail-oa1-f51.google.com ([209.85.160.51]:42967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyNK7-0008US-Oa for 59137@debbugs.gnu.org; Thu, 24 Nov 2022 20:16:12 -0500 Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-142b72a728fso3564010fac.9 for <59137@debbugs.gnu.org>; Thu, 24 Nov 2022 17:16:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=LNWWmlvmClk1LOmjYSIINbc4ZaUP5k+j2ORSr6GhNJg=; b=WXBkAhftoueKm1OmP0NFbfDKg+rKSerSmMhsSgtefWuKC7ZMMyPSmQdySbnujWH3TB pu2lGHbDe/uYM62UHLy40ysIeljtREb7fVPJNsD16qKIK6lQlNUTuWwHBZZMFNzwba7L MvjVtk/c/wfmqYuctNMGAlc6TavcwkuNGFCwUtvbsSb8iCmRwTYxHLhJcDG4eNM7jdMN f9moJHEj7HGHYgW7x3dgpEce+88ZizY3gnfqA/yjQY7OOTw2vGBvxQEbq9mNV5d2KMsr Pya60y+/CcYkIg1oDdcRF3r7LaSl5nj5U0CPYd2v54CItf+IaGQTuI5SXfeOXlqNJk5u iv+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LNWWmlvmClk1LOmjYSIINbc4ZaUP5k+j2ORSr6GhNJg=; b=0P9sJ9iRgScZc48RE13ejpmE155MXCbo1CshPcPp3SFG/ZlzlPsC6YDNZ2EH+4Z7nh T2iH7Wjm9bZMDwuc4oT5UwPHjgEvzo4WlhhhMuV9gICne/9Z4vr3UdJz0XPQB5pqHyL4 BbFqLne4OM0qjWRuUXQmjXGWELHONJtHx+4Lw09JlIrEjdXxhK/9FuRrUhC3CN/Sd6db wND+5ioO2v8NnyiIThu+V+CO7QrnRfKp3XEunYC5TyVg5+E5X9hOrsBi5Ef6XEYhWLsB DcGPND2zVClipseZ3SPh7dhhAssLVeWJdlHSSc3HR+8Mn6LIE/Vls+hWId27F9f4Zeds zfnw== X-Gm-Message-State: ANoB5pmNZbE71yYgZy28KQ0exBPpPOyk4n8Cb9IXlWU0CJrB1GA65fYK mnkYZirZUJYx1p7ZA5rdH70+8XoiKxls8X4dLh6U6amm9F0= X-Google-Smtp-Source: AA0mqf5PiUMGmrYq8bDL7kVXT4xl8RgcTXzK17FkU3F2XxvsvmXN851xNNoRsQaMl6SvILM0OefJXN2cOVAZZ5uuhAg= X-Received: by 2002:a05:6870:4995:b0:143:522a:ebcc with SMTP id ho21-20020a056870499500b00143522aebccmr2890096oab.199.1669338966389; Thu, 24 Nov 2022 17:16:06 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 24 Nov 2022 17:16:06 -0800 From: Stefan Kangas In-Reply-To: <87edu46r4z.fsf@rfc20.org> (Matt Armstrong's message of "Tue, 15 Nov 2022 09:53:32 -0800") References: <87edudm43j.fsf@rfc20.org> <834jv7rt5p.fsf@gnu.org> <87edu46r4z.fsf@rfc20.org> X-Hashcash: 1:20:221125:59137@debbugs.gnu.org::uzyxwxWaDbdney7S:3DZh MIME-Version: 1.0 Date: Thu, 24 Nov 2022 17:16:06 -0800 Message-ID: Subject: Re: bug#59137: [PATCH] To minor changes related to overlays To: Matt Armstrong Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59137 Cc: Eli Zaretskii , Stefan Monnier , 59137@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Matt Armstrong writes: > Eli Zaretskii writes: > >>> + if (!node) >>> + itree_iterator_finish(g); >> ^ >> Please leave one space between the function's name and the open >> parenthesis of the argument list. > > Ahh, yes. Attached are new patches, rebased to current master, with > that formatting change. Should these patches be installed? Stefan? From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 25 09:48:39 2022 Received: (at 59137) by debbugs.gnu.org; 25 Nov 2022 14:48:39 +0000 Received: from localhost ([127.0.0.1]:33944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oya0N-0003T8-32 for submit@debbugs.gnu.org; Fri, 25 Nov 2022 09:48:39 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oya0I-0003Sq-0z for 59137@debbugs.gnu.org; Fri, 25 Nov 2022 09:48:37 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C7FB11000FF; Fri, 25 Nov 2022 09:48:27 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7C1351000D1; Fri, 25 Nov 2022 09:48:26 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1669387706; bh=83hzw4wE17Sq+QGCOqxZmKJYCGw5neiezax2/plBaY4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Zr1PJ8HYrO21ClFivyI7rK3H1rK9KHHS7PwlQ0xNLG+nkcAKkzY58WcVS55DkSiV3 QLBtcRcYjPIUPliw+o9bDQeAzhZafL3XDcxJtmdrOf+Yj9Sy9NNfGKfKnKjVKyxBDt KEwQ7/tRmuCW/Q/r4VXA+Wxc5YrYhjnE+FrOlQuV0qwSKfH/ZAFyFQp/6zScP9RU8V ETaw08CKxYrtYWOwWNN1ctKQ6JHqi1aHDUn/0Jpx2SDMHYv2A93HmEHKC2AV6AdEYP esWEjvcjeLxdo/6nW1q9Hv7d4MO2Z5qsxxNNtoH+KLK7Y8akPnjPAb9cppO72KKv9v P54YPk3N9/idg== Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4D54F121DE6; Fri, 25 Nov 2022 09:48:26 -0500 (EST) From: Stefan Monnier To: Stefan Kangas Subject: Re: bug#59137: [PATCH] To minor changes related to overlays In-Reply-To: (Stefan Kangas's message of "Thu, 24 Nov 2022 17:16:06 -0800") Message-ID: References: <87edudm43j.fsf@rfc20.org> <834jv7rt5p.fsf@gnu.org> <87edu46r4z.fsf@rfc20.org> Date: Fri, 25 Nov 2022 09:48:25 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: =?UTF-8?Q?0=0A=09?=ALL_TRUSTED -1 Passed through trusted hosts only via =?UTF-8?Q?SMTP=0A=09?=AWL -0.014 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily =?UTF-8?Q?valid=0A=09?=DKIM_VALID -0.1 Message has at least one valid DKIM or DK =?UTF-8?Q?signature=0A=09?=DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59137 Cc: Matt Armstrong , Eli Zaretskii , 59137@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Should these patches be installed? Stefan? I don't have an opinion on the `itree_empty_p` patch, but the one about `itree_iterator_finish` doesn't apply any more because `itree_iterator_finish` has been removed in the mean time. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 09:05:48 2022 Received: (at 59137) by debbugs.gnu.org; 26 Nov 2022 14:05:48 +0000 Received: from localhost ([127.0.0.1]:38267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyvoR-0004ff-Rb for submit@debbugs.gnu.org; Sat, 26 Nov 2022 09:05:48 -0500 Received: from mail-oi1-f175.google.com ([209.85.167.175]:35505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyvoN-0004fP-AL for 59137@debbugs.gnu.org; Sat, 26 Nov 2022 09:05:46 -0500 Received: by mail-oi1-f175.google.com with SMTP id h132so7147848oif.2 for <59137@debbugs.gnu.org>; Sat, 26 Nov 2022 06:05:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=SGnwo/4KLUBcipn0kqkCbnl3XJeVMa7hwQJA362AevE=; b=ONYq91xb8NDDkQXG8wZcRVFnT9OjJ9JzWCcvpv2Q+9/rv3OfbiBYH69Loy/FO42qgt 1lH7I1a9/buxVU8da9wj11zfr+I9c/PQwryCNYcEv0IuY9zdd1DcWByD/oXyXDv2ZoS5 zCyAP1O/qOgBWZ5MTIRzpmyamOmL87hcBHGPO2WkuvMMR8/zHjKe2766GKlGK2DtfdYe jCtf0DRuIPfxalOua4xRWR+b2w8lV0PxAlUcK/RMz1fNiycVev+YHF9SDG9DWHXws14y I0YbaNS6ADKycxvgNApPqN4fFdNLTZVrF3fMDsmgqgS4ELU9EVAT6Fee8PImpNlXVJL9 9zTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SGnwo/4KLUBcipn0kqkCbnl3XJeVMa7hwQJA362AevE=; b=NZCAlYB7UPDJ2zCNNXunN3YD6o5+a9xLcus0vpOTm9KAQhwD9mj8NORSFVWypaKFdd ikx5U/X0LIXFP9jEtSlQgHdsdJDmn3lQiTnNhBwkiFCPxV1PQCk6GldZKKaZI68yNa9n dm0m4Al4iR58j6pYLPUwTWiOwyAHqfBvKZ11K7Jz30r6CPIh72xb5ozuBp9hhVDXPXLb AY9UJUBPMJnOyNPUyM1oIEn2d9HE7T+QUmro1lWxn4B/j/LI1eLum03FerS8bRgrybsy RQDCERPWe7cywBVgTEDFd5uKqsLKb402bYjMpTAEdEr8xgWf9V0Qr7i7hGrWn5BxqiOz rzEw== X-Gm-Message-State: ANoB5pkv6d/cAv37VlHwWdlvEy+8xDOg5//8fgWq4/kzlQ12Yj2ORlQs AcKuSDDKAP2H+PyYfMXmoyn3sAUkUynEArsNKAZYTXjSOUA= X-Google-Smtp-Source: AA0mqf50xUddhVzLh8zWUl1CBY9SXnfX809mPl8BLt1Mt7B4LPsROUqWc8s/zWuLs8UoRTpUhDSzspUuZan7TBmHpGY= X-Received: by 2002:a05:6808:2229:b0:35b:2b17:af81 with SMTP id bd41-20020a056808222900b0035b2b17af81mr11588961oib.199.1669471537467; Sat, 26 Nov 2022 06:05:37 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 26 Nov 2022 06:05:36 -0800 From: Stefan Kangas In-Reply-To: References: <87edudm43j.fsf@rfc20.org> <834jv7rt5p.fsf@gnu.org> <87edu46r4z.fsf@rfc20.org> X-Hashcash: 1:20:221126:59137@debbugs.gnu.org::TFa2FKz8/gD/QHD6:5JPX MIME-Version: 1.0 Date: Sat, 26 Nov 2022 06:05:36 -0800 Message-ID: Subject: Re: bug#59137: [PATCH] To minor changes related to overlays To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59137 Cc: Matt Armstrong , Eli Zaretskii , 59137@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> Should these patches be installed? Stefan? > > I don't have an opinion on the `itree_empty_p` patch, but the one about > `itree_iterator_finish` doesn't apply any more because > `itree_iterator_finish` has been removed in the mean time. Matt, if you think these patches are still relevant, could you please rebase them on top of current master? Thanks in advance. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 14:37:33 2022 Received: (at 59137) by debbugs.gnu.org; 26 Nov 2022 19:37:33 +0000 Received: from localhost ([127.0.0.1]:41477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz0zU-0006Oh-MU for submit@debbugs.gnu.org; Sat, 26 Nov 2022 14:37:33 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:34009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz0zR-0006OY-Kv for 59137@debbugs.gnu.org; Sat, 26 Nov 2022 14:37:31 -0500 Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id CCF3EC0003; Sat, 26 Nov 2022 19:37:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1669491444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MIBZwlTp9/qQFY/2Zk3gwj9t3mLcAWFAy8q/G1M1jGc=; b=NI5GUbc3VdMyrCStJOlx/edbo+lL2C1ewBx2CedcCVaLpVRxwsMTltreiJqUoFeEvbcWXv L0DLKIuTXgRpKI5VlrSShE3++HYpy8gj3/L5rjb968C7Q98xWYSJ78hLOj1gMdHjL7Vn8F 742V4w7HYSfaz/Nc1ur2U+5tqgd3fnmciFusyuJgZV21xKRjwPXcsLyVUvLVIqHUIvX2mW EHBTSkCriRnnTNFkQhJQB+m1bM4Lw8VoPxJGs1+f2/NmGHIHUAbjpmDP/eNwPIu+2JaGDL qSGLoGb5fnqXIGVT3rAvoZzjUttpX7G/Uho1APr9ZNAvM1EU5RjxkTDJRCOW1w== Received: by mac-mini.lan (Postfix) with ESMTPS id 564E43BD4B; Sat, 26 Nov 2022 11:37:19 -0800 (PST) Received: by naz.lan (Postfix, from userid 1000) id 345E043CED56; Sat, 26 Nov 2022 11:37:19 -0800 (PST) From: Matt Armstrong To: Stefan Kangas , Stefan Monnier Subject: Re: bug#59137: [PATCH] To minor changes related to overlays In-Reply-To: References: <87edudm43j.fsf@rfc20.org> <834jv7rt5p.fsf@gnu.org> <87edu46r4z.fsf@rfc20.org> Date: Sat, 26 Nov 2022 11:37:18 -0800 Message-ID: <87k03hpkwh.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59137 Cc: Eli Zaretskii , 59137@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Stefan Kangas writes: > Stefan Monnier writes: > >>> Should these patches be installed? Stefan? >> >> I don't have an opinion on the `itree_empty_p` patch, but the one about >> `itree_iterator_finish` doesn't apply any more because >> `itree_iterator_finish` has been removed in the mean time. > > Matt, if you think these patches are still relevant, could you please > rebase them on top of current master? Thanks in advance. Hi Stefan and Stefan, Attached is the rebased patch for the new helper function (it didn't change much if at all). As Stefan suggested, the patch for the iterator is no longer relevant. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Add-itree_empty_p-for-clarity-and-reduced-coupling.patch >From 3e2c4cd143d51c66198dd606e18015eeae42f3ec Mon Sep 17 00:00:00 2001 From: Matt Armstrong Date: Tue, 8 Nov 2022 15:00:18 -0800 Subject: [PATCH] Add itree_empty_p for clarity and reduced coupling * src/itree.h (itree_empty_p): New predicate. * src/buffer.h (buffer_has_overlays): Call it. * src/pdumper.c (dump_buffer): ditto. * src/alloc.c (mark_buffer): ditto. --- src/alloc.c | 2 +- src/buffer.h | 3 +-- src/itree.h | 9 +++++++++ src/pdumper.c | 2 +- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/alloc.c b/src/alloc.c index 0653f2e0cc..526a25393f 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -6553,7 +6553,7 @@ mark_buffer (struct buffer *buffer) if (!BUFFER_LIVE_P (buffer)) mark_object (BVAR (buffer, undo_list)); - if (buffer->overlays) + if (!itree_empty_p (buffer->overlays)) mark_overlays (buffer->overlays->root); /* If this is an indirect buffer, mark its base buffer. */ diff --git a/src/buffer.h b/src/buffer.h index dded0cd98c..9ead875bcf 100644 --- a/src/buffer.h +++ b/src/buffer.h @@ -1277,8 +1277,7 @@ set_buffer_intervals (struct buffer *b, INTERVAL i) INLINE bool buffer_has_overlays (void) { - return current_buffer->overlays - && (current_buffer->overlays->root != NULL); + return !itree_empty_p (current_buffer->overlays); } /* Functions for accessing a character or byte, diff --git a/src/itree.h b/src/itree.h index 291fa53fd3..248ea9b84d 100644 --- a/src/itree.h +++ b/src/itree.h @@ -25,6 +25,8 @@ #define ITREE_H #include "lisp.h" +INLINE_HEADER_BEGIN + /* The tree and node structs are mainly here, so they can be allocated. @@ -114,6 +116,11 @@ #define ITREE_H ptrdiff_t, ptrdiff_t); extern struct itree_tree *itree_create (void); extern void itree_destroy (struct itree_tree *); +INLINE bool +itree_empty_p (struct itree_tree *tree) +{ + return !tree || !tree->root; +} extern intmax_t itree_size (struct itree_tree *); extern void itree_clear (struct itree_tree *); extern void itree_insert (struct itree_tree *, struct itree_node *, @@ -178,4 +185,6 @@ #define ITREE_FOREACH(n, t, beg, end, order) \ #define ITREE_FOREACH_NARROW(beg, end) \ itree_iterator_narrow (itree_iter_, beg, end) +INLINE_HEADER_END + #endif diff --git a/src/pdumper.c b/src/pdumper.c index fedcd3e404..35e86d2b50 100644 --- a/src/pdumper.c +++ b/src/pdumper.c @@ -2863,7 +2863,7 @@ dump_buffer (struct dump_context *ctx, const struct buffer *in_buffer) DUMP_FIELD_COPY (out, buffer, inhibit_buffer_hooks); DUMP_FIELD_COPY (out, buffer, long_line_optimizations_p); - if (buffer->overlays && buffer->overlays->root != NULL) + if (!itree_empty_p (buffer->overlays)) /* We haven't implemented the code to dump overlays. */ emacs_abort (); else -- 2.35.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 15:07:38 2022 Received: (at 59137) by debbugs.gnu.org; 26 Nov 2022 20:07:39 +0000 Received: from localhost ([127.0.0.1]:41518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz1Sc-0006hg-JH for submit@debbugs.gnu.org; Sat, 26 Nov 2022 15:07:38 -0500 Received: from mail-ot1-f50.google.com ([209.85.210.50]:44991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz1SZ-0006hZ-79 for 59137@debbugs.gnu.org; Sat, 26 Nov 2022 15:07:37 -0500 Received: by mail-ot1-f50.google.com with SMTP id p8-20020a056830130800b0066bb73cf3bcso4624203otq.11 for <59137@debbugs.gnu.org>; Sat, 26 Nov 2022 12:07:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=UBlQ5qfsU9xhH/DYOqVwk80mtswPUyg+o5i6iw08nfg=; b=VQ5SG9hqCq/x8I4h4qXPzHLfz835/J8fwMV1CoI7NVlaW3swzvG0vYlQTPcSpRTb1x GjxHljhFGY3uhfbA4Th9CQHm5oR42qbUDZI3q2gtXxU9D7hgjf641ZxNyWH+JpATHOPN cbwXj+7nbEQ0+2Boxo9fNvWjSmm+OXuEFWEINwdCmIEqSFUVsyQm44yIxv4vJHakYx73 3HNgjRRlk8j2ZE7M7Zp/QbkCd/17pP5WqMfxW0+PFSm+ObQZyOCqYl/PjyQZa/CjUbD4 /nNb6IX2uhFsTDqjDaWEZdE79r8fUHDD81bNYIipx7rksq22A7ryYuAgMPNfbP6APlij Fo4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UBlQ5qfsU9xhH/DYOqVwk80mtswPUyg+o5i6iw08nfg=; b=k4FvT+UjSp64TPloMoIvyrG7RO5K9na6f7zTBNlNZ9CrenSHyu9+jqtOUSrpTv15AZ aO+peXw5d5rpDPCXZZZ734W6dgXShsrX4S/x2Ljyvm6g7JdWd4DX9Xjzd3AzYKV8CuPH pnrCZ9w93cJkQQqsBSJa/2HG9Rcj5QgLSMYLJ2DQtmwV63oqGgtzihY6ib81EHn/jwbO lYvVfwhdu0A3HTfTPGSGcud9saSbRN4/cq/q2FAsnfDUsrtV8i/BYgHEM4kwIXpVFJxj xgPiy1fQkybftl3GM1/oYv6qPwxGyLkIehsWwercvBZtWiqS0cMeyv/cFM9g7um1tfA6 f/NQ== X-Gm-Message-State: ANoB5plqx+zbtFvkXXzweC1V+g0vQTb+fimnNC6FezCD91Q/q0SPKFV7 SA3s3SU1lopUuww+EF0YtIKjdqJaZmNs1d/34/4= X-Google-Smtp-Source: AA0mqf40OAHhq18fsCsQ0hjQEgQZg2b3rTf2mNoUUjCb74B+kbA53Zm0cbinS4BawjMqcPaiQ88jGFmx6K8FkXNWGY4= X-Received: by 2002:a9d:5c81:0:b0:661:c48b:12db with SMTP id a1-20020a9d5c81000000b00661c48b12dbmr13368649oti.105.1669493249453; Sat, 26 Nov 2022 12:07:29 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 26 Nov 2022 12:07:28 -0800 From: Stefan Kangas In-Reply-To: <87k03hpkwh.fsf@rfc20.org> References: <87edudm43j.fsf@rfc20.org> <834jv7rt5p.fsf@gnu.org> <87edu46r4z.fsf@rfc20.org> <87k03hpkwh.fsf@rfc20.org> X-Hashcash: 1:20:221126:matt@rfc20.org::3oALhtuRNJjLz01I:3W+Q MIME-Version: 1.0 Date: Sat, 26 Nov 2022 12:07:28 -0800 Message-ID: Subject: Re: bug#59137: [PATCH] To minor changes related to overlays To: Matt Armstrong , Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59137 Cc: Eli Zaretskii , 59137@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Matt Armstrong writes: > Attached is the rebased patch for the new helper function (it didn't > change much if at all). As Stefan suggested, the patch for the iterator > is no longer relevant. Thanks. > From 3e2c4cd143d51c66198dd606e18015eeae42f3ec Mon Sep 17 00:00:00 2001 > From: Matt Armstrong > Date: Tue, 8 Nov 2022 15:00:18 -0800 > Subject: [PATCH] Add itree_empty_p for clarity and reduced coupling > > * src/itree.h (itree_empty_p): New predicate. > * src/buffer.h (buffer_has_overlays): Call it. > * src/pdumper.c (dump_buffer): ditto. > * src/alloc.c (mark_buffer): ditto. Equivalently, you can leave out "ditto" so the above is just the below (I added the bug number too, according to our conventions): * src/itree.h (itree_empty_p): New predicate. * src/buffer.h (buffer_has_overlays): * src/pdumper.c (dump_buffer): * src/alloc.c (mark_buffer): Call it. (Bug#59137) > --- > src/alloc.c | 2 +- > src/buffer.h | 3 +-- > src/itree.h | 9 +++++++++ > src/pdumper.c | 2 +- > 4 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/src/alloc.c b/src/alloc.c > index 0653f2e0cc..526a25393f 100644 > --- a/src/alloc.c > +++ b/src/alloc.c > @@ -6553,7 +6553,7 @@ mark_buffer (struct buffer *buffer) > if (!BUFFER_LIVE_P (buffer)) > mark_object (BVAR (buffer, undo_list)); > > - if (buffer->overlays) > + if (!itree_empty_p (buffer->overlays)) > mark_overlays (buffer->overlays->root); I'm not familiar with this code at all, but I note that the condition here changes from: buffer->overlays to buffer->overlays && buffer->overlays->root Is that correct? Unless I missed something, the patch description doesn't say anything about it. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 18:16:32 2022 Received: (at 59137) by debbugs.gnu.org; 29 Nov 2022 23:16:32 +0000 Received: from localhost ([127.0.0.1]:57081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p09q3-0004TW-IH for submit@debbugs.gnu.org; Tue, 29 Nov 2022 18:16:31 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:54077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p09py-0004TQ-JL for 59137@debbugs.gnu.org; Tue, 29 Nov 2022 18:16:30 -0500 Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id 7AAE61C0002; Tue, 29 Nov 2022 23:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1669763780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B8P17KEU5GNA26XAESLvXxZ/WKUe8WPslHPI7SgrbWU=; b=XY+x3/yWX1F7ON2mBzSxPMAiGMpKwxYI0PuC+lDe4MZ97aNlEvTaEtAjsSiBk7jpa5gPD6 WXcD1lzVvfyL7PPyG8ZNZr5vSl+66aEDCASsf8EvVvxyUUepDmDwnemanCEf7pp3qwwZrS wpnHmOAOSvw/unnqytwnXaQxfmKx2VBhkwYsbc1SW/3x8MvW/cDvRKBwLzr01tSuIH+jrQ puYoSxl01kaD1DXlajdqFcPjdAo6cmNI8O+9CO4FY7oyigThabCdT96vaCv2TZDyuuCJyf UbeMyHnM6weFkFc4SZcSkGXF+RK9dNB28Ce0Wm3xNBDXwM7BhPbMEX0uQrXDhQ== Received: by mac-mini.lan (Postfix) with ESMTPS id 52B423C991; Tue, 29 Nov 2022 15:16:16 -0800 (PST) Received: by naz.lan (Postfix, from userid 1000) id 3636443D6886; Tue, 29 Nov 2022 15:16:16 -0800 (PST) From: Matt Armstrong To: Stefan Kangas , Stefan Monnier Subject: Re: bug#59137: [PATCH] To minor changes related to overlays In-Reply-To: References: <87edudm43j.fsf@rfc20.org> <834jv7rt5p.fsf@gnu.org> <87edu46r4z.fsf@rfc20.org> <87k03hpkwh.fsf@rfc20.org> Date: Tue, 29 Nov 2022 15:16:16 -0800 Message-ID: <87h6yhpd1b.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59137 Cc: Eli Zaretskii , 59137@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Kangas writes: > Matt Armstrong writes: > >> Attached is the rebased patch for the new helper function (it didn't >> change much if at all). As Stefan suggested, the patch for the iterator >> is no longer relevant. > > Thanks. > >> From 3e2c4cd143d51c66198dd606e18015eeae42f3ec Mon Sep 17 00:00:00 2001 >> From: Matt Armstrong >> Date: Tue, 8 Nov 2022 15:00:18 -0800 >> Subject: [PATCH] Add itree_empty_p for clarity and reduced coupling >> >> * src/itree.h (itree_empty_p): New predicate. >> * src/buffer.h (buffer_has_overlays): Call it. >> * src/pdumper.c (dump_buffer): ditto. >> * src/alloc.c (mark_buffer): ditto. Thanks for the tips. > Equivalently, you can leave out "ditto" so the above is just the below > (I added the bug number too, according to our conventions): > > * src/itree.h (itree_empty_p): New predicate. > * src/buffer.h (buffer_has_overlays): > * src/pdumper.c (dump_buffer): > * src/alloc.c (mark_buffer): Call it. (Bug#59137) > >> --- >> src/alloc.c | 2 +- >> src/buffer.h | 3 +-- >> src/itree.h | 9 +++++++++ >> src/pdumper.c | 2 +- >> 4 files changed, 12 insertions(+), 4 deletions(-) >> >> diff --git a/src/alloc.c b/src/alloc.c >> index 0653f2e0cc..526a25393f 100644 >> --- a/src/alloc.c >> +++ b/src/alloc.c >> @@ -6553,7 +6553,7 @@ mark_buffer (struct buffer *buffer) >> if (!BUFFER_LIVE_P (buffer)) >> mark_object (BVAR (buffer, undo_list)); >> >> - if (buffer->overlays) >> + if (!itree_empty_p (buffer->overlays)) >> mark_overlays (buffer->overlays->root); > > I'm not familiar with this code at all, but I note that the condition > here changes from: > > buffer->overlays > > to > > buffer->overlays && buffer->overlays->root > > Is that correct? Unless I missed something, the patch description > doesn't say anything about it. The admittedly redundant NULL check done by itree_empty_p does not change semantics or cause harm. mark_overlays in alloc.c is a recursive function so it handles NULL itself, hence the NULL check was omitted in the original code. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 20:28:28 2022 Received: (at 59137) by debbugs.gnu.org; 30 Nov 2022 01:28:28 +0000 Received: from localhost ([127.0.0.1]:57646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0Btk-0005fN-C8 for submit@debbugs.gnu.org; Tue, 29 Nov 2022 20:28:28 -0500 Received: from mail-oi1-f179.google.com ([209.85.167.179]:38589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0Bti-0005fG-A2 for 59137@debbugs.gnu.org; Tue, 29 Nov 2022 20:28:27 -0500 Received: by mail-oi1-f179.google.com with SMTP id b126so2740168oif.5 for <59137@debbugs.gnu.org>; Tue, 29 Nov 2022 17:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PetJYibxEklc8SWkRozOG3JQ/IfyGGxVT7BvIAzWB6E=; b=IcLiVs9AVsImPPM8yu5lT9PRrFc+5XF+2qJIhpdNa1ezl3IJQcdpcjT/B0oHPzrkv+ Mib8xGnM7HqAfXbf9G2zuh/xuBn1j1iOzZips3cxrC+KFs1eUuA8ofTR0Z3dL8tVlFtp +H9YYg9AkPWxo6PAWhNMrUvYxaa00uaBh5GAhbdbmDxwsDOE7/xU2si9oxBUG6hwPOCz vzlaxh+JnjKnzYr+BnzQ/d/9kcem2QIIokJLyOUwJdsrnXj4sLEHAKvpeoYOmhAYeXNI pkyaXBOy63tXG2ms5YE9ItDyp5eNEkUu9ArXcuVb+QW1aINO+/jEZwHi556Bj8DCdhbf QltA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PetJYibxEklc8SWkRozOG3JQ/IfyGGxVT7BvIAzWB6E=; b=d5/0jm2JFUvvAIGGENqLnN3toqsYqLAQKusxf52IhTfDSAw/tJCzVH0p2Rb769X+OS 3/ZM60uU+c3+Jg7QPbpNEQNMt/IlPW4Qg/brcBLeWYosl+tf3hcJNASAZLEa3Krg3bZ1 Q+mpko99SZlXg98MODcqdrubZjMIOObEctnXiX26xwx465TU31G3p/eyGa8Nt+lFkNoQ bUdOii5LNKDUvclIQdVa+AyU4SjtppfdMRqHjEMXkyRQndUXJEmO2ZkVYCcmxdc7kinL YJVrcbNsoriCrzn0CNHT4ESXbrosnGhiU0F14ddrK1BUd8cyoG8wxp3ds7FtP0Er3ftk 1Vkw== X-Gm-Message-State: ANoB5pkph0czBI3r+ksCpzZYUOvnRgbALrjpBe+ml7F1hhNteoCZZ2Vf D70E/N431iRfPYVtAI+uaz/1LVOYEVBdYQqOTQg= X-Google-Smtp-Source: AA0mqf4kifkJyeNXrw+n8DoBovc11RpGlRVCQGKAP2dTXeoI1K4pu0/WDG5ZfqS8qLMPf+wcqrFbwhfSHUrdfxGjzyU= X-Received: by 2002:a05:6808:1287:b0:359:dc32:4f9e with SMTP id a7-20020a056808128700b00359dc324f9emr19702156oiw.92.1669771700478; Tue, 29 Nov 2022 17:28:20 -0800 (PST) MIME-Version: 1.0 References: <87edudm43j.fsf@rfc20.org> <834jv7rt5p.fsf@gnu.org> <87edu46r4z.fsf@rfc20.org> <87k03hpkwh.fsf@rfc20.org> <87h6yhpd1b.fsf@rfc20.org> In-Reply-To: <87h6yhpd1b.fsf@rfc20.org> From: Stefan Kangas Date: Wed, 30 Nov 2022 02:28:09 +0100 Message-ID: Subject: Re: bug#59137: [PATCH] To minor changes related to overlays To: Matt Armstrong Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59137 Cc: Eli Zaretskii , Stefan Monnier , 59137@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Matt Armstrong writes: > The admittedly redundant NULL check done by itree_empty_p does not > change semantics or cause harm. mark_overlays in alloc.c is a recursive > function so it handles NULL itself, hence the NULL check was omitted in > the original code. Thanks. I guess as this is a minor cleanup this should go to master at this point. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 08:26:20 2022 Received: (at 59137) by debbugs.gnu.org; 30 Nov 2022 13:26:20 +0000 Received: from localhost ([127.0.0.1]:32768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0N6S-0005Am-4P for submit@debbugs.gnu.org; Wed, 30 Nov 2022 08:26:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0N6Q-0005Af-NB for 59137@debbugs.gnu.org; Wed, 30 Nov 2022 08:26:19 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0N6L-0005z8-4u; Wed, 30 Nov 2022 08:26:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=V+rS167qLbaqySVtJWhrbxE+odd+ZYpgRZ46FYuPbY8=; b=m8CPH5m2AJ+W M+lmkJGkAz42hjQzLjm/a0rxe6hgcXqVTI72LiOLRYwUrXxFxsWUAWogiw2OzVzwy409xHwE4+GfT ggs733dM3TgJIJ+KsWfspOR0BSs6svNlunOZEBIuDfHPaOHseN03VKyN/ohoWA25uTEGFyTnM847L pub1tOtoQrEeeKO/8Wp+LjduJQqayqVQiMfOHZPGzEPIpG04QTTHKTI6YryzK308wDXwO1FtUkhnN ikn3wBj4/9O9Hl4C3AxeXzPeazX1In8YXFF3JJXhH06kwlQ4sGYnluuCPYtt/4Flgc5Y+Pz0YFlgL mtWJh0ZIchLmZXz/JnUBSg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0N6K-0007BP-J5; Wed, 30 Nov 2022 08:26:12 -0500 Date: Wed, 30 Nov 2022 15:25:41 +0200 Message-Id: <83fse0lgkq.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Wed, 30 Nov 2022 02:28:09 +0100) Subject: Re: bug#59137: [PATCH] To minor changes related to overlays References: <87edudm43j.fsf@rfc20.org> <834jv7rt5p.fsf@gnu.org> <87edu46r4z.fsf@rfc20.org> <87k03hpkwh.fsf@rfc20.org> <87h6yhpd1b.fsf@rfc20.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59137 Cc: matt@rfc20.org, monnier@iro.umontreal.ca, 59137@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Wed, 30 Nov 2022 02:28:09 +0100 > Cc: Stefan Monnier , Eli Zaretskii , 59137@debbugs.gnu.org > > Matt Armstrong writes: > > > The admittedly redundant NULL check done by itree_empty_p does not > > change semantics or cause harm. mark_overlays in alloc.c is a recursive > > function so it handles NULL itself, hence the NULL check was omitted in > > the original code. > > Thanks. > > I guess as this is a minor cleanup this should go to master at this point. I agree. We can always cherry-pick if we find a good reason. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 12:34:57 2022 Received: (at 59137-done) by debbugs.gnu.org; 30 Nov 2022 17:34:57 +0000 Received: from localhost ([127.0.0.1]:34060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0Qz3-0007Xm-AL for submit@debbugs.gnu.org; Wed, 30 Nov 2022 12:34:57 -0500 Received: from mail-oa1-f41.google.com ([209.85.160.41]:46025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0Qyx-0007Xg-Lu for 59137-done@debbugs.gnu.org; Wed, 30 Nov 2022 12:34:55 -0500 Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-1432a5f6468so21832480fac.12 for <59137-done@debbugs.gnu.org>; Wed, 30 Nov 2022 09:34:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=V1+YyH5zIrHm7eN3TuJ3NhtyWaNOmLtM0LVcaUttE40=; b=Pky3jup25L5g12hBK2vsLauB9ImhFwXgTfcVuqvxl6r9zcjEidRgrLElxg0EIDAhlb hfqQzdWA1YoKoMhM3cnxlhdazSPSp/Gmpw2wU23LH+5jSMjkYxkt4HJIya+TPoWhW63J 49akh0RvqoorJK7VIWsMesJijPxQp6ri/QXlGhr3ywnszAiXYAVDxUazfrt+Lkz0hD/u REPoqC5mDHVnk+YTHmo21IKufwLe2NQWdSN0FxWqigJCt3RRNo2ZPp0vxancGr2UKSNi jYO0OqYCGYGAHeUN0pFhCedPRE95di0k6akjEkbUDdXF8OHA0wVn884P2hfogve20Zkc n19w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V1+YyH5zIrHm7eN3TuJ3NhtyWaNOmLtM0LVcaUttE40=; b=Qlxh7mwOyAQQiGqP3n7/jd+b7qqCSQ2/E3+IX6nT7e7tUNHr/ZWWrLGMZpGmZlx/82 HeVqDgqd7IcVGUbXugDq/zlg/wRJLnc81hd9BTmqDMBVCl4l4ufYDB32tN0dO7c7wWyp 5Q7J9EfPPo4LoI55uZNLL21Kes/Zv2Pgt2DLMCWt41s8lck9wAVUNh23UZLhq1KtkPQb l0b6jerqugD1URwRP/K5U2vLBNa4ZDNmfUMLAafqJ5TXtQSkZXNYvC5Ypfa9MqKvCVme SPKE/zA0SN5CGx9QB6vJ5uGOL8fE0GEZpPf948VnIyfXUug1ARkEB7BQZB9MGdpZpYrG miWA== X-Gm-Message-State: ANoB5pkWnk0VDDBZhf8piFTXSRp3OF8BadzWVafpkbxrCUaRYn0oD5aN 3KBc7y6VtPIiapNObXli3NMjVTyL4ye9fXL6tyk= X-Google-Smtp-Source: AA0mqf5vpbzybDehxzUO7ZivK3/PS8owNqTqRwlFJPFkoHEu4jPBE3cobTqmuOJgaldIKD7NuDuTrTY5VfB4WWQzbQ0= X-Received: by 2002:a05:6870:4995:b0:143:522a:ebcc with SMTP id ho21-20020a056870499500b00143522aebccmr18045185oab.199.1669829685948; Wed, 30 Nov 2022 09:34:45 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 30 Nov 2022 09:34:45 -0800 From: Stefan Kangas In-Reply-To: <83fse0lgkq.fsf@gnu.org> References: <87edudm43j.fsf@rfc20.org> <834jv7rt5p.fsf@gnu.org> <87edu46r4z.fsf@rfc20.org> <87k03hpkwh.fsf@rfc20.org> <87h6yhpd1b.fsf@rfc20.org> <83fse0lgkq.fsf@gnu.org> X-Hashcash: 1:20:221130:59137-done@debbugs.gnu.org::bXGUk583AadMWqlh:0KTg MIME-Version: 1.0 Date: Wed, 30 Nov 2022 09:34:45 -0800 Message-ID: Subject: Re: bug#59137: [PATCH] To minor changes related to overlays To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59137-done Cc: matt@rfc20.org, monnier@iro.umontreal.ca, 59137-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> I guess as this is a minor cleanup this should go to master at this point. > > I agree. We can always cherry-pick if we find a good reason. Thanks, pushed to master (commit 656a54b823). From unknown Fri Jun 20 07:24:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 29 Dec 2022 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator