GNU bug report logs - #59127
[PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS export.

Previous Next

Full log

Message #13 received at 59127-done <at> debbugs.gnu.org (full text, mbox):

From: Prafulla Giri <prafulla.giri <at> protonmail.com>
To: 宋文武 <iyzsong <at> envs.net>
Cc: 59127-done <at> debbugs.gnu.org
Subject: Re: bug#59127: [PATCH] guix-install.sh: remove unnecessary
 XDG_DATA_DIRS export.
Date: Tue, 15 Nov 2022 05:11:31 +0000

Thank you.

The copyright year was because I introduced the guix.sh init profile back in 2019 but had not put the copyright year in (https://git.savannah.gnu.org/cgit/guix.git/log/?qt=author&q=Prafulla+Giri). But that's all right. (Turns out the first patch was committed in 2020 - authored in 2019 - so it was wrong anyways)

Cheers!

------- Original Message -------
On Monday, November 14th, 2022 at 8:12 AM, 宋文武 <iyzsong <at> envs.net> wrote:


> Prafulla Giri prafulla.giri <at> protonmail.com writes:
> 
> > Hello there,
> > 
> > Here's a small patch.
> > 
> > Regards.
> > 
> > From 22a94cf122a8f01ba8078255031cc520f4f1b70d Mon Sep 17 00:00:00 2001
> > From: Prafulla Giri prafulla.giri <at> protonmail.com
> > Date: Tue, 8 Nov 2022 13:39:21 +0545
> > Subject: [PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS export.
> > 
> > This started out as a bug-fix for a GUI login loop that was resulting from XDG_DATA_DIRS
> > not including any of the host distro's directories. The solution was to export the vari-
> > able (with fail-safe defaults) before source-ing GUIX_PROFILE/etc/profile. It turns out
> > changes have already been made to ensure that XDG_DATA_DIRS, etc. are always exported
> > before anything guix-specific. So, this export is no longer necessary.
> > 
> > For reference, the aforementioned bug was found on a Debian 11 machine and it's guix.sh
> > init profile for guix version 1.2.
> > ---
> > etc/guix-install.sh | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/etc/guix-install.sh b/etc/guix-install.sh
> > index c8ef59d4a4..21253f538b 100755
> > --- a/etc/guix-install.sh
> > +++ b/etc/guix-install.sh
> > @@ -10,6 +10,7 @@
> > # Copyright © 2021 Jakub Kądziołka kuba <at> kadziolka.net
> > # Copyright © 2021 Chris Marusich cmmarusich <at> gmail.com
> > # Copyright © 2021, 2022 Maxim Cournoyer maxim.cournoyer <at> gmail.com
> > +# Copyright © 2019, 2020, 2022 Prafulla Giri prafulla.giri <at> protonmail.com
> 
> 
> I changed copyright years to only '2022'.
> 
> Pushed, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.