Subject: bug#59127: closed (Re: bug#59127: [PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS export.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 14 Nov 2022 02:28:02 +0000

Your bug report

#59127: [PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS export.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
59127: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59127
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#59127: [PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS export.
From: 宋文武 <[email-masked]>
To: Prafulla Giri <[email-masked]>
Cc: [email-masked]
Date: Mon, 14 Nov 2022 10:27:20 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Prafulla Giri <[email-masked]> writes:

> Hello there,
>
> Here's a small patch.
>
> Regards.
>
> From 22a94cf122a8f01ba8078255031cc520f4f1b70d Mon Sep 17 00:00:00 2001
> From: Prafulla Giri <[email-masked]>
> Date: Tue, 8 Nov 2022 13:39:21 +0545
> Subject: [PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS export.
>
> This started out as a bug-fix for a GUI login loop that was resulting from XDG_DATA_DIRS
> not including any of the host distro's directories. The solution was to export the vari-
> able (with fail-safe defaults) before source-ing GUIX_PROFILE/etc/profile. It turns out
> changes have already been made to ensure that XDG_DATA_DIRS, etc. are always exported
> before anything guix-specific. So, this export is no longer necessary.
>
> For reference, the aforementioned bug was found on a Debian 11 machine and it's guix.sh
> init profile for guix version 1.2.
> ---
>  etc/guix-install.sh | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/etc/guix-install.sh b/etc/guix-install.sh
> index c8ef59d4a4..21253f538b 100755
> --- a/etc/guix-install.sh
> +++ b/etc/guix-install.sh
> @@ -10,6 +10,7 @@
>  # Copyright © 2021 Jakub Kądziołka <[email-masked]>
>  # Copyright © 2021 Chris Marusich <[email-masked]>
>  # Copyright © 2021, 2022 Maxim Cournoyer <[email-masked]>
> +# Copyright © 2019, 2020, 2022 Prafulla Giri <[email-masked]>

I changed copyright years to only '2022'.

Pushed, thank you!

Subject: [PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS export.
From: Prafulla Giri <[email-masked]>
To: "[email-masked]" <[email-masked]>
Date: Tue, 08 Nov 2022 09:47:57 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello there,

Here's a small patch.

Regards.

From 22a94cf122a8f01ba8078255031cc520f4f1b70d Mon Sep 17 00:00:00 2001
From: Prafulla Giri <[email-masked]>
Date: Tue, 8 Nov 2022 13:39:21 +0545
Subject: [PATCH] guix-install.sh: remove unnecessary XDG_DATA_DIRS export.

This started out as a bug-fix for a GUI login loop that was resulting from XDG_DATA_DIRS
not including any of the host distro's directories. The solution was to export the vari-
able (with fail-safe defaults) before source-ing GUIX_PROFILE/etc/profile. It turns out
changes have already been made to ensure that XDG_DATA_DIRS, etc. are always exported
before anything guix-specific. So, this export is no longer necessary.

For reference, the aforementioned bug was found on a Debian 11 machine and it's guix.sh
init profile for guix version 1.2.
---
 etc/guix-install.sh | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index c8ef59d4a4..21253f538b 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -10,6 +10,7 @@
 # Copyright © 2021 Jakub Kądziołka <[email-masked]>
 # Copyright © 2021 Chris Marusich <[email-masked]>
 # Copyright © 2021, 2022 Maxim Cournoyer <[email-masked]>
+# Copyright © 2019, 2020, 2022 Prafulla Giri <[email-masked]>
 #
 # This file is part of GNU Guix.
 #
@@ -535,9 +536,6 @@ GUIX_LOCPATH="$GUIX_PROFILE/lib/locale"
 export GUIX_LOCPATH
 
 [ -f "$GUIX_PROFILE/etc/profile" ] && . "$GUIX_PROFILE/etc/profile"
-
-# set XDG_DATA_DIRS to include Guix installations
-export XDG_DATA_DIRS="$GUIX_PROFILE/share:$XDG_DATA_DIRS"
 EOF
 }
 
-- 
2.38.0