From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 00:29:29 2022 Received: (at submit) by debbugs.gnu.org; 8 Nov 2022 05:29:29 +0000 Received: from localhost ([127.0.0.1]:35987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osHAv-0004HW-5O for submit@debbugs.gnu.org; Tue, 08 Nov 2022 00:29:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:58962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osHAt-0004HO-8R for submit@debbugs.gnu.org; Tue, 08 Nov 2022 00:29:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osHAt-0008Ku-2z for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 00:29:27 -0500 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osHAq-0008Hm-Ih for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 00:29:26 -0500 Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id 3BD28C0003 for ; Tue, 8 Nov 2022 05:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1667885358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=m+u91rYFtX1kpiRpU4F8DSFm7h/rZUDqTS087JH88Sk=; b=IMnfLeTtmMZINoTboCpymQLKRLSJTjc9sE4HHXR5GPjwjQA/vs4AkyOU3SDCZDGKl8/bvW oGNYkKjJQu+j98cpJUXeseKfD3GMoSMC87pGzRY/HvObSB+SYBLDx8Sgt2ddyL9wb64TTU /o1qi98cvRU0ztY9D0S693EncKGjuZzWPOz2BtLcg92V/xQBWI0D5FSDfdTA7zriateuVR svMBKfv509T6YRyF+oDMPBU7crYMU9TyNOYexQ3mPoBRQySu/EG92i4J9PNgADZput5Tx0 a84mkuLHkLDH3KpNZN9WiKVyCckVmLa/Th5G64T4mIh5TEeQX0MvMdtL9Cp2Qw== Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1osHAh-000vXA-0y for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 21:29:15 -0800 From: Matt Armstrong To: bug-gnu-emacs@gnu.org Subject: [PATCH] Prefix all itree functions with itree_ Date: Mon, 07 Nov 2022 21:29:15 -0800 Message-ID: <87o7tim2tw.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2001:4b98:dc4:8::226; envelope-from=matt@rfc20.org; helo=relay6-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Tags: patch X-Debbugs-CC: Eli Zaretskii , Basil L. Contovounesios Steph and I put some effort into prefixing all functions in itree.h with itree_. It would be nice to be consistent with that. In GNU Emacs 29.0.50 (build 9, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.16.0) of 2022-11-07 built on naz Repository revision: d04433b96215d7d3387573f19cc315de86f2341a Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12201003 System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure 'CFLAGS=-O2 -g3'' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Prefix-all-itree-functions-with-itree_.patch >From 3318c0688814de5d68a20038ff03d7376d4fd129 Mon Sep 17 00:00:00 2001 From: Matt Armstrong Date: Mon, 7 Nov 2022 21:21:36 -0800 Subject: [PATCH] Prefix all itree functions with itree_ * src/itree.h: init_itree -> itree_init, forget_itree to itree_forget. * src/itree.c (itree_init): Rename. (itree_forget): Rename. * test/manual/noverlay/itree-tests.c (main): Handle rename. --- src/emacs.c | 4 ++-- src/itree.c | 4 ++-- src/itree.h | 4 ++-- test/manual/noverlay/itree-tests.c | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/emacs.c b/src/emacs.c index 1b2aa9442b7..d61cb4e1570 100644 --- a/src/emacs.c +++ b/src/emacs.c @@ -1932,7 +1932,7 @@ main (int argc, char **argv) running_asynch_code = 0; init_random (); init_xfaces (); - init_itree (); + itree_init (); #if defined HAVE_JSON && !defined WINDOWSNT init_json (); @@ -3105,7 +3105,7 @@ DEFUN ("dump-emacs", Fdump_emacs, Sdump_emacs, 2, 2, 0, gflags.will_dump_with_unexec_ = false; gflags.dumped_with_unexec_ = true; - forget_itree (); + itree_forget (); alloc_unexec_pre (); diff --git a/src/itree.c b/src/itree.c index 989173db4e5..9088e3985eb 100644 --- a/src/itree.c +++ b/src/itree.c @@ -288,7 +288,7 @@ itree_iterator_create (struct itree_tree *tree) } void -init_itree (void) +itree_init (void) { eassert (!iter); iter = itree_iterator_create (NULL); @@ -296,7 +296,7 @@ init_itree (void) #ifdef HAVE_UNEXEC void -forget_itree (void) +itree_forget (void) { iter = NULL; } diff --git a/src/itree.h b/src/itree.h index 10ee0897c37..5fdb4020dbd 100644 --- a/src/itree.h +++ b/src/itree.h @@ -106,9 +106,9 @@ #define ITREE_H ITREE_PRE_ORDER, }; -extern void init_itree (void); +extern void itree_init (void); #ifdef HAVE_UNEXEC -extern void forget_itree (void); +extern void itree_forget (void); #endif extern void itree_node_init (struct itree_node *, bool, bool, Lisp_Object); extern ptrdiff_t itree_node_begin (struct itree_tree *, struct itree_node *); diff --git a/test/manual/noverlay/itree-tests.c b/test/manual/noverlay/itree-tests.c index 278e65f9bf7..08d4f357e24 100644 --- a/test/manual/noverlay/itree-tests.c +++ b/test/manual/noverlay/itree-tests.c @@ -1281,7 +1281,7 @@ main (void) Suite *s = basic_suite (); SRunner *sr = srunner_create (s); - init_itree (); + itree_init (); srunner_run_all (sr, CK_ENV); int nfailed = srunner_ntests_failed (sr); srunner_free (sr); -- 2.35.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 01:53:31 2022 Received: (at submit) by debbugs.gnu.org; 8 Nov 2022 06:53:31 +0000 Received: from localhost ([127.0.0.1]:36058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osIUF-0006fy-5d for submit@debbugs.gnu.org; Tue, 08 Nov 2022 01:53:31 -0500 Received: from lists.gnu.org ([209.51.188.17]:46972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osIUC-0006fp-8b for submit@debbugs.gnu.org; Tue, 08 Nov 2022 01:53:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osIUC-00016H-2K for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 01:53:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osIUB-0005KY-Bv; Tue, 08 Nov 2022 01:53:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Subject:To:From: Date; bh=FoO6pxIt0s6Fi3lLiwIA1mWIKOUnSXNoFKLcfKxGUAQ=; b=Bys9OhTA+9HBQHaJWh/M 8lPwEaj9Bh2OuQcqima75SO0Tr7cEuVvApTKFyNQR10iH/nwryx8QlUBOmNlUj8smK3aVkZaRPY/d BZVfI3rbxJ/sTy0o0MO6XLZ6Fdl7No2utaHShFGEKN1arzr7LBJtwmcfWxUDHDuh/HA/1Df6Sj6eY 4tLn+MKfcy/GKRT+JvRpnsyq82xXRHIBOnbuDS+7jxwNToe518TGQOh12MbF5pz4WpirbIhhKfUAH oEWeXQLAWYd2Ap01A4oDNPO9jSuKt1ihvR+bHUKjoSioxQP5xW3R6VRwU+5rDp+OYlC6kJ2OrQeq8 5W1RHeiKdbmWQA==; Received: from [2a02:14f:4:daf6::1] (helo=[IPv6:::1]) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osIU7-0008R9-UI; Tue, 08 Nov 2022 01:53:26 -0500 Date: Tue, 08 Nov 2022 08:53:21 +0200 From: Eli Zaretskii To: bug-gnu-emacs@gnu.org, Matt Armstrong , 59118@debbugs.gnu.org Subject: Re: bug#59118: [PATCH] Prefix all itree functions with itree_ User-Agent: K-9 Mail for Android In-Reply-To: <87o7tim2tw.fsf@rfc20.org> References: <87o7tim2tw.fsf@rfc20.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Autocrypt: addr=eliz@gnu.org; keydata= mQENBF+pf4UBCAC6vjkWLSAsQpe8YIGKLQzNOJx/IjGtCdFF8uzmO5jmME+SD8ROuJN+t5KXVw58 uzu75EFD0vHTY9e+udJ2gkpuy0NnzkFcbumdLLo2ERKCoSctZZRhzKXI5z5cHxCqW0B2ygHRrRLt oNlGID7bAgcgSViT1ptGqTXO7zGVu4Airok7dNzcPtHgns8GlR5YAFX0TvE6oGd0l2VPghNeVJKJ OjrbfhoDxl3ucFpqbqMH8z9HTLDOFpz8UaYYUdJMi3xX6vwTZxI2sM2RRVLUpZyllAkSMI4lln1O OgazM/62DJUs/rKIHKBnF6h3/qsJUjUYXaAHbrXY26mWllAd536lABEBAAG0I0VsaSBaYXJldHNr aWkgKGVsaXopIDxlbGl6QGdudS5vcmc+iQE4BBMBAgAiBQJfqX+FAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAAKCRCRwSYvAeuNOYUQB/4/iIKKOG45ijNaRoTvmJJZMvj1S07WQxEm7c5SHEeE QbLOAxB9vESOV7sLueuN3oqEndtzyYt4x1WTSBmHFF7h5fcCMjBs41siOIp5Sj/xD0Bvaa0IKGCR SZ7PAo8Mq3wgajXpTpn9vxE2PmtzA8KdEE0K1+f9pVAfOpUIcCl44rIxLUW352XG0y7iz6c/O6LB 1deOKMiKFctKO7pBti1dJEm1ImewLH3H8uTbwspLOs3EB8xhsESxmTidnze68HX2jt+2EeMgCdki NU+LWbexQZPfIS7+ZmE06ll0v6+Jy7ZdTkCCRypKWTnW7pIFsq/p4kybV8O/kHSV6B4vvQBfuQEN BF+pf4UBCACvFrdx/m22lgObypSmSS4TNlNvQnMUorrMmp0U32hv5adt6CKXeMjk05F+GcIfVMrp xqMBn4sEUIXWhhogQJa9ZbWEP/HbS8XjMMbz0Q0Siaty9+DSspK/9u2GWKsz3uQzLCexIJtzmXvj AVmvoMCAU/F2t038ggygjYLRgyLRNLgbbartu2dMkvrfxRjheip60S4S3utOcwUf/qdoa1grNann CFluHr/ftXCeeuGB4H8iO0BXWNby6NZPizxJttx9gdcH8/OmDOJkXyRMTT/3sSem76CSOjfXcz7s aJlg680NQhG5TmuYERjJD4+U02K5RuqTsEnOuWeFy4p+/mslABEBAAGJATYEGAECAAkFAl+pf4UC GwwAIQkQkcEmLwHrjTkWIQTmyQKcNjrUHXh6jruRwSYvAeuNOejsB/9rVegsfEBSRLjeeYXyJrOf dme7BYpYsQCw2vGTnrJTGFQ9HM2zT9+wAENBHWjQPJOptJwo5w4xIbZgwJy0uIN3sV18xbCRSxX0 ZSk8GJG0PrQTCaf2xs0kqsShnkvqyo5QSyUlFUAG7m1o7NUhF95Q89oxGO8JyvR356kqNbzUn0Cq PxKyS42QfC8dyFNgVhVPbZp6aONnUwY5SbtCLJtZCBgvppI9XaBH41BDukSE4GgSLoYsSIGShg4h e+bGypAsGtQ9uwmryUi1gRrDgca3wFo/G0rbJn2ZKoLbGFZivWPVgAgd9/O5sLSPFznOdcRGxEA2 gk7A1ReaJ10PtQz0 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On November 8, 2022 7:29:15 AM GMT+02:00, Matt Armstrong = wrote: > Tags: patch >=20 > X-Debbugs-CC: Eli Zaretskii , Basil L=2E Contovounesios = >=20 > Steph and I put some effort into prefixing all functions in itree=2Eh wi= th > itree_=2E It would be nice to be consistent with that=2E Functions that initialize Emacs subsystems during startup are traditionall= y called init_FOO and syms_of_FOO=2E So I'd rather we left init_itree alon= e=2E As for forget_itree, I don't mind renaming it, although it's largely a was= ted effort: that function is only present in the unexec build, and will die= of natural causes at some not too distant point=2E From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 11:03:18 2022 Received: (at 59118-done) by debbugs.gnu.org; 8 Nov 2022 16:03:18 +0000 Received: from localhost ([127.0.0.1]:38032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osR4I-0004ZG-1P for submit@debbugs.gnu.org; Tue, 08 Nov 2022 11:03:18 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:52905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osR4G-0004Z2-O0 for 59118-done@debbugs.gnu.org; Tue, 08 Nov 2022 11:03:17 -0500 Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id 39DA620016; Tue, 8 Nov 2022 16:03:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1667923390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l0nKIBEm76JMtSJ66bqElHJMRepYQ3O1huWuLMm2ozM=; b=mQ+TxkHa43wUzK06dm0h6ACpI1+LefiyO9rkrYEf/DoBRuqhyFia+XhbrfYIO0Ym2KPTep 824HGHywSvOixwy86464xr/RKBb5P4an/PJprC5dQyPjhdATWMN2KvsfnvwRudTmq95opQ flm039rIZ9LTH2dFvnHq9bB66t9VXhbj0wyAdgTUi6lJImeXaClFfiSqYN5Qn7VuSUCwF4 Nnqxx7631kZIPTUcx9dtzrsr42/bTTnBrt6TlC8Sk+RIo3uSxt9+spusHjrJtnWDzrwaGE wenYuzP+D5zqXP744Z9BZgFRIX36314qQnxmX9H5pCZlujkcoxBS/X9Q6ASeRg== Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1osR48-001Ahm-0E; Tue, 08 Nov 2022 08:03:08 -0800 From: Matt Armstrong To: Eli Zaretskii , 59118-done@debbugs.gnu.org Subject: Re: bug#59118: [PATCH] Prefix all itree functions with itree_ In-Reply-To: References: <87o7tim2tw.fsf@rfc20.org> Date: Tue, 08 Nov 2022 08:03:08 -0800 Message-ID: <87h6z9mo1v.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59118-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: > Functions that initialize Emacs subsystems during startup are > traditionally called init_FOO and syms_of_FOO. So I'd rather we left > init_itree alone. > > As for forget_itree, I don't mind renaming it, although it's largely a > wasted effort: that function is only present in the unexec build, and > will die of natural causes at some not too distant point. Fair enough, closing. From unknown Tue Jun 17 22:29:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 07 Dec 2022 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator