GNU bug report logs - #59115
29.0.50; byte-recompile-directory incorrectly ignoring files

Previous Next

Full log

Message #8 received at 59115 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: No Wayman <iarchivedmywholelife <at> gmail.com>,
 Philip Kaludercic <philipk <at> posteo.net>
Cc: 59115 <at> debbugs.gnu.org
Subject: Re: bug#59115: 29.0.50;
 byte-recompile-directory incorrectly ignoring files
Date: Tue, 08 Nov 2022 16:35:34 +0200

> From: No Wayman <iarchivedmywholelife <at> gmail.com>
> Date: Mon, 07 Nov 2022 19:49:58 -0500
> 
> Commit 8638aace3fbe01529f33870f469fa60bf5e43ee7
> introduced a bug which will cause byte-recompile-directory to 
> invert the semantics of the byte-compile-ingore-files option.
> 
> To reproduce:
> 
> 1. mkdir /tmp/bug/ && cd /tmp/bug/
> 2. Copy an elisp file which would normally be byte-compiled into 
> that directory
> 3. emacs -Q --batch --eval "(byte-recompile-directory 
> default-directory 0 'force)"
> 
> You should see output similar to:
> 
> Checking /tmp/bug...
> Done (Total of 0 files compiled)
> 
> 
> In general the entire logic of byte-recompile-directory is messy.
> Two ifs without elses, lots of negated predicates, etc. I can see 
> why the mistake was easy to overlook. This could be further 
> refactored to make it easier to read by leveraging when/unless 
> appropriately. Perhaps there's an argument for some abnormal hooks 
> in place of those long chains of ad-hoc predicates, but I'm more 
> interested in fixing the problem now.
> 
> The attached patch fixes it for me.

Philip, can you look into tis, please?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.