From unknown Fri Aug 22 01:33:55 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59108 <59108@debbugs.gnu.org> To: bug#59108 <59108@debbugs.gnu.org> Subject: Status: 28.2; rmail-get-new-mail sets unmodified if no new mail even if buffer modified before Reply-To: bug#59108 <59108@debbugs.gnu.org> Date: Fri, 22 Aug 2025 08:33:55 +0000 retitle 59108 28.2; rmail-get-new-mail sets unmodified if no new mail even = if buffer modified before reassign 59108 emacs submitter 59108 Ken Olum severity 59108 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 07 11:20:35 2022 Received: (at submit) by debbugs.gnu.org; 7 Nov 2022 16:20:35 +0000 Received: from localhost ([127.0.0.1]:35180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os4rS-0006vw-HA for submit@debbugs.gnu.org; Mon, 07 Nov 2022 11:20:34 -0500 Received: from lists.gnu.org ([209.51.188.17]:50984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os4rQ-0006vo-66 for submit@debbugs.gnu.org; Mon, 07 Nov 2022 11:20:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1os4rQ-0001C1-0c for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 11:20:32 -0500 Received: from cosmos.phy.tufts.edu ([130.64.84.253]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1os4rM-0006BL-Lx for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 11:20:31 -0500 Received: from kdo by cosmos.phy.tufts.edu ([local]:local) with local id 1os4rE-0006ds-1R - Using Exim-4.96 (MandrivaLinux) MTA (return-path ); Mon, 07 Nov 2022 11:20:20 -0500 From: Ken Olum To: bug-gnu-emacs@gnu.org Subject: 28.2; rmail-get-new-mail sets unmodified if no new mail even if buffer modified before Date: Mon, 07 Nov 2022 11:20:20 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=130.64.84.253; envelope-from=kdo@cosmos.phy.tufts.edu; helo=cosmos.phy.tufts.edu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) rmail-get-new-mail-1 sets buffer-modified-p at the beginning to deal with locking issues right away. Then if there is no new mail it clears buffer-modified-p. Thus if the buffer was modified already it gets marked unmodified without being saved. I think it should restore buffer-modified-p to whatever it was to begin with when it doesn't find any new mail. I'll send a patch if you like. To reproduce: emacs -Q M-x rmail Delete a message or make some other change. Buffer now marked modified. Without having any new mail, press "g". Get message "0 new messages read". Buffer now marked unmodified. Ken In GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars) of 2022-11-07 built on cosmos Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Ubuntu 18.04.6 LTS Configured features: FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XFT XIM XPM LUCID ZLIB Important settings: value of $LC_ALL: C value of $LANG: en_US.UTF-8 locale-coding-system: nil Major mode: RMAIL Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug sendmail shr-color color shr kinsoku svg xml dom browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars mailcap rmailmm message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader mail-parse rfc2231 rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs cl-loaddefs cl-lib password-cache json subr-x map seq byte-opt gv bytecomp byte-compile cconv rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads inotify dynamic-setting system-font-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 61191 13369) (symbols 48 7588 1) (strings 32 23283 2385) (string-bytes 1 722945) (vectors 16 14763) (vector-slots 8 204330 17922) (floats 8 135 324) (intervals 56 334 0) (buffers 992 12)) From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 05:33:59 2022 Received: (at 59108) by debbugs.gnu.org; 10 Nov 2022 10:34:00 +0000 Received: from localhost ([127.0.0.1]:42023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot4sh-000819-EK for submit@debbugs.gnu.org; Thu, 10 Nov 2022 05:33:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot4sf-00080t-VC for 59108@debbugs.gnu.org; Thu, 10 Nov 2022 05:33:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot4sZ-0002sT-9m; Thu, 10 Nov 2022 05:33:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mFUxNLBDV76CaS12rvZfE69o6KB0rE5lbc3/VoPK5rk=; b=m4fg4TINAZ5b zfBkeUDQ9G5YGtis34lZ+qrOGsPVqlERqj8j/osrhEMKByEHcyoqcyRxGaMoxHPHzw1RJN+VRlMWU BwAQPfdGKI9b68TQiTPBMIIS+3x8QtMQlT6EYNV4DOospCFggVRnZ6OdvzC480HMV7HkfDLsMjerw OVKY/THWuQoWcOQttI6LDFXdn1a4EIMHx/q66e2zS7COFGx6nwEWiGUwKfkIcFG6Znp0P1GN1T/zC gJISX/ha7eVG4InVE5AQ7QI7w0muR77n0bRqQvPAesmWxrsaiEZkw0vsXrTydZr9OnjEp00tAowwJ hPlbTSxx5uFZHhDz+r8jkA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot4sW-0002iE-Qx; Thu, 10 Nov 2022 05:33:50 -0500 Date: Thu, 10 Nov 2022 12:33:49 +0200 Message-Id: <835yfnrtde.fsf@gnu.org> From: Eli Zaretskii To: Ken Olum In-Reply-To: (message from Ken Olum on Mon, 07 Nov 2022 11:20:20 -0500) Subject: Re: bug#59108: 28.2; rmail-get-new-mail sets unmodified if no new mail even if buffer modified before References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59108 Cc: 59108@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ken Olum > Date: Mon, 07 Nov 2022 11:20:20 -0500 > > rmail-get-new-mail-1 sets buffer-modified-p at the beginning to deal > with locking issues right away. Then if there is no new mail it clears > buffer-modified-p. Thus if the buffer was modified already it gets > marked unmodified without being saved. > > I think it should restore buffer-modified-p to whatever it was to begin > with when it doesn't find any new mail. I'll send a patch if you like. Thanks. Does the patch below give good results? diff --git a/lisp/mail/rmail.el b/lisp/mail/rmail.el index f095d5e..e3372a6 100644 --- a/lisp/mail/rmail.el +++ b/lisp/mail/rmail.el @@ -1751,6 +1751,7 @@ rmail-get-new-mail-1 (spam-filter-p (and (featurep 'rmail-spam-filter) rmail-use-spam-filter)) (blurb "") + (mod-p (buffer-modified-p)) result success suffix) (narrow-to-region (point) (point)) ;; Read in the contents of the inbox files, renaming them as @@ -1766,10 +1767,11 @@ rmail-get-new-mail-1 (rmail-insert-inbox-text files nil) (setq delete-files (rmail-insert-inbox-text files t)))) ;; If there was no new mail, or we aborted before actually - ;; trying to get any, mark buffer unmodified. Otherwise the - ;; buffer is correctly marked modified and the file locked - ;; until we save out the new mail. - (if (= (point-min) (point-max)) + ;; trying to get any, mark buffer unmodified, unless it was + ;; modified originally. Otherwise the buffer is correctly + ;; marked modified and the file locked until we save out the + ;; new mail. + (if (and (null mod-p) (= (point-min) (point-max))) (set-buffer-modified-p nil))) ;; Scan the new text and convert each message to ;; Rmail/mbox format. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 11:23:46 2022 Received: (at 59108) by debbugs.gnu.org; 10 Nov 2022 16:23:46 +0000 Received: from localhost ([127.0.0.1]:44079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otALB-0000zM-Qc for submit@debbugs.gnu.org; Thu, 10 Nov 2022 11:23:45 -0500 Received: from cosmos.phy.tufts.edu ([130.64.84.253]:48196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otALA-0000zE-3M for 59108@debbugs.gnu.org; Thu, 10 Nov 2022 11:23:44 -0500 Received: from kdo by cosmos.phy.tufts.edu ([local]:local) with local id 1otAL7-0005sN-2i - Using Exim-4.96 (MandrivaLinux) MTA (return-path ); Thu, 10 Nov 2022 11:23:41 -0500 From: Ken Olum To: Eli Zaretskii Subject: Re: bug#59108: 28.2; rmail-get-new-mail sets unmodified if no new mail even if buffer modified before In-Reply-To: <835yfnrtde.fsf@gnu.org> (message from Eli Zaretskii on Thu, 10 Nov 2022 12:33:49 +0200) Date: Thu, 10 Nov 2022 11:23:41 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59108 Cc: 59108@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Yes, it works. Thanks, Eli. Ken From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 12:18:12 2022 Received: (at 59108) by debbugs.gnu.org; 10 Nov 2022 17:18:12 +0000 Received: from localhost ([127.0.0.1]:44260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otBBs-0006ov-9O for submit@debbugs.gnu.org; Thu, 10 Nov 2022 12:18:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otBBp-0006oi-Px for 59108@debbugs.gnu.org; Thu, 10 Nov 2022 12:18:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otBBj-0004yd-5b; Thu, 10 Nov 2022 12:18:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1027grrI8KTPbSkCxmmhzwNTuBDIm8P2COT/u1PkySA=; b=VIQlvB3A3dii lMuABlav311ERp1+rKs5EXv/JE3fhVfBhaGXxq+D5WydMws7t9ZeuQCMJjToUKoUMEeS17kWNxcUr Ch1XjVqp6YxwJ/su2vuqIB/qnos1ZIpXfS5nwEzLmnI04eyutqRYkndy7Ab/DAef3EA4IMTQpDXcp ZC/LSzNQq/At1Eu94tNi0rSgLEnL4D0uEg8Tvx1a0xJTRl7xbU6wuC9ryQe4KPeYxpRWZDWiMK65l JyJg3nkeCI63PyQjS9+jmkSEAE8hFY8sD3K127cU0oIBnSWb/xU+NzBchvicYVg54qztngzWIuXFk dfyldzTzafDd8KXucFhQ/w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otBBi-0006YC-LF; Thu, 10 Nov 2022 12:18:02 -0500 Date: Thu, 10 Nov 2022 19:18:03 +0200 Message-Id: <83eduarano.fsf@gnu.org> From: Eli Zaretskii To: Ken Olum In-Reply-To: (message from Ken Olum on Thu, 10 Nov 2022 11:23:41 -0500) Subject: Re: bug#59108: 28.2; rmail-get-new-mail sets unmodified if no new mail even if buffer modified before References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59108 Cc: 59108@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ken Olum > Cc: 59108@debbugs.gnu.org > Date: Thu, 10 Nov 2022 11:23:41 -0500 > > Yes, it works. Thanks, Eli. Thanks, installed for the upcoming Emacs 29. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 12:24:43 2022 Received: (at 59108-done) by debbugs.gnu.org; 10 Nov 2022 17:24:43 +0000 Received: from localhost ([127.0.0.1]:44279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otBIA-0006zS-Ja for submit@debbugs.gnu.org; Thu, 10 Nov 2022 12:24:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otBI0-0006z7-49 for 59108-done@debbugs.gnu.org; Thu, 10 Nov 2022 12:24:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otBHu-00081T-H1 for 59108-done@debbugs.gnu.org; Thu, 10 Nov 2022 12:24:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QHcktjeez2hKRKXgFSroCdBu9Mm7Kg//9DPlWC4O3BI=; b=H63gOn9gjN8Y /ZPGsLVGVl+WR+oPWHscEXuFkNlIGQ+HOrYJOUD84etjsVyMF0VLhBhhADaIzkdMzZrp3Bhpp57Ec LVsz5/sFYrDT/GnLeUzNhB0g8ju0Z+CIzM2UCNJ4WGfh7ikxCKHZQMj5+/SEn0+lptc4AFbCPs4BP vapwqMhTiVu1Nlcf6YdWT/psbHmD4yFcbdMs2xXztGAMp8CCJvFxwNCMOOrQQdaYUJ5DCGbEtez/N 0C0HZlV6eTeM9xCzPBOvS8GRCl1/Ayst0+SpKXQcykbfoqLUcg9Qp/rqHEoqTW9o5vjsHdo1JhqId vXK9UUfv25VFPFG+1r5e7Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otBHs-0007BX-IP for 59108-done@debbugs.gnu.org; Thu, 10 Nov 2022 12:24:25 -0500 Date: Thu, 10 Nov 2022 19:24:26 +0200 Message-Id: <83a64yrad1.fsf@gnu.org> From: Eli Zaretskii To: 59108-done@debbugs.gnu.org In-Reply-To: <83eduarano.fsf@gnu.org> (message from Eli Zaretskii on Thu, 10 Nov 2022 19:18:03 +0200) Subject: Re: bug#59108: 28.2; rmail-get-new-mail sets unmodified if no new mail even if buffer modified before References: <83eduarano.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59108-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 59108@debbugs.gnu.org > Date: Thu, 10 Nov 2022 19:18:03 +0200 > From: Eli Zaretskii > > > From: Ken Olum > > Cc: 59108@debbugs.gnu.org > > Date: Thu, 10 Nov 2022 11:23:41 -0500 > > > > Yes, it works. Thanks, Eli. > > Thanks, installed for the upcoming Emacs 29. And closing. From unknown Fri Aug 22 01:33:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 09 Dec 2022 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator