Subject: Re: bug#59093: [PATCH] gnu: Add xnedit

From: zimoun <[email-masked]>
Date: Fri, 06 Jan 2023 12:50:51 +0100

Hi,

On Sun, 06 Nov 2022 at 21:12, Andy Tai <[email-masked]> wrote:

> +      (arguments
> +       `(#:make-flags (list (string-append "PREFIX="
> +                                         (assoc-ref %outputs "out"))
                                                      --^
                                                   this

This pattern is now deprecated, if I understand correctly.

    https://guix.gnu.org/en/blog/2021/the-big-change/

Instead, something like,

      (arguments
       (list
       #:make-flags #~(list (string-append "PREFIX=" #$output)
                            (string-append "CC=" #$(cc-for-target)))
         #:tests? #f                  ; no tests
         #:phases #~(modify-phases %standard-phases
                        (delete 'configure)
                        (replace 'build
                            (lambda* (#:key make-flags #:allow-other-keys)
                                (apply invoke "make" "linux" make-flags)))))))

seems more compliant with the “new” style.

> +      (inputs (list
> +              motif
> +              pcre))

Incorrect indentation or just (inputs (list motif pcre))

Cheers,
simon