GNU bug report logs - #59074
[PATCH] build-system/linux-module: Add #:source-directory to linux-module-build-cross.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59074 in the body.
You can then email your comments to 59074 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] build-system/linux-module: Add #:source-directory to
 linux-module-build-cross.
Date: Sun,  6 Nov 2022 10:13:17 +0100

Otherwise computing cross-compilation derivations for packages (e.g. xpadneo)
using the #:source-directory argument fails with this error:

  Unrecognized keyword: #:source-directory

* guix/build-system/linux-module.scm (linux-module-build-cross): Support
 #:source-directory.
---
 guix/build-system/linux-module.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/guix/build-system/linux-module.scm b/guix/build-system/linux-module.scm
index 94a293da13..d6c369d65d 100644
--- a/guix/build-system/linux-module.scm
+++ b/guix/build-system/linux-module.scm
@@ -210,6 +210,7 @@ (define* (linux-module-build-cross
           (tests? #f)
           (phases '%standard-phases)
           (system (%current-system))
+          (source-directory ".")
           (substitutable? #t)
           (imported-modules
            %linux-module-build-system-modules)
@@ -229,6 +230,7 @@ (define %build-target-inputs
 
           (linux-module-build #:name #$name
                               #:source #+source
+                              #:source-directory #$source-directory
                               #:system #$system
                               #:target #$target
                               #:arch #$(system->arch (or target system))
-- 
2.37.3

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 59074-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59074] [PATCH] build-system/linux-module: Add
 #:source-directory to linux-module-build-cross.
Date: Mon, 07 Nov 2022 21:00:09 +0100

[Message part 1 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> Otherwise computing cross-compilation derivations for packages (e.g. xpadneo)
> using the #:source-directory argument fails with this error:
>
>   Unrecognized keyword: #:source-directory
>
> * guix/build-system/linux-module.scm (linux-module-build-cross): Support
>  #:source-directory.
> ---
>  guix/build-system/linux-module.scm | 2 ++
>  1 file changed, 2 insertions(+)

I've gone ahead and pushed this as
da21c5d45f418103bb39061787c90920ee3f36d8.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.