From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 05 19:11:26 2022 Received: (at submit) by debbugs.gnu.org; 5 Nov 2022 23:11:26 +0000 Received: from localhost ([127.0.0.1]:58307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orSJy-0007N8-1S for submit@debbugs.gnu.org; Sat, 05 Nov 2022 19:11:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:47490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orSJv-0007N0-DM for submit@debbugs.gnu.org; Sat, 05 Nov 2022 19:11:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orSJv-0004AJ-6V for bug-gnu-emacs@gnu.org; Sat, 05 Nov 2022 19:11:23 -0400 Received: from mout.gmx.net ([212.227.17.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orSJt-00051H-Bo for bug-gnu-emacs@gnu.org; Sat, 05 Nov 2022 19:11:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1667689877; bh=OEMt8/D0pqVWCi1CLizfABEyZ4k30C8NbkSGJr11384=; h=X-UI-Sender-Class:From:To:Subject:Date; b=TP0FYoRFiPeUXlyy5XDjxTqNMRHmS3OZxoMAXXiPP5oQ+yt2uVd4pmNDG5T0iWTbP LSTQonfxD2rojjRVhD1RU+hsLg0o5SosdLRJBavk7bNvXNpcjovT28V7VaV+KCR2B1 BjJlTqb8Q1sg0IdmZwuKr8rlldv4fkqfIjjmgNXoN1Bie1gx3PhrgGi74FdPBJaW+L VyLx5OfDxeXgym9cKd0hUAXmZBGxt7he9AY91wjyHg5uWYFmhrWAtDkFjCl075AUFP 3/5Dj4GW8K/kcLUWRzZneQYBBJmtujhzmQfK0BcPOo/nQx/z5UQGkJVnuXLmmzJT+0 gbUy5i5kUT8sA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost ([95.90.239.135]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mq2jC-1pLYDH1wig-00n6Ms; Sun, 06 Nov 2022 00:11:17 +0100 From: Gregor Zattler To: bug-gnu-emacs@gnu.org Subject: 29.0.50; build problem git worktree linked to main worktree (repo) Date: Sun, 06 Nov 2022 00:11:09 +0100 Message-ID: <87k0492e0i.fsf@no.workgroup> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:2Ke3454UN6ju1CFNuxgLX7EwvvjkPK+ACkmRBpsyql/+LVz7/tM C7bX32Y+M8J5YUqwPlGjmq+hxPRdHe8S5BMJ2oHzKiHgvVcgxZF/xfRT2mYEIVuBT5DY6rv bxGM5yaHVkNkoMbCEznIkcxG4X3syb+MkUWiYicO4oP8QarDFEbmvbBLIsd4/C95up58OlB UUsvTYomFMPiQPTMuPc7Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ck43BS4ikKk=;PNhWe+ZQmke2Or8ooRc+0dTkZBp Ur0dEfRK878DODOfU2z6OZriCn2USKWqKH/F43m4VAe0vy3p8rksHMC5Wvr6PuCHS2OHOuYIS 4fC7o7xK7Lmk47fwntzP5S74U2kxN4WtPSAr4BI+Qgch/NdEeRAqACjb4h5V/NYcdThCBiNtk 3Agpht30uC3WibhxXqal3YdQloi5PQuc22I0kYkN6VyB7kxscPw7STXuguUMZd/BkUlVn9+v0 jRClr/1K2kGhX2C3BgtjwEUZmo9owemAOqmgVIt4RZO977nBvzsgai7yy5SdYM0EkiwnrYiUo qAexonA0SZODkDQp2ApatQ8qzC68/ZMEGN22PNL554he7zpHshpNpoTlZzkBFncL1iOZclKZk Jx53e2SgaXax7f5VyGN2wD71NusSmbEuig66IG1hD+KfOXdUqhrX74I+tRi25ArvgIJWL2WAQ YgSqL62eNEE9Zakg9WcaRw4e66Rlr6XPE8uC70sxzYsF4oVP0vNaxVs4OUDvE9zlFty7ykwOA XxMXPL7Dgnp5csZyZ5uuiIrPXyf8RCJmSnjQ53/g4ErT9F0xjEQJcUpg1QBnMbqWMqmq/IBt8 ww+5rplGDwTA5/rCCWWcFHWTJgqjfDgBYkezgf41zCdHlUga3XeosSs4jeylqKuv4eU5Pgbj0 ZxI4IsJkNTo5J9HqjkRDejspAqX/nd6Qw5PmSx+qulwSKZn0tErQ95KDGRTuxyfpjYt3Lb+ij LRhIkjDhhLOG8PAulfCQyCCviZBErp0GbC89BytNk939DjPcTE6jA49OuBSDKko595Rz5wGpC 4I6c+eGG9FdGlETbrrl2KQoVIu/8NJH7ajgveX4AyYy56aNWjycye8RufCiTZ6GjRvCMYp/0E v8xKOZE0evjiMN1oBPAxEl7JC0URcHkRMmRzwNsk6TEzmk2VyPaL4I9xT7yr1vEt2nXNtczRO OKJc6JQEilFoDCFNTrhkTH20OPw= Received-SPF: pass client-ip=212.227.17.22; envelope-from=telegraph@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Dear Emacs developers, building Emacs from sources in a detached linked worktree[1] linked to a main worktree[1] fails, because necessary -by.el, -wy.el files are not generated as described in admin/grammars/Makefile for targets `bovine` and `wisent`. Instead while these files are generated error messages "Args out of range: "master", 0, 7" are shown and the respective files are not generated. Why this is the case, I have no clue. The respective code for generating these files is way above my skills. But I found out that building instead from sources in a linked worktree linked to a bare repository[1] works as expected. This is what I will do from now on, therefore the aforementioned failure is no problem for me any more. If there is a bug in the Emacs build system regarding linked worktrees linked to main worktrees, though, is up to you. In order to rule out any misconfiguration on my side, I installed Emacs build dependencies on a minimal installation of Debian/bullseye, cloned the emacs git repo with a freshly created and otherwise unconfigured user. To trigger the build process this user then issued only "make V=1 -j 1" to get the most default build process. All tests were made with freshly cloned repos respectively freshly generated git worktrees created from those pristine git repos. The difference between a linked worktree and its main worktree is in the .git directory only, as this diff shows: $ diff -aNurx.git/* emacs2 emacs2-worktree File emacs2/.git is a directory while file emacs2-worktree/.git is a regular file While investigating, I learned that the build process embeds the repository revision into the Emacs binary. This is the case if Emacs is build in a linked worktree linked to a bare repository, as the template from emacs-report-bug shows. In case of the linked worktree linked to the main worktree the build process does *not* fail if one removes the .git file before. This destroy the link to the repo, though and the repository version is not embedded in the resulting binary accordingly. Why the existence of the .git file disturbs the production of the grammar files, I have no clue. If you have further specific questions, I'm happy to help as far as my very limited knowledge allows. Thanks for your attention, Gregor P.S.: This started with a message on help-gnu-emacs: https://lists.gnu.org/archive/html/help-gnu-emacs/2022-10/msg00860.html and helpful answers by Eli: https://lists.gnu.org/archive/html/help-gnu-emacs/2022-11/msg00002.html and following messages. [1] In git parlance a - "linked worktree" has no .git directory, but a .git *file* which's contents points to either a - "main worktree" which contains the .git directory, (is a git repo with a checked out worktree of its own), or a - bare repository, which basically is a directory containing the contents of a .git dir but without a checked out worktree. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 05 20:04:33 2022 Received: (at 59064) by debbugs.gnu.org; 6 Nov 2022 00:04:33 +0000 Received: from localhost ([127.0.0.1]:58355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orT9N-0004ef-DM for submit@debbugs.gnu.org; Sat, 05 Nov 2022 20:04:33 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:51045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orT9I-0004eO-2r for 59064@debbugs.gnu.org; Sat, 05 Nov 2022 20:04:32 -0400 Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id 1D7D520002; Sun, 6 Nov 2022 00:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1667693061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nSTUR3Ws5eHLNMWDyuo79ZEJN6lvFIvUG4NbLr7hU6s=; b=L9zeOu9Wr8H8YLyt3ah1Vx4oFVhXagGwNdiwPHSj8O/Wz9toGsmnHMJg7NOLsIOgFgAOEZ 9ibRg4tMVOKHeko7AXEge8GlxmKaVPKLD6pWmiB0n+UQBnyggDPkXSODAcqVYl4dwaAvx6 OGneCNB8ows+huEM+kiUzxAgKSXh1By2cEMzvD8kR8ZEdDa+oMaApCtgGXH9KoZmN2wrwm g6e1gCDA5V9cN5s+Q+LbDlsF5Palj8zQZc2/2eizfmzauc0GOOptFd4XKfKLvcx67o7ac9 +9OeX2l4u2W0Q17W0i2uKquOZMccVAt9bIWvgl8zrTpRXeUKEJ8I20p6qj5mDQ== Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1orT98-000Jgq-1d; Sat, 05 Nov 2022 17:04:18 -0700 From: Matt Armstrong To: Gregor Zattler , 59064@debbugs.gnu.org Subject: Re: bug#59064: 29.0.50; build problem git worktree linked to main worktree (repo) In-Reply-To: <87k0492e0i.fsf@no.workgroup> References: <87k0492e0i.fsf@no.workgroup> Date: Sat, 05 Nov 2022 17:04:18 -0700 Message-ID: <87y1spaqyl.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59064 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Gregor Zattler writes: > Dear Emacs developers, > > building Emacs from sources in a detached linked worktree[1] > linked to a main worktree[1] fails, because necessary > -by.el, -wy.el files are not generated as described in > admin/grammars/Makefile for targets `bovine` and `wisent`. > Instead while these files are generated error messages "Args > out of range: "master", 0, 7" are shown and the respective > files are not generated. These sorts of lisp level "Args out of range" errors during the build are typical of a need to run "make bootstrap" to rebuild much more than is usually rebuilt. With respect to lisp compilation the build system takes a few short cuts for expediency sake, and sometimes requires this extra help. See the INSTALL.REPO file in the root of the git tree for more information about this. At the extreme, you can tell git to delete all files not under version control with this command: git clean -dfx This is what I do when I want to get the tree into the same state it would be if I deleted it entirely and re-cloned it. > But I found out that building instead from sources in a > linked worktree linked to a bare repository[1] works as > expected. This may have been because re-cloning the worktree was akin to the git clean command above? (however, what you say next raises doubts...) > In order to rule out any misconfiguration on my side, I installed > Emacs build dependencies on a minimal installation of Debian/bullseye, > cloned the emacs git repo with a freshly created and otherwise > unconfigured user. To trigger the build process this user then issued > only "make V=1 -j 1" to get the most default build process. All tests > were made with freshly cloned repos respectively freshly generated git > worktrees created from those pristine git repos. > > The difference between a linked worktree and its main > worktree is in the .git directory only, as this diff shows: > $ diff -aNurx.git/* emacs2 emacs2-worktree > File emacs2/.git is a directory while file emacs2-worktree/.git is a regular file Well that is a pretty compelling argument. I have just created a fresh worktree from a non-bare git repo using: git worktree add ../b59064 scratch/matta/master The "scratch/matta/master" tree is close to the current "master" branch. Then in the ../b59064 repository, "cat .git" produces: gitdir: /home/matt/git/e/emacs/.git/worktrees/b59064 In this directory a clean build works fine, so I have not yet reproduced the problem. > While investigating, I learned that the build process embeds > the repository revision into the Emacs binary. This is the > case if Emacs is build in a linked worktree linked to a bare > repository, as the template from emacs-report-bug shows. In my case, the built Emacs successfully above figures out the repository revision. For example, this is copied out of the buffer created by M-x report-emacs-bug: In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.16.0) of 2022-11-05 built on naz Repository revision: ce917027c69f77b8dd6eb2052b018593f36a393f Repository branch: scratch/matta/master System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure 'CFLAGS=-Og -g3' 'CXXFLAGS=-Og -g3' --enable-checking=yes --enable-check-lisp-object-type --with-pgtk' > If you have further specific questions, I'm happy to help as > far as my very limited knowledge allows. You reproduced this on a fresh Debian/bullseye system, presumably run in a VM? I am on Debian Testing, updated about a week ago. So that is one difference. I think the next thing to do is to figure out if either: a) This can reproduce this on a Debian/testing or Debian/sid system. Is it easy for you to spin up a VM to do this? If so, it would be useful to know if this is related to the Debian version, as you are likely to use steps similar to what you've already done. b) Whether I can reproduce this on a vanilla Debian/bullseye system, using steps as you've described. I'm willing to try this, but I don't have time to do it today. ...or someone else can reproduce it before either of us get to (a) or (b). From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 06:30:35 2022 Received: (at 59064) by debbugs.gnu.org; 6 Nov 2022 11:30:35 +0000 Received: from localhost ([127.0.0.1]:58836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ordrH-0007KC-6f for submit@debbugs.gnu.org; Sun, 06 Nov 2022 06:30:35 -0500 Received: from mout.gmx.net ([212.227.17.22]:47863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ordrC-0007Jt-2x for 59064@debbugs.gnu.org; Sun, 06 Nov 2022 06:30:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1667734221; bh=uS5goWmQaziP3ysXDXBKdE9nqeUQMzP4kYGvUWFHX6A=; h=X-UI-Sender-Class:From:To:Subject:Date; b=g6yfj6e2370glBAYX+Qov+F/0egrtqxPb7FC3Pct8MVi4HWI+fyvP/KUcPCnCE/84 avO6u7YzUD11hpVZ7sZAtvbYeVDjs2th5dQPr2dwxGuKszctxkiWHlp9lgzQYcV8rr VuK/gvV4Xj/bh/swbCetn9Ga5d69WjYFFD3nm7VQGFsFCNjYYY1pXe5p/50UUlWWnU w+3lDTv8NtPN8ufyUWBRXpSQqmgSQUN7gZG6C1ETahY9xNmmyzRaJdJprnt8D5nfgm yKDhTIoRH/h3L87zaadYtYhIe1VrPd6TMCxMRj0iXoedg+QECDiUR3GQ3D/djXyGQo Vt6EZtYU/HA2Q== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost ([95.90.239.135]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MvK4f-1p8tgq1mT3-00rJEw; Sun, 06 Nov 2022 12:30:21 +0100 From: Gregor Zattler To: Matt Armstrong , 59064@debbugs.gnu.org Subject: Re: bug#59064: 29.0.50; build problem git worktree linked to main worktree (repo) Date: Sun, 06 Nov 2022 12:30:15 +0100 Message-ID: <87y1so1fso.fsf@no.workgroup> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:a5POdJ73liZbIitjotKAYsT/XQTc8nc9lzxg+W6jFkuT+jIxAxY /6egJGwrJucuCAtrK8JGdG4nqqcWdp7NquoNlmXg2pwrTA7BCtoOHQybbbo5ubdLCEnXwZ7 7ArLlUwEk2vl9voz/gON2qFpZ1+j3IcZ9DCKGkIgdrLpyWNJfyGEFe/gShKiROXt7x6YL2n y3JSY6543R0dvtq50D/HA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:rDUwgD7bqSs=;0xrm9gb9J4wOoQjV+TJ3sm71qoJ hqGu0U+OjfqhnczO7yLu4Nvut6jTUeV+NuR4IyKVDw54zzRzo92ovaerizzWKVr0tBipbULvP dVn1+pHC7FloO91CZLkoFr9/YPn/e/dpH0Dxu10+aAquOtIVo3xxzjnHBzbEpFJ9dH8KqWq7X StL05GtQdAsVpf0VcmQcgwYvhKRoDvR1H/qsyYMC+t63EHgKWES4cBsLDzjepfvKK8wR3ZPfu t55i1NfzzI5Po933CeyVtqJ1beiXWhaPBfUR4g9PcqBVh/CeCb4jneBT9KsVsPuw2i3t1MmHe ByO2VXdgQeH2NDQwX2r02PpxdjW3AJFs/viTO9gEJXr+J4nfF/il8eG4rc+st0chtEefXaPyc dTVseU5MD+BH2+Ti4Nn8Ac/Vd22SuZEr1jWglyNrl999SxYkaSFPPNXOhHKSq8MxKmeH6JPwi R97Z4u5GzPdvdotj7gIKy0+iN3mPzRo90Pz3AImZZd+SNFvoXTy3j8melvEsHMew+YUxjjqB2 FA2OBwn3it4OCwSFOoEKYz/c3yuGe8PIotB9M2+TmzKXOqW2spDlmAHz7lclrtx45zsIqFS2M Ugrn0w7Cl+P9fbyE7DIOnF6O/WYCRU6ZaYPpcOCdCNyM8k+lRq9I9OxV5WQGw0gH5BElHLYxZ l5QIGTuiPTRGbuOgOe+lUdbI3tpYJUfwf7LtiITG6+ICrm45oBne/1PE3xDL/CbOThmHhwvq9 Vs5OMTy2OGnrwO3RBU15i1ybHd3e//uyi8vm9WpG7Urh2S+8s95p5FPUbzzjOF7Hf3JVO70PK 0M5SsZ80wEwd7bo8tkbsOdXb9jfrhTN12kSb5BDVC028QvJNWBxk8I0LDT0qXYVX9UDz1bIye ANEklyxY4A3HTpwQLQeE/P8014iDCkrjdUx5su8AZ96MBdpfZR/BaYZhnuIOO6jYbEI1lXZBD 8LQJZus0V1BDAl4jMLOIsmiGj+I= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59064 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Matt, emacs developers, * Matt Armstrong [2022-11-05; 17:04 -07]: > Gregor Zattler writes: >> Dear Emacs developers, >> >> building Emacs from sources in a detached linked worktree[1] >> linked to a main worktree[1] fails, because necessary >> -by.el, -wy.el files are not generated as described in >> admin/grammars/Makefile for targets `bovine` and `wisent`. >> Instead while these files are generated error messages "Args >> out of range: "master", 0, 7" are shown and the respective >> files are not generated. > > These sorts of lisp level "Args out of range" errors during the build > are typical of a need to run "make bootstrap" to rebuild much more than > is usually rebuilt. With respect to lisp compilation the build system > takes a few short cuts for expediency sake, and sometimes requires this > extra help. > > See the INSTALL.REPO file in the root of the git tree for more > information about this. > > At the extreme, you can tell git to delete all files not under version > control with this command: > > git clean -dfx > > This is what I do when I want to get the tree into the same state it > would be if I deleted it entirely and re-cloned it. > > >> But I found out that building instead from sources in a >> linked worktree linked to a bare repository[1] works as >> expected. > > This may have been because re-cloning the worktree was akin to the git > clean command above? > > (however, what you say next raises doubts...) All experiments were done in freshly cloned main worktrees, freshly added linked worktrees from freshly cloned main worktrees and the like. >> In order to rule out any misconfiguration on my side, I installed >> Emacs build dependencies on a minimal installation of Debian/bullseye, >> cloned the emacs git repo with a freshly created and otherwise >> unconfigured user. To trigger the build process this user then issued >> only "make V=3D1 -j 1" to get the most default build process. All test= s >> were made with freshly cloned repos respectively freshly generated git >> worktrees created from those pristine git repos. >> >> The difference between a linked worktree and its main >> worktree is in the .git directory only, as this diff shows: >> $ diff -aNurx.git/* emacs2 emacs2-worktree >> File emacs2/.git is a directory while file emacs2-worktree/.git is a re= gular file > > Well that is a pretty compelling argument. > > I have just created a fresh worktree from a non-bare git repo using: > > git worktree add ../b59064 scratch/matta/master > > The "scratch/matta/master" tree is close to the current "master" branch. > > Then in the ../b59064 repository, "cat .git" produces: > > gitdir: /home/matt/git/e/emacs/.git/worktrees/b59064 > > In this directory a clean build works fine, so I have not yet reproduced > the problem. I now see, I should have showed my command line, I do *detached* linked worktrees: git worktree add -d ../emacs2-worktree This is, because I do not develop, I just want different builds in order for the possibility to use an older build, if something goes wrong with a new one. In a detached linked worktree the build fails as described. In a not-detached linked worktree produced like so: git worktree add -f ../emacs2-master master the build process does *not* fail. *So this bug report is about detached linked worktrees only.* (Now it's even more likely this does not bother emacs devs). >> While investigating, I learned that the build process embeds >> the repository revision into the Emacs binary. This is the >> case if Emacs is build in a linked worktree linked to a bare >> repository, as the template from emacs-report-bug shows. > > In my case, the built Emacs successfully above figures out the > repository revision. For example, this is copied out of the buffer > created by M-x report-emacs-bug: > > In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > 3.24.34, cairo version 1.16.0) of 2022-11-05 built on naz > Repository revision: ce917027c69f77b8dd6eb2052b018593f36a393f > Repository branch: scratch/matta/master > System Description: Debian GNU/Linux bookworm/sid > > Configured using: > 'configure 'CFLAGS=3D-Og -g3' 'CXXFLAGS=3D-Og -g3' --enable-checking=3D= yes > --enable-check-lisp-object-type --with-pgtk' > > >> If you have further specific questions, I'm happy to help as >> far as my very limited knowledge allows. > > You reproduced this on a fresh Debian/bullseye system, presumably run in > a VM? No, this is a Microserver used for backup purposes. > I am on Debian Testing, updated about a week ago. So that > is one difference. > > I think the next thing to do is to figure out if either: > > a) This can reproduce this on a Debian/testing or Debian/sid system. Is > it easy for you to spin up a VM to do this? If so, it would be useful > to know if this is related to the Debian version, as you are likely to > use steps similar to what you've already done. I used to use VirtualBox, but since this is not part of Debian stable, I will use this opportunity to learn how to use KVM. This will take some time, I will report back. Ciao; Gregor =2D- -... --- .-. . -.. ..--.. ...-.- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 09:59:25 2022 Received: (at 59064) by debbugs.gnu.org; 6 Nov 2022 14:59:25 +0000 Received: from localhost ([127.0.0.1]:60403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orh7N-0004ux-0e for submit@debbugs.gnu.org; Sun, 06 Nov 2022 09:59:25 -0500 Received: from mout.gmx.net ([212.227.17.22]:44235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orh7H-0004uh-Pv for 59064@debbugs.gnu.org; Sun, 06 Nov 2022 09:59:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1667746753; bh=urrUzjQI7MMi6Carok4w8AHG3ryft5ZVpb8IRe1n1vs=; h=X-UI-Sender-Class:From:To:Subject:In-Reply-To:References:Date; b=tFE1lXTbFgX4ltHvi5naC+/QxCOCskBwzSFOVHy9nCcP5zVMtztHPZvFWfRKcr6qn l9YV8GSEobFlrIYjx5+piGBnwwxeQnDC+060hEYsTjsG8b6JQhDos6ssLbzyo90VdU oC/3ZtG2g6FNm/YInpKv5eHc6oDvA84B0sc2D295uarcV7tFOsmRMWAeVZJJD6imt4 3wJXzHVxx6i0iBXUODw46fOMfqvkOENJ3GFJ3ONgY6CSJcH7+aOenuDfFOjQX0bmF2 3tM6+BEsIAvgzoLiYefTYLPCgv2ARmfMaAxXovSgSqxhwlpz23KzPm57Auz+VA14OT Zsa9jAnOdoJdw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost ([95.90.239.135]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1McYCb-1pRZdM1DtF-00cxTw; Sun, 06 Nov 2022 15:59:13 +0100 From: Gregor Zattler To: Matt Armstrong , 59064@debbugs.gnu.org Subject: Re: bug#59064: 29.0.50; build problem git worktree linked to main worktree (repo) In-Reply-To: <87y1so1fso.fsf@no.workgroup> References: <87y1so1fso.fsf@no.workgroup> Date: Sun, 06 Nov 2022 15:59:08 +0100 Message-ID: <87iljsruwz.fsf@no.workgroup> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:HMCsFyrndbiGb6gnrIXugclDOhxUmIv/a1N/JcE0LUQn2zTNeGP j0c3UMfJtXcGe7i2PSXXb1mx9jUPbGu9f1CfuIlMxRqTdBro6EL+auyKDVuNgTSqOwtlzOu memqnhQDFMOURJmVpjaIRJ18rSf5msxQi6oqDgeXqL6mhlC5qoezbjShkuMYflDFDY7Hx+e iMQzxWkdEb5r6IaR+wTIg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:s0iPxM8npB8=;GBjQX63mtYSzPkcIojv2DVr/fz6 f/nY8ZWQzRULEBoTuvJqowEiSygbkxiXoanYmOhZXtujWE2zT77Pk3j6ND/k9f9n2zn/KRSr5 Jp+eqNXBvfGBguyMriynG+SpuLHCC46i2hqduLvbliKUqQ44a1iy4WBx4iL7rsAI8O59opefl SaIJIU1Q9KTg7qIDgPvob9MFMbDMuiLbmWPsIGm/nx/lHt3ODMQ+GKji3V2w8FkPaJSB5Ye34 plKM7/w4q092q/itebPyZwJeaca9nxjGG6jDKB6NWuUozeUkboR6B22VRCommixO6yNCAbwDa 8g/Otnt14/oaTWWPN7qQ9fcVXOkGoooReXvzQec3p8bxCXsRs9+i1xaG5eVe4sBt9GgcwhRKe Z2dn9wf2K8uPc/jsfenl7nGbIQZIl/YWUafI00z6ecfsPGE5ikw9fETu7fslrQ3Zkhs7q0E26 dsM2O6ex8baujT2TgjlYegEvbOp8azPF1pvaJzQHz7dNGd3qP+FQ8xmROQFYW0Mi73eaRZHLR PGojAbWoTd3JFaCoeYOPpJLdeosY2kSkkSsj1Hgq/guCW95CeG9PCJYmbxo5cQ5wOGx5ZHM8Z Req2wLrEi1p8/1nKmpHgkTszun7GN04AnAKsP/Ja98+CCxak3YWbuCLNY0RqgONIUGZQ+dmcu +daFMM5HNpwC+Kn07RR8l9KMMhLJgy3nllS2/7C8enyLNrgaFsh7qj3NIrUg8m7F5BApZU+Ak fRbq5xC9Ol/u3HBu+wonJZRH//cwtNlTIvIQoCjMR8PDVZXd6JWKpa/S8c+vQjvP4oUJ91tGu Vv2sHbgFucqnjXIKfYwCZ3Xeh7VE8zrZtt2ickReY6OMCrP82RptevmGYT/xu6jlUvahyWILO ZcoDfdJN82mvRWI+m7TbZcMBGN97HDB1mMrngzynGEuU1IuIXT/aShUBT3u4tRnKAHIOmqsj9 zFcJI3oAXnblBoEyM+YwdKFvYqM= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59064 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Matt, emacs developers, * Gregor Zattler [2022-11-06; 12:30 +01]: > * Matt Armstrong [2022-11-05; 17:04 -07]: >> I think the next thing to do is to figure out if either: >> >> a) This can reproduce this on a Debian/testing or Debian/sid system. I= s >> it easy for you to spin up a VM to do this? If so, it would be useful >> to know if this is related to the Debian version, as you are likely to >> use steps similar to what you've already done. > > I used to use VirtualBox, but since this is not part of > Debian stable, I will use this opportunity to learn how to > use KVM. This will take some time, I will report back. I did so, the results for bookworm are the same: build in detached linked worktree linked to main worktree fails, build in non-detached linked worktree linked to main worktree succeeds. Meanwhile on the bullseye server I tested the same with the sources from emacs-28.2. There was no failure building theses in an detached linked worktree, linked to a main worktree. I will try to bisect. But since I have no clue regarding the build system I only hope that this will not hit other build failures in between. This will take days... Ciao; Gregor =2D- -... --- .-. . -.. ..--.. ...-.- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 13:17:23 2022 Received: (at 59064) by debbugs.gnu.org; 6 Nov 2022 18:17:23 +0000 Received: from localhost ([127.0.0.1]:60554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orkCw-0005pX-GC for submit@debbugs.gnu.org; Sun, 06 Nov 2022 13:17:22 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:43635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orkCs-0005pH-6k for 59064@debbugs.gnu.org; Sun, 06 Nov 2022 13:17:20 -0500 Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id 13411240004; Sun, 6 Nov 2022 18:17:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1667758631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ByQbEknMK2BdALNw7ZofO/j+EfMXHimY1K1E3XOmM/o=; b=BFkfuFkEwCZkBBtroNOthdmMMOAseG8xiAGnCo3q/PKuWCnMAz+mf+cmtTm/AGcyu0jx9J 1wiZT8nLYK4sZ93D/cWUgnz+siAnz3eMcUwLJ3wyVuQtDDNyEwir1jOOLDWTSCXLwKLeTk 40QgmOinSoLhD4VIOQAFjszWpvG1A2eEx2c2uaxmfe1DdtuGY0CPBTo0mKss8+pPwIwPS3 Kor6mny6W6binOS7BnEVol2ZScnJ7NmxjLZytFiNJ77EYrGKtK28EFqcf4H91ZlXbIOJXt SNr09zgovjyFFJWVdaCqOpd7MRmUWnTlR8JSh6m28JLrFC+o2zR7mUDNmHvW6Q== Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1orkCg-000SEl-0G; Sun, 06 Nov 2022 10:17:06 -0800 From: Matt Armstrong To: Gregor Zattler , 59064@debbugs.gnu.org Subject: Re: bug#59064: 29.0.50; build problem git worktree linked to main worktree (repo) In-Reply-To: <87iljsruwz.fsf@no.workgroup> References: <87y1so1fso.fsf@no.workgroup> <87iljsruwz.fsf@no.workgroup> Date: Sun, 06 Nov 2022 10:17:06 -0800 Message-ID: <87v8nsaqxp.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59064 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) X-Debbugs-CC: Philip Kaludercic Hi Philip, this bug manifests for Gregor as Emacs build error in a particular kind of git repository, but it is really a problem with `vc-git-mode-line-string' caused by a recent commit of yours to `vc-working-revision'. Could you take a look? Gregor Zattler writes: > I will try to bisect. But since I have no clue regarding the build > system I only hope that this will not hit other build failures in > between. This will take days... Gregor, no need to bisect. Your most recent instructions helped. This is not a mysterious problem with the build system, but a simpler one with a recent regression in Emacs' vc-mode. The steps to reproduce are simple: 1) In the root directory of an existing Emacs git repository, run this: git switch master git worktree add -d ../b59064 Note that the -d is important. This creates a "detached" work tree attached to no branch at all, but just happens to be at the same rev as "master". 2) cd ../b59064 3) git status Confirm this prints "Not currently on any branch." 3) emacs -Q (using a recent Emacs built on master, not one built in this new repository) 3) M-: (setq debug-on-error t) Edit any file in this repository, I did C-x C-f "INSTALL". You may then need to run M-x vc-mode. You get the following problem in `vc-git-mode-line-string': Debugger entered--Lisp error: (args-out-of-range "master" 0 7) vc-git-mode-line-string("/home/matt/git/e/b59064/admin/grammars/srecode-tem...") apply(vc-git-mode-line-string "/home/matt/git/e/b59064/admin/grammars/srecode-tem...") vc-call-backend(Git mode-line-string "/home/matt/git/e/b59064/admin/grammars/srecode-tem...") vc-mode-line("/home/matt/git/e/b59064/admin/grammars/srecode-tem..." Git) vc-refresh-state() run-hooks(find-file-hook) after-find-file(nil t) find-file-noselect-1(# "~/git/e/b59064/admin/grammars/srecode-template.wy" nil nil "~/git/e/b59064/admin/grammars/srecode-template.wy" (67952095 27)) find-file-noselect("/home/matt/git/e/b59064/admin/grammars/srecode-tem..." nil nil nil) find-file("/home/matt/git/e/b59064/admin/grammars/srecode-tem...") dired--find-file(find-file "/home/matt/git/e/b59064/admin/grammars/srecode-tem...") dired--find-possibly-alternative-file("/home/matt/git/e/b59064/admin/grammars/srecode-tem...") dired-find-file() funcall-interactively(dired-find-file) call-interactively(dired-find-file nil nil) command-execute(dired-find-file) The `vc-git-mode-line-string' code assumes that if `vc-git--symbolic-ref` returns nil then `vc-working-revision' must necessarily return a full hex git rev ID, so it unconditionally performs the following on that value: (substring rev 0 7) However, Philip Kaludercic's recent commit 307ad210040 changed `vc-working-revision' to resolve a hex ID to a symbolic revision if possible, so in this case the function returns "master", causing `substring' to signal as above. This is not currently a problem in "normal" git trees because the following command works in them: git symbolic-ref HEAD ...and this is what vc-git-mode-line-string normally uses to construct the displayed revision used in that line. In detached worktrees that command fails: $ git symbolic-ref HEAD fatal: ref HEAD is not a symbolic ref ...yet the following works: $ git rev-parse HEAD 6e5ec085510ccf52ac6cb07c3a1a2778324a1d89 ...and from that we can get to a symbolic name (the new code Philip added to `vc-working-revision'): $ git name-rev --no-undefined --name-only 6e5ec085510ccf52ac6cb07c3a1a2778324a1d89 master Arguably, `vc-git-mode-line-string' should no longer call `vc-working-revision' but instead a lower level variation that must return the hex rev id. Perhaps? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 13:38:48 2022 Received: (at 59064) by debbugs.gnu.org; 6 Nov 2022 18:38:48 +0000 Received: from localhost ([127.0.0.1]:60574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orkXf-0006MW-Vq for submit@debbugs.gnu.org; Sun, 06 Nov 2022 13:38:48 -0500 Received: from mout02.posteo.de ([185.67.36.66]:44197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orkXc-0006MI-AU for 59064@debbugs.gnu.org; Sun, 06 Nov 2022 13:38:46 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0D019240101 for <59064@debbugs.gnu.org>; Sun, 6 Nov 2022 19:38:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667759918; bh=YPhCebBfiFaPqKlUtSiXIor+tOcGTVjT0wiLNi1+wz0=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=M7ir3zYBu/psTK4k+nBEMhJ1TnUM/fTc3Fd1My/Pps4okEcirDGOuzL7OCt2HQYqi hD4/2ko0qNGWNqi+gYDMUmcuNZfE39mHqIkWRH0snpK3+LGqptjFM+9GcwY8usQx1D nd6S+JsmV5MeMaofNafCxbiTYbrO+uaMA7yPedDhIsN302ZVl2cxvJJyaIzyrnnZQn HZZhZrWApnZ6Hf9PkBNnXbvKJr66FFNPLRHDKOORNzwZD4sFnrk7jRdGCfG1u5MhQ9 EDnW5t4XWUEdNQoTpiFnaKG2fMUGuHJOJ2sZ+Nw3/C9DJKecS4A4OfkUrPPC3TVYu7 Ps+7lmZIK34Yw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N5362742rz9rxW; Sun, 6 Nov 2022 19:38:34 +0100 (CET) From: Philip Kaludercic To: Matt Armstrong Subject: Re: bug#59064: 29.0.50; build problem git worktree linked to main worktree (repo) In-Reply-To: <87v8nsaqxp.fsf@rfc20.org> (Matt Armstrong's message of "Sun, 06 Nov 2022 10:17:06 -0800") References: <87y1so1fso.fsf@no.workgroup> <87iljsruwz.fsf@no.workgroup> <87v8nsaqxp.fsf@rfc20.org> Autocrypt: addr=philipk@posteo.net; keydata= mQGNBGLfygUBDADVznbke6w0n9nE42xb+ZggbBy0IYRkkru/K+NA67523YTl2DoR2a5OMW90w7L9 KDtX2Mp34JN/6jVOSVC07VUbHVu6/exoGKixkiTpGhBPy5tUUJoxQKqLrzVQhN3fIyvg1oyHXKZm QGkUeevV0wjj4++xfjmcP235YvDh3TF8HC9t5KxIQIbhWnQm4ZyDkpWWS2CmdNttlj2+eH+51WLL bgx2bcwTmqrs079Q3hgF3yh44bBEmp9MgFjiZldOY2my0/ZSeucRxYmiM0vbJEBQgZV/MvA3gTxe 7ibV3ii7AyoYA8FiFDP98S/R2y5Nfq3ez9B7qeqtpSNseQHOU7h8Y5VV01a71ZszENAmbbwsldb9 j+HRLke7rn6mswDZl1qA/9ZFRzliFOdQtS1878XjraY+h5jfjvxaFVK23prGGVrrKv0LPWavoFUr nsjeHEZhYezBKhC2PwvRtXm01S3rkNbwm9pj0tfLSDW+1pT+6eZWptfQCXF2oEvgfKSTASUAEQEA AbQmUGhpbGlwIEthbHVkZXJjaWMgPHBoaWxpcGtAcG9zdGVvLm5ldD6JAdQEEwEKAD4WIQRxJuHe LwzjXHcL7QHyw8xRPbifZgUCYt/KBQIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAK CRDyw8xRPbifZkH+DACmCKmhrYgcv2i6dj3vRCVINaLtKUODTna/wAmP20WRKPhqvqvKNUx/wzpT aZrXIxpxOU2xawRWeHhWUktxS+W9L3xTACeR0gf5gomCxD9RuBTIohzWDkQt5rk8QwLqx5rAy5zo feXujnDCXkZtodo1m54cY2kUFF/WIYRrciL/EBzpcizybMJFwx4HxSBlGRkdwnSH9Dzo+4U+8ctB xDfTvQ7cK/0+Qz/TvKjUK8LXLN1/rJTmqpRDv+Odx9LaxutGGoXeLwmhhgpRhvUS8EsqHGF37Zxe AV/ybdVU4NHXVecZAhSgOXX4EHDa7NjhTihx9Id478aQycOKf3CiI6Z8AgcR/iKE4bD4osh2cqQB +JIBtktImxJ1vFsehdQVjdLPWqlr/1weMHM4xH/4VtCLOl5mO3K+fUWxQ/DGLXeQVZ+hilITSKMl YVH/7he26WGd9FRJR25t9uTSgL2YIG8xYppKXueyK/5zjHq05UZRFKiFuPTE4Daoemqx86vYlui5 AY0EYt/KBQEMANvhe1fPQ3BHBcE2GfdX9kVXV0uAP+2Be2DxKWPJI1SqZbrS4wSUsDdd2+2m4YMX E3d+K9Z6IqBcr5gMFSN9QKGEo91FYYgnqvtnd6n9sEAScfNri2GVJzlmXAtEAWeVlv83cu0v0Gsw rSKkxZfMxt+EodtN0aswf5SAy77t28NZUw4fk/0o0AlIMjByVcDkipn7N02gLHjYsvMGFFtM3Zqg Fps8ix3XytSg3Pf8hIVhXFGkBs/iN6dGeIs8wVWBsB7azdqE84uUSRAcS4ymqUE6KxsbNo4x8RAx 9Pt2fcL5bWURAZB+83dk8NVmoQdtY+d4JUV9RAKM/Qg/qtE0fVxcZnj8YmxB1NzLf0UxgHuGYtaq HWrB80CROxMzK7fH8yDRnQKHT2gJYMMQjzMwakSSk8bNJDGBTvAbnxSbYMUC3FR4Pz3pSAbsaSz6 LY0QHDRlroBpyJHatrtKh9Uf9nV0wPIKgZfaH2mhiU17/N6wx0W12cBhrTDRoSnTYIgvQQARAQAB iQG8BBgBCgAmFiEEcSbh3i8M41x3C+0B8sPMUT24n2YFAmLfygUCGwwFCQPCZwAACgkQ8sPMUT24 n2b4ogv/Z5HKvWT2hB238G0ZrUxBptNdQHSG3VwfghN30KH7AEW8ZxsDn3zckn/jXxob4VyhUC8d zZdBQstsNgl+NZ7S2JYRUEsIpoRiHnQFJnfPpt6YZMVNYHJkuh7zRIQGji4OoS8j9QdUHsJnQDia xElXx2vwcBTRZBybcNC+3scGgFBzAcrI4AhYjKZBj5lvKMTrWhK+o4bVdFaYTJDIq37MM3IQLzFF oPIB1C525V916wVYSVl7+RQ1T/mf9oX9kZcYVTC0g4KBEEDI4SGK0i5sKDLfBp4c91AFlUo/J8nC hUMWblnpfCC7epUEbrms0ZQE7RFLgy7YCLZ9Fx2JfV6gx9n9vH7kI605uLnTHgkw3uED/CKfVlbW v0Yrtvi0rUMunLnlySIpXItkSIK+PCqTMdLJ3rBe0ALPgbKN6Lu+yxfe0eaAmFbrNZFI0xp40403 gDwhwoq742fLwbxPSldSeb8A93KRg/8e92CMwKVYtxoADeoksMq10iid4POQl2vw Date: Sun, 06 Nov 2022 18:38:34 +0000 Message-ID: <87h6zcnd1x.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59064 Cc: Gregor Zattler , 59064@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Matt Armstrong writes: > X-Debbugs-CC: Philip Kaludercic > > Hi Philip, this bug manifests for Gregor as Emacs build error in a > particular kind of git repository, but it is really a problem with > `vc-git-mode-line-string' caused by a recent commit of yours to > `vc-working-revision'. Could you take a look? Could this be a duplicate of bug#58709 or bug#59011? I have argued in both threads that the commit ought to be reversed. This particular issue could be resolved by making the code more robust and removing the hard-coded assumption about how git revisions have to look like. > Gregor Zattler writes: > >> I will try to bisect. But since I have no clue regarding the build >> system I only hope that this will not hit other build failures in >> between. This will take days... > > Gregor, no need to bisect. Your most recent instructions helped. This > is not a mysterious problem with the build system, but a simpler one > with a recent regression in Emacs' vc-mode. > > The steps to reproduce are simple: > > 1) In the root directory of an existing Emacs git repository, run this: > > git switch master > git worktree add -d ../b59064 > > Note that the -d is important. This creates a "detached" work tree > attached to no branch at all, but just happens to be at the same rev > as "master". > > 2) cd ../b59064 > > 3) git status > > Confirm this prints "Not currently on any branch." > > 3) emacs -Q (using a recent Emacs built on master, not one built in > this new repository) > > 3) M-: (setq debug-on-error t) > > Edit any file in this repository, I did C-x C-f "INSTALL". You may then > need to run M-x vc-mode. > > You get the following problem in `vc-git-mode-line-string': > > Debugger entered--Lisp error: (args-out-of-range "master" 0 7) > vc-git-mode-line-string("/home/matt/git/e/b59064/admin/grammars/srecode-tem...") > apply(vc-git-mode-line-string "/home/matt/git/e/b59064/admin/grammars/srecode-tem...") > vc-call-backend(Git mode-line-string "/home/matt/git/e/b59064/admin/grammars/srecode-tem...") > vc-mode-line("/home/matt/git/e/b59064/admin/grammars/srecode-tem..." Git) > vc-refresh-state() > run-hooks(find-file-hook) > after-find-file(nil t) > find-file-noselect-1(# "~/git/e/b59064/admin/grammars/srecode-template.wy" nil nil "~/git/e/b59064/admin/grammars/srecode-template.wy" (67952095 27)) > find-file-noselect("/home/matt/git/e/b59064/admin/grammars/srecode-tem..." nil nil nil) > find-file("/home/matt/git/e/b59064/admin/grammars/srecode-tem...") > dired--find-file(find-file "/home/matt/git/e/b59064/admin/grammars/srecode-tem...") > dired--find-possibly-alternative-file("/home/matt/git/e/b59064/admin/grammars/srecode-tem...") > dired-find-file() > funcall-interactively(dired-find-file) > call-interactively(dired-find-file nil nil) > command-execute(dired-find-file) > > The `vc-git-mode-line-string' code assumes that if > `vc-git--symbolic-ref` returns nil then `vc-working-revision' must > necessarily return a full hex git rev ID, so it unconditionally performs > the following on that value: > > (substring rev 0 7) > > However, Philip Kaludercic's recent commit 307ad210040 changed > `vc-working-revision' to resolve a hex ID to a symbolic revision if > possible, so in this case the function returns "master", causing > `substring' to signal as above. > > This is not currently a problem in "normal" git trees because the > following command works in them: > > git symbolic-ref HEAD > > ...and this is what vc-git-mode-line-string normally uses to construct > the displayed revision used in that line. > > In detached worktrees that command fails: > > $ git symbolic-ref HEAD > fatal: ref HEAD is not a symbolic ref > > ...yet the following works: > > $ git rev-parse HEAD > 6e5ec085510ccf52ac6cb07c3a1a2778324a1d89 > > ...and from that we can get to a symbolic name (the new code Philip > added to `vc-working-revision'): > > $ git name-rev --no-undefined --name-only 6e5ec085510ccf52ac6cb07c3a1a2778324a1d89 > master > > Arguably, `vc-git-mode-line-string' should no longer call > `vc-working-revision' but instead a lower level variation that must > return the hex rev id. Perhaps? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 14:06:11 2022 Received: (at 59064) by debbugs.gnu.org; 6 Nov 2022 19:06:11 +0000 Received: from localhost ([127.0.0.1]:60588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orky9-00074m-0P for submit@debbugs.gnu.org; Sun, 06 Nov 2022 14:06:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orky4-00073o-IW for 59064@debbugs.gnu.org; Sun, 06 Nov 2022 14:06:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orkxy-0005Nb-VM; Sun, 06 Nov 2022 14:05:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=a7ej5eKn4UIKNA8j9LjpVct7UeGTRdh+0nIz5EQEWW4=; b=pXujPHr+O6af qnpimvc8bfYiTjz4E1MmGlOmvJaUgGv9+0xEZdnkQdkQ1P9G6vU4uzcKaTEbRK/8gvyDp/j513jJP meNneHa4VuZWr9qYgLb4Ksic973VALDoCN2dXjE+c/mGFJ+JONcDGENJCXJowtrqT51y24t2txhiC VS0HBDELx9631XaqwWPxyaTXI6H+S/bzCGadnLBAXiTn17wQumwDhqA/ns0u+enHW/1b4iVapW3DY nbIRm3Vgo9+Yra+QQR2R8Y8ggk0Klj3M7rDTP/BwCYoNTSIeqtAXgmKm8z3KO6BEam2C/s90kqavz yLtnmBVJcPK2nHi+u4Afdw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orkxx-0005hP-RL; Sun, 06 Nov 2022 14:05:58 -0500 Date: Sun, 06 Nov 2022 21:05:41 +0200 Message-Id: <83pmdzzywq.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87h6zcnd1x.fsf@posteo.net> (message from Philip Kaludercic on Sun, 06 Nov 2022 18:38:34 +0000) Subject: Re: bug#59064: 29.0.50; build problem git worktree linked to main worktree (repo) References: <87y1so1fso.fsf@no.workgroup> <87iljsruwz.fsf@no.workgroup> <87v8nsaqxp.fsf@rfc20.org> <87h6zcnd1x.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59064 Cc: matt@rfc20.org, telegraph@gmx.net, 59064@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Gregor Zattler , 59064@debbugs.gnu.org > From: Philip Kaludercic > Date: Sun, 06 Nov 2022 18:38:34 +0000 > > Matt Armstrong writes: > > > X-Debbugs-CC: Philip Kaludercic > > > > Hi Philip, this bug manifests for Gregor as Emacs build error in a > > particular kind of git repository, but it is really a problem with > > `vc-git-mode-line-string' caused by a recent commit of yours to > > `vc-working-revision'. Could you take a look? > > Could this be a duplicate of bug#58709 or bug#59011? I have argued in > both threads that the commit ought to be reversed. Then please go ahead and revert it. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 16:35:53 2022 Received: (at 59064) by debbugs.gnu.org; 6 Nov 2022 21:35:53 +0000 Received: from localhost ([127.0.0.1]:60822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ornJ3-0002TJ-Cv for submit@debbugs.gnu.org; Sun, 06 Nov 2022 16:35:53 -0500 Received: from mout.gmx.net ([212.227.17.22]:42431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ornJ0-0002T5-Ot for 59064@debbugs.gnu.org; Sun, 06 Nov 2022 16:35:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1667770542; bh=FyLhvgQmEPM7wJd4uq5zEHDAkLRAXUuuW1yKlm30wdY=; h=X-UI-Sender-Class:From:To:Subject:In-Reply-To:References:Date; b=pJ9kadyQA9sjBErGpF8kN8y2U7Va8p4AoIiX+8VZdzkhCVWFWoS1r19bOyi+ugG6E EPsZT56llU/ZvPKjEwP48gV0wct2leKjdv1p6DsSIVRitaI8n7xk6IlvsuC5OQuOd/ g9PzjX7c5RlaS4kzPmwQh/6EzYANMrIKv601ojtB+gT31Ysf/rXvYP5ZNLhBhMRFXz CfJWhUtrntkTNUcqJlZ7fvolkJ6qZffNmFTp9YrTfoJJ7aMqIIjO7wNvbpEBWvtyMI oOORcB3gGXhoiEEZ6wwPyr0GjZamLlCmBj1TTedpY56GIuo6OIcLI7p2+Q88gQAyUf nNfdX+pCMuE5Q== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost ([95.90.239.135]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4hzj-1p2hJ30Ku7-011jTi; Sun, 06 Nov 2022 22:35:42 +0100 From: Gregor Zattler To: Matt Armstrong , 59064@debbugs.gnu.org Subject: Re: bug#59064: 29.0.50; build problem git worktree linked to main worktree (repo) In-Reply-To: <87v8nsaqxp.fsf@rfc20.org> References: <87y1so1fso.fsf@no.workgroup> <87iljsruwz.fsf@no.workgroup> <87v8nsaqxp.fsf@rfc20.org> Date: Sun, 06 Nov 2022 22:35:37 +0100 Message-ID: <87cz9zsr4m.fsf@no.workgroup> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:hXlvif0MpqC6z8tCQgmqQ1e3NIzY9XgfPf6JvJq1dEGhYMI5vWU SLrZ626h8JJCX55iPk8mZmdiQZVxgJ9/FDZaMXvd+yOyj15fe8D9SIU0G0lORt+nSAbliCC nyCJ0ivL6V1dNVZx0RTIlu+bnfmSTtvANQF/GpQ4Y2bGykx6Wx2+QeAbdNUXEkW8K/kzWJ1 LTvzR1Ot2LeShTxsSCSaA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:0/OoOG6J9M8=;UwdTuk805YBv6IxihbsaJIDPOow eSH5SbB5WoaC1vUtfibP9EMUDo2U+x0OeA6vIo/MKh+S6svTjb/Sn5tGIsXX69ksH1MbEjnfs E2sPAqBxcdtIrR98sRjjqVkXshB9N27expTEc6ukADCNxBeCdr5s+Wg17QQIQkJeAnAtLK0wk PUh1axkGwgM/RZ3r2wlW1XCuk+/grPj+xKnJ4zH8TIBr46B0ehp25t454Jcn1ykns6WSD2GTE usmhznXX/9VySTQY1hsNwP9G3qDKgqJDHXAPAlW3uDdkXSaieRi3eTOBQVnayZ9iHqW8WTo4l Yym5rnuqqPgM3WRQubQDYlMOYcMvEUqtn+Y2DuGR8qU8ruSSU8bT3JiWYKHLnTVPjbzdKL4/i TLSPe0vPjq6hfs87KYHg/zWKfxol4BCa5VUrpM4lTfxUqUZcyApFOdqMsbx6GOTqw89EJhp7Q Zb0iTUFUDzA6IRJvpTd4sOvSI+fFmO6D/3zG7a72tD2vNaLYdaLy57ia1jXOMZhUrbE1JF9rL wx2axD+S2HpgLTZl6ID7HuJV+3VfSojhr8tKXRbTQj20pnd3vf0h7kGqXlxlzmn7eLvhEz3IM d0NpCOry5VD2NZZw1og+WiMJHH5MZg+XoVM6u7ZJtX7HUyjXri4vDVB9S+HUcbD0svuWKa7AV tPPv9PPI4ZLWvBJTbt+gzngA3+Jy/4vTW0VQph6D0Ex3mhvaqgEuBFMfZrZ/1y4hrjJb7qdza U6HfJUA+wbzBoPZSE/iEc9yGIQ315Ye4ghbQ9DMRmkyh7Ubc0GHWNjTGmiQNzyeSEa3N3nsDm 2/rAoyW0+k3/hrqJ72yAc+qBbVJ00SCylKfjf95//m6XiQmlA9e4e/1l0YJZakKODIcWHzVC4 B4lOIDzVX79pCTpdPcUbIfDjCc821/4VqXGwMsowB9JeDtjgvJuUbAOl5OCE9YnCxWJFxAY6i prNTVXFqHlu98GysT0AdKqLcTJI= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59064 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Matt, Emacs developers, * Matt Armstrong [2022-11-06; 10:17 -08]: > X-Debbugs-CC: Philip Kaludercic > > Hi Philip, this bug manifests for Gregor as Emacs build error in a > particular kind of git repository, but it is really a problem with > `vc-git-mode-line-string' caused by a recent commit of yours to > `vc-working-revision'. Could you take a look? > > > Gregor Zattler writes: > >> I will try to bisect. [...] > Gregor, no need to bisect. I already did and it hit on the wrong commit (44ad42240069d8d82772b0c0ef5ec93c2566ca7e) :-( > Your most recent instructions helped. That's good to hear, but I have no idea how you came to your conclusion :-) Thanks for your efforts, Gregor =2D- -... --- .-. . -.. ..--.. ...-.- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 07 03:52:55 2022 Received: (at 59064) by debbugs.gnu.org; 7 Nov 2022 08:52:55 +0000 Received: from localhost ([127.0.0.1]:33267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orxsE-0007Q8-Ol for submit@debbugs.gnu.org; Mon, 07 Nov 2022 03:52:55 -0500 Received: from mout01.posteo.de ([185.67.36.65]:60599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orxsC-0007Pu-WF for 59064@debbugs.gnu.org; Mon, 07 Nov 2022 03:52:53 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 11EE224002B for <59064@debbugs.gnu.org>; Mon, 7 Nov 2022 09:52:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667811167; bh=1VZ4go0E9qWttrfLLFBmFCOkOePzJDLljyq/3xPKL30=; h=From:To:Cc:Subject:Date:From; b=YHkxqR1CrC5goqWE/sf7yZbGyu27YkNQNs9xuNmNbEIHlzDprMMbcF6DrEgDrc2/a LvIkdN0Tp21NrZsrQ0bwusDaOUHRWnbLKTQ1YqUriRp1GwaczQbqnjuedr+zc7nNsR U/p1Mn77BZZ9a8QfImMX82QW9r/xME+cWeSUb3PbeKunQVzl/tPHTIA6YOnsrfI2yH clxX5iqE3A7/F7sVxqQtJcLqyxUMvt0vPWhZ00EKMeqI8alnwqfTjbBOqJzr8CYzvA 3TxXRZCbgXFs5kKX1qP8Qsk4LopMSFp97ggmotLpHzgL+ScZNWCz3Dafh+x4Oq11KC X1W1zWD6p9WrQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N5Q3d7202z9rxH; Mon, 7 Nov 2022 09:52:44 +0100 (CET) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#59064: 29.0.50; build problem git worktree linked to main worktree (repo) In-Reply-To: <83pmdzzywq.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 06 Nov 2022 21:05:41 +0200") References: <87y1so1fso.fsf@no.workgroup> <87iljsruwz.fsf@no.workgroup> <87v8nsaqxp.fsf@rfc20.org> <87h6zcnd1x.fsf@posteo.net> <83pmdzzywq.fsf@gnu.org> Date: Mon, 07 Nov 2022 08:52:44 +0000 Message-ID: <874jvbywmb.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59064 Cc: matt@rfc20.org, telegraph@gmx.net, 59064@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Cc: Gregor Zattler , 59064@debbugs.gnu.org >> From: Philip Kaludercic >> Date: Sun, 06 Nov 2022 18:38:34 +0000 >> >> Matt Armstrong writes: >> >> > X-Debbugs-CC: Philip Kaludercic >> > >> > Hi Philip, this bug manifests for Gregor as Emacs build error in a >> > particular kind of git repository, but it is really a problem with >> > `vc-git-mode-line-string' caused by a recent commit of yours to >> > `vc-working-revision'. Could you take a look? >> >> Could this be a duplicate of bug#58709 or bug#59011? I have argued in >> both threads that the commit ought to be reversed. > > Then please go ahead and revert it. Done. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 07 12:20:12 2022 Received: (at 59064) by debbugs.gnu.org; 7 Nov 2022 17:20:12 +0000 Received: from localhost ([127.0.0.1]:35252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os5nA-0002Fa-3y for submit@debbugs.gnu.org; Mon, 07 Nov 2022 12:20:12 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:58667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os5n8-0002FJ-Jj for 59064@debbugs.gnu.org; Mon, 07 Nov 2022 12:20:11 -0500 Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id 91B081BF211; Mon, 7 Nov 2022 17:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1667841604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3mrBaX0Gm9BpplQONpRFxz9JYuE0wguUHjtoy4vOks4=; b=OZp82O6SIyK9LFPx4pmXrnql6oSK/UhmIvzvw+L/jatqy1tTWQVNNW9f3OCrpjrbLD5mM2 j+Vs3rUxuqphorp8qH+YU8ODYY4ZAcGEJzDR+Y0UUW1TdpxMlKDOCbtcsp2BI7SBkJ/tXB viWpDbw8KmsuwC3/0ni1nU9tm4P9T7e93DYuqQS5nVhL0PVr2vQ9dwWmAb/zYIVvVm8XQQ oy95PKqXpEhkUXCe1BdHwmLJRTrlOhXwVbeTl+2pX1eRkxoFXaf6Gd5kue2Kh5hbJZIhT6 56Mhpxy6gAyz5vcBaQ1soo45o14OAU17M1PWY+hYwx1WGWFJBleNY0ubqgLMNg== Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1os5my-000dgq-03; Mon, 07 Nov 2022 09:20:00 -0800 From: Matt Armstrong To: Gregor Zattler , 59064@debbugs.gnu.org Subject: Re: bug#59064: 29.0.50; build problem git worktree linked to main worktree (repo) In-Reply-To: <87cz9zsr4m.fsf@no.workgroup> References: <87y1so1fso.fsf@no.workgroup> <87iljsruwz.fsf@no.workgroup> <87v8nsaqxp.fsf@rfc20.org> <87cz9zsr4m.fsf@no.workgroup> Date: Mon, 07 Nov 2022 09:19:59 -0800 Message-ID: <87h6zaof5s.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59064 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Gregor Zattler writes: >> Your most recent instructions helped. > > That's good to hear, but I have no idea how you came to your > conclusion :-) ...only with a little bit of luck. I noticed the same lisp level errors you did when building Emacs in the detached-head repo, and when I happened to use a recent 29.0.50 Emacs to open one of the .el files in the same repo I noticed the same error. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 07 12:24:16 2022 Received: (at 59064-done) by debbugs.gnu.org; 7 Nov 2022 17:24:16 +0000 Received: from localhost ([127.0.0.1]:35256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os5r5-0002Lz-NA for submit@debbugs.gnu.org; Mon, 07 Nov 2022 12:24:16 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:35317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os5r3-0002Lk-Pn for 59064-done@debbugs.gnu.org; Mon, 07 Nov 2022 12:24:14 -0500 Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id DA0B824000A; Mon, 7 Nov 2022 17:24:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1667841847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KLFMvJJofm7GcDQv61hX6hz5yjLjEETrnfcab3NUbAI=; b=ns7zq2013XMQuN22yPDfxq4ml5B/2t3E8VyOx5Di4SSydZUGa0sshWIemg3iTpALzds2aP HiVRf/S6OpwLiKxHV5hRFtuesiEsTGU0sgyZHpRDaILqGY3CehKR38sZr0WTNFIQ+I8U8I yIagXU6CEzeKr1UCjLUmwU2X6LQ5302ppB1EHhW8N/N6n3dy3rRGuAhAUspozXnfxhP00o lyKtoUIZ/KjhZwAQqFCJOdhQKmse7Z073jdpyEl9jV8XiVUBHPGy9zQnK7FGB0aiJvo0u8 UwyBY7mH8Zvk7w9ozV+nQWJwSM107EjVe3Q8BxdDS4ZGTWF6SyoVvqU7Nqcs6g== Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1os5qu-000doQ-0a; Mon, 07 Nov 2022 09:24:04 -0800 From: Matt Armstrong To: Philip Kaludercic , Eli Zaretskii Subject: Re: bug#59064: 29.0.50; build problem git worktree linked to main worktree (repo) In-Reply-To: <874jvbywmb.fsf@posteo.net> References: <87y1so1fso.fsf@no.workgroup> <87iljsruwz.fsf@no.workgroup> <87v8nsaqxp.fsf@rfc20.org> <87h6zcnd1x.fsf@posteo.net> <83pmdzzywq.fsf@gnu.org> <874jvbywmb.fsf@posteo.net> Date: Mon, 07 Nov 2022 09:24:04 -0800 Message-ID: <87edueoeyz.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59064-done Cc: telegraph@gmx.net, 59064-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Philip Kaludercic writes: >> Then please go ahead and revert it. > > Done. Thanks Philip, I've confirmed that your commit 8fe62b2ab571ba313587e8543006eca03ff36025 on Sun Nov 6 22:18:24 2022 +0100 fixed this issue. From unknown Mon Aug 18 11:26:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 06 Dec 2022 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator