GNU bug report logs - #59000
[PATCH 1/2] gnu: Add emacs-waveform.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59000 in the body.
You can then email your comments to 59000 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH 1/2] gnu: Add emacs-waveform.
Date: Thu, 3 Nov 2022 13:08:26 -0500

Message #8 received at 59000 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 59000 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH 1/2] gnu: Add emacs-mpv.
Date: Thu,  3 Nov 2022 13:09:54 -0500

* gnu/packages/emacs-xyz.scm (emacs-mpv): New variable.
---
 gnu/packages/emacs-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8478a47591..c2942c5b79 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -33700,6 +33700,42 @@ (define-public emacs-flymake-mypy
 using mypy.")
       (license license:bsd-2))))
 
+(define-public emacs-mpv
+  ;; No release since Dec 28, 2021.
+  (let ((commit "2e0234bc21a3dcdf12d94d3285475e7f6769d3e8")
+        (revision "0"))
+    (package
+      (name "emacs-mpv")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/kljohann/mpv.el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0mvzg2wqpycny2dmiyp8jm0fflvll7ay6scvsb9rxgfwimr2vbw5"))))
+      (build-system emacs-build-system)
+      (arguments
+       (list
+        #:tests? #f ; There are no tests.
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'set-mpv-el-version 'patch-exec-paths
+              (lambda* (#:key inputs #:allow-other-keys)
+                (make-file-writable "mpv.el")
+                (emacs-substitute-variables "mpv.el"
+                  ("mpv-executable"
+                   (search-input-file inputs "/bin/mpv"))))))))
+      (inputs (list mpv))
+      (home-page "https://github.com/kljohann/mpv.el/")
+      (synopsis "Control mpv for easy note taking")
+      (description
+"This package is a potpourri of helper functions to control a @code{mpv}
+process via its IPC interface.")
+      (license license:gpl3+))))
+  
 (define-public emacs-project-x
   ;; There is no proper release.
   ;; The base version is extracted from the README.org.
-- 
2.38.1

Message #11 received at 59000 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 59000 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH 2/2] gnu: Add emacs-waveform.
Date: Thu,  3 Nov 2022 13:09:55 -0500

* gnu/packages/emacs-xyz.scm (emacs-waveform): New variable.
---
 gnu/packages/emacs-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c2942c5b79..6fba8e6db8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -33736,6 +33736,42 @@ (define-public emacs-mpv
 process via its IPC interface.")
       (license license:gpl3+))))
   
+(define-public emacs-waveform
+  (let ((commit "ee52c6a72b3e9890743e3a6e2fc1f3195f5687b2")
+        (revision "0"))
+    (package
+      (name "emacs-waveform")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/sachac/waveform-el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0cxyvp2aav27znc7mf6c83q5pddpdniaqkrxn1r8dbgr540qmnpn"))))
+      (build-system emacs-build-system)
+      (arguments
+       (list
+        #:tests? #f ; There are no tests.
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'set-waveform-el-version 'patch-exec-paths
+              (lambda* (#:key inputs #:allow-other-keys)
+                (make-file-writable "lisp/waveform-el-sequence.el")
+                (emacs-substitute-variables "waveform.el"
+                  ("waveform-ffmpeg-executable"
+                   (search-input-file inputs "/bin/ffmpeg"))))))))
+      (inputs (list ffmpeg))
+      (propagated-inputs (list emacs-mpv))
+      (home-page "https://github.com/sachac/waveform-el/")
+      (synopsis "Display a waveform and use it to navigate")
+      (description
+"This package displays a waveform of a sound file.  It is intended to
+be used with @code{emacs-mpv}")
+      (license license:gpl3+))))
+  
 (define-public emacs-project-x
   ;; There is no proper release.
   ;; The base version is extracted from the README.org.
-- 
2.38.1

Message #14 received at 59000 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 59000 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH v2 1/2] gnu: Add emacs-mpv.
Date: Thu,  3 Nov 2022 13:14:59 -0500

* gnu/packages/emacs-xyz.scm (emacs-mpv): New variable.

hi, ignore v1
---
 gnu/packages/emacs-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8478a47591..c2942c5b79 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -33700,6 +33700,42 @@ (define-public emacs-flymake-mypy
 using mypy.")
       (license license:bsd-2))))
 
+(define-public emacs-mpv
+  ;; No release since Dec 28, 2021.
+  (let ((commit "2e0234bc21a3dcdf12d94d3285475e7f6769d3e8")
+        (revision "0"))
+    (package
+      (name "emacs-mpv")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/kljohann/mpv.el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0mvzg2wqpycny2dmiyp8jm0fflvll7ay6scvsb9rxgfwimr2vbw5"))))
+      (build-system emacs-build-system)
+      (arguments
+       (list
+        #:tests? #f ; There are no tests.
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'set-mpv-el-version 'patch-exec-paths
+              (lambda* (#:key inputs #:allow-other-keys)
+                (make-file-writable "mpv.el")
+                (emacs-substitute-variables "mpv.el"
+                  ("mpv-executable"
+                   (search-input-file inputs "/bin/mpv"))))))))
+      (inputs (list mpv))
+      (home-page "https://github.com/kljohann/mpv.el/")
+      (synopsis "Control mpv for easy note taking")
+      (description
+"This package is a potpourri of helper functions to control a @code{mpv}
+process via its IPC interface.")
+      (license license:gpl3+))))
+  
 (define-public emacs-project-x
   ;; There is no proper release.
   ;; The base version is extracted from the README.org.
-- 
2.38.1

Message #17 received at 59000 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 59000 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH v2 2/2] gnu: Add emacs-waveform.
Date: Thu,  3 Nov 2022 13:15:00 -0500

* gnu/packages/emacs-xyz.scm (emacs-waveform): New variable.
---
 gnu/packages/emacs-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c2942c5b79..01b97b3e69 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -33736,6 +33736,42 @@ (define-public emacs-mpv
 process via its IPC interface.")
       (license license:gpl3+))))
   
+(define-public emacs-waveform
+  (let ((commit "ee52c6a72b3e9890743e3a6e2fc1f3195f5687b2")
+        (revision "0"))
+    (package
+      (name "emacs-waveform")
+      (version (git-version "0.0.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/sachac/waveform-el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "082ls7khd22fjwnk7h1zxrmqqcmxqh2wx2vljlxhjh9bcp1y2pyr"))))
+      (build-system emacs-build-system)
+      (arguments
+       (list
+        #:tests? #f ; There are no tests.
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'set-waveform-el-version 'patch-exec-paths
+              (lambda* (#:key inputs #:allow-other-keys)
+                (make-file-writable "waveform.el")
+                (emacs-substitute-variables "waveform.el"
+                  ("waveform-ffmpeg-executable"
+                   (search-input-file inputs "/bin/ffmpeg"))))))))
+      (inputs (list ffmpeg))
+      (propagated-inputs (list emacs-mpv))
+      (home-page "https://github.com/sachac/waveform-el/")
+      (synopsis "Display a waveform and use it to navigate")
+      (description
+"This package displays a waveform of a sound file.  It is intended to
+be used with @code{emacs-mpv}")
+      (license license:gpl3+))))
+  
 (define-public emacs-project-x
   ;; There is no proper release.
   ;; The base version is extracted from the README.org.
-- 
2.38.1

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>
Cc: jgart <jgart <at> dismail.de>, 59000-done <at> debbugs.gnu.org
Subject: Re: [bug#59000] [PATCH v2 1/2] gnu: Add emacs-mpv.
Date: Sun, 06 Nov 2022 15:13:17 +0100

Hello,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-mpv): New variable.

Thank you. Applied, with the following changes.

> +    (package
> +      (name "emacs-mpv")
> +      (version (git-version "0.0.0" revision commit))

Base version is actually 0.2.0.

> +        #~(modify-phases %standard-phases
> +            (add-after 'set-mpv-el-version 'patch-exec-paths
> +              (lambda* (#:key inputs #:allow-other-keys)
> +                (make-file-writable "mpv.el")

`make-file-writable' is not necessary.

> +                (emacs-substitute-variables "mpv.el"
> +                  ("mpv-executable"
> +                   (search-input-file inputs "/bin/mpv"))))))))
> +      (synopsis "Control mpv for easy note taking")
> +      (description
> +"This package is a potpourri of helper functions to control a @code{mpv}
> +process via its IPC interface.")

mpv -> MPV

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.