GNU bug report logs - #58989
[PATCH] services: gitolite: Add local-code configuration option.

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Alexey Abramov <levenson <at> mmer.org>
Cc: 58989 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#58989] [PATCH] services: gitolite: Add local-code
 configuration option.
Date: Sun, 06 Nov 2022 15:03:38 +0100

[Message part 1 (text/plain, inline)]

Alexey Abramov via Guix-patches via <guix-patches <at> gnu.org> writes:

>    (match file
> -    (($ <gitolite-rc-file> umask unsafe-pattern git-config-keys roles enable)
> +    (($ <gitolite-rc-file> umask local-code unsafe-pattern git-config-keys roles enable)
>       (apply text-file* "gitolite.rc"
>        `("%RC = (\n"
>          "    UMASK => " ,(format #f "~4,'0o" umask) ",\n"
>          "    GIT_CONFIG_KEYS => '" ,git-config-keys "',\n"
> +        ,(if local-code
> +             (simple-format #f "    LOCAL_CODE => \"~A\",\n" local-code))
>          "    ROLES => {\n"
>          ,@(map (match-lambda
>                   ((role . value)

This generally looks good, but I believe the above will break if
local-code is #f.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.