From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 03 12:16:14 2022 Received: (at submit) by debbugs.gnu.org; 3 Nov 2022 16:16:14 +0000 Received: from localhost ([127.0.0.1]:50122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqct4-00032s-9X for submit@debbugs.gnu.org; Thu, 03 Nov 2022 12:16:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:50354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqcsz-00032e-Ha for submit@debbugs.gnu.org; Thu, 03 Nov 2022 12:16:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqcsr-0008F7-SL for guix-patches@gnu.org; Thu, 03 Nov 2022 12:16:03 -0400 Received: from mail.mmer.org ([178.22.65.174]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqcsq-0007rq-2D for guix-patches@gnu.org; Thu, 03 Nov 2022 12:16:01 -0400 Received: from mail.mmer.org (localhost [127.0.0.1]) by mail.mmer.org (OpenSMTPD) with ESMTP id d9232543 for ; Thu, 3 Nov 2022 16:15:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=mmer.org; h=from:to :subject:date:message-id:mime-version:content-transfer-encoding; s=dkim; bh=V2QJMRn02h61z9Q/a0kQ+qw1OgLlZlf3/zyEwALVEz0=; b=BTeE iN41NVaehBiYjT8bOkYk6WpQo/mljg01N1GLW6N8es63vfBx30sHB7Q6rM8wb8Sx tEx824YNKr5okwL8t1apWo73CPXTQ/Jf6EdjxBjo4f9Hv2OTBSOgANw872jNmRVN eYZmVXR1GuMK3yrqC9Za7eF8dQHQostZU6exOrw= Received: from delta (j74210.upc-j.chello.nl [24.132.74.210]) by mail.mmer.org (OpenSMTPD) with ESMTPSA id 14f2a8ec (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Thu, 3 Nov 2022 16:15:54 +0000 (UTC) From: Alexey Abramov To: guix-patches@gnu.org Subject: [PATCH] services: gitolite: Add local-code configuration option. Date: Thu, 3 Nov 2022 17:15:25 +0100 Message-Id: <20221103161525.2130-1-levenson@mmer.org> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.22.65.174; envelope-from=levenson@mmer.org; helo=mail.mmer.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/services/version-control.scm (gitolite-rc-file): Add local-code field. (gitolite-rc-file-compiler): Serialize the field. * doc/guix.texi: Document it. --- doc/guix.texi | 9 +++++++++ gnu/services/version-control.scm | 7 ++++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/doc/guix.texi b/doc/guix.texi index 80fb3bc47f..c05c7961e5 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -35704,6 +35704,15 @@ A value like @code{#o0027} will give read access to the group used by Gitolite (by default: @code{git}). This is necessary when using Gitolite with software like cgit or gitweb. +@item @code{local-code} (default: @code{"$rc@{GL_ADMIN_BASE@}/local"}) +Allows you to add your own non-core programs, or even override the +shipped ones with your own. + +Please supply the FULL path to this variable. By default, directory +called "local" in your gitolite clone is used, providing the benefits of +versioning them as well as making changes to them without having to log +on to the server. + @item @code{unsafe-pattern} (default: @code{#f}) An optional Perl regular expression for catching unsafe configurations in the configuration file. See diff --git a/gnu/services/version-control.scm b/gnu/services/version-control.scm index cd8763f5ea..8c9701afe0 100644 --- a/gnu/services/version-control.scm +++ b/gnu/services/version-control.scm @@ -54,6 +54,7 @@ (define-module (gnu services version-control) gitolite-rc-file + gitolite-rc-file-local-code gitolite-rc-file-umask gitolite-rc-file-unsafe-pattern gitolite-rc-file-git-config-keys @@ -242,6 +243,8 @@ (define-record-type* gitolite-rc-file? (umask gitolite-rc-file-umask (default #o0077)) + (local-code gitolite-rc-file-local-code + (default "$rc{GL_ADMIN_BASE}/local")) (unsafe-pattern gitolite-rc-file-unsafe-pattern (default #f)) (git-config-keys gitolite-rc-file-git-config-keys @@ -263,11 +266,13 @@ (define-record-type* (define-gexp-compiler (gitolite-rc-file-compiler (file ) system target) (match file - (($ umask unsafe-pattern git-config-keys roles enable) + (($ umask local-code unsafe-pattern git-config-keys roles enable) (apply text-file* "gitolite.rc" `("%RC = (\n" " UMASK => " ,(format #f "~4,'0o" umask) ",\n" " GIT_CONFIG_KEYS => '" ,git-config-keys "',\n" + ,(if local-code + (simple-format #f " LOCAL_CODE => \"~A\",\n" local-code)) " ROLES => {\n" ,@(map (match-lambda ((role . value) -- 2.36.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 09:05:37 2022 Received: (at submit) by debbugs.gnu.org; 6 Nov 2022 14:05:37 +0000 Received: from localhost ([127.0.0.1]:58996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orgHJ-0007Fl-3Q for submit@debbugs.gnu.org; Sun, 06 Nov 2022 09:05:37 -0500 Received: from lists.gnu.org ([209.51.188.17]:48950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orgHH-0007Fd-8l for submit@debbugs.gnu.org; Sun, 06 Nov 2022 09:05:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orgHH-0000Hb-2h for guix-patches@gnu.org; Sun, 06 Nov 2022 09:05:35 -0500 Received: from mira.cbaines.net ([212.71.252.8]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orgHF-0005AJ-Hu for guix-patches@gnu.org; Sun, 06 Nov 2022 09:05:34 -0500 Received: from localhost (host-82-184-251-30.business.telecomitalia.it [82.184.251.30]) by mira.cbaines.net (Postfix) with ESMTPSA id 5090B27BBEB; Sun, 6 Nov 2022 14:05:32 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id cf85c611; Sun, 6 Nov 2022 14:05:30 +0000 (UTC) References: <20221103161525.2130-1-levenson@mmer.org> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines To: Alexey Abramov Subject: Re: [bug#58989] [PATCH] services: gitolite: Add local-code configuration option. Date: Sun, 06 Nov 2022 15:03:38 +0100 In-reply-to: <20221103161525.2130-1-levenson@mmer.org> Message-ID: <87a654gouw.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 58989@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Alexey Abramov via Guix-patches via writes: > (match file > - (($ umask unsafe-pattern git-config-keys roles enable) > + (($ umask local-code unsafe-pattern git-config-keys roles enable) > (apply text-file* "gitolite.rc" > `("%RC = (\n" > " UMASK => " ,(format #f "~4,'0o" umask) ",\n" > " GIT_CONFIG_KEYS => '" ,git-config-keys "',\n" > + ,(if local-code > + (simple-format #f " LOCAL_CODE => \"~A\",\n" local-code)) > " ROLES => {\n" > ,@(map (match-lambda > ((role . value) This generally looks good, but I believe the above will break if local-code is #f. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNnvydfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xc+Rg/+K1A/yFpIPhGCgxlR4mx4KoP1nuwoqmk1 mmwmagCw4/WOyDq/lyoR1/NzSVMhG3prbr5iCZCvGfar+edEm4yW0XopOy4GtvAg v4d+VGtsn72vFABV4jnMsheYOZclUlv16FIRDIRedtExnw7oBozd3nTWiga56g70 eKW30EC7Z+v2WSkod7K4+Lan2gePDjQ+p6pcwgCJZfp6S6IanEobTzOkw5L8fZuL yYLeQII7IoAxmvzddJdwtY2ZKqiP96gFggCVcw4TkUFOEmf1/8JmZw6xhfia5FtA df1rofpUAcdCO7tUHS6Ho1rwlF+B/UukKF8keapK98CRMF17TUSpnj5j3iVEtHs8 BZSM3R3rYfeUljlZAYDWs9u+LGWfwMLXAg6AlDvUSzTwt6uxxMYirglqkzjbiXhl IQtvUKpagwnLcZI545OoN9s7wbU+ML1Nby0DBumn8F/MX5j1XaTc2ggWmolX5AIR AmE3eunv70G+jSltrZZppW8JiIih4LkRwM2TRojZLg0Sndd6sHdQyuSTUhz0hxs+ r3EzZWqHDQDKgxeRLgKj4EQ5yfMo3s/ARwg7Tmru+lSOhPuLQtDaR1CDqR/QLtxq xdx8KV+FH5YCTQe3U8ZOFZOJcObafZmHorqsygjm3AQrATzQgeVdGDE9Hpo1NV89 N2lI375PD1I= =raCR -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 09:05:45 2022 Received: (at control) by debbugs.gnu.org; 6 Nov 2022 14:05:45 +0000 Received: from localhost ([127.0.0.1]:58999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orgHR-0007G8-EN for submit@debbugs.gnu.org; Sun, 06 Nov 2022 09:05:45 -0500 Received: from mira.cbaines.net ([212.71.252.8]:41778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orgHP-0007Fx-8F for control@debbugs.gnu.org; Sun, 06 Nov 2022 09:05:43 -0500 Received: from localhost (host-82-184-251-30.business.telecomitalia.it [82.184.251.30]) by mira.cbaines.net (Postfix) with ESMTPSA id 844F127BBE9 for ; Sun, 6 Nov 2022 14:05:42 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 91b5b217 for ; Sun, 6 Nov 2022 14:05:40 +0000 (UTC) From: Christopher Baines To: control@debbugs.gnu.org Subject: tag 58989 moreinfo Date: Sun, 06 Nov 2022 14:05:39 +0000 Message-ID: <87edug9o0c.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 58989 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 07 01:40:17 2022 Received: (at submit) by debbugs.gnu.org; 7 Nov 2022 06:40:17 +0000 Received: from localhost ([127.0.0.1]:33032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orvns-0001cH-Lo for submit@debbugs.gnu.org; Mon, 07 Nov 2022 01:40:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:54110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orvno-0001bx-Kj for submit@debbugs.gnu.org; Mon, 07 Nov 2022 01:40:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orvno-000746-FK for guix-patches@gnu.org; Mon, 07 Nov 2022 01:40:12 -0500 Received: from mail.mmer.org ([178.22.65.174]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orvnm-0007l0-Mi for guix-patches@gnu.org; Mon, 07 Nov 2022 01:40:12 -0500 Received: from mail.mmer.org (localhost [127.0.0.1]) by mail.mmer.org (OpenSMTPD) with ESMTP id 1406822c; Mon, 7 Nov 2022 06:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=mmer.org; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=dkim; bh=XFN3Eldm0NHzlLeyBTqQC2hKr1tuUbTXl44A20 AgLfw=; b=sRhyTvZIrn4mNFtwyqlwIn4zuH9RJKooZwCDdZIK6DAmk200f7AsEU 6VqrAFuYnpOvS+9093ME7w8sQdon0gVJ0SRoivThDj5DYJeZTIcAr6rMsSg1//Nl VioXkGZKgEdgMCq38ZaQjP5elmtqFAn8Do+hl1Tk6ipj1b7nAx78E= Received: from delta.lan (j74210.upc-j.chello.nl [24.132.74.210]) by mail.mmer.org (OpenSMTPD) with ESMTPSA id fb04ae20 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 7 Nov 2022 06:40:03 +0000 (UTC) From: Alexey Abramov To: Christopher Baines Subject: Re: [bug#58989] [PATCH] services: gitolite: Add local-code configuration option. In-Reply-To: <87a654gouw.fsf@cbaines.net> (Christopher Baines's message of "Sun, 06 Nov 2022 15:03:38 +0100") References: <20221103161525.2130-1-levenson@mmer.org> <87a654gouw.fsf@cbaines.net> Date: Mon, 07 Nov 2022 07:40:02 +0100 Message-ID: <87leon469p.fsf@delta.lan> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=178.22.65.174; envelope-from=levenson@mmer.org; helo=mail.mmer.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 58989@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Christopher Baines writes: > Alexey Abramov via Guix-patches via writes: > [...] > > This generally looks good, but I believe the above will break if > local-code is #f. Yeah, you are absolutely right. I have attached an updated patch. -- Alexey --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-services-gitolite-Add-local-code-configuration-optio.patch >From 0eb61654d46e171b29a3be7b75cad22f8c32f636 Mon Sep 17 00:00:00 2001 From: Alexey Abramov Date: Wed, 19 Oct 2022 11:34:31 +0200 Subject: [PATCH] services: gitolite: Add local-code configuration option. * gnu/services/version-control.scm (gitolite-rc-file): Add local-code field. (gitolite-rc-file-compiler): Serialize the field. * doc/guix.texi: Document it. --- doc/guix.texi | 9 +++++++++ gnu/services/version-control.scm | 8 +++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/doc/guix.texi b/doc/guix.texi index 80fb3bc47f..c05c7961e5 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -35704,6 +35704,15 @@ A value like @code{#o0027} will give read access to the group used by Gitolite (by default: @code{git}). This is necessary when using Gitolite with software like cgit or gitweb. +@item @code{local-code} (default: @code{"$rc@{GL_ADMIN_BASE@}/local"}) +Allows you to add your own non-core programs, or even override the +shipped ones with your own. + +Please supply the FULL path to this variable. By default, directory +called "local" in your gitolite clone is used, providing the benefits of +versioning them as well as making changes to them without having to log +on to the server. + @item @code{unsafe-pattern} (default: @code{#f}) An optional Perl regular expression for catching unsafe configurations in the configuration file. See diff --git a/gnu/services/version-control.scm b/gnu/services/version-control.scm index cd8763f5ea..b6b78e504e 100644 --- a/gnu/services/version-control.scm +++ b/gnu/services/version-control.scm @@ -54,6 +54,7 @@ (define-module (gnu services version-control) gitolite-rc-file + gitolite-rc-file-local-code gitolite-rc-file-umask gitolite-rc-file-unsafe-pattern gitolite-rc-file-git-config-keys @@ -242,6 +243,8 @@ (define-record-type* gitolite-rc-file? (umask gitolite-rc-file-umask (default #o0077)) + (local-code gitolite-rc-file-local-code + (default "$rc{GL_ADMIN_BASE}/local")) (unsafe-pattern gitolite-rc-file-unsafe-pattern (default #f)) (git-config-keys gitolite-rc-file-git-config-keys @@ -263,11 +266,14 @@ (define-record-type* (define-gexp-compiler (gitolite-rc-file-compiler (file ) system target) (match file - (($ umask unsafe-pattern git-config-keys roles enable) + (($ umask local-code unsafe-pattern git-config-keys roles enable) (apply text-file* "gitolite.rc" `("%RC = (\n" " UMASK => " ,(format #f "~4,'0o" umask) ",\n" " GIT_CONFIG_KEYS => '" ,git-config-keys "',\n" + ,(if local-code + (simple-format #f " LOCAL_CODE => \"~A\",\n" local-code) + "") " ROLES => {\n" ,@(map (match-lambda ((role . value) -- 2.36.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 07 14:54:50 2022 Received: (at submit) by debbugs.gnu.org; 7 Nov 2022 19:54:50 +0000 Received: from localhost ([127.0.0.1]:35379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os8Co-0006BW-DG for submit@debbugs.gnu.org; Mon, 07 Nov 2022 14:54:50 -0500 Received: from lists.gnu.org ([209.51.188.17]:55262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os8Cm-0006BO-QK for submit@debbugs.gnu.org; Mon, 07 Nov 2022 14:54:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1os8Cm-0001HE-LU for guix-patches@gnu.org; Mon, 07 Nov 2022 14:54:48 -0500 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1os8Ck-00019a-QU for guix-patches@gnu.org; Mon, 07 Nov 2022 14:54:47 -0500 Received: from localhost (93-42-6-17.ip84.fastwebnet.it [93.42.6.17]) by mira.cbaines.net (Postfix) with ESMTPSA id 4C3D927BBE9; Mon, 7 Nov 2022 19:54:44 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 8a3f4710; Mon, 7 Nov 2022 19:54:43 +0000 (UTC) References: <20221103161525.2130-1-levenson@mmer.org> <87a654gouw.fsf@cbaines.net> <87leon469p.fsf@delta.lan> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines To: Alexey Abramov Subject: Re: [bug#58989] [PATCH] services: gitolite: Add local-code configuration option. Date: Mon, 07 Nov 2022 20:54:04 +0100 In-reply-to: <87leon469p.fsf@delta.lan> Message-ID: <874jvapmkc.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 58989-done@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Alexey Abramov writes: > Christopher Baines writes: > >> This generally looks good, but I believe the above will break if >> local-code is #f. > > Yeah, you are absolutely right. I have attached an updated patch. Thanks, I've pushed this to master as 73b35195681f8367e27ebf2a239c2d4790fb2304. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNpYoNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xctfg/9GWQxmrqrvDqEBecEbB1jaoXTggarKy7Z Gum4eVxd77hZ/KnYByo7cnSgc1KjGWb88iS014bQISPJyxlKooxGvkgU/2bE0KBL vYPjN2BjEOi+3k/CvmqmWRRLrQYikEg79OUZJQ2NgHSJvVZVWV0o8eIopoMDz7ZZ tToWxiYlMKfYJv7klYF/j2G39qPTlhT4WWygd0Nb8fJwefH1WaAV145Fa4v9rjAZ Mjhe8aMV7RbF3tyLTn3XsXFlMqfPdLCfHfpEg1jT3KXEpJ0MkT0ykT97JT90M7oZ dTVMX+fXUS31TGimKSrI5NwdnDOmO+ET48Z1mQzFIX27e0QtMMKW3LmXHJO4Ys+O ZgJfS+9BlhL9zHxSjZxsX4mxPTQIhPhw86Q6wFysBROE5b9TFTicTDSRXIGQXep4 mlvzxuar8zV27EEnAnBa/53AFw+1zlegBsy6slKz9a+/qW4udHORDvUULdydAO43 5gm9H6TPQ0X9dAQID9fCyaPD6vhtsim0JncOesQA3a+mDX+Fj16X4z6pc6gKxci3 mgEDNHucVwWZ5XmYNsH1zxYVf1fL3bN5f+i1T1Vqo0s4tdpYv6IscNEVB7JUXrQK JRWuLKxgMYXnA1/0IFnGGsxxbzxZzkxc2gXfo+OwP4lVi7oiL0n3/ZdWARkHGlB/ inDFRdJu7tk= =VFSV -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Aug 17 22:07:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 06 Dec 2022 12:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator