GNU bug report logs - #58979
treesitter-regression with json-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#58979: closed (treesitter-regression with json-mode)
Date: Sat, 07 Jan 2023 23:11:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 7 Jan 2023 15:10:14 -0800
with message-id <F3B916BB-4966-4C1E-B3C6-1421814587F7 <at> gmail.com>
and subject line Re: bug#58979: treesitter-regression with json-mode
has caused the debbugs.gnu.org bug report #58979,
regarding treesitter-regression with json-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
58979: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58979
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Johann Höchtl <johann.hoechtl <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: treesitter-regression with json-mode
Date: Wed, 2 Nov 2022 17:16:08 +0100

[Message part 3 (text/plain, inline)]

When I open a large json file (about 3_000_000 lines, about 72Mb,
pretty-printed) Emacs 29.0.50 opens the file just fine in `js-json-mode`
and when using regexp-based font locking, it works well.

When I force this buffer into javascript-mode, Emacs hangs. Memory
consumption as reported by Windows task manager "dances" around 2Gb, yet
even after waiting for three minutes, Emacs doesn't get responsive any more.

I consider this an unfortunately regression as recent commits to Emacs 29
(long lines patches) actually makes working with such large files with long
lines absolutely pleasant, yet as it seems the interaction with tree-sitter
destroys this gains.

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: 58979-done <at> debbugs.gnu.org
Subject: Re: bug#58979: treesitter-regression with json-mode
Date: Sat, 7 Jan 2023 15:10:14 -0800

Yuan Fu <casouri <at> gmail.com> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> Johann Höchtl <johann.hoechtl <at> gmail.com> writes:
>>
>>> When I open a large json file (about 3_000_000 lines, about 72Mb,
>>> pretty-printed) Emacs 29.0.50 opens the file just fine in
>>> `js-json-mode` and when using regexp-based font locking, it works
>>> well.
>>>
>>> When I force this buffer into javascript-mode, Emacs hangs. Memory
>>> consumption as reported by Windows task manager "dances" around 2Gb,
>>> yet even after waiting for three minutes, Emacs doesn't get responsive
>>> any more.
>>>
>>> I consider this an unfortunately regression as recent commits to Emacs
>>> 29 (long lines patches) actually makes working with such large files
>>> with long lines absolutely pleasant, yet as it seems the interaction
>>> with tree-sitter destroys this gains.
>>
>> Copying in Yuan Fu.
>
> Again, sorry for the delay, I just saw this report :-)
>
> Since your previous report is actually about emacs-tree-sitter, I think
> this one is too?
>
> Anyway, since tree-sitter is merged into master now, if you rebuild
> master and turn on json-ts-mode, you should be in tree-sitter backed
> JSON mode. I’d give that a try and see if works fine.
>
> Thanks,
> Yuan

Closing this report since I think there’s nothing to do. Feel free to
reopen.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.